Andrew Pardoe
5205a4e567
updating date
2017-06-11 21:25:28 -07:00
Andrew Pardoe
c0b1ea189f
Merge pull request #958 from xfix/patch-1
...
Rename rnd to round in I.1
2017-06-11 18:44:55 -07:00
Andrew Pardoe
18e8e91745
Merge pull request #957 from eliaskosunen/master
...
Add braces to for loop in P.1 example
2017-06-11 18:41:25 -07:00
Andrew Pardoe
ba3bdb1f40
Merge pull request #949 from robert-andrzejuk/patch-2
...
Minor typo (I think)
2017-06-11 18:36:21 -07:00
Konrad Borowski
7367e07598
Rename rnd to round in I.1
...
At first, I assumed that this is "rand" function, not "round" function,
and was confused why exactly is it a problem that this returns
different values. While it's easy to notice when actually reading the
code, this slows down the comprehension, and bad function naming is
not point of that particular guideline.
2017-06-10 12:08:12 +02:00
Elias Kosunen
7763b97b52
Add braces to for loop in P.1 example
...
`for` with no `block-statement` as its `statement` is bad practice and should not be shown in an example. This example is meant to demonstrate code duplication and expessiveness, not to show poor usage of braces or lack thereof.
2017-06-09 23:30:42 +03:00
Andrew Pardoe
6907911089
Updating date
2017-06-08 16:58:52 -07:00
Robert Andrzejuk
d5667c5f8a
Minor typo
...
I think a minor typo got itself in ... the second 'string_span' should be string_view.
2017-06-08 22:24:25 +02:00
Tom Isaacson
974d6a2090
Fix link to constructor virtual
2017-06-09 08:04:15 +12:00
Florin
d4d48ec772
Fix tense, semantic error
2017-06-08 13:57:50 +02:00
Sergey Zubkov
fe9861d98a
New rule: I.27 Pimpl
2017-06-04 10:58:27 -04:00
Sergey Zubkov
906ae347f3
travis CI fixes
2017-06-04 10:47:46 -04:00
Bjarne Stroustrup
c355df948f
reorganize the lifetime profile description
2017-06-03 15:38:36 -04:00
Abigail
11e92eb4c5
Fix Markdown rendering failure
...
Use of <iostream> without backticks causes the Markdown render to fail
from this point onwards on GitHub pages.
2017-06-03 07:47:06 +01:00
Zachary Henkel
f3ff5bae6d
Clarify "unnecessary cast" by decomposing the class into identity casts and implicit casts.
2017-06-02 09:24:29 -05:00
Thibault Kruse
9cc50836bd
Diverse style fixes
...
Remove whitespace at end of line
fix code indent
whitepsace between operators
align comments
add method name to fix syntax highlighting
typo: start with capital letter
Apply snake-case naming for unctions (for consistency)
2017-06-02 20:34:32 +09:00
Gabriel Dos Reis
520087569f
Merge pull request #943 from galik/fix_unique_target_case
...
Fix case of unique anchors to match others
2017-06-01 19:51:54 -07:00
Bledson Kivy
d240b7611e
#include
d instead of #included
2017-06-01 23:26:45 -03:00
Zachary Henkel
3c867e5079
Final style changes
2017-05-31 10:11:19 -05:00
Zachary Henkel
2ef544d4ad
Additional formatting
2017-05-31 10:10:00 -05:00
Zachary Henkel
abd71982da
Another try with the linter
2017-05-31 10:03:02 -05:00
Zachary Henkel
ca35984813
Try to make the linter happy
2017-05-31 09:50:10 -05:00
Andrew Pardoe
c7733a398a
Updating date
2017-05-29 17:46:56 -07:00
galik
7cf5f01bad
Fix case if unique anchors to match others
...
SL.str.5, SL.str.10, SL.str.11, SL.str.12
2017-05-26 06:21:54 +01:00
Gabriel Dos Reis
07d2413d80
Merge pull request #939 from galik/fix_item_tags
...
Fix various item tags (missing colons)
2017-05-25 15:18:15 -07:00
galik
fa50221dd0
Fix various item tags (missing colons)
...
I.2, C.10, A.1, A.2, A.4, NL.5
2017-05-25 23:09:08 +01:00
Gabriel Dos Reis
9e29780db6
Merge pull request #937 from ProgramMax/add-missing-period
...
Add missing period
2017-05-25 15:05:02 -07:00
Chris Blume
ea50b4ea78
Add missing period
2017-05-25 13:38:51 -07:00
Sergey Zubkov
d816cc5705
travis CI fixes
2017-05-24 22:35:05 -04:00
Zachary Henkel
2cd9993ae4
Revise cast guidance following upstream edits
2017-05-24 15:31:11 -05:00
Zachary Henkel
9ef1d51c34
Merge from https://github.com/isocpp/CppCoreGuidelines
2017-05-24 14:58:33 -05:00
Bjarne Stroustrup
6c3620d1e8
minor cleanup
2017-05-24 08:49:21 -04:00
Malcolm Parsons
4dfe88b716
Fix broken links ( #935 )
2017-05-24 11:15:58 +01:00
Sergey Zubkov
531a8a5ebd
travis CI fixes and other typos
2017-05-23 23:48:56 -04:00
Shalom Craimer
5f5d5d8ca6
Fixing link to C.146 to be valid, and a link to ??? to be unlinked ( #934 )
...
this fixes links and the issues discovered by travis CI
2017-05-23 22:55:06 -04:00
Bjarne Stroustrup
5975f4d5db
more bounds profile reorganization
2017-05-23 21:36:14 -04:00
Bjarne Stroustrup
df160f3654
Most of the bounds safety profile
2017-05-23 15:55:51 -04:00
Bjarne Stroustrup
9eb18fdf9e
vector exception to {} initializers
2017-05-23 15:03:52 -04:00
Bjarne Stroustrup
9d44e718eb
Reorganized the Type safety profile
2017-05-23 14:39:13 -04:00
Andrew Pardoe
c721b2c325
Merge pull request #931 from sizeofvoid/master
...
fix: unsigned int value comment
2017-05-22 07:55:26 -07:00
Bjarne Stroustrup
5da51a9a44
more work on anchors
2017-05-22 10:45:16 -04:00
Bjarne Stroustrup
9d283bc451
anchors for Type.*
2017-05-21 21:54:27 -04:00
Bjarne Stroustrup
986106c63c
more Type.* reorganization
2017-05-21 21:15:35 -04:00
Bjarne Stroustrup
e2719d035b
Reorganize Type.1-3
2017-05-21 15:40:25 -04:00
Bjarne Stroustrup
6e86c182f9
Don't detach, rename raii_thread to joining_thread
...
Addressing #925 . Please review carefully. #925 is tricky.
2017-05-21 12:18:59 -04:00
Sergey Zubkov
96a41a4a6e
travis CI fixes
2017-05-20 21:04:04 -04:00
Bjarne Stroustrup
a1f59395bb
modifications to C.43
...
Issue #544
2017-05-20 14:29:23 -04:00
Sergey Zubkov
85cb14703c
travis CI fixes
2017-05-19 23:33:06 -04:00
Bjarne Stroustrup
aabfe119d3
typo fix
2017-05-19 18:05:17 -04:00
Rafael Sadowski
a591b3c279
fix: unsigned int value comment
2017-05-19 18:01:41 +02:00
Bjarne Stroustrup
14ef2cde84
add rules against use of unsigned
...
addresses #571
2017-05-18 16:45:10 -04:00
Bjarne Stroustrup
50576c0144
issue #841
...
SF.10: Avoid dependencies on implicitly `#included` names
2017-05-17 15:06:48 -04:00
Bjarne Stroustrup
974fdf4661
improve I.11
...
as suggested in #552
2017-05-17 14:41:53 -04:00
Bjarne Stroustrup
fa1d0e5995
exceptionsand const
...
Added to E.15
2017-05-17 14:25:13 -04:00
Bjarne Stroustrup
81493f331c
Undid untentional change to C.85
2017-05-16 15:58:01 -04:00
Bjarne Stroustrup
7206b618a4
C.86 example accesses private members #541
...
fixed
2017-05-16 15:56:16 -04:00
Bjarne Stroustrup
9620ea8d43
I.30: Encapsulate rule violations
...
Fiexed #893 by moving the bad example from ES.28 to a new rule: I.30:
Encapsulate rule violations.
I may inadvertenly have invented a new suppression syntax
2017-05-16 14:59:55 -04:00
Bjarne Stroustrup
17ccab5836
Fix C.139
2017-05-16 13:28:23 -04:00
hsutter
b10ffdf55f
Reversed order of Lifetime.1 and .2
2017-05-11 19:09:56 -07:00
hsutter
ff9bce8035
Add Lifetime.1-3 rules so tools can refer to them
2017-05-11 17:56:25 -07:00
Zachary Henkel
f1b348e0db
Additional guidance around casts:
...
- Warn on unnecessary casts
- Avoid casts on arithmetic types
- Add specializations of the rules for Pro-type-reinterpretcast
2017-05-09 16:17:45 -07:00
Sergey Zubkov
17715010a2
travis CI fixes and grammar fix from #920
2017-05-08 22:34:18 -04:00
Andrew Pardoe
b09b9ad8b9
Updating date & typos
2017-05-08 12:05:23 -07:00
Andrew Pardoe
bec67d690a
Merge pull request #914 from AndrewPardoe/issue911
...
Clarify I.11 with regards to recommending smart pointers/owner<T>.
2017-05-08 11:09:19 -07:00
Andrew Pardoe
52eca9a174
Merge pull request #917 from scraimer/master
...
C.148 adding Reason and Example
2017-05-08 11:08:12 -07:00
Andrew Pardoe
2e1d9c34d4
Merge pull request #920 from cubbimew/issue899
...
CP.111 more precise motivation and examples
2017-05-08 11:05:28 -07:00
Andrew Pardoe
d5ea1fcc4f
Merge pull request #922 from AndrewPardoe/issue-918
...
Fix anchors in C.147/148
2017-05-08 11:04:21 -07:00
Gabriel Dos Reis
52aa9ba997
Fix #903 .
2017-05-08 10:50:03 -07:00
Andrew Pardoe
e354279e0e
Fix anchors in C.147/148
2017-05-08 10:21:01 -07:00
Bjarne Stroustrup
ad6f863152
Added not about notation to Con.2
...
in response to #902
2017-05-07 15:59:55 -04:00
Sergey Zubkov
f41d36ff25
CP.111 more precise motivation and examples
2017-05-07 14:17:21 -04:00
Bledson Kivy
7c90bdba50
Intended heading level?
...
Following the heading levels throughout the doc, it seems these are typos.
2017-05-05 16:47:41 -03:00
Shalom Craimer
12f0954f66
Fixed the errors detected by Travis CI and @jwakely
2017-05-05 01:20:16 +03:00
Shalom Craimer
cdf2e7e5ea
Fixed the errors detected by Travis CI and @jwakely
2017-05-05 00:56:29 +03:00
Jonathan Wakely
bdb5d27a10
Remove spaces before ptr-declarators in examples
2017-05-04 09:48:19 +01:00
Shalom Craimer
1c53b29a3a
C.148 - Fixing Travis-reported errors discovered so far in the code example
2017-05-04 11:19:31 +03:00
Shalom Craimer
b6132db539
C.148 adding Reason and Example
2017-05-04 10:13:22 +03:00
Andrew Pardoe
343f40792a
Clarify I.11 with regards to recommending smart pointers/owner<T>.
2017-05-01 15:32:28 -07:00
Sergey Zubkov
f0239407ad
travis fixes
2017-05-01 15:51:44 -04:00
Andrew Pardoe
03c2b4699d
Updating date
2017-05-01 12:03:31 -07:00
Jonathan Wakely
32d6313607
Improve example for ES.45
...
Fixes #895
2017-05-01 19:57:39 +01:00
Andrew Pardoe
a96fed9c99
Merge pull request #896 from tlanc007/master
...
ES.45/ES.46 renamed and reordered to match anchors found later in file
2017-05-01 11:10:57 -07:00
Gabriel Dos Reis
0ff5518dca
Merge pull request #905 from ewoudvc/es24_toc_rule_correction
...
ES.24: have TOC rule match body rule
2017-05-01 11:07:32 -07:00
Andrew Pardoe
b41bea68c1
Merge pull request #909 from tvaneerd/patch-2
...
Note -> Not, are -> is
2017-05-01 11:07:16 -07:00
Gabriel Dos Reis
f9f3422ac5
Fix C.183.
2017-05-01 11:05:32 -07:00
Gabriel Dos Reis
918a5695c7
Address C.128: say 'avoid'.
2017-05-01 10:45:36 -07:00
Tony Van Eerd
481996c849
Note -> Not, are -> is
2017-04-30 22:32:46 -04:00
Bjarne Stroustrup
e0de4df83b
added clarifying note for C.139
2017-04-30 13:33:35 -04:00
Bjarne Stroustrup
b3584cfa5f
added reference to C.137
2017-04-30 12:18:42 -04:00
Bjarne Stroustrup
a6a087dfc5
regular added to glossary
2017-04-30 12:06:28 -04:00
Bjarne Stroustrup
64622d5cca
testing
...
and fixing one "thinko"
2017-04-30 10:57:58 -04:00
ewoudvc
caa86ae38b
GSL.assert: replace is by are ( #908 )
2017-04-28 16:34:25 +01:00
Jonathan Wakely
e3fe0c5b5e
Fix indentation of NR.1 example
2017-04-28 13:31:20 +01:00
Ewoud Van Craeynest
10805fb7a1
ES.24: have TOC rule match body rule
2017-04-27 21:44:51 +02:00
Sergey Zubkov
94a7a3fd46
travis CI fixes, one more time
2017-04-26 22:08:13 -04:00
Bjarne Stroustrup
046d62c51e
minor improvements to SL.io
2017-04-25 15:07:41 -04:00
Sergey Zubkov
c99a366bba
travis CI fixes
2017-04-24 22:49:02 -04:00
Bjarne Stroustrup
4f9a6c89be
banning exception specifications
...
a bit more abut exceptions; the beginnings of I/O
2017-04-24 17:41:18 -04:00
Bjarne Stroustrup
1e38eb8ae7
ban longjmp
2017-04-22 18:10:58 -04:00
Bjarne Stroustrup
5397c9c5fe
very minor typo
...
testing
2017-04-21 15:18:21 -04:00
Bjarne Stroustrup
1b7d217cd1
nothing
2017-04-20 20:46:17 -04:00
Tal Lancaster
5306795214
ES.45/ES.46: renamed and reordered to match jump tags
...
The anchors later in the file were using 46 for narrowing and 45 for
magic. Renamed and reordered the tags in the TOC to match.
2017-04-20 11:35:25 -06:00
Sergey Zubkov
2a098a2b39
travis CI fixes
2017-04-20 10:54:50 -04:00
Bjarne Stroustrup
df8a441dcf
fix bug in C.9 example
...
a real-world example would be an improvement
2017-04-20 08:28:30 -04:00
Bjarne Stroustrup
d1ff56d07e
date
2017-04-19 20:53:12 -04:00
Bjarne Stroustrup
cfa2fec1f2
C.137
2017-04-18 21:27:30 -04:00
Bjarne Stroustrup
6987bfd2f0
C.9 and C.133
2017-04-18 20:35:46 -04:00
Bjarne Stroustrup
05118054f6
NL.11 literals
2017-04-18 18:11:30 -04:00
Bjarne Stroustrup
e30bb60320
more xrefs
2017-04-18 17:51:49 -04:00
Louis Brandy
540c393501
Merge pull request #892 from lbrandy/master
...
Example of an inheritance hierarchy for C.120.
2017-04-18 12:05:29 -07:00
Sergey Zubkov
04537cdb11
travis CI fixes
2017-04-17 23:37:21 -04:00
Sergey Zubkov
74ab713700
travis CI and some typo fixes
...
had to drop runtime/printf from the checks because it bans strcpy
2017-04-17 23:07:21 -04:00
Bjarne Stroustrup
54f57d8d1b
more language feature xrefs
...
These xrefs are menat part as teasers to get language-feature obsessed
programmers to look at the guidelines and partly to cover topics that
appears in several places. They are not meant to be complete
2017-04-17 21:01:51 -04:00
Bjarne Stroustrup
6fa4cb32cd
more language feature xrefs
2017-04-17 17:05:07 -04:00
Bjarne Stroustrup
e144bd4f9b
minor
2017-04-17 16:00:18 -04:00
Louis Brandy
29fdd0d30c
Attempt to add an example (that is as non-controversial as possible) of an inheritance hierarchy to C.120
2017-04-17 12:23:22 -07:00
Andrew Pardoe
f1d3846300
updating date
2017-04-17 12:00:18 -07:00
hsutter
0ff543fe19
Addresses #568
2017-04-17 11:51:20 -07:00
hsutter
323912e609
A pass at improving F.52. Closes #884
2017-04-17 11:42:08 -07:00
Bjarne Stroustrup
6d01cfd99b
more language term examples
2017-04-17 12:37:42 -04:00
Bjarne Stroustrup
c46bebc58f
idea for language feature xref
2017-04-17 12:24:28 -04:00
Bjarne Stroustrup
1b5f6d0c97
change "concepts lite" to "concepts"
2017-04-17 11:12:41 -04:00
Bjarne Stroustrup
098dd3ee90
add example to NR.1
2017-04-16 21:50:52 -04:00
Bjarne Stroustrup
13ee61a3cb
start of impact statements for profiles
2017-04-16 15:55:13 -04:00
Bjarne Stroustrup
fc5222ca26
Added a first cut of string guidelines
2017-04-16 14:50:07 -04:00
Bjarne Stroustrup
6bcfaa4fbe
Clarify that finally() is a last resort
...
E.6 and E.19
2017-04-15 21:32:57 -04:00
Andrew Pardoe
a8572ad328
Update link to iso.org per #888
2017-04-15 09:23:47 -07:00
Sergey Zubkov
d71d95a4b6
travis CI fixes
2017-04-12 22:56:23 -04:00
Bjarne Stroustrup
0b58d04fde
ES.84
2017-04-10 15:57:38 -04:00
Bjarne Stroustrup
6a3d61fd8d
a few more fix-ups in ES.*
2017-04-09 15:15:48 -04:00
Bjarne Stroustrup
26d56a2f54
More changes to ES.*
...
break and continue
goto
fallthrough
when to use "default"
order of evaluation (C++17)
2017-04-09 12:16:58 -04:00
Bjarne Stroustrup
1f948653bb
Cleanup of ES.7*
...
also ES.10: structured binding
and ES.28: eliminating an owning reference
2017-04-09 10:52:48 -04:00
Andrew Pardoe
960f6dad1c
updating date
2017-04-04 16:38:57 -07:00
Andrew Pardoe
0aa9994e54
whitespace for formatting
2017-04-03 12:15:05 -07:00
Andrew Pardoe
5b1043104c
Resolving issue #662
2017-04-03 12:07:43 -07:00
Bjarne Stroustrup
fbeff91d05
typos
2017-04-02 20:42:58 -04:00
Bjarne Stroustrup
cbb3de625e
add example to F.21
2017-04-02 20:42:58 -04:00
Neil MacIntosh
b0cd06aa2e
Updated note in C.131 to add clarity.
2017-04-02 12:50:48 -07:00
Bjarne Stroustrup
45e11be0ad
added example to C.136
2017-04-02 14:36:21 -04:00
Bjarne Stroustrup
13d6eff946
improving SF.6
...
In respose to #725
2017-04-02 14:13:37 -04:00
Bjarne Stroustrup
5080166d3c
fix ES.10
2017-04-02 13:36:09 -04:00
Sergey Zubkov
83566ba7d1
travis fixes
2017-03-31 21:01:48 -04:00
Jonathan Wakely
65aa60fe10
Clarify that synchronized_value is not standardised yet
2017-03-27 20:06:29 +01:00
Jonathan Wakely
85543a94e9
Replace invalid uses of defer_lock in C.21 with adopt_lock
2017-03-27 20:06:29 +01:00
Anthony Williams
1b51c917d0
Expanded CP.50 to reference synchronized_value<T>
2017-03-27 20:06:29 +01:00
Anthony Williams
f15d001ba0
Added note about detached threads racing with global destructors
2017-03-27 20:06:29 +01:00
Anthony Williams
ce93de647a
Added reference to variadic scoped_lock to CP.21
2017-03-27 20:06:29 +01:00
Andrew Pardoe
795efa71f7
missed one space
2017-03-27 12:05:48 -07:00
Andrew Pardoe
f9f35c78bc
adding space after includes per #769
2017-03-27 12:02:06 -07:00
Andrew Pardoe
49abfa6509
Merge pull request #780 from zingsheim/T.84.Link_base
...
T.84 Correction of Example: Change type of suc and pre to Link_base
2017-03-26 10:13:20 -07:00
Neil MacIntosh
907de2aa4c
Corrected mistake in enforcement for R.3.
2017-03-21 14:19:31 -07:00
Neil MacIntosh
deb47c0c47
Corrected obsolete syntax in span examples.
2017-03-20 19:54:30 -07:00
Andrew Pardoe
8caa0fe007
updating date
2017-03-20 12:02:59 -07:00
Andrew Pardoe
de099e2b57
adding punctuation
2017-03-20 11:50:15 -07:00
Andrew Pardoe
cc284d260f
Merge remote-tracking branch 'refs/remotes/origin/master'
2017-03-20 11:47:49 -07:00
Andrew Pardoe
e19aed0ef3
Update glossary per issue 820
2017-03-20 11:47:26 -07:00
Neil MacIntosh
33098ab31e
Updated guidance on noexcept on destructors ( #814 )
2017-03-20 11:44:13 -07:00
hsutter
38a6acc1c0
Closes #827
...
Stated the main two reasons why functions with lots of parameters exist:
Because they're missing an abstraction, or because the function is
trying to do more than one job.
Added explicit coverage of those reasons and another example
illustrating that.
2017-03-20 11:35:33 -07:00
Andrew Pardoe
b8b178e98a
Merge pull request #867 from tkruse/fix-warnings
...
Fix travis warnings, includes other PRS
2017-03-20 11:10:01 -07:00
Neil MacIntosh
c6f8afc931
Updated example of enforcement suppression.
2017-03-20 08:34:02 -07:00
Jacob Langley
2c8b34653d
Add a line to help remark identify code block inside bullet list
2017-03-20 11:19:35 +09:00
Jacob Langley
a2dba2e78b
Fix cpplint issues
...
Rconc-create0.cpp:20: Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Res-always5.cpp:15: Missing space after , [whitespace/comma] [3]
Rp-lib0.cpp:15: Missing space after , [whitespace/comma] [3]
Rs-using-directive0.cpp:25: Extra space after ( in function call [whitespace/parens] [4]
Rs-using-directive0.cpp:25: Extra space before ) [whitespace/parens] [2]
2017-03-20 11:19:35 +09:00
Jacob Langley
48b40df328
Fix markdown lint errors
...
11979:3 warning Incorrect indentation before bullet: remove 1 space list-item-bullet-indent
19412:1-19462:23 warning Missing blank line before block node no-missing-blank-lines
2017-03-20 11:19:34 +09:00
Jacob Langley
04fd2a5807
Fix spellcheck errors
...
Line 1037: analyser -> analyses
Line 2399: yu -> yew
Line 3745: funtions -> functions
Line 3748: multimethods -> multi methods
Line 6652: mixins -> mixing
Line 11991: unittests -> unittest
2017-03-20 11:19:34 +09:00
Kevin Kennedy
b9a1ed62e9
Change Unicode EN SPACE (U+2002) characters to SPACE (U+0020) so that Pandoc-generated LaTeX can compile without Error
2017-03-19 10:07:40 -04:00
Andrew Pardoe
5408dd3e75
updating date
2017-03-17 15:48:41 -07:00
hsutter
ba3c4b5692
Updated example for Con.1
...
The original example was good, but it used a reference where the point
of Con.1 is about declaring objects themselves const
2017-03-17 15:39:49 -07:00
hsutter
dfb2a5b1fe
Minor consistency cleanup
...
- Fixed an inconsistent title (section ToC and actual guideline title
differed)
- Can't reseat a reference, so changed it to pointer
- Removed what I think is a stray/outdated rule against passing
move-only types (unique_ptr) by &&
- Reordered a three-line example for logical flow
2017-03-16 08:54:26 -07:00
hsutter
55780020c1
Added lifetime profile placeholder
2017-03-15 11:14:29 -07:00
hsutter
398d3a7400
Added Bounds.* section index
2017-03-15 11:05:22 -07:00
hsutter
e436db0a0e
Type.5.1 actually belongs after Type.4
...
So making it Type.4.1 for now
2017-03-15 10:59:19 -07:00
hsutter
901b301b1f
Updated refresh date
2017-03-15 10:47:31 -07:00
hsutter
42da80ef76
Fixed numbering in Type section
...
There were two Type.7's. Renumbered one of them to .5.1 for now, and
fixed the section table of contents.
2017-03-15 10:42:56 -07:00
hsutter
0af5e31eb2
Closes #836
2017-03-13 12:05:51 -07:00
hsutter
33adf1eede
Elaborated on #835 .
...
Incorporating @cubbimew's comments. Thanks!
2017-03-13 11:48:22 -07:00
hsutter
3b3148d99c
Closes #835
...
We do not encourage `owner<T&>`.
2017-03-13 11:44:40 -07:00
hsutter
0bb2de37a0
Closed 856 and 857
...
Added C++17-specific text in ES.6 for `if` and `switch` initializers.
Note that the Guidelines assume C++14, so the "Enforcement" clauses for
C++17-specific rules will be separate until we assume people have broad
access to C++17 features in their compilers. Once that happens we can
roll the C++17-specific parts into the main text.
2017-03-13 11:32:41 -07:00
Jonathan Wakely
c7c5614a42
Fix spelling typos
2017-02-13 20:20:05 +00:00
Jonathan Wakely
464870c7d3
Fix some markdown warnings seen in the Travis CI checks
2017-02-13 20:14:47 +00:00
Andrew Pardoe
52ad087bb3
Merge pull request #845 from jacobl-at-ms/jacobl.macbuild
...
Enable building directly on a mac
2017-02-13 11:45:27 -08:00
Herb Sutter
3f2e675f7d
Merge pull request #763 from Eliyahu-Ravuna/patch-1
...
Exception of CP.100 refined to include the "sequentially consistent memory model" only
2017-02-13 14:38:07 -05:00
Gabriel Dos Reis
2b6d208d58
Merge pull request #777 from cubbimew/nvi
...
dropping NVI from proto-rules due to no consensus on #768
2017-02-13 11:35:46 -08:00
Bjarne Stroustrup
bd5f0c34db
Merge branch 'master' into bs-local-1
2017-02-11 13:02:30 -05:00
Bjarne Stroustrup
c5cecf1e88
new rule F.9; unused parameters
...
Issue #808
2017-02-11 12:25:05 -05:00
Bjarne Stroustrup
631bbbbaf8
typos MI and membership
2017-02-09 17:32:01 -05:00
Jacob Langley
eb4be01970
Fix spelling errors
2017-02-08 10:04:05 -08:00
Bjarne Stroustrup
87bb531080
tools and library rules
...
in philosophy
2017-02-07 18:05:54 -05:00
Andrew Pardoe
47e5764e6e
Update date
2017-02-06 11:55:23 -08:00
Andrew Pardoe
9ddb9e1648
Merge parts of PR #787
2017-02-06 11:51:03 -08:00
Andrew Pardoe
20403c8d6d
Merge branch 'thread-tooling' of https://github.com/tituswinters/CppCoreGuidelines into tituswinters-thread-tooling
2017-02-06 11:36:22 -08:00
Andrew Pardoe
11e5e00f23
Merge pull request #818 from cubbimew/c138
...
C.138 initial content
2017-02-06 11:23:59 -08:00
Bjarne Stroustrup
f2dfcfc438
minor cleanup
2017-02-01 17:05:22 -05:00
Jonathan Wakely
14f67ae8dd
Fix typos from commit 9858685786
2017-01-31 12:13:10 +00:00
hsutter
8f2ecf0665
Closed #557
...
Added example from the issue
2017-01-30 11:52:11 -08:00
hsutter
51b4cddbca
Closed #810
...
Added an example to SF.7
Clarified SF.6 and SF.7 that "using-directive" means "using namespace"
2017-01-30 11:40:47 -08:00
Andrew Pardoe
9858685786
Clarifying title per issue 793
2017-01-30 11:36:57 -08:00
teassy000
8a9bb3bc61
fix c.127 example issue. ( #789 )
...
auto will deduce as unique_ptr<D> and the correct destructor will call. Anyway, this should be a bad example.
2017-01-30 19:32:41 +00:00
Sergey Zubkov
4d86abfdb4
When the title of ES.56 was changed, its entry in the ES ToC wasn't ( #831 )
2017-01-30 19:27:13 +00:00
Sergey Zubkov
0b4b815d0b
uncross links to the self-assignment rules ( #830 )
2017-01-30 19:26:56 +00:00
Andrew Pardoe
51191c13d2
Merge pull request #825 from johelegp/interfaces_non_trivial_fixes
...
I: Enforcement fixes/completion
2017-01-30 11:19:55 -08:00
Gabriel Dos Reis
dd7275623d
Merge pull request #834 from cubbimew/c131-constify
...
C.131: getters should be const member functions
2017-01-30 06:59:27 -08:00
Sergey Zubkov
bee5e87e90
C.131: getters should be const member functions
2017-01-30 06:47:00 -05:00
Sergey Zubkov
808d304687
C.127 should not claim that there is a defined behavior
2017-01-30 06:24:16 -05:00
mancoast
63582c929e
Rework of English Language style
2017-01-18 07:45:47 -05:00
Gabriel Dos Reis
655bbcafa8
Merge pull request #824 from johelegp/interfaces_fixes
...
I: Grammar, spacing and typo fixes
2017-01-02 12:51:18 -08:00
Gabriel Dos Reis
94fdad103d
Merge pull request #823 from johelegp/gsl_concept_dead_link_fix
...
GSL.concept: Dead link fix
2017-01-02 12:50:02 -08:00
Gabriel Dos Reis
c040dfab55
Merge pull request #822 from johelegp/gsl_fixes
...
GSL: Grammar, spacing and markdown fixes
2017-01-02 12:49:05 -08:00
Johel Ernesto Guerrero Peña
2b3e249cff
I: Grammar, spacing and typo fixes
2016-12-31 20:58:30 -04:00
Johel Ernesto Guerrero Peña
5f95cb2734
I: Enforcement fixes/completion
2016-12-31 20:56:49 -04:00
Johel Ernesto Guerrero Peña
3bb9192d66
GSL: Grammar, spacing and markdown fixes
2016-12-30 18:20:04 -04:00
Johel Ernesto Guerrero Peña
bb4202ed92
GSL.concept: Dead link fix
...
Described in #407 , 4a9e41d7
added the section but didn't fix the links.
2016-12-30 17:28:21 -04:00
Johel Ernesto Guerrero Peña
d30134b150
P: Grammar, correction and typo fixes
2016-12-30 00:21:51 -04:00
Sergey Zubkov
a968af59d0
C.138 initial content
2016-12-18 14:46:11 -05:00
Andrew Pardoe
9cfa3eafd7
Updating date
2016-12-12 11:39:59 -08:00
Andrew Pardoe
4f2a64b920
Per our discussion, C.42 enforcement belongs to C.41
2016-12-12 11:27:40 -08:00
hsutter
882d88ebe5
Closed #809 .
2016-12-05 14:20:37 -08:00
Severin Meyer
bcd9904ae2
Fix remaining typos mentioned in issue #556
...
ES.23: Correct the Fibonacci series
ES.71: Fix bug in example code
T.61: Use the correct type for the class member
Appendix C: Use an example string that is not identical to a C++ keyword and clarify comment
2016-11-22 23:08:27 +01:00
Gabriel Dos Reis
7fb5621495
Merge pull request #799 from severinmeyer/NL-Typos-squashed
...
Fix typos in section NL: Naming and layout
2016-11-22 07:54:48 -08:00
Gabriel Dos Reis
32368d99c6
Merge pull request #800 from severinmeyer/CP-Typos-squashed
...
Fix typos in section CP: Concurrency
2016-11-22 07:53:52 -08:00
Gabriel Dos Reis
1b259959f6
Merge pull request #801 from severinmeyer/ES-Typos-squashed
...
Fix typos in section ES: Expressions and statements
2016-11-22 07:53:00 -08:00
Gabriel Dos Reis
783ab6c6ca
Merge pull request #802 from severinmeyer/E-Typos-squashed
...
Fix typos in section E: Error handling
2016-11-22 07:52:01 -08:00
Severin Meyer
6fb7ad6bb5
Fix a few more typos
...
F.22: Fix typos
C.128: Update the title in the ToC, to match the new title from commit f0e29f0
Con.1: Fix typo
T.84: Fix typo
NR.2: Remove duplicated word from title (single single)
2016-11-22 16:10:31 +01:00
Severin Meyer
185f70781d
Fix typos in section E: Error handling
...
E.25: Fix several typos
E.25: Add missing comma
E.2: Add missing verb
2016-11-22 15:53:13 +01:00
Severin Meyer
63f1948962
Fix typos in section NL: Naming and layout
...
NL.1: Add missing period to title in ToC
NL.5: Fix typo
NL.8: Fix several typos
NL.9: Add missing period in title
NL.9: Fix typo
NL.19: Fix typo
2016-11-22 13:56:52 +01:00
Severin Meyer
efdd83bf9a
Fix typos in section ES: Expressions and statements
...
ES.dcl: Fix typo
ES.25: Use the singular form for the title, to correct it and to match it with the entry in the ToC
ES.30: Fix several typos
ES.40: Fix typo in code comments
ES.61: Capitalize first word of title
ES.63: Fix typo
ES.70: Fix typo and capitalization
ES.74: Fix typo in title
ES.102: Fix typo and add missing comma
2016-11-22 13:43:07 +01:00
Severin Meyer
c1ed09786d
Fix typos in section CP: Concurrency
...
CP.8: Add missing colon to title
CP.30: In title, close inline code block with backtick
CP.101: Correct saying, Icarus flew to close to the sun, not the wind
2016-11-22 13:32:38 +01:00
Andrew Pardoe
9987d835b9
Updating date
2016-11-21 08:38:55 -08:00
Andrew Pardoe
7741b8689e
Merge pull request #796 from severinmeyer/C-Typos
...
Fix typos in section C: Classes and class hierarchies
2016-11-21 08:33:22 -08:00
Severin Meyer
353f8ffc4c
C.140: Fix typo in text
2016-11-17 14:56:45 +01:00
Severin Meyer
26953e0bf9
C.139: Fix typo in text
2016-11-17 14:55:54 +01:00
Severin Meyer
fc0999c56e
C.129: Fix typo in text
2016-11-17 14:54:52 +01:00
Severin Meyer
434f995679
C.128: Fix typo in text
2016-11-17 14:53:58 +01:00
Severin Meyer
66c0348d19
C.80: Fix typo in text
2016-11-17 14:51:08 +01:00
Severin Meyer
7070ffa839
C.41: Add missing comma
2016-11-17 14:49:54 +01:00
Severin Meyer
efb284388f
C.defop: Fix typo in introductory text
2016-11-17 14:48:43 +01:00
Severin Meyer
db8273d068
C.concrete: Fix typo in introductory text
2016-11-17 14:47:44 +01:00
Severin Meyer
0d02b7e8bf
C.9: Capitalize first word of title
2016-11-17 14:45:50 +01:00
Severin Meyer
edb59eea86
C.8: Fix typo in text
2016-11-17 14:43:03 +01:00
Severin Meyer
b516c49efc
C.8: Fix typo in title and capitalize first word
2016-11-17 14:41:18 +01:00
Severin Meyer
c6071b8add
CP.41: Fix typo in code example
2016-11-17 13:28:15 +01:00
Gabriel Dos Reis
09d76d93fc
Merge pull request #791 from severinmeyer/P.9-Typo
...
P.9: Fix typo in code example
2016-11-15 07:57:54 -08:00
Severin Meyer
c3ee965a28
P.9: Fix typo in code example
2016-11-15 16:00:56 +01:00
Stéphane Magnenat
17c7ba9b8b
Fixed missing `
2016-11-15 10:25:34 +01:00
Titus Winters
3768e82fc3
Fix spelling / expand dictionary.
2016-11-10 13:35:22 -05:00
Titus Winters
e8ecae3171
Added some example tooling discussion.
2016-11-03 12:09:26 -04:00
Mustafa Serdar Sanli
53bc78fd49
Fix broken anchor link
2016-10-31 20:00:14 +00:00
Jan Nils Ferner
d86a82f1eb
Fix typo ( #782 )
2016-10-20 10:48:31 +01:00
Frank Zingsheim
84b1d80c61
T.84 Correction of Example: Change type of suc and pre to Link_base
2016-10-18 22:35:18 +02:00
Sergey Zubkov
bc41bd6e9f
dropping NVI from proto-rules due to no consensus on #768
2016-10-17 17:41:56 -04:00
Jonathan Wakely
98f1e46602
C.146 Compare pb2->id() instead of pb2
...
Fixes #504
2016-10-17 19:15:04 +01:00
Doan Tran Cong Danh
db85ec865d
ES.7 Fix typo, "i" -> "current_element_index"
2016-10-07 17:58:08 +07:00
Jonathan Wakely
aab97d9e48
C.32 Fix typo, "aide" -> "aid"
2016-10-05 13:00:48 +01:00
Eliyahu Ravuna
5f66e004d8
Exception of CP.100 refined to include the "sequentially consistent memory model" only
...
Atomic variables are safe with the sequentially consistent memory model (memory_order_seq_cst) only. Weakly ordered atomics cannot be considered safe for mainstream use. The exception clause of CP.100 refined to include the "sequentially consistent memory model" only.
cst added to dictionary
For std::memory_order_seq_cst, which is defined in <atomic>.
2016-10-04 20:36:09 +03:00
Gabriel Dos Reis
6767413118
Merge pull request #760 from derekxgl/patch-1
...
P.11 call vector reserve(100) instead of vector(100)
2016-10-04 07:25:52 -07:00
Malcolm Parsons
38772fc251
Correct spelling of nullptr
2016-10-04 15:12:56 +01:00
Derek Li
6c29e226d8
P.11 call vector reserve(100) instead of vector(100)
2016-10-04 12:55:52 +01:00
Gabriel Dos Reis
7b4a1903ec
Merge pull request #745 from kks32/master
...
Fixes wrong order of type and function name in naming scheme - master branch
2016-10-03 16:41:53 -07:00
Gabriel Dos Reis
804964d653
Merge pull request #758 from Eliyahu-Ravuna/patch-22
...
Short string optimization example for C.180
2016-10-03 16:41:07 -07:00
Eliyahu Ravuna
52c4376433
Short string optimization example for C.180
...
Extra blank lines removed
strcpy replaced with strcpy_s to get rid of Travis CI warnings
Note: strcpy_s is defined in the Annex K of the C++11 standard.
Gabriel's comments incorporated
- No need for braces for a single statement.
- Comment to explain why buffer_size is 16.
Bracing style made consistent with the rest of the examples
Bracing style made consistent with the rest of the examples
braces made consistent with the rest of the examples
2016-10-04 02:37:25 +03:00
Andrew Pardoe
f6dd6159f8
Fix issue #747
2016-10-03 15:40:56 -07:00
Andrew Pardoe
f66d9aea46
Fix 798177568e
2016-10-03 15:37:56 -07:00
Andrew Pardoe
798177568e
Merge pull request #754 from Eliyahu-Ravuna/patch-21
...
CP.110 & CP.111: Double-checked locking
2016-10-03 11:17:25 -07:00
Andrew Pardoe
b149a50faf
Merge pull request #756 from pepsiman/patch-1
...
P.5 Correct case of Int alias
2016-10-03 11:10:59 -07:00
Andrew Pardoe
4d45c6bb1d
Merge pull request #755 from pepsiman/executionpolicy
...
P.3 Split execution policy and container
2016-10-03 11:09:51 -07:00
Eliyahu Ravuna
ec2f23781d
CP.110 renamed as "Do not write your own double-checked locking"
...
CP.110 renamed as "Do not write your own double-checked locking".
Explanation and two examples added.
Added exception
Double-checked locking may be legitimately used in lock-free programming. However, see the rule [CP.100: Don't use lock-free programming unless you absolutely have to](#Rconc-lockfree).
Title made clearer and a conventional pattern has been added
* Title made clearer
* A correct example of double-checked locking has been added
Casing fixed
Casing fixed
Extra whitespace deleted
CP.110 and CP.111 separated
- CP.110: Do not write your own double-checked locking for initialization
- CP.111: Use a conventional pattern if you really need double-checked locking
Whitespace removed
Example simplified
Whitespace issue fixed.
punctuation fixed.
2016-10-03 10:21:04 +03:00
Malcolm Parsons
71df1537b3
P.5 Correct case of Int alias
...
Revert d9562f683d
and part of 9590bb94b1
2016-10-02 19:58:34 +01:00
Malcolm Parsons
e66f5bb28e
P.3 Split execution policy and container
2016-10-02 16:28:24 +01:00
Johel Ernesto Guerrero Peña
2a000ac21a
In: Grammar and correction fixes
...
We use letters to identify the first part of a rule "number", not just one letter.
The rest are grammar fixes.
2016-10-01 19:18:50 -04:00
Oleksandr Senkovych
e0abec4259
Remove mode string from ifstream constructor in R.12
2016-09-28 11:23:18 +02:00
Krishna Kumar
7f872a9d50
Fixes wrong order of type and function name in naming scheme
2016-09-27 15:43:04 -07:00
Johel Ernesto Guerrero Peña
8aaf6e1b76
Correct glossary entry order
2016-09-27 13:42:22 -04:00
Johel Ernesto Guerrero Peña
138da22db4
Fix glossary definitions and grammar
...
A class isn't abstract for having a protected constructor, but for only having protected constructors.
2016-09-27 02:00:24 -04:00
Rian Quinn
8be1869663
Update C.128 to remove override from destructors
...
Clang Tidy has a a check called (modernize-use-override) that explicitly verifies that `override` be placed on destructors of derived classes whose base class is `virtual` as seen [here](https://github.com/Microsoft/clang-tools-extra/blob/master/test/clang-tidy/modernize-use-override.cpp#L48 ). This issue was brought up by @jaredgrubb in the following [ticket](https://github.com/isocpp/CppCoreGuidelines/issues/721#issuecomment-246627077 ) and was also seen [here](https://github.com/Bareflank/hypervisor/issues/208 ) as well. @gdr-at-ms closed the ticket stating that the C++ Core Guideline Editors have decided that `override` should not be placed on destructors, but the documentation makes no mention of this decision. The following PR addresses this issue. With the documentation updated, an issue ticket can be generated for Clang Tidy to have the destructor check modified to reflect the C++ Core Guidance.
2016-09-13 07:05:52 -06:00
Gabriel Dos Reis
3f33bd9c89
Merge pull request #730 from olafdietsche/spelling
...
Minor spelling fixes
2016-09-12 11:48:55 -07:00
Gabriel Dos Reis
729c515a2b
Merge pull request #703 from amdn/master
...
T.44: Added `s` suffix to string literal
2016-09-12 11:13:04 -07:00
Andrew Pardoe
c4a19c99b2
Merge pull request #706 from tkruse/fix-examples2
...
Fix examples2
2016-09-12 11:11:16 -07:00
Andrew Pardoe
97503abeaa
Merge pull request #700 from tkruse/fix-examples
...
fix code examples
2016-09-12 11:08:13 -07:00
Akim Demaille
2b80bc92a5
T.65: fix code examples
2016-09-12 18:41:54 +02:00
Olaf Dietsche
bb2e744c3f
Minor spelling fixes
2016-09-11 17:19:52 +02:00
Thibault Kruse
1c0e2b7d11
fix invalid code
2016-09-10 22:56:15 +09:00
Thibault Kruse
25e3ec4652
improve code example, use() function makes little sense with void results of f() and g()
2016-09-10 22:56:15 +09:00
Thibault Kruse
7c991f0e7e
fix varname
2016-09-10 22:56:15 +09:00
Thibault Kruse
a361c37f5e
unique funIds
2016-09-10 22:56:15 +09:00
Thibault Kruse
9590bb94b1
fix code examples
2016-09-10 22:56:14 +09:00
Thibault Kruse
2db47928df
fix unnecessary block
2016-09-10 22:56:11 +09:00
Thibault Kruse
6a39a88bf8
Fix initializer list example
2016-09-10 22:56:11 +09:00
Gabriel Dos Reis
3acba2ebae
Merge pull request #726 from tkruse/fix-typos
...
Fix typos
2016-09-09 19:23:25 -07:00
Olaf Dietsche
bceec9e494
CP.3: Fix example: function declarations
2016-09-09 18:44:19 +02:00
Thibault Kruse
a11f1f7f53
fix typos
2016-09-07 18:17:59 +09:00
Felix Morgner
8078b0a1f8
Move whitespace to right place
2016-09-06 15:43:55 +02:00
Thibault Kruse
1e4b13bfb0
fix whitespace after comma
2016-09-06 18:32:23 +09:00
Thibault Kruse
9c148afad3
Fix transition of *Excption* to #### Exception in 4d7b1d
2016-09-06 18:31:47 +09:00
Thibault Kruse
254c123c14
fix internal link
2016-09-05 22:22:08 +09:00
Thibault Kruse
13419aa5dd
fix code style
2016-09-05 22:17:03 +09:00
Thibault Kruse
603a1b4286
Fix whitespace inconsistencies, remove tabs
2016-09-05 22:08:04 +09:00
Thibault Kruse
27b585ad71
style issues
2016-09-05 22:08:04 +09:00
Bjarne Stroustrup
0aea7d997b
Added Per.7
...
Design to enable optimization
2016-09-04 11:08:54 -04:00
Jeroen Habraken
bf0d7e415f
Fixes the NL.26 link.
2016-08-31 16:32:34 -07:00
Neil MacIntosh
b5d5d3f547
Fix order of declarations inside example
...
Fixes #668 .
2016-08-30 14:31:16 -07:00
Neil MacIntosh
d1f22ae88d
Fix order of declarations inside example
...
As per #668 , fixing order of declarations in example to match NL.16.
2016-08-30 14:22:40 -07:00
Bjarne Stroustrup
3ca23f1575
fix Enum.4
2016-08-29 15:50:47 -04:00
Bjarne Stroustrup
3ec8cfc5cc
Issue 660
...
Note added
2016-08-28 14:49:47 -04:00
Bjarne Stroustrup
4d7b1d7b63
minor formatting changes
2016-08-28 14:39:49 -04:00
Bjarne Stroustrup
56b4efd430
fixing some bugs in examples
...
#697
2016-08-28 12:31:11 -04:00
Thibault Kruse
4d97aea4c9
fix typos
2016-08-28 11:58:16 +09:00
Bjarne Stroustrup
d7725aa37c
ES.100
...
new example
2016-08-27 21:14:16 -04:00
Bjarne Stroustrup
1d53754694
Union section fleshed out
...
#692 #570
2016-08-27 14:49:57 -04:00
Bjarne Stroustrup
cbad9769de
ES.102 fleshed out
...
response to issue #675
2016-08-26 16:30:20 -04:00
Bjarne Stroustrup
34e719bb36
ES.12: Do not reuse names in nested scopes
...
new rule, and a few minor fixes
2016-08-26 11:48:09 -04:00
Gabriel Dos Reis
ca798a640b
Merge pull request #709 from tkruse/fix-typos
...
Fix typos
2016-08-25 20:02:23 -07:00
Thibault Kruse
83f60b4415
Fix typos
2016-08-26 04:59:00 +02:00
Thibault Kruse
5aea4a1fef
style: fix code indentation
2016-08-26 04:03:20 +02:00
Bjarne Stroustrup
67191255fa
Updates to NR section
2016-08-25 16:18:48 -04:00
Arturo Martín-de-Nicolás
d01675876f
Added s
suffix to string literal
...
As written, the type for "Hamlet" without the `s` suffix will be deduced to `const char*` instead of the intended `std::string`, see example earlier for auto deduced `std::string` for "Ophelia"s with the `s` suffix.
2016-08-24 16:01:48 -05:00
Bjarne Stroustrup
1ddd9cdb7a
typo fix
...
P.11 issue #670
2016-08-24 11:18:58 -04:00
Andrew Pardoe
3f0aa7c379
Merge pull request #694 from tkruse/merge-leftovers
...
Bad Merge leftovers
2016-08-22 18:00:04 -07:00
Thibault Kruse
1931fdcff5
Google styleguide now lives on github
2016-08-23 00:15:42 +02:00
Thibault Kruse
a1c248b26f
unique variable names in example
2016-08-22 23:21:14 +02:00
Thibault Kruse
c0bff45961
style fixes
2016-08-22 23:21:14 +02:00
Andrew Pardoe
9cf040ebec
Merge branch 'fix-style-classname' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-style-classname
2016-08-22 12:00:11 -07:00
Andrew Pardoe
fbe6aac021
Merge pull request #618 from tlanc007/CP.2_617
...
CP.2_617: Changed variable s to a tigher form of span.
2016-08-22 11:43:39 -07:00
Gabriel Dos Reis
6760960e7a
Merge pull request #613 from tlanc007/C.33_610
...
C.33_610: changed owner<T>* to owner<T*> per issue 610
2016-08-22 11:39:31 -07:00
Gabriel Dos Reis
4efa0fb291
Merge pull request #666 from tkruse/dodgy-code
...
Minor dodgy code issues
2016-08-22 11:33:01 -07:00
Andrew Pardoe
7cbdb3d356
Merge branch 'fix-unique-anchors' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-unique-anchors
2016-08-22 11:27:12 -07:00
Gabriel Dos Reis
7e34d8880c
Merge pull request #681 from tkruse/rebased-typo-fixes
...
Rebased typo fixes
2016-08-22 11:25:56 -07:00
Andrew Pardoe
bfcffb8561
Merge branch 'master' of https://github.com/0x8000-0000/CppCoreGuidelines into 0x8000-0000-master
2016-08-22 11:16:42 -07:00
Andrew Pardoe
3f3d80d7ec
Reapplying one fix from 680 after a slightly bad merge
2016-08-22 11:11:10 -07:00
Andrew Pardoe
6ba822f535
Merge branch 'upgrade-checkers' of https://github.com/tkruse/CppCoreGuidelines into tkruse-upgrade-checkers
2016-08-22 11:09:01 -07:00
Andrew Pardoe
7f510892e5
Merge pull request #680 from tkruse/fix-style
...
style fixes
2016-08-22 11:05:40 -07:00
Andrew Pardoe
9a9e958955
Manually fixed PR #657
2016-08-22 10:49:29 -07:00
Andreas Scherer
25044afca0
Correct a few typos.
...
A quick inspection with 'aspell -l en_US'.
2016-08-21 12:26:42 +02:00
Thibault Kruse
be304fedd6
R.1 example: change names according to NL.8
2016-08-18 02:00:36 +02:00
Thibault Kruse
0af83def79
Style: Rename classes with underscore as separator
2016-08-18 01:49:26 +02:00
Thibault Kruse
2bfb860cfe
separate names with underscores
2016-08-18 01:47:12 +02:00
Thibault Kruse
0701c4df62
Style: Consistently name custom classes with initial capital and underscore notation
2016-08-18 01:33:29 +02:00
Thibault Kruse
00cf8d08ff
Fix bad reference
2016-08-17 22:25:49 +02:00
Sam Bristow
9f2d2645ff
Remove rogue comma from example
2016-08-17 18:29:08 +02:00
Passw
04cd9a5d73
fix typo
2016-08-17 18:28:24 +02:00
Robin Degen
d084dcef31
Fixed typo shuld -> should, fixed missing words
2016-08-17 18:26:59 +02:00
Thibault Kruse
70d056f087
Fix duplicate/wrong anchors. Fix Makefile uniq check for anchors, must sort
2016-08-17 18:05:33 +02:00
Thibault Kruse
4cbbf55bd3
style fixes
2016-08-17 18:01:58 +02:00
Thibault Kruse
6e1599f6f9
style fixes
2016-08-17 17:55:51 +02:00
Thibault Kruse
0120560f13
update to pypi cpplint 1.3.0, fix linter errors
2016-08-17 17:53:57 +02:00
Thibault Kruse
ced78ffad1
typo
2016-08-17 17:53:44 +02:00
Thibault Kruse
6867d13363
type error
2016-08-17 17:53:43 +02:00
Thibault Kruse
9160dbb818
invalid enums
2016-08-17 17:53:43 +02:00
Thibault Kruse
b14fe453a4
avoid keyword name
2016-08-17 17:53:43 +02:00
Thibault Kruse
9d4fc0b5cb
bad type
2016-08-17 17:53:43 +02:00
Thibault Kruse
d6ffbfdcc2
missing semicolon
2016-08-17 17:53:43 +02:00
Thibault Kruse
3e1519beb3
bad parens within name
2016-08-17 17:53:43 +02:00
Thibault Kruse
bcca1488e8
unique var names in example
2016-08-17 17:53:43 +02:00
Thibault Kruse
46a26976ba
typo in method invocation
2016-08-17 17:53:43 +02:00
Thibault Kruse
4e46bd9a8b
fix indent
2016-08-17 17:53:43 +02:00
Thibault Kruse
12bdb63b06
fix parens
2016-08-17 17:53:42 +02:00
Thibault Kruse
6a8728a054
qualified access
2016-08-17 17:53:42 +02:00
Thibault Kruse
04345df6d0
remove duplicate constructor
2016-08-17 17:53:42 +02:00
Thibault Kruse
0997489573
bad signature
2016-08-17 17:53:42 +02:00
Thibault Kruse
b9f41b5cd0
missing template argument
2016-08-17 17:53:42 +02:00
Thibault Kruse
0b15a43c54
missing comma
2016-08-17 17:53:42 +02:00
Thibault Kruse
dc683521ee
wrong sample class
2016-08-17 17:53:42 +02:00
Thibault Kruse
01b66d9a7e
unique variable names in example
2016-08-17 17:53:42 +02:00
Thibault Kruse
bf11606c1a
completely implement assignOperator
2016-08-17 17:53:42 +02:00
Thibault Kruse
165c61e7ce
bad signature
...
# Conflicts:
# CppCoreGuidelines.md
2016-08-17 17:53:42 +02:00
Thibault Kruse
005e546d63
bad return type
2016-08-17 17:53:41 +02:00
Thibault Kruse
2a9d0a43b8
dodgy example code
2016-08-17 17:53:41 +02:00
Thibault Kruse
360ba610d1
Fix many typos
2016-08-17 17:40:13 +02:00
Gabriel Dos Reis
d4da142302
Merge pull request #678 from alex-weej/patch-3
...
Typos in NL.7
2016-08-17 08:35:06 -07:00
Alexander “weej” Jones
43f6b85fbc
Typos in NL.7
2016-08-17 16:15:00 +01:00
Alexander “weej” Jones
ca4b223a27
Typo "intelligible"
2016-08-17 16:13:55 +01:00
Andrew Pardoe
3dcc0e6976
Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines
2016-08-15 11:48:38 -07:00
Andrew Pardoe
745b148ba7
Merge PR #643
2016-08-15 11:48:02 -07:00
Gabriel Dos Reis
5ced8d0e16
Merge pull request #605 from anthonywilliams/master
...
Fix some typos in the concurrency section
2016-08-15 11:45:02 -07:00
ypyf
866abafb07
fixed typo
2016-08-15 13:56:17 +08:00
Pim Schellart
e708b8856d
Fix link
2016-08-09 08:24:32 -04:00
Lars Volker
91ceea287c
Fix typo
2016-08-06 19:28:55 +02:00
Bjarne Stroustrup
a0a1d8615c
some cleanup in NL and SL
2016-07-28 20:08:07 -04:00
Gabriel Dos Reis
72a58497a9
Merge pull request #648 from cubbimew/travis-fixes
...
fix Travis CI issues caused by recent direct commits
2016-07-28 09:24:26 -07:00
Bjarne Stroustrup
a5cd446ccf
minor cleanup of exception section
...
Closing issue 313 on E.25 for now
2016-07-28 10:51:47 -04:00
Bjarne Stroustrup
441070c203
PRO->PRO and CON->Con
...
they are not acronyms
2016-07-28 09:07:25 -04:00
Sergey Zubkov
7890037c8d
fix Travis CI issues caused by recent direct commits
2016-07-27 21:30:55 -04:00
Bjarne Stroustrup
141356db52
F.21 and GSL and Etc.
...
The cleanup continues.
Note the caller-allocates example in F.21.
Note the attempted cleanup of the Enforcement section of F.7: too many
ands and ors; did I get it right?
Note the simplification of the treatment of char* in the GSL section;
char* is considered a pointer to a single char, rather than a C-style
string; viable?
2016-07-27 16:08:21 -04:00
Florin Iucha
3876d12c63
Fix a few typos
2016-07-24 23:08:18 -04:00
Bjarne Stroustrup
d155244c70
a few minor changes
2016-07-21 16:27:25 -04:00
Bjarne Stroustrup
1b026e5492
Slight cleanup in profiles section
2016-07-21 11:31:53 -04:00
Bjarne Stroustrup
cb5bab9ae5
C.129
...
rationale and examples added
2016-07-20 15:35:41 -04:00
Bjarne Stroustrup
df88742f7d
int->if
2016-07-19 20:28:36 -04:00
Bjarne Stroustrup
25deeba3b5
T.140
2016-07-19 16:49:44 -04:00
Bjarne Stroustrup
6d1de28c91
template rule cleanup
2016-07-19 14:42:02 -04:00
Bjarne Stroustrup
c553535fb8
fixing typos
...
adding "concept" markers, hopefully to minimize confusion
2016-07-18 21:10:52 -04:00
Bjarne Stroustrup
bf5635d085
a few changes to "Templates"
...
and a definition of "Library"
2016-07-18 15:50:43 -04:00
Bjarne Stroustrup
2950a03589
Cleanup of the template section
...
More cleanup is needed
The new T.41 is interesting
2016-07-17 20:49:06 -04:00
Bjarne Stroustrup
ae8c320cdf
Update and extension of enumeration section
2016-07-16 18:13:43 -04:00
Bjarne Stroustrup
39eaac7317
Cleanup of P and I
...
P.11 added
2016-07-16 15:17:33 -04:00
Bjarne Stroustrup
e63549f287
Improve F.22
2016-07-16 13:50:38 -04:00
Gabriel Dos Reis
7c9ec43f8b
Merge pull request #642 from galik/SL.50fix-typos
...
Fix typos in SL.50
2016-07-13 13:37:49 -07:00
Sergey Zubkov
ba8ccd35a5
Fix Travis CI by reverting "Better comment for implicit conversion example"
...
This reverts commit c2f54b5ed1
.
2016-07-13 15:15:23 -04:00
galik
b290556127
Fix typos in SL.50
2016-07-13 19:15:04 +01:00
Andrew Pardoe
c2f54b5ed1
Better comment for implicit conversion example
2016-07-11 13:36:03 -07:00
Andrew Pardoe
c9bd992a92
Merge pull request #635 from grzebiel/master
...
use proper argument for creation of span from array
2016-07-11 12:13:14 -07:00
grzebiel
f4ad185de5
visualy align comments
2016-07-09 23:14:47 +02:00
Jeff Hutchison
ddc0093d7e
Fix the URL to isocpp.org.
2016-06-27 06:35:07 -04:00
grzebiel
470a603239
use proper argument for creation of span from array
2016-06-25 23:51:52 +02:00
tal
5d19b4b875
CP.2_617: Switched to an alternate form of span<>.
2016-05-23 14:41:16 -07:00
tal
54bd880898
C.33_610: changed owner<T>* to owner<T*> per issue 610
...
Did not change the owner<T> to owner<T*> in the Enforcement section.
2016-05-19 10:25:37 -07:00
tal
c3e45c9403
R.3_609: changed owner<T> to owner<T*> in R.3 per issue #609
2016-05-18 18:21:00 -07:00
Anthony Williams
60e3875e63
Fix some typos in the concurrency section
2016-05-09 13:52:32 +01:00
eyal bari
e41f3f85f8
fix mixed index / iterator loop condition
...
replaced end with size
2016-05-03 11:02:33 +03:00
Sergey Zubkov
d7d39b4c98
update FAQ.55
2016-04-26 21:28:47 -04:00
Thibault Kruse
0ad523eecf
fix cpplint style warnings
2016-04-24 22:32:11 +02:00
Thibault Kruse
765ebd6fbc
fix slanted quotes
2016-04-24 22:25:05 +02:00
Andrew Pardoe
3b93c16fbd
Merge pull request #596 from tkruse/style-fix27
...
Style fix27
2016-04-24 09:58:29 -07:00
Andrew Pardoe
11ee7e5626
Merge branch 'patch-1' of https://github.com/rafzi/CppCoreGuidelines into rafzi-patch-1
2016-04-24 09:53:53 -07:00
Andrew Pardoe
d6143fb6c7
Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines
2016-04-24 09:51:14 -07:00
Andrew Pardoe
e19e0575c0
Merge branch 'fix-linelength' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-linelength
2016-04-24 09:48:24 -07:00
Andrew Pardoe
27dc740789
Merge pull request #593 from ubique/span-c-style-traversal-example
...
Fix span C-style traversal example
2016-04-24 09:43:26 -07:00
Andrew Pardoe
11718e96a2
Merge branch 'check-badchars' of https://github.com/tkruse/CppCoreGuidelines into tkruse-check-badchars
2016-04-24 09:23:48 -07:00
Boris Smidt
122ce83509
fixed markdown style errors
2016-04-24 17:51:54 +02:00
Boris Smidt
757737e86d
changed tabs into 4 spaces
2016-04-24 17:44:02 +02:00
rafzi
109f00847a
Fix bounds.3 example
2016-04-23 22:36:45 +02:00
Bjarne Stroustrup
e8dea3807a
replaced the concurrency section
...
a couple of dozen new rules;
introduced raii_thread and detached_thread.
ntroduced the beginnings of lifetime and ownership safety.
2016-04-23 12:11:46 -04:00
Bjarne Stroustrup
d76d8c31ef
"do no harm"
...
a philosophical addition
2016-04-23 11:51:17 -04:00
Thibault Kruse
d7bab1ab0f
Fix whitespace around operator
2016-04-23 14:16:59 +02:00
Thibault Kruse
da92068a5f
Shorten Fix longest C++ lines longer than 100 chars
2016-04-23 11:41:51 +02:00
Dmitry Banschikov
5ece97ed68
Fix span C-style traversal example
2016-04-22 19:26:58 +03:00
Thibault Kruse
321e411e4f
Fix further typographic mistakes
2016-04-18 20:53:12 +02:00
Andreas Scherer
6353ff2c8f
Undo typographic apostrophes.
...
Double- and single-quotes (apostrophes) are written in their "straight"
versions. The task of replacing them by their typographic versions is
left to the Markdown renderer, e.g., `pandoc --smart ...`.
2016-04-18 20:53:12 +02:00
Andreas Scherer
b83449a33b
Consistent use of double-hyphen for en-dash.
...
Use `--` for all occurrences of en-dashes. All UTF-8 dashes are reduced
to this convention. Let the Markdown renderer cope with the correct
expansion of such items, e.g., `pandoc --smart ...`.
2016-04-18 20:53:12 +02:00
Andrew Pardoe
111dcfada1
Merge pull request #589 from tkruse/remark-fix
...
Remark fix
2016-04-18 07:16:19 -07:00
Andrew Pardoe
2a95737285
Merge branch 'style-fix26' of https://github.com/tkruse/CppCoreGuidelines into tkruse-style-fix26
2016-04-18 07:13:27 -07:00
Thibault Kruse
91a731a6f8
Remove last 2 tab instances, Flag all tabs as warning breaking travis build
2016-04-17 18:56:29 +02:00
Thibault Kruse
0491ccb880
Remove superfluous newlines
2016-04-17 18:33:52 +02:00
Thibault Kruse
34d6c79f06
Escape slashes to fix footnote warnings
2016-04-17 18:32:58 +02:00
Thibault Kruse
d9562f683d
typo Int -> int
2016-04-17 18:00:44 +02:00
Thibault Kruse
e8675ea23a
unify dummy function names
2016-04-17 18:00:44 +02:00
Thibault Kruse
c4698f22fe
Consistently use simple function name for meaningless functions
2016-04-17 18:00:11 +02:00
Thibault Kruse
e910836f3b
typo
2016-04-17 18:00:11 +02:00
Thibault Kruse
1863a750c0
whitespace
2016-04-17 18:00:11 +02:00
Thibault Kruse
0695f5968d
fix ellipses encoding
2016-04-17 18:00:11 +02:00
Thibault Kruse
19c0e77a6e
Fix whitespace around operators and commas
2016-04-17 11:25:26 +02:00
Thibault Kruse
a9c42279bb
delete trailing whitespace
2016-04-17 11:25:18 +02:00
Thibault Kruse
55083af21e
fix line length
2016-04-17 11:25:07 +02:00
Thibault Kruse
46b4a20881
Minor style: convert tabs to spaces
2016-04-17 11:24:48 +02:00
d3fault
8382c216d7
Fix tiny typo in CP.2
2016-04-12 21:08:25 -07:00
Andrew Pardoe
68af55caaf
Removing the rest of the unnecessary escapes
2016-04-11 14:27:00 -07:00
Roman
6ea1422dd6
Update CppCoreGuidelines.md
...
Must be `int* p = new int[12]; delete[] p;`
2016-04-11 14:41:58 +04:00
Andrew Pardoe
7255e7d2f0
Testing formatting on bibliography
2016-04-10 12:37:59 -07:00
Thibault Kruse
006832159c
Consistent References Blocks
2016-04-09 11:40:11 +02:00
Thibault Kruse
f9ebe1fc9a
Fix missing open braces escape and missing backticks
2016-04-09 11:29:21 +02:00
Thibault Kruse
c8a18317c1
whitespaces fixes, by remark tool
2016-04-09 11:29:00 +02:00
Andrew Pardoe
033918b998
Updating date
2016-04-07 17:01:36 -07:00