StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Rename rnd to round in I.1

Browse Source 
At first, I assumed that this is "rand" function, not "round" function,
and was confused why exactly is it a problem that this returns
different values. While it's easy to notice when actually reading the
code, this slows down the comprehension, and bad function naming is
not point of that particular guideline.
This commit is contained in:
Konrad Borowski 2017-06-10 12:08:12 +02:00 committed by GitHub
parent 6907911089
commit 7367e07598
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
CppCoreGuidelines.md
View File

@ -1223,12 +1223,12 @@ Correctness. Assumptions not stated in an interface are easily overlooked and ha
Controlling the behavior of a function through a global (namespace scope) variable (a call mode) is implicit and potentially confusing. For example:
int rnd(double d)
int round(double d)
{
return (rnd_up) ? ceil(d) : d; // don't: "invisible" dependency
return (round_up) ? ceil(d) : d; // don't: "invisible" dependency
}
It will not be obvious to a caller that the meaning of two calls of `rnd(7.2)` might give different results.
It will not be obvious to a caller that the meaning of two calls of `round(7.2)` might give different results.
##### Exception