StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity
1,339 Commits 14 Branches 4 Tags 216 MiB
e12e73e670
Commit Graph

1073 Commits

Author SHA1 Message Date
Stéphane Magnenat
17c7ba9b8b Fixed missing ` 2016-11-15 10:25:34 +01:00
Titus Winters
3768e82fc3 Fix spelling / expand dictionary. 2016-11-10 13:35:22 -05:00
Titus Winters
e8ecae3171 Added some example tooling discussion. 2016-11-03 12:09:26 -04:00
Mustafa Serdar Sanli
53bc78fd49 Fix broken anchor link 2016-10-31 20:00:14 +00:00
Jan Nils Ferner
d86a82f1eb Fix typo (#782) 2016-10-20 10:48:31 +01:00
Frank Zingsheim
84b1d80c61 T.84 Correction of Example: Change type of suc and pre to Link_base 2016-10-18 22:35:18 +02:00
Sergey Zubkov
bc41bd6e9f dropping NVI from proto-rules due to no consensus on #768 2016-10-17 17:41:56 -04:00
Jonathan Wakely
98f1e46602 C.146 Compare pb2->id() instead of pb2 
Fixes #504
 2016-10-17 19:15:04 +01:00
Doan Tran Cong Danh
db85ec865d ES.7 Fix typo, "i" -> "current_element_index" 2016-10-07 17:58:08 +07:00
Jonathan Wakely
aab97d9e48 C.32 Fix typo, "aide" -> "aid" 2016-10-05 13:00:48 +01:00
Eliyahu Ravuna
5f66e004d8 Exception of CP.100 refined to include the "sequentially consistent memory model" only 
Atomic variables are safe with the sequentially consistent memory model (memory_order_seq_cst) only. Weakly ordered atomics cannot be considered safe for mainstream use. The exception clause of CP.100 refined to include the "sequentially consistent memory model" only.

cst added to dictionary

For std::memory_order_seq_cst, which is defined in <atomic>.
 2016-10-04 20:36:09 +03:00
Gabriel Dos Reis
6767413118 Merge pull request #760 from derekxgl/patch-1 
P.11 call vector reserve(100) instead of vector(100)
 2016-10-04 07:25:52 -07:00
Malcolm Parsons
38772fc251 Correct spelling of nullptr 2016-10-04 15:12:56 +01:00
Derek Li
6c29e226d8 P.11 call vector reserve(100) instead of vector(100) 2016-10-04 12:55:52 +01:00
Gabriel Dos Reis
7b4a1903ec Merge pull request #745 from kks32/master 
Fixes wrong order of type and function name in naming scheme - master branch
 2016-10-03 16:41:53 -07:00
Gabriel Dos Reis
804964d653 Merge pull request #758 from Eliyahu-Ravuna/patch-22 
Short string optimization example for C.180
 2016-10-03 16:41:07 -07:00
Eliyahu Ravuna
52c4376433 Short string optimization example for C.180 
Extra blank lines removed

strcpy replaced with strcpy_s to get rid of Travis CI warnings

Note: strcpy_s  is defined in the Annex K of the C++11 standard.

Gabriel's comments incorporated

- No need for braces for a single statement.
- Comment to explain why buffer_size is 16.

Bracing style made consistent with the rest of the examples

Bracing style made consistent with the rest of the examples

braces made consistent with the rest of the examples
 2016-10-04 02:37:25 +03:00
Andrew Pardoe
f6dd6159f8 Fix issue #747 2016-10-03 15:40:56 -07:00
Andrew Pardoe
f66d9aea46 Fix 798177568e 2016-10-03 15:37:56 -07:00
Andrew Pardoe
798177568e Merge pull request #754 from Eliyahu-Ravuna/patch-21 
CP.110 & CP.111: Double-checked locking
 2016-10-03 11:17:25 -07:00
Andrew Pardoe
b149a50faf Merge pull request #756 from pepsiman/patch-1 
P.5 Correct case of Int alias
 2016-10-03 11:10:59 -07:00
Andrew Pardoe
4d45c6bb1d Merge pull request #755 from pepsiman/executionpolicy 
P.3 Split execution policy and container
 2016-10-03 11:09:51 -07:00
Eliyahu Ravuna
ec2f23781d CP.110 renamed as "Do not write your own double-checked locking" 
CP.110 renamed as "Do not write your own double-checked locking".
Explanation and two examples added.

Added exception

Double-checked locking may be legitimately used in lock-free programming. However, see the rule [CP.100: Don't use lock-free programming unless you absolutely have to](#Rconc-lockfree).

Title made clearer and a conventional pattern has been added

* Title made clearer
* A correct example of double-checked locking has been added

Casing fixed

Casing fixed

Extra whitespace deleted

CP.110 and CP.111 separated

- CP.110: Do not write your own double-checked locking for initialization
- CP.111: Use a conventional pattern if you really need double-checked locking

Whitespace removed

Example simplified

Whitespace issue fixed.

punctuation fixed.
 2016-10-03 10:21:04 +03:00
Malcolm Parsons
71df1537b3 P.5 Correct case of Int alias 
Revert d9562f683d and part of 9590bb94b1
 2016-10-02 19:58:34 +01:00
Malcolm Parsons
e66f5bb28e P.3 Split execution policy and container 2016-10-02 16:28:24 +01:00
Johel Ernesto Guerrero Peña
2a000ac21a In: Grammar and correction fixes 
We use letters to identify the first part of a rule "number", not just one letter.
The rest are grammar fixes.
 2016-10-01 19:18:50 -04:00
Oleksandr Senkovych
e0abec4259 Remove mode string from ifstream constructor in R.12 2016-09-28 11:23:18 +02:00
Krishna Kumar
7f872a9d50 Fixes wrong order of type and function name in naming scheme 2016-09-27 15:43:04 -07:00
Johel Ernesto Guerrero Peña
8aaf6e1b76 Correct glossary entry order 2016-09-27 13:42:22 -04:00
Johel Ernesto Guerrero Peña
138da22db4 Fix glossary definitions and grammar 
A class isn't abstract for having a protected constructor, but for only having protected constructors.
 2016-09-27 02:00:24 -04:00
Rian Quinn
8be1869663 Update C.128 to remove override from destructors 
Clang Tidy has a a check called (modernize-use-override) that explicitly verifies that `override` be placed on destructors of derived classes whose base class is `virtual` as seen [here](https://github.com/Microsoft/clang-tools-extra/blob/master/test/clang-tidy/modernize-use-override.cpp#L48). This issue was brought up by @jaredgrubb in the following [ticket](https://github.com/isocpp/CppCoreGuidelines/issues/721#issuecomment-246627077) and was also seen [here](https://github.com/Bareflank/hypervisor/issues/208) as well. @gdr-at-ms closed the ticket stating that the C++ Core Guideline Editors have decided that `override` should not be placed on destructors, but the documentation makes no mention of this decision. The following PR addresses this issue. With the documentation updated, an issue ticket can be generated for Clang Tidy to have the destructor check modified to reflect the C++ Core Guidance.
 2016-09-13 07:05:52 -06:00
Gabriel Dos Reis
3f33bd9c89 Merge pull request #730 from olafdietsche/spelling 
Minor spelling fixes
 2016-09-12 11:48:55 -07:00
Gabriel Dos Reis
729c515a2b Merge pull request #703 from amdn/master 
T.44: Added `s` suffix to string literal
 2016-09-12 11:13:04 -07:00
Andrew Pardoe
c4a19c99b2 Merge pull request #706 from tkruse/fix-examples2 
Fix examples2
 2016-09-12 11:11:16 -07:00
Andrew Pardoe
97503abeaa Merge pull request #700 from tkruse/fix-examples 
fix code examples
 2016-09-12 11:08:13 -07:00
Akim Demaille
2b80bc92a5 T.65: fix code examples 2016-09-12 18:41:54 +02:00
Olaf Dietsche
bb2e744c3f Minor spelling fixes 2016-09-11 17:19:52 +02:00
Thibault Kruse
1c0e2b7d11 fix invalid code 2016-09-10 22:56:15 +09:00
Thibault Kruse
25e3ec4652 improve code example, use() function makes little sense with void results of f() and g() 2016-09-10 22:56:15 +09:00
Thibault Kruse
7c991f0e7e fix varname 2016-09-10 22:56:15 +09:00
Thibault Kruse
a361c37f5e unique funIds 2016-09-10 22:56:15 +09:00
Thibault Kruse
9590bb94b1 fix code examples 2016-09-10 22:56:14 +09:00
Thibault Kruse
2db47928df fix unnecessary block 2016-09-10 22:56:11 +09:00
Thibault Kruse
6a39a88bf8 Fix initializer list example 2016-09-10 22:56:11 +09:00
Gabriel Dos Reis
3acba2ebae Merge pull request #726 from tkruse/fix-typos 
Fix typos
 2016-09-09 19:23:25 -07:00
Olaf Dietsche
bceec9e494 CP.3: Fix example: function declarations 2016-09-09 18:44:19 +02:00
Thibault Kruse
a11f1f7f53 fix typos 2016-09-07 18:17:59 +09:00
Felix Morgner
8078b0a1f8 Move whitespace to right place 2016-09-06 15:43:55 +02:00
Thibault Kruse
1e4b13bfb0 fix whitespace after comma 2016-09-06 18:32:23 +09:00
Thibault Kruse
9c148afad3 Fix transition of *Excption* to #### Exception in 4d7b1d 2016-09-06 18:31:47 +09:00
Thibault Kruse
254c123c14 fix internal link 2016-09-05 22:22:08 +09:00
Thibault Kruse
13419aa5dd fix code style 2016-09-05 22:17:03 +09:00
Thibault Kruse
603a1b4286 Fix whitespace inconsistencies, remove tabs 2016-09-05 22:08:04 +09:00
Thibault Kruse
27b585ad71 style issues 2016-09-05 22:08:04 +09:00
Bjarne Stroustrup
0aea7d997b Added Per.7 
Design to enable optimization
 2016-09-04 11:08:54 -04:00
Jeroen Habraken
bf0d7e415f Fixes the NL.26 link. 2016-08-31 16:32:34 -07:00
Neil MacIntosh
b5d5d3f547 Fix order of declarations inside example 
Fixes #668.
 2016-08-30 14:31:16 -07:00
Neil MacIntosh
d1f22ae88d Fix order of declarations inside example 
As per #668, fixing order of declarations in example to match NL.16.
 2016-08-30 14:22:40 -07:00
Bjarne Stroustrup
3ca23f1575 fix Enum.4 2016-08-29 15:50:47 -04:00
Bjarne Stroustrup
3ec8cfc5cc Issue 660 
Note added
 2016-08-28 14:49:47 -04:00
Bjarne Stroustrup
4d7b1d7b63 minor formatting changes 2016-08-28 14:39:49 -04:00
Bjarne Stroustrup
56b4efd430 fixing some bugs in examples 
#697
 2016-08-28 12:31:11 -04:00
Thibault Kruse
4d97aea4c9 fix typos 2016-08-28 11:58:16 +09:00
Bjarne Stroustrup
d7725aa37c ES.100 
new example
 2016-08-27 21:14:16 -04:00
Bjarne Stroustrup
1d53754694 Union section fleshed out 
#692 #570
 2016-08-27 14:49:57 -04:00
Bjarne Stroustrup
cbad9769de ES.102 fleshed out 
response to issue #675
 2016-08-26 16:30:20 -04:00
Bjarne Stroustrup
34e719bb36 ES.12: Do not reuse names in nested scopes 
new rule, and a few minor fixes
 2016-08-26 11:48:09 -04:00
Gabriel Dos Reis
ca798a640b Merge pull request #709 from tkruse/fix-typos 
Fix typos
 2016-08-25 20:02:23 -07:00
Thibault Kruse
83f60b4415 Fix typos 2016-08-26 04:59:00 +02:00
Thibault Kruse
5aea4a1fef style: fix code indentation 2016-08-26 04:03:20 +02:00
Bjarne Stroustrup
67191255fa Updates to NR section 2016-08-25 16:18:48 -04:00
Arturo Martín-de-Nicolás
d01675876f Added s suffix to string literal 
As written, the type for "Hamlet" without the `s` suffix will be deduced to `const char*` instead of the intended `std::string`, see example earlier for auto deduced `std::string` for "Ophelia"s with the `s` suffix.
 2016-08-24 16:01:48 -05:00
Bjarne Stroustrup
1ddd9cdb7a typo fix 
P.11 issue #670
 2016-08-24 11:18:58 -04:00
Andrew Pardoe
3f0aa7c379 Merge pull request #694 from tkruse/merge-leftovers 
Bad Merge leftovers
 2016-08-22 18:00:04 -07:00
Thibault Kruse
1931fdcff5 Google styleguide now lives on github 2016-08-23 00:15:42 +02:00
Thibault Kruse
a1c248b26f unique variable names in example 2016-08-22 23:21:14 +02:00
Thibault Kruse
c0bff45961 style fixes 2016-08-22 23:21:14 +02:00
Andrew Pardoe
9cf040ebec Merge branch 'fix-style-classname' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-style-classname 2016-08-22 12:00:11 -07:00
Andrew Pardoe
fbe6aac021 Merge pull request #618 from tlanc007/CP.2_617 
CP.2_617: Changed variable s to a tigher form of span.
 2016-08-22 11:43:39 -07:00
Gabriel Dos Reis
6760960e7a Merge pull request #613 from tlanc007/C.33_610 
C.33_610: changed owner<T>* to owner<T*> per issue 610
 2016-08-22 11:39:31 -07:00
Gabriel Dos Reis
4efa0fb291 Merge pull request #666 from tkruse/dodgy-code 
Minor dodgy code issues
 2016-08-22 11:33:01 -07:00
Andrew Pardoe
7cbdb3d356 Merge branch 'fix-unique-anchors' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-unique-anchors 2016-08-22 11:27:12 -07:00
Gabriel Dos Reis
7e34d8880c Merge pull request #681 from tkruse/rebased-typo-fixes 
Rebased typo fixes
 2016-08-22 11:25:56 -07:00
Andrew Pardoe
bfcffb8561 Merge branch 'master' of https://github.com/0x8000-0000/CppCoreGuidelines into 0x8000-0000-master 2016-08-22 11:16:42 -07:00
Andrew Pardoe
3f3d80d7ec Reapplying one fix from 680 after a slightly bad merge 2016-08-22 11:11:10 -07:00
Andrew Pardoe
6ba822f535 Merge branch 'upgrade-checkers' of https://github.com/tkruse/CppCoreGuidelines into tkruse-upgrade-checkers 2016-08-22 11:09:01 -07:00
Andrew Pardoe
7f510892e5 Merge pull request #680 from tkruse/fix-style 
style fixes
 2016-08-22 11:05:40 -07:00
Andrew Pardoe
9a9e958955 Manually fixed PR #657 2016-08-22 10:49:29 -07:00
Andreas Scherer
25044afca0 Correct a few typos. 
A quick inspection with 'aspell -l en_US'.
 2016-08-21 12:26:42 +02:00
Thibault Kruse
be304fedd6 R.1 example: change names according to NL.8 2016-08-18 02:00:36 +02:00
Thibault Kruse
0af83def79 Style: Rename classes with underscore as separator 2016-08-18 01:49:26 +02:00
Thibault Kruse
2bfb860cfe separate names with underscores 2016-08-18 01:47:12 +02:00
Thibault Kruse
0701c4df62 Style: Consistently name custom classes with initial capital and underscore notation 2016-08-18 01:33:29 +02:00
Thibault Kruse
00cf8d08ff Fix bad reference 2016-08-17 22:25:49 +02:00
Sam Bristow
9f2d2645ff Remove rogue comma from example 2016-08-17 18:29:08 +02:00
Passw
04cd9a5d73 fix typo 2016-08-17 18:28:24 +02:00
Robin Degen
d084dcef31 Fixed typo shuld -> should, fixed missing words 2016-08-17 18:26:59 +02:00
Thibault Kruse
70d056f087 Fix duplicate/wrong anchors. Fix Makefile uniq check for anchors, must sort 2016-08-17 18:05:33 +02:00
Thibault Kruse
4cbbf55bd3 style fixes 2016-08-17 18:01:58 +02:00
Thibault Kruse
6e1599f6f9 style fixes 2016-08-17 17:55:51 +02:00
Thibault Kruse
0120560f13 update to pypi cpplint 1.3.0, fix linter errors 2016-08-17 17:53:57 +02:00
Thibault Kruse
ced78ffad1 typo 2016-08-17 17:53:44 +02:00
Thibault Kruse
6867d13363 type error 2016-08-17 17:53:43 +02:00
Thibault Kruse
9160dbb818 invalid enums 2016-08-17 17:53:43 +02:00
Thibault Kruse
b14fe453a4 avoid keyword name 2016-08-17 17:53:43 +02:00
Thibault Kruse
9d4fc0b5cb bad type 2016-08-17 17:53:43 +02:00
Thibault Kruse
d6ffbfdcc2 missing semicolon 2016-08-17 17:53:43 +02:00
Thibault Kruse
3e1519beb3 bad parens within name 2016-08-17 17:53:43 +02:00
Thibault Kruse
bcca1488e8 unique var names in example 2016-08-17 17:53:43 +02:00
Thibault Kruse
46a26976ba typo in method invocation 2016-08-17 17:53:43 +02:00
Thibault Kruse
4e46bd9a8b fix indent 2016-08-17 17:53:43 +02:00
Thibault Kruse
12bdb63b06 fix parens 2016-08-17 17:53:42 +02:00
Thibault Kruse
6a8728a054 qualified access 2016-08-17 17:53:42 +02:00
Thibault Kruse
04345df6d0 remove duplicate constructor 2016-08-17 17:53:42 +02:00
Thibault Kruse
0997489573 bad signature 2016-08-17 17:53:42 +02:00
Thibault Kruse
b9f41b5cd0 missing template argument 2016-08-17 17:53:42 +02:00
Thibault Kruse
0b15a43c54 missing comma 2016-08-17 17:53:42 +02:00
Thibault Kruse
dc683521ee wrong sample class 2016-08-17 17:53:42 +02:00
Thibault Kruse
01b66d9a7e unique variable names in example 2016-08-17 17:53:42 +02:00
Thibault Kruse
bf11606c1a completely implement assignOperator 2016-08-17 17:53:42 +02:00
Thibault Kruse
165c61e7ce bad signature 
# Conflicts:
#	CppCoreGuidelines.md
 2016-08-17 17:53:42 +02:00
Thibault Kruse
005e546d63 bad return type 2016-08-17 17:53:41 +02:00
Thibault Kruse
2a9d0a43b8 dodgy example code 2016-08-17 17:53:41 +02:00
Thibault Kruse
360ba610d1 Fix many typos 2016-08-17 17:40:13 +02:00
Gabriel Dos Reis
d4da142302 Merge pull request #678 from alex-weej/patch-3 
Typos in NL.7
 2016-08-17 08:35:06 -07:00
Alexander “weej” Jones
43f6b85fbc Typos in NL.7 2016-08-17 16:15:00 +01:00
Alexander “weej” Jones
ca4b223a27 Typo "intelligible" 2016-08-17 16:13:55 +01:00
Andrew Pardoe
3dcc0e6976 Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines 2016-08-15 11:48:38 -07:00
Andrew Pardoe
745b148ba7 Merge PR #643 2016-08-15 11:48:02 -07:00
Gabriel Dos Reis
5ced8d0e16 Merge pull request #605 from anthonywilliams/master 
Fix some typos in the concurrency section
 2016-08-15 11:45:02 -07:00
ypyf
866abafb07 fixed typo 2016-08-15 13:56:17 +08:00
Pim Schellart
e708b8856d Fix link 2016-08-09 08:24:32 -04:00
Lars Volker
91ceea287c Fix typo 2016-08-06 19:28:55 +02:00
Bjarne Stroustrup
a0a1d8615c some cleanup in NL and SL 2016-07-28 20:08:07 -04:00
Gabriel Dos Reis
72a58497a9 Merge pull request #648 from cubbimew/travis-fixes 
fix Travis CI issues caused by recent direct commits
 2016-07-28 09:24:26 -07:00
Bjarne Stroustrup
a5cd446ccf minor cleanup of exception section 
Closing issue 313 on E.25 for now
 2016-07-28 10:51:47 -04:00
Bjarne Stroustrup
441070c203 PRO->PRO and CON->Con 
they are not acronyms
 2016-07-28 09:07:25 -04:00
Sergey Zubkov
7890037c8d fix Travis CI issues caused by recent direct commits 2016-07-27 21:30:55 -04:00
Bjarne Stroustrup
141356db52 F.21 and GSL and Etc. 
The cleanup continues.
Note the caller-allocates example in F.21.
Note the attempted cleanup of the Enforcement section of F.7: too many
ands and ors; did I get it right?
Note the simplification of the treatment of char* in the GSL section;
char* is considered a pointer to a single char, rather than a C-style
string; viable?
 2016-07-27 16:08:21 -04:00
Florin Iucha
3876d12c63 Fix a few typos 2016-07-24 23:08:18 -04:00
Bjarne Stroustrup
d155244c70 a few minor changes 2016-07-21 16:27:25 -04:00
Bjarne Stroustrup
1b026e5492 Slight cleanup in profiles section 2016-07-21 11:31:53 -04:00
Bjarne Stroustrup
cb5bab9ae5 C.129 
rationale and examples added
 2016-07-20 15:35:41 -04:00
Bjarne Stroustrup
df88742f7d int->if 2016-07-19 20:28:36 -04:00
Bjarne Stroustrup
25deeba3b5 T.140 2016-07-19 16:49:44 -04:00
Bjarne Stroustrup
6d1de28c91 template rule cleanup 2016-07-19 14:42:02 -04:00
Bjarne Stroustrup
c553535fb8 fixing typos 
adding "concept" markers, hopefully to minimize confusion
 2016-07-18 21:10:52 -04:00
Bjarne Stroustrup
bf5635d085 a few changes to "Templates" 
and a definition of "Library"
 2016-07-18 15:50:43 -04:00
Bjarne Stroustrup
2950a03589 Cleanup of the template section 
More cleanup is needed
The new T.41 is interesting
 2016-07-17 20:49:06 -04:00
Bjarne Stroustrup
ae8c320cdf Update and extension of enumeration section 2016-07-16 18:13:43 -04:00
Bjarne Stroustrup
39eaac7317 Cleanup of P and I 
P.11 added
 2016-07-16 15:17:33 -04:00
Bjarne Stroustrup
e63549f287 Improve F.22 2016-07-16 13:50:38 -04:00
Gabriel Dos Reis
7c9ec43f8b Merge pull request #642 from galik/SL.50fix-typos 
Fix typos in SL.50
 2016-07-13 13:37:49 -07:00
Sergey Zubkov
ba8ccd35a5 Fix Travis CI by reverting "Better comment for implicit conversion example" 
This reverts commit c2f54b5ed1.
 2016-07-13 15:15:23 -04:00
galik
b290556127 Fix typos in SL.50 2016-07-13 19:15:04 +01:00
Andrew Pardoe
c2f54b5ed1 Better comment for implicit conversion example 2016-07-11 13:36:03 -07:00
Andrew Pardoe
c9bd992a92 Merge pull request #635 from grzebiel/master 
use proper argument for creation of span from array
 2016-07-11 12:13:14 -07:00
grzebiel
f4ad185de5 visualy align comments 2016-07-09 23:14:47 +02:00
Jeff Hutchison
ddc0093d7e Fix the URL to isocpp.org. 2016-06-27 06:35:07 -04:00
grzebiel
470a603239 use proper argument for creation of span from array 2016-06-25 23:51:52 +02:00
tal
5d19b4b875 CP.2_617: Switched to an alternate form of span<>. 2016-05-23 14:41:16 -07:00
tal
54bd880898 C.33_610: changed owner<T>* to owner<T*> per issue 610 
Did not change the owner<T> to owner<T*> in the Enforcement section.
 2016-05-19 10:25:37 -07:00
tal
c3e45c9403 R.3_609: changed owner<T> to owner<T*> in R.3 per issue #609 2016-05-18 18:21:00 -07:00
Anthony Williams
60e3875e63 Fix some typos in the concurrency section 2016-05-09 13:52:32 +01:00
eyal bari
e41f3f85f8 fix mixed index / iterator loop condition 
replaced end with size
 2016-05-03 11:02:33 +03:00
Sergey Zubkov
d7d39b4c98 update FAQ.55 2016-04-26 21:28:47 -04:00
Thibault Kruse
0ad523eecf fix cpplint style warnings 2016-04-24 22:32:11 +02:00
Thibault Kruse
765ebd6fbc fix slanted quotes 2016-04-24 22:25:05 +02:00
Andrew Pardoe
3b93c16fbd Merge pull request #596 from tkruse/style-fix27 
Style fix27
 2016-04-24 09:58:29 -07:00
Andrew Pardoe
11ee7e5626 Merge branch 'patch-1' of https://github.com/rafzi/CppCoreGuidelines into rafzi-patch-1 2016-04-24 09:53:53 -07:00
Andrew Pardoe
d6143fb6c7 Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines 2016-04-24 09:51:14 -07:00
Andrew Pardoe
e19e0575c0 Merge branch 'fix-linelength' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-linelength 2016-04-24 09:48:24 -07:00
Andrew Pardoe
27dc740789 Merge pull request #593 from ubique/span-c-style-traversal-example 
Fix span C-style traversal example
 2016-04-24 09:43:26 -07:00
Andrew Pardoe
11718e96a2 Merge branch 'check-badchars' of https://github.com/tkruse/CppCoreGuidelines into tkruse-check-badchars 2016-04-24 09:23:48 -07:00
Boris Smidt
122ce83509 fixed markdown style errors 2016-04-24 17:51:54 +02:00
Boris Smidt
757737e86d changed tabs into 4 spaces 2016-04-24 17:44:02 +02:00
rafzi
109f00847a Fix bounds.3 example 2016-04-23 22:36:45 +02:00
Bjarne Stroustrup
e8dea3807a replaced the concurrency section 
a couple of dozen new rules;
introduced raii_thread and detached_thread.
ntroduced the beginnings of lifetime and ownership safety.
 2016-04-23 12:11:46 -04:00
Bjarne Stroustrup
d76d8c31ef "do no harm" 
a philosophical addition
 2016-04-23 11:51:17 -04:00
Thibault Kruse
d7bab1ab0f Fix whitespace around operator 2016-04-23 14:16:59 +02:00
Thibault Kruse
da92068a5f Shorten Fix longest C++ lines longer than 100 chars 2016-04-23 11:41:51 +02:00
Dmitry Banschikov
5ece97ed68 Fix span C-style traversal example 2016-04-22 19:26:58 +03:00
Thibault Kruse
321e411e4f Fix further typographic mistakes 2016-04-18 20:53:12 +02:00
Andreas Scherer
6353ff2c8f Undo typographic apostrophes. 
Double- and single-quotes (apostrophes) are written in their "straight"
versions. The task of replacing them by their typographic versions is
left to the Markdown renderer, e.g., `pandoc --smart ...`.
 2016-04-18 20:53:12 +02:00
Andreas Scherer
b83449a33b Consistent use of double-hyphen for en-dash. 
Use `--` for all occurrences of en-dashes. All UTF-8 dashes are reduced
to this convention. Let the Markdown renderer cope with the correct
expansion of such items, e.g., `pandoc --smart ...`.
 2016-04-18 20:53:12 +02:00
Andrew Pardoe
111dcfada1 Merge pull request #589 from tkruse/remark-fix 
Remark fix
 2016-04-18 07:16:19 -07:00
Andrew Pardoe
2a95737285 Merge branch 'style-fix26' of https://github.com/tkruse/CppCoreGuidelines into tkruse-style-fix26 2016-04-18 07:13:27 -07:00
Thibault Kruse
91a731a6f8 Remove last 2 tab instances, Flag all tabs as warning breaking travis build 2016-04-17 18:56:29 +02:00
Thibault Kruse
0491ccb880 Remove superfluous newlines 2016-04-17 18:33:52 +02:00
Thibault Kruse
34d6c79f06 Escape slashes to fix footnote warnings 2016-04-17 18:32:58 +02:00
Thibault Kruse
d9562f683d typo Int -> int 2016-04-17 18:00:44 +02:00
Thibault Kruse
e8675ea23a unify dummy function names 2016-04-17 18:00:44 +02:00
Thibault Kruse
c4698f22fe Consistently use simple function name for meaningless functions 2016-04-17 18:00:11 +02:00
Thibault Kruse
e910836f3b typo 2016-04-17 18:00:11 +02:00
Thibault Kruse
1863a750c0 whitespace 2016-04-17 18:00:11 +02:00
Thibault Kruse
0695f5968d fix ellipses encoding 2016-04-17 18:00:11 +02:00
Thibault Kruse
19c0e77a6e Fix whitespace around operators and commas 2016-04-17 11:25:26 +02:00
Thibault Kruse
a9c42279bb delete trailing whitespace 2016-04-17 11:25:18 +02:00
Thibault Kruse
55083af21e fix line length 2016-04-17 11:25:07 +02:00
Thibault Kruse
46b4a20881 Minor style: convert tabs to spaces 2016-04-17 11:24:48 +02:00
d3fault
8382c216d7 Fix tiny typo in CP.2 2016-04-12 21:08:25 -07:00
Andrew Pardoe
68af55caaf Removing the rest of the unnecessary escapes 2016-04-11 14:27:00 -07:00
Roman
6ea1422dd6 Update CppCoreGuidelines.md 
Must be `int* p = new int[12]; delete[] p;`
 2016-04-11 14:41:58 +04:00
Andrew Pardoe
7255e7d2f0 Testing formatting on bibliography 2016-04-10 12:37:59 -07:00
Thibault Kruse
006832159c Consistent References Blocks 2016-04-09 11:40:11 +02:00
Thibault Kruse
f9ebe1fc9a Fix missing open braces escape and missing backticks 2016-04-09 11:29:21 +02:00
Thibault Kruse
c8a18317c1 whitespaces fixes, by remark tool 2016-04-09 11:29:00 +02:00
Andrew Pardoe
033918b998 Updating date 2016-04-07 17:01:36 -07:00
uli
4af6b1e5e0 The table of contents was missing several chapters. The TOC now correctly reflects the order of the chapters in the document. 2016-04-06 14:40:28 -07:00
uli
88a6c1d790 The rule name ES.40 was used twice. 2016-04-06 14:40:28 -07:00
Andrew Pardoe
1c3c35b0f5 Updating date 2016-04-05 18:48:55 +00:00
johan lundberg
11275aa086 Add links to GSL, structure to README.md 2016-03-26 10:52:37 +01:00
jmihalicza
f48dac72bd P.10 typo 
Sumething -> Something
 2016-03-25 12:04:54 +01:00
Steven Peters
2a7fab1697 CppCoreGuidelines.md spelling error 
stared_ptr -> shared_ptr
 2016-03-23 15:24:19 -07:00
tvaneerd
7a4fbef370 remove use of == on doubles 
could use an epsilon, but that just distracts from the point of the example, so changed double to int instead
 2016-03-22 11:51:30 -04:00
Andrew Pardoe
7a8cac8dbc Changed { { hack to proper liquid template fix 2016-03-20 17:24:56 -07:00
Andrew Pardoe
aa82e03ac8 Updated date` 2016-03-20 16:56:07 -07:00
Patryk Małek
9b2b07d8f3 Updated comments after updating variable names 2016-03-20 19:07:51 +01:00
hsutter
dd3d73f643 Closed #537 2016-03-20 10:05:28 -07:00
Andrew Pardoe
0e9d6502f8 Merge pull request #552 from ltowarek/patch-2 
Fix broken links in I.13
 2016-03-20 09:56:24 -07:00
Andrew Pardoe
aa7f978f3c Merge pull request #551 from ltowarek/patch-1 
Fix broken links in P.8
 2016-03-20 09:55:23 -07:00
Andrew Pardoe
98aee93b0a Merge pull request #546 from tvaneerd/patch-1 
== instead of =
 2016-03-20 09:53:52 -07:00
Andrew Pardoe
1c686854e2 Merge pull request #536 from Marat-Tanalin/master 
Typos
 2016-03-20 09:48:56 -07:00
Andrew Pardoe
89cd79db3f Merge pull request #531 from tituswinters/per-opt 
A more numeric reason for targeted optimization.
 2016-03-20 09:27:17 -07:00
Andrew Pardoe
f01b4aac2e Merge pull request #528 from tituswinters/per-editorial 
Expanding missing text for PER and CP sections, some editorial cleanup
 2016-03-20 09:25:43 -07:00
Andrew Pardoe
033d3ec0eb Merge pull request #521 from jeanphilippeD/Minor-typo 
Add missing word 'from'
 2016-03-20 09:22:14 -07:00
Andrew Pardoe
3fe4e40ae9 Merge pull request #520 from PiotrSliwa/F.53 
More comprehensive example and enforcements for F.53
 2016-03-20 09:20:48 -07:00
Lukasz Towarek
cf8d521437 Fix broken links in I.13 2016-03-15 21:18:38 +01:00
Lukasz Towarek
70c4997f84 Fix broken links in P.8 2016-03-15 20:38:06 +01:00
tvaneerd
5e855a2de4 == instead of = 
really should be +/- epsilon, or change double to int
 2016-03-15 08:53:02 -04:00
hsutter
bcb93bd803 Updated RF.rules 2016-03-14 15:41:36 -07:00
Marat Tanalin
8e8d437123 Typos 
expecially => especially (This is expecially important for)
deafault => default (This is what a deafault == would do)
+ `==` marked-down as code.
 2016-02-26 23:37:26 +03:00
psliwa
c680191bf9 F.53: Fixed after review. 2016-02-24 13:37:43 +01:00
hsutter
a4cfded181 Editorial: Moved ES.60 into proper order 2016-02-22 09:29:32 -08:00
hsutter
1b3efdf1e8 Rewrote ES.56, closed #514 2016-02-22 09:28:41 -08:00
Titus Winters
92091c4b81 A more numeric reason for targeted optimization. 2016-02-17 10:57:02 -05:00
Titus Winters
e8f5dac762 Add note on brace-init for type conversion. 2016-02-17 10:41:13 -05:00
Titus Winters
ea1ed17c1c Bad editorial fix. 2016-02-16 16:54:26 -05:00
Titus Winters
b93b851568 Editorial updates for PER, CP. 
Especially some descriptive text for conurrency, races, lock-free
programming.
 2016-02-16 16:51:38 -05:00
Bjarne Stroustrup
23b7ceab9c a bit of fillout in the template section 2016-02-15 15:38:10 -05:00
hsutter
fd2dc97baf Closed #527 2016-02-15 11:31:45 -08:00
Bjarne Stroustrup
af86ae575e some minor fixes in the class hierarchy section 
closing issue 524
 2016-02-13 18:06:11 -05:00
Bjarne Stroustrup
e7f6ecc470 hat to do if you can't use exceptions 2016-02-13 17:19:08 -05:00
Bjarne Stroustrup
dfd29f3963 immutability 
Added immutability under "Philosophy" and fleshed out the Con section
 2016-02-13 14:35:22 -05:00
jeanphilippeD
b99f3765c7 Add missing word 'from' 2016-02-05 22:38:21 +00:00
psliwa
f11db25628 Minor improvement. 2016-02-04 11:06:55 +01:00
psliwa
fdd91e959a F.53: Minor fix. 2016-02-04 11:05:16 +01:00
Bjarne Stroustrup
f1fcc0fe68 added a not to C.170 2016-02-03 21:21:10 -05:00
psliwa
4fc0beafc3 F.53: More comprehensive example and enforcements. 2016-02-03 18:27:31 +01:00
Bjarne Stroustrup
3eca774fc7 a few cross references relating to operators 2016-02-02 16:36:12 -05:00
Bjarne Stroustrup
31d3dac828 C.168 
define operators in the namespace of their operands
 2016-02-02 16:14:46 -05:00
Andrew Pardoe
3e57e3603a Merge branch 'es-editorial' of https://github.com/tituswinters/CppCoreGuidelines into tituswinters-es-editorial 2016-02-01 21:42:41 -08:00
Andrew Pardoe
36c209a374 Merging PR486 2016-02-01 21:34:22 -08:00
Marat Tanalin
210455c1c6 23 typos 
transfering => transferring (ownership transfering APIs)
prefent => prevent (to prefent range errors)
standarization => standardization (active discussion in standarization)
effectivily => effectively (This effectivily means)
declarate => declared (Flag classes declarate with `struct`)
Mimimize => Minimize (Mimimize the chance of untended access.)
The The => The (The The standard-library containers)
contaiers => containers (Users of hashed contaiers)
defie => define (to defie a specialization)
ibrary => library (combine standard-ibrary specializations)
specoalists => specialists ("cleverness" for non-specoalists)
yur => your (don't invent yur own names)
deploymenta => deployment (deploymenta and use of such tools)
suprises => surprises (perennial source of suprises and bugs)
implementating  => implementing (essential for implementating)
movesemantics => move semantics (movesemantics and certain rare
optimizations)
assingment => assignment (copying only part of an object using
assingment)
user => used (type can be user for a wide variety)
Templatizing => Templating (Templatizing a class hierarchy)
sourcefiles => source files (declarations used in multiple sourcefiles)
[2 times]
alternatives.These => alternatives. These (// space between sentences)
its => it’s (the first time its called)
LanguagesC++ => Languages — C++ ([C++03]: ISO/IEC 14882:2003(E),
Programming LanguagesC++)
 2016-02-02 05:21:20 +03:00
Bjarne Stroustrup
ad97ba3fdb Dealt with issue 516 
added C.8 and C.9 to clarify access conventions
 2016-02-01 16:19:39 -05:00
Gabriel Dos Reis
6e812c1588 Merge pull request #498 from tituswinters/editorial-2 
Editorial changes for PER, CP, E, and T.
 2016-02-01 11:25:22 -08:00
Andrew Pardoe
8452e8ae84 Merge pull request #490 from dkorolev/master 
Declaring one name per declaration.
 2016-02-01 10:33:04 -08:00
Andrew Pardoe
0712b24c91 Merge pull request #510 from ZhangWangda/patch-1 
fix typo
 2016-02-01 10:25:01 -08:00
Andrew Pardoe
366150957b Merge pull request #513 from cmello/master 
passes -> passed
 2016-02-01 10:23:31 -08:00
Marat Tanalin
a67f8d3c27 Typos 
wil => will;
developemnt => development.
 2016-02-01 19:38:31 +03:00
Bjarne Stroustrup
5547b43c4b a few issues 2016-01-31 21:43:50 -05:00
Bjarne Stroustrup
df9aca5ec3 a bit of fill-in and cleanup 2016-01-31 17:32:14 -05:00
Cesar Mello
c041ced2c0 passes -> passed 2016-01-27 16:39:09 -02:00
ZhangWangda
67bf6a14ab fix typo 
add a missing bracket
 2016-01-26 14:20:38 -05:00
Bjarne Stroustrup
379938d743 rule against std::move() 
ES.55
maybe the rule could be phrased more precisely
 2016-01-26 14:12:59 -05:00
Bjarne Stroustrup
99673eb1f4 overloading vs default arguments 
prefer default arguments and flag inconsistent default arguments on
virtual functions
 2016-01-26 13:29:36 -05:00
hsutter
4748906ec1 c/assigned to/modified in F.7 and R.30 2016-01-25 11:27:11 -08:00
hsutter
94b567d2b8 Updated F.7 and R.30 based on 2016-01-25 telecon discussion 2016-01-25 11:25:56 -08:00
hsutter
ad66f6ecda Tweaked F.7 enforcement 2016-01-25 11:05:25 -08:00
hsutter
815cdbbe72 Refined Enforcement for F.7 2016-01-25 10:02:54 -08:00
Bjarne Stroustrup
1d6e7a6e6b many minor changes to the F section 2016-01-24 17:40:22 -05:00
hsutter
63316bc0dc Corrected F.54, part 2 2016-01-12 12:04:32 -08:00
hsutter
b97f67cd60 Corrected F.54 example 2016-01-12 12:02:59 -08:00
Titus Winters
20ed3d12fd Editorial changes for PER, CP, E, and T. 2016-01-12 13:28:08 -05:00
hsutter
7ae6ad4eb7 Completed and corrected Meyers book references 2016-01-11 13:59:02 -08:00
hsutter
3668c8c491 Added F.54 to never capture this implicitly 2016-01-11 11:00:27 -08:00
Jeremy Voorhis
dd683abae7 Fix typographical error (variable name) in example for C.30. 2016-01-10 19:47:36 -08:00
hsutter
935a5ee325 Closed #485. 2016-01-07 07:17:14 -08:00
hsutter
e4f908093d Closed #484. 2016-01-07 07:14:12 -08:00
Dima
2d9c0582ad Another minor grammar fix. 2016-01-06 23:23:30 -08:00
Dima
7ae316c605 Minor grammar fix. 2016-01-06 23:20:52 -08:00
Dima
6a39167b86 Declaring one name per declaration. 2016-01-06 22:31:13 -08:00
Titus Winters
d653d5e89c (Hopefully) editorial cleanup for Sec ES. 2016-01-06 14:44:01 -05:00
hsutter
46f38a7917 Closed #388. 2016-01-01 10:48:34 -08:00
hsutter
2bea1b9d30 Closed #442. 2015-12-31 17:18:35 -08:00
hsutter
8758eabcbf Folded duplicate C.6 into Con.2 and addressed PR #438. 2015-12-29 11:25:08 -08:00
hsutter
7cd72691e8 Improved R.3 note wording to help address PR #417. 2015-12-29 11:15:04 -08:00
hsutter
13c8df9abc Applied suggestion in PR #414. 2015-12-29 11:07:37 -08:00
hsutter
41751f548c Merge pull request #409 from agrygorenko/F-27-patch 
F.27: Example fix
 2015-12-29 13:57:07 -05:00
hsutter
47a1405707 Applied suggestion in PR #343. 2015-12-29 10:46:58 -08:00
hsutter
f013c1b22d Applied suggestion in PR #298. 2015-12-29 10:39:36 -08:00
hsutter
3586cf7d0e Applied suggestion in PR #273. 2015-12-29 10:35:29 -08:00
hsutter
6c47693b58 Applied suggestion in PR #268. 2015-12-29 10:28:57 -08:00
hsutter
50e89327bb Applied the suggestion in PR #238. 2015-12-29 10:25:42 -08:00
hsutter
12dd788e1d Applied suggestion in PR #213. 2015-12-29 10:23:47 -08:00
hsutter
4b15a57f96 Applied the suggestion in PR #198. 2015-12-29 10:21:05 -08:00
hsutter
10d1d9dbc5 Addressed PR #140. 2015-12-29 10:15:43 -08:00
hsutter
c9e015ce1f Addressed PR 52. 2015-12-29 09:29:06 -08:00
hsutter
9c2aba298c Closed #436. 2015-12-28 10:49:07 -08:00
hsutter
c6891262a7 Tweaked PR #481. 2015-12-28 10:20:58 -08:00