Commit Graph

466 Commits

Author SHA1 Message Date
Gregory P. Smith
965d902e13
Merge pull request #697 from google/python_styleguide
Project import generated by Copybara.
2022-06-07 17:09:21 -07:00
Google Python team
c2b992c6f5 Project import generated by Copybara.
PiperOrigin-RevId: 453553841
2022-06-07 17:08:25 -07:00
Gregory P. Smith
a5197abff2
Merge pull request #692 from google/python_styleguide
Project import generated by Copybara.
2022-05-25 14:05:50 -07:00
Google Python team
4a6e97d092 Project import generated by Copybara.
PiperOrigin-RevId: 450985691
2022-05-25 14:03:28 -07:00
Tony Ruscoe
1faa779a12
Make the Declaration Order recommendation optional
This recommendation was relaxed in the internal style guide a few months ago. The suggestion is still to continue using alphabetical order unless teams have access to the appropriate tooling which can support consistently automating and enforcing different sorting rules which may be more logical to read.
2022-05-06 11:48:31 +01:00
Titus Winters
cada798ffe
Merge pull request #688 from zetafunction/update-styleguide
Update C++ style guide.
2022-05-05 13:26:55 -04:00
Tony Ruscoe
992ad03d50
Update HTML Line-Wrapping examples
Replaces the examples in the HTML Line-Wrapping recommendation to include child elements.
2022-05-05 10:04:58 +01:00
Daniel Cheng
93c7bd88c6 Update C++ style guide.
- Reword guidance for definitions of inline functions and templates.
- Capitalize the first letter of various comments.
- Update command-line flag reference to use absl flags.
- Improve braced-initialization example for 64-bit constants.
- Delete C++03 guidance for NULL.
- Clarify wording around wrapping of string literals.
- Use C++17 [[fallthrough]] instead of ABSL_FALLTHROUGH.
2022-05-03 23:57:01 +00:00
Google Python team
2eb7e16647 Project import generated by Copybara.
PiperOrigin-RevId: 442743475
2022-04-25 20:17:14 +00:00
Gregory P. Smith
629edc1ca9
Merge pull request #683 from google/python_styleguide
Project import generated by Copybara.  Mostly modernizing to a 3.9+ Pythonisms. Some clarification on TypeVars.
2022-04-12 20:47:33 -07:00
Google Python team
d2ca0a820a Project import generated by Copybara.
PiperOrigin-RevId: 440926376
2022-04-13 03:44:05 +00:00
Samuel Freilich
af78b49ac4
Merge pull request #673 from rex4539/typos
Fix typos
2022-02-10 11:59:19 -05:00
Dimitris Apostolou
18fff725af
Fix typos 2022-02-10 17:44:21 +02:00
Michael Diamond
31c830a22d
Merge pull request #671 from cushon/gh-pages
Update Java style guide
2022-02-02 20:26:54 -08:00
Liam Miller-Cushon
89416627bc Move a </p> around 2022-02-02 20:00:05 -08:00
Liam Miller-Cushon
49488412b2 Update Java style guide 2022-02-02 19:31:16 -08:00
Tony Ruscoe
e6233c7428
Add recommendation to avoid using !important
This recommendation was adopted internally to align with our infrastructure conformance checks and best practices.

While !important is a legitimate feature of CSS, its use increased complexity and maintenance costs when styles were reused and shared across multiple projects.
2022-01-13 14:29:39 +00:00
Tony Ruscoe
8d4a22bd69
Update ID and class selector/attribute guidance
We now recommend avoiding unnecessary `id` attributes and prefer using class selectors for styling.

Where `id` attributes are strictly required, we recommend always including a hyphen in the value.
2022-01-13 14:13:57 +00:00
Tony Ruscoe
5ac8b604fa
Move the ID and Class Name sections to be together
This change was made to the internal style guide a while ago to make it easier to find related sections also containing IDs and class name guidance.
2022-01-13 14:03:19 +00:00
Tony Ruscoe
2dcaf50252
Prefer leading zeros in CSS values
This was reversed in the internal style guide a while ago to align the guidance with our autoformatting tooling configuration.

Any optimisations to reduce file size should be handled by compilers and minifiers.
2022-01-13 13:53:15 +00:00
Tony Ruscoe
50c42bf956
Explain the 4-space HTML line-wrapping guidance
This clarification was added to the internal style guide a few months ago.
2022-01-13 13:46:52 +00:00
Tony Ruscoe
4f848da9f3
Merge pull request #667 from tonyruscoe/gh-pages
Update format for numbered sections and whitespace
2022-01-12 16:59:40 +00:00
Tony Ruscoe
aec4ccfe4b Update format for numbered sections and whitespace 2022-01-12 16:56:30 +00:00
Tony Ruscoe
18ed71c507
Replace HTML entities in the HTML/CSS Style Guide
The internal script that converts our style guides from Markdown to HTML now does this.
2022-01-12 14:33:52 +00:00
Tony Ruscoe
106edd4b39
Merge pull request #666 from tonyruscoe/gh-pages
Remove prettyprint from HTML/CSS Style Guide
2022-01-12 13:59:46 +00:00
Tony Ruscoe
53c4d95517 Remove prettyprint from HTML/CSS Style Guide
This is because the internal style guide does not use prettyprint.
2022-01-12 13:47:57 +00:00
Gregory P. Smith
842b872ac4
Merge pull request #660 from google/python_styleguide
Project import generated by Copybara.
2021-12-07 13:42:38 -08:00
Google Python team
6e7639af59 Project import generated by Copybara.
PiperOrigin-RevId: 414768544
2021-12-07 21:40:47 +00:00
Titus Winters
9806df89a3
Merge pull request #650 from zetafunction/new-thingie
Update the C++ style guide.
2021-10-20 12:26:38 -04:00
Daniel Cheng
840e5839f6 Update the C++ style guide.
- Recommend the use of absl::implicit_cast for safe upcasting.
- Remove std::hash guidance
- Remove end-of-line comment guidance
- Remove "consistency to local style" guidance
- Miscellaneous wording updates
2021-10-20 09:17:56 -07:00
Google Python team
9a6a5d3db3 Project import generated by Copybara.
PiperOrigin-RevId: 396282811
2021-09-13 21:38:04 +00:00
Google Python team
d88a5b7b59 Project import generated by Copybara.
PiperOrigin-RevId: 385825978
2021-07-20 11:05:01 -07:00
Titus Winters
78f4fca97f
Merge pull request #643 from jruderman/patch-1
cppguide: remove space before comma
2021-07-20 12:08:07 -04:00
Jesse Ruderman
b1956b20a2
cppguide: remove space before comma 2021-07-20 08:53:06 -07:00
Google Python team
4044bbd5ca Project import generated by Copybara.
PiperOrigin-RevId: 384778037
2021-07-14 14:12:11 -07:00
Google Python team
9c8784ded3 Project import generated by Copybara.
PiperOrigin-RevId: 372845522
2021-05-10 17:22:02 -07:00
Google Python team
f614c922a8 Project import generated by Copybara.
PiperOrigin-RevId: 372441803
2021-05-07 19:58:49 -07:00
Titus Winters
15fddd2eaf
Merge pull request #635 from elharo/code
add code of conduct
2021-04-26 07:11:07 -04:00
Elliotte Rusty Harold
0ce82b9a74 use the 2.0 version of the Contributor Covenant, with modification 2021-04-19 15:28:07 -04:00
Titus Winters
bc0aa941db
Merge pull request #636 from elharo/issue
add issue template discouraging contributions
2021-04-12 09:50:41 -04:00
Elliotte Rusty Harold
7ae99d6db0 add issue template 2021-04-12 08:53:25 -04:00
Elliotte Rusty Harold
6fc1f800ce add code of conduct 2021-04-12 08:35:57 -04:00
Titus Winters
68dc41b578
Merge pull request #634 from elharo/gh-pages
add pull request template discouraging contributions
2021-04-12 08:08:49 -04:00
Elliotte Rusty Harold
aa19fd7504 allow for typo corrections 2021-04-09 08:21:46 -04:00
Elliotte Rusty Harold
103ea74d5d add pull request template discouraging contributions 2021-04-08 17:23:10 -04:00
Elliotte Rusty Harold
f854eb0f9c
Merge pull request #1 from google/gh-pages
merge head
2021-04-08 21:13:16 +00:00
Titus Winters
845e4f9a15
Merge pull request #633 from elharo/patch-1
docs: discourage external contributors
2021-04-08 17:04:38 -04:00
Elliotte Rusty Harold
d754e413ec
Update README.md 2021-04-08 20:30:44 +00:00
Elliotte Rusty Harold
c6d79d07ab
expand on treatment of external contributions 2021-04-08 20:28:33 +00:00
Elliotte Rusty Harold
52483ac7e4
docs: discourage external contributors
@tituswinters
2021-04-08 14:08:23 -04:00