Commit Graph

451 Commits

Author SHA1 Message Date
Liam Miller-Cushon
49488412b2 Update Java style guide 2022-02-02 19:31:16 -08:00
Tony Ruscoe
e6233c7428
Add recommendation to avoid using !important
This recommendation was adopted internally to align with our infrastructure conformance checks and best practices.

While !important is a legitimate feature of CSS, its use increased complexity and maintenance costs when styles were reused and shared across multiple projects.
2022-01-13 14:29:39 +00:00
Tony Ruscoe
8d4a22bd69
Update ID and class selector/attribute guidance
We now recommend avoiding unnecessary `id` attributes and prefer using class selectors for styling.

Where `id` attributes are strictly required, we recommend always including a hyphen in the value.
2022-01-13 14:13:57 +00:00
Tony Ruscoe
5ac8b604fa
Move the ID and Class Name sections to be together
This change was made to the internal style guide a while ago to make it easier to find related sections also containing IDs and class name guidance.
2022-01-13 14:03:19 +00:00
Tony Ruscoe
2dcaf50252
Prefer leading zeros in CSS values
This was reversed in the internal style guide a while ago to align the guidance with our autoformatting tooling configuration.

Any optimisations to reduce file size should be handled by compilers and minifiers.
2022-01-13 13:53:15 +00:00
Tony Ruscoe
50c42bf956
Explain the 4-space HTML line-wrapping guidance
This clarification was added to the internal style guide a few months ago.
2022-01-13 13:46:52 +00:00
Tony Ruscoe
4f848da9f3
Merge pull request #667 from tonyruscoe/gh-pages
Update format for numbered sections and whitespace
2022-01-12 16:59:40 +00:00
Tony Ruscoe
aec4ccfe4b Update format for numbered sections and whitespace 2022-01-12 16:56:30 +00:00
Tony Ruscoe
18ed71c507
Replace HTML entities in the HTML/CSS Style Guide
The internal script that converts our style guides from Markdown to HTML now does this.
2022-01-12 14:33:52 +00:00
Tony Ruscoe
106edd4b39
Merge pull request #666 from tonyruscoe/gh-pages
Remove prettyprint from HTML/CSS Style Guide
2022-01-12 13:59:46 +00:00
Tony Ruscoe
53c4d95517 Remove prettyprint from HTML/CSS Style Guide
This is because the internal style guide does not use prettyprint.
2022-01-12 13:47:57 +00:00
Gregory P. Smith
842b872ac4
Merge pull request #660 from google/python_styleguide
Project import generated by Copybara.
2021-12-07 13:42:38 -08:00
Google Python team
6e7639af59 Project import generated by Copybara.
PiperOrigin-RevId: 414768544
2021-12-07 21:40:47 +00:00
Titus Winters
9806df89a3
Merge pull request #650 from zetafunction/new-thingie
Update the C++ style guide.
2021-10-20 12:26:38 -04:00
Daniel Cheng
840e5839f6 Update the C++ style guide.
- Recommend the use of absl::implicit_cast for safe upcasting.
- Remove std::hash guidance
- Remove end-of-line comment guidance
- Remove "consistency to local style" guidance
- Miscellaneous wording updates
2021-10-20 09:17:56 -07:00
Google Python team
9a6a5d3db3 Project import generated by Copybara.
PiperOrigin-RevId: 396282811
2021-09-13 21:38:04 +00:00
Google Python team
d88a5b7b59 Project import generated by Copybara.
PiperOrigin-RevId: 385825978
2021-07-20 11:05:01 -07:00
Titus Winters
78f4fca97f
Merge pull request #643 from jruderman/patch-1
cppguide: remove space before comma
2021-07-20 12:08:07 -04:00
Jesse Ruderman
b1956b20a2
cppguide: remove space before comma 2021-07-20 08:53:06 -07:00
Google Python team
4044bbd5ca Project import generated by Copybara.
PiperOrigin-RevId: 384778037
2021-07-14 14:12:11 -07:00
Google Python team
9c8784ded3 Project import generated by Copybara.
PiperOrigin-RevId: 372845522
2021-05-10 17:22:02 -07:00
Google Python team
f614c922a8 Project import generated by Copybara.
PiperOrigin-RevId: 372441803
2021-05-07 19:58:49 -07:00
Titus Winters
15fddd2eaf
Merge pull request #635 from elharo/code
add code of conduct
2021-04-26 07:11:07 -04:00
Elliotte Rusty Harold
0ce82b9a74 use the 2.0 version of the Contributor Covenant, with modification 2021-04-19 15:28:07 -04:00
Titus Winters
bc0aa941db
Merge pull request #636 from elharo/issue
add issue template discouraging contributions
2021-04-12 09:50:41 -04:00
Elliotte Rusty Harold
7ae99d6db0 add issue template 2021-04-12 08:53:25 -04:00
Elliotte Rusty Harold
6fc1f800ce add code of conduct 2021-04-12 08:35:57 -04:00
Titus Winters
68dc41b578
Merge pull request #634 from elharo/gh-pages
add pull request template discouraging contributions
2021-04-12 08:08:49 -04:00
Elliotte Rusty Harold
aa19fd7504 allow for typo corrections 2021-04-09 08:21:46 -04:00
Elliotte Rusty Harold
103ea74d5d add pull request template discouraging contributions 2021-04-08 17:23:10 -04:00
Elliotte Rusty Harold
f854eb0f9c
Merge pull request #1 from google/gh-pages
merge head
2021-04-08 21:13:16 +00:00
Titus Winters
845e4f9a15
Merge pull request #633 from elharo/patch-1
docs: discourage external contributors
2021-04-08 17:04:38 -04:00
Elliotte Rusty Harold
d754e413ec
Update README.md 2021-04-08 20:30:44 +00:00
Elliotte Rusty Harold
c6d79d07ab
expand on treatment of external contributions 2021-04-08 20:28:33 +00:00
Elliotte Rusty Harold
52483ac7e4
docs: discourage external contributors
@tituswinters
2021-04-08 14:08:23 -04:00
Titus Winters
635fe96f8e
Merge pull request #630 from zetafunction/gh-pages
Update C++ style guide.
2021-03-29 07:41:18 -04:00
Daniel Cheng
4e25657924 Update C++ style guide.
Mostly minor wording updates (e.g. preferring int64_t to int64). The
most significant change is clarifying the section on consistency to
clarify that consistency, in and of itself, should not be used as the
sole argument for blocking adoption of style changes.
2021-03-26 16:54:25 -07:00
Titus Winters
6e239d7f90
Merge pull request #620 from zetafunction/update-c++
Update C++ style guide.
2021-01-29 14:10:19 -05:00
Daniel Cheng
a4413633ec Update C++ style guide.
Minor formatting and wording fixes.
2021-01-29 11:04:19 -08:00
Google Python team
5120fd6b14 Project import generated by Copybara.
PiperOrigin-RevId: 347693939
2021-01-26 00:56:55 +00:00
Google Python team
2e797961e9 Project import generated by Copybara.
PiperOrigin-RevId: 353740685
2021-01-26 00:38:44 +00:00
Alex Okrushko
87c54065a2 remove the go-link 2021-01-22 21:32:51 -08:00
Alex Okrushko
bfa71446db Add TypeScript style guide 2021-01-22 21:32:51 -08:00
Titus Winters
d5b5104763
Merge pull request #584 from zetafunction/yet-again-how-does-this-work
Update C++ styleguide
2020-11-11 08:50:32 -05:00
Daniel Cheng
ed3dd33df3 Update Google C++ styleguide
- Guidance for return values (prefer return by value, return by
  reference, then return by pointer in that order)
- Mandate curly braces around the body of a control statement,
  providing one exception for historical reasons (`if` with no `else`,
  and `if` + body fits completely in a single line or the `if` fits in
  one line and the body fits in another separate line).
2020-11-10 22:26:05 -08:00
Titus Winters
96f6a64d30
Merge pull request #577 from zetafunction/how-does-this-work-again
Update C++ styleguide
2020-09-25 13:27:34 -04:00
Daniel Cheng
3919c347aa Update C++ styleguide
- add section for inclusive language.
- move include-what-you-use to a new section.
- clarify usage of absl::optional for by-value vs by-reference params.
- document usage of `` as a code-indexing hint
- note that enclosing identifiers in `` can help code indexers.
2020-09-25 00:29:52 -07:00
Google Python team
ddccc0fbeb Project import generated by Copybara.
PiperOrigin-RevId: 332885552
2020-09-23 01:40:40 +00:00
Google Python team
f84020eeec Project import generated by Copybara.
PiperOrigin-RevId: 332244028
2020-09-17 17:49:28 +00:00
Michael Diamond
32916a92da
Add owners for the Java and Shell guides, and alphabetize the list. 2020-09-16 02:20:35 -07:00