Commit Graph

400 Commits

Author SHA1 Message Date
Alexandra Latysheva
6945f7304f replace all unsigned except in wrapper 2020-10-11 10:01:59 +00:00
Alexandra Latysheva
69fbe39293 Declare all vars on separate lines 2020-10-11 09:44:02 +00:00
Alexandra Latysheva
d190abf2e2 using from .h to .cc 2020-10-11 09:40:47 +00:00
Alexandra Latysheva
1785e39d4b add nolint to every include '*.h' that is added by this pr 2020-10-11 08:20:40 +00:00
Alexandra Latysheva
5449e2f0df renamed g_in_dir in local variable style 2020-10-04 17:58:21 +00:00
Alexandra Latysheva
b6abae3356 rewtite pixels and clusters check for clarify. sapi::StatusOr -> absl::StatusOr (building problems). resolved review issues 2020-10-04 17:38:10 +00:00
Alexandra Latysheva
6497a40bff last for now 2020-10-01 17:11:28 +00:00
Alexandra Latysheva
fea40e017f format 2020-10-01 16:56:45 +00:00
Alexandra Latysheva
2869fba479 example 2020-10-01 16:49:59 +00:00
Alexandra Latysheva
477de3b6b7 last for today 2020-09-30 19:17:23 +00:00
Alexandra Latysheva
0f8cbd1bfc some more fixes 2020-09-30 18:45:48 +00:00
Alexandra Latysheva
d513f18c2e resolved part of issues 2020-09-30 17:54:47 +00:00
Alexandra Latysheva
8b36b3e5af clang-format again 2020-09-26 11:27:13 +00:00
Alexandra Latysheva
71e43cd99c main fixes 2020-09-25 21:21:07 +00:00
Alexandra Latysheva
309b476a3d wrong clang-google-style parts 2020-09-23 21:33:11 +00:00
Alexandra Latysheva
6a2f0cebd8 wrong clang-google-style parts 2020-09-23 21:32:45 +00:00
Alexandra Latysheva
6f3acfabb0 gstyle 2020-09-23 21:18:17 +00:00
Alexandra Latysheva
358d919ea0 remove unused funcs 2020-09-23 20:48:59 +00:00
Alexandra Latysheva
673154e65c from local repo to fork 2020-09-23 20:21:33 +00:00
Christian Blichmann
9331eabd7e Copybara import of the project:
Including changes for GitHub -> internal migration

--
b5d7e43dde by Federico Stazi <34340238+FedericoStazi@users.noreply.github.com>:

Initial curl commit
--
24786c44d8 by Federico Stazi <fstazi@google.com>:

Added gitignore and curl submodule

--
6d5cfd575a by Federico Stazi <fstazi@google.com>:

Added new line at the end of files

--
c7423c5f8a by Federico Stazi <fstazi@google.com>:

Remove SHARED from add_sapi_library

--
05c0a4b004 by Federico Stazi <fstazi@google.com>:

Fix includes

--
5be51fabbe by Federico Stazi <fstazi@google.com>:

Improve comments

--
34338411b8 by Federico Stazi <fstazi@google.com>:

Improve style

--
8c68ac221f by Federico Stazi <fstazi@google.com>:

Address review comments

--
ac1112ae4d by Federico Stazi <fstazi@google.com>:

Minor fix

--
f47e1cc6ac by Federico Stazi <fstazi@google.com>:

Implement all curl methods

--
9291231275 by Federico Stazi <fstazi@google.com>:

Address reviews and improve code style

--
1b0a8edfd4 by Federico Stazi <fstazi@google.com>:

Minor fix

--
cea046d3e2 by Federico Stazi <fstazi@google.com>:

Implement stricter policy

--
cf23888b88 by Federico Stazi <fstazi@google.com>:

Improve and extend examples

--
6167cafbde by Federico Stazi <fstazi@google.com>:

Implement tests

--
9fed2ec097 by Federico Stazi <fstazi@google.com>:

Improved error handling

--
e446ec81a1 by Federico Stazi <fstazi@google.com>:

Address review comments

--
cf41ec4701 by Federico Stazi <34340238+FedericoStazi@users.noreply.github.com>:

Fix project name
--
9a4293a3cf by Federico Stazi <fstazi@google.com>:

Fix project name

--
bbebeee1a6 by Federico Stazi <fstazi@google.com>:

Fix test mock server

--
eb783de3f5 by Federico Stazi <fstazi@google.com>:

Address review comments

--
cf6cb89bca by Federico Stazi <fstazi@google.com>:

Minor mock server fix

--
b52d9e6e4f by Federico Stazi <fstazi@google.com>:

Address review comments

PiperOrigin-RevId: 333292204
Change-Id: I9ff27348028d9f22486492dc92c0859ff8f44d68
2020-09-23 08:00:10 -07:00
Christian Blichmann
00e724fb8a CMake build improvements
- Try to fix Ninja needlessly rebuilding everything every time
  See https://stackoverflow.com/questions/47087237/cmake-and-ninja-rebuild-unnecessary-files/47100426#47100426
- Since SAPI requires CMake >= 3.12, remove custom `list_join`

PiperOrigin-RevId: 333281764
Change-Id: I334d67d7ee54d21824b19e60a7a7f1e43bb5a057
2020-09-23 06:43:01 -07:00
Wiktor Garbacz
f91f843f50 Use size_t/uintptr_t instead of uintptr_t or uint64_t where appropriate
PiperOrigin-RevId: 332449107
Change-Id: I623c320c7f31bb73b92799dfbeb9a1e8ce0cdb3b
2020-09-18 07:45:03 -07:00
Wiktor Garbacz
c33f1fb03e Simplify casts
Drive-by: check for malloc failure in sapi:✌️:Array
PiperOrigin-RevId: 332446225
Change-Id: I375ea94845e04dffc3353d70737402daa66ae50a
2020-09-18 07:23:19 -07:00
Wiktor Garbacz
08a956a415 Use opaque void* instead of uint8_t* in Comms
PiperOrigin-RevId: 332441641
Change-Id: I09902e98726a0bd57b47d3454ddcb6ef05021d56
2020-09-18 06:48:57 -07:00
Wiktor Garbacz
9ffa5afba6 Remove unnecessary TLV struct
Drive-by: Zero-copy RecvString
PiperOrigin-RevId: 332412385
Change-Id: I169ffa78f016ec2d55c1a3677ea97beed095123c
2020-09-18 02:23:22 -07:00
Christian Blichmann
45c208b19a Update .clang-format to prefer & and * to be close to the type
PiperOrigin-RevId: 332412318
Change-Id: I4cd6d295ef68292c9412722829729142578c4c9f
2020-09-18 02:22:43 -07:00
Copybara-Service
c663427cf9 Merge pull request #49 from bohdanty:master
PiperOrigin-RevId: 332240434
Change-Id: I9e71cf3d3ab50e3a379e3c651b931ca95692666f
2020-09-17 08:36:07 -07:00
Copybara-Service
d4274251a6 Merge pull request #50 from Manwi23:master
PiperOrigin-RevId: 332214390
Change-Id: If9e87dc52cf1e5e2266135c38b6c4429f7f78e5f
2020-09-17 05:28:19 -07:00
Christian Blichmann
13c28403a6 Implement system include detection for CMake build
The Bazel build already queries the current toolchain for its system include
directories. This change brings feature parity and is necessary for systems
with unusual include locations.

PiperOrigin-RevId: 332195812
Change-Id: Ie81d614d21e90b4bd9edf2084ef80bf0d85dd750
2020-09-17 03:08:11 -07:00
Maciej Szawłowski
a68b851c2c Added TypeKind.CHAR_U handling in the generator.
PiperOrigin-RevId: 331988119
Change-Id: I8301c5041c32da185202ed34292e6a2988ecff46
2020-09-16 06:00:55 -07:00
Katarzyna Miernikiewicz
5eed4ec606
Merge branch 'master' into master 2020-09-15 18:26:58 +02:00
Copybara-Service
da41899797 Merge pull request #51 from doinachiroiu:master
PiperOrigin-RevId: 331767052
Change-Id: I286e746fec6248c88df563be00da9451ddd63eb7
2020-09-15 07:46:03 -07:00
Christian Blichmann
ed0086eb66 Fix dynamic binary startup on PPC and newer glibc (> 2.19)
This allows the `_llseek` syscall when it is defined.

PiperOrigin-RevId: 331498182
Change-Id: I2760b264e3a82000b38d278a9c280501a3dbc724
2020-09-14 01:18:33 -07:00
Bohdan
e8a15ea151 Moved tests to root folder, removed unused headers 2020-09-13 18:20:10 +03:00
Katarzyna Miernikiewicz
71e6237cf7 cast changes 2020-09-11 16:35:52 +00:00
Christian Blichmann
21f7373e76 Initial changes to support AArch64
This is a work in progress:
- Syscall tables need work
- Only tested on real hardware using one of our test hosts

As a drive-by, this change also enables the open source version to function on
POWER.

Another side-effect of this change is that the default policies no longer
check for different host architectures at runtime. On x86_64, we do not need
to check for PPC or AArch64 specifice and vice versa.

PiperOrigin-RevId: 331137472
Change-Id: Ic6d6be5cbe61d83dbe13d5a0be036871754b2eb8
2020-09-11 06:34:27 -07:00
Christian Blichmann
c19949eb7b Use inclusive language
PiperOrigin-RevId: 331116936
Change-Id: I7084b24440a1c78c0d70030da900330f0b8d954f
2020-09-11 03:14:12 -07:00
Christian Blichmann
6a1e4b881c Introduce config header to centralize CPU architecture checks
This allows us to remove some uses of macros.

Related changes:
- Make it clear that we support hosting sandboxed binaries from 64-bit
  processes only. CPU architectures are x86-64 and POWER64 (little endian).
- Introduced CPU architecture macros, abstracting away compiler specifics

PiperOrigin-RevId: 330918134
Change-Id: Ife7ad5f14723eec9f68055127b0583b8aecd38dd
2020-09-10 05:48:00 -07:00
Kevin Hamacher
1f8e88586b Log details when executor fails to open the sandboxee binary
PiperOrigin-RevId: 330680717
Change-Id: I4ec855861196177321783dc94f2e05a28e84d512
2020-09-09 02:12:29 -07:00
Sandboxed API Team
776e34502a Internal cleanup migrating StatusOr.
PiperOrigin-RevId: 330561315
Change-Id: Ie8d8857e7fa5819be3358b26425790ede97c99f8
2020-09-08 12:24:35 -07:00
doinachiroiu
1869fe515f Required changes resolved 2020-09-03 14:59:54 +00:00
Christian Blichmann
fdf0483ca0 Migrate to open-source absl::StatusOr<>
This removes our own fork of `absl::StatusOr<>`. Sandboxed API still includes
a custom matcher for Googletest, as that is not open source yet. For
compatibility, the `statusor.h` header is still retained and now aliases
`sapi::StatusOr<>` to `absl::StatusOr<>`.

PiperOrigin-RevId: 329916309
Change-Id: I0544b73a9e312dce499bc4128c28457e04ab9929
2020-09-03 07:40:48 -07:00
Sandboxed API Team
23da55c19a Internal BUILD refactoring
PiperOrigin-RevId: 329720214
Change-Id: I25fbb94dea17db3bdca6438d17508fa304d9706f
2020-09-03 07:40:33 -07:00
Katarzyna Miernikiewicz
490bc569ed changed copying files to patching 2020-09-01 11:06:12 +00:00
Sandboxed API Team
1c833d6f25 Internal cleanup migrating StatusOr.
PiperOrigin-RevId: 329304527
Change-Id: Id6c141272df54c4e165829d690f9f5b2e9ee90cc
2020-08-31 08:13:29 -07:00
doinachiroiu
7e22952c42 Setup error handling modified 2020-08-31 11:48:19 +00:00
doinachiroiu
531850afc2 Required changes resolved 2020-08-31 11:17:15 +00:00
Bohdan Tyshchenko
9803d0549f Changed README, Bazel deps and different parts of code according to the review 2020-08-31 02:19:00 -07:00
Sandboxed API Team
cfac8eb2d9 Internal cleanup migrating StatusOr.
PiperOrigin-RevId: 329250595
Change-Id: I0447d8154a57b1132981b116f02b4d5bceedfd4c
2020-08-31 00:13:54 -07:00
Katarzyna Miernikiewicz
28089de353 workaround to avoid manually copying library files 2020-08-28 15:27:23 +00:00