Commit Graph

1178 Commits

Author SHA1 Message Date
Andrew Pardoe
8c0f764b77 Merge pull request #952 from tkruse/code-fixes
small issues found trying to compile examples
2017-06-19 10:09:36 -07:00
Rory Jaffe
24fa6d4b00 Added break to each case in switch statement 2017-06-18 16:44:57 -07:00
Thibault Kruse
b02eb91b84 code fixes 2017-06-18 20:39:00 +09:00
Sergey Zubkov
22c305fdee travis fixes and a typo 2017-06-17 20:36:23 -04:00
Thibault Kruse
70655d1131 Fix typos and change spellcheck call to not check URLs (#961) 2017-06-17 20:32:04 -04:00
Jacob Taylor Hindle
e12e73e670 ES.34 Add alternative example. 2017-06-13 16:14:12 +01:00
Andrew Pardoe
03dc7d3f44 Updating date 2017-06-12 16:13:30 -07:00
Bjarne Stroustrup
9472111c6c Talk materials list
Issue #929.
It would be nice to have more material, and I haven't yet uploaded all
slides.
2017-06-12 17:55:01 -04:00
Bjarne Stroustrup
8cc76e2c38 Fix Enum.4 example
Issue #716
2017-06-12 17:07:50 -04:00
Bjarne Stroustrup
5393fab88f labels missing
#938. I have inserted a temporary fix. We need to re-work the whole
discussions section
2017-06-12 16:54:38 -04:00
Andrew Pardoe
5e2f9064b2 Merge pull request #927 from ZachHenkel/master
Additional guidance around casts:
2017-06-12 11:26:37 -07:00
Andrew Pardoe
19da9a1d03 Merge pull request #950 from cubbimew/pimpl
New rule: I.27 Pimpl
2017-06-12 11:20:56 -07:00
Sergey Zubkov
0048b15ead fix mismatch between title and toc for F.22 2017-06-12 08:57:15 -04:00
Andrew Pardoe
5205a4e567 updating date 2017-06-11 21:25:28 -07:00
Andrew Pardoe
c0b1ea189f Merge pull request #958 from xfix/patch-1
Rename rnd to round in I.1
2017-06-11 18:44:55 -07:00
Andrew Pardoe
18e8e91745 Merge pull request #957 from eliaskosunen/master
Add braces to for loop in P.1 example
2017-06-11 18:41:25 -07:00
Andrew Pardoe
ba3bdb1f40 Merge pull request #949 from robert-andrzejuk/patch-2
Minor typo (I think)
2017-06-11 18:36:21 -07:00
Konrad Borowski
7367e07598 Rename rnd to round in I.1
At first, I assumed that this is "rand" function, not "round" function,
and was confused why exactly is it a problem that this returns
different values. While it's easy to notice when actually reading the
code, this slows down the comprehension, and bad function naming is
not point of that particular guideline.
2017-06-10 12:08:12 +02:00
Elias Kosunen
7763b97b52 Add braces to for loop in P.1 example
`for` with no `block-statement` as its `statement` is bad practice and should not be shown in an example. This example is meant to demonstrate code duplication and expessiveness, not to show poor usage of braces or lack thereof.
2017-06-09 23:30:42 +03:00
Andrew Pardoe
6907911089 Updating date 2017-06-08 16:58:52 -07:00
Robert Andrzejuk
d5667c5f8a Minor typo
I think a minor typo got itself in ... the second 'string_span' should be string_view.
2017-06-08 22:24:25 +02:00
Tom Isaacson
974d6a2090 Fix link to constructor virtual 2017-06-09 08:04:15 +12:00
Florin
d4d48ec772 Fix tense, semantic error 2017-06-08 13:57:50 +02:00
Sergey Zubkov
fe9861d98a New rule: I.27 Pimpl 2017-06-04 10:58:27 -04:00
Sergey Zubkov
906ae347f3 travis CI fixes 2017-06-04 10:47:46 -04:00
Bjarne Stroustrup
c355df948f reorganize the lifetime profile description 2017-06-03 15:38:36 -04:00
Abigail
11e92eb4c5 Fix Markdown rendering failure
Use of <iostream> without backticks causes the Markdown render to fail
from this point onwards on GitHub pages.
2017-06-03 07:47:06 +01:00
Zachary Henkel
f3ff5bae6d Clarify "unnecessary cast" by decomposing the class into identity casts and implicit casts. 2017-06-02 09:24:29 -05:00
Thibault Kruse
9cc50836bd Diverse style fixes
Remove whitespace at end of line

fix code indent

whitepsace between operators

align comments

add method name to fix syntax highlighting

typo: start with capital letter

Apply snake-case naming for unctions (for consistency)
2017-06-02 20:34:32 +09:00
Gabriel Dos Reis
520087569f Merge pull request #943 from galik/fix_unique_target_case
Fix case of unique anchors to match others
2017-06-01 19:51:54 -07:00
Bledson Kivy
d240b7611e #included instead of #included 2017-06-01 23:26:45 -03:00
Zachary Henkel
3c867e5079 Final style changes 2017-05-31 10:11:19 -05:00
Zachary Henkel
2ef544d4ad Additional formatting 2017-05-31 10:10:00 -05:00
Zachary Henkel
abd71982da Another try with the linter 2017-05-31 10:03:02 -05:00
Zachary Henkel
ca35984813 Try to make the linter happy 2017-05-31 09:50:10 -05:00
Andrew Pardoe
c7733a398a Updating date 2017-05-29 17:46:56 -07:00
galik
7cf5f01bad Fix case if unique anchors to match others
SL.str.5, SL.str.10, SL.str.11, SL.str.12
2017-05-26 06:21:54 +01:00
Gabriel Dos Reis
07d2413d80 Merge pull request #939 from galik/fix_item_tags
Fix various item tags (missing colons)
2017-05-25 15:18:15 -07:00
galik
fa50221dd0 Fix various item tags (missing colons)
I.2, C.10, A.1, A.2, A.4, NL.5
2017-05-25 23:09:08 +01:00
Gabriel Dos Reis
9e29780db6 Merge pull request #937 from ProgramMax/add-missing-period
Add missing period
2017-05-25 15:05:02 -07:00
Chris Blume
ea50b4ea78 Add missing period 2017-05-25 13:38:51 -07:00
Sergey Zubkov
d816cc5705 travis CI fixes 2017-05-24 22:35:05 -04:00
Zachary Henkel
2cd9993ae4 Revise cast guidance following upstream edits 2017-05-24 15:31:11 -05:00
Zachary Henkel
9ef1d51c34 Merge from https://github.com/isocpp/CppCoreGuidelines 2017-05-24 14:58:33 -05:00
Bjarne Stroustrup
6c3620d1e8 minor cleanup 2017-05-24 08:49:21 -04:00
Malcolm Parsons
4dfe88b716 Fix broken links (#935) 2017-05-24 11:15:58 +01:00
Sergey Zubkov
531a8a5ebd travis CI fixes and other typos 2017-05-23 23:48:56 -04:00
Shalom Craimer
5f5d5d8ca6 Fixing link to C.146 to be valid, and a link to ??? to be unlinked (#934)
this fixes links and the issues discovered by travis CI
2017-05-23 22:55:06 -04:00
Bjarne Stroustrup
5975f4d5db more bounds profile reorganization 2017-05-23 21:36:14 -04:00
Bjarne Stroustrup
df160f3654 Most of the bounds safety profile 2017-05-23 15:55:51 -04:00
Bjarne Stroustrup
9eb18fdf9e vector exception to {} initializers 2017-05-23 15:03:52 -04:00
Bjarne Stroustrup
9d44e718eb Reorganized the Type safety profile 2017-05-23 14:39:13 -04:00
Andrew Pardoe
c721b2c325 Merge pull request #931 from sizeofvoid/master
fix: unsigned int value comment
2017-05-22 07:55:26 -07:00
Bjarne Stroustrup
5da51a9a44 more work on anchors 2017-05-22 10:45:16 -04:00
Bjarne Stroustrup
9d283bc451 anchors for Type.* 2017-05-21 21:54:27 -04:00
Bjarne Stroustrup
986106c63c more Type.* reorganization 2017-05-21 21:15:35 -04:00
Bjarne Stroustrup
e2719d035b Reorganize Type.1-3 2017-05-21 15:40:25 -04:00
Bjarne Stroustrup
6e86c182f9 Don't detach, rename raii_thread to joining_thread
Addressing #925 . Please review carefully. #925 is tricky.
2017-05-21 12:18:59 -04:00
Sergey Zubkov
96a41a4a6e travis CI fixes 2017-05-20 21:04:04 -04:00
Bjarne Stroustrup
a1f59395bb modifications to C.43
Issue #544
2017-05-20 14:29:23 -04:00
Sergey Zubkov
85cb14703c travis CI fixes 2017-05-19 23:33:06 -04:00
Bjarne Stroustrup
aabfe119d3 typo fix 2017-05-19 18:05:17 -04:00
Rafael Sadowski
a591b3c279 fix: unsigned int value comment 2017-05-19 18:01:41 +02:00
Bjarne Stroustrup
14ef2cde84 add rules against use of unsigned
addresses #571
2017-05-18 16:45:10 -04:00
Bjarne Stroustrup
50576c0144 issue #841
SF.10: Avoid dependencies on implicitly `#included` names
2017-05-17 15:06:48 -04:00
Bjarne Stroustrup
974fdf4661 improve I.11
as suggested in #552
2017-05-17 14:41:53 -04:00
Bjarne Stroustrup
fa1d0e5995 exceptionsand const
Added to E.15
2017-05-17 14:25:13 -04:00
Bjarne Stroustrup
81493f331c Undid untentional change to C.85 2017-05-16 15:58:01 -04:00
Bjarne Stroustrup
7206b618a4 C.86 example accesses private members #541
fixed
2017-05-16 15:56:16 -04:00
Bjarne Stroustrup
9620ea8d43 I.30: Encapsulate rule violations
Fiexed #893 by moving the bad example from ES.28 to a new rule: I.30:
Encapsulate rule violations.

I may inadvertenly have invented a new suppression syntax
2017-05-16 14:59:55 -04:00
Bjarne Stroustrup
17ccab5836 Fix C.139 2017-05-16 13:28:23 -04:00
hsutter
b10ffdf55f Reversed order of Lifetime.1 and .2 2017-05-11 19:09:56 -07:00
hsutter
ff9bce8035 Add Lifetime.1-3 rules so tools can refer to them 2017-05-11 17:56:25 -07:00
Zachary Henkel
f1b348e0db Additional guidance around casts:
- Warn on unnecessary casts
- Avoid casts on arithmetic types
- Add specializations of the rules for Pro-type-reinterpretcast
2017-05-09 16:17:45 -07:00
Sergey Zubkov
17715010a2 travis CI fixes and grammar fix from #920 2017-05-08 22:34:18 -04:00
Andrew Pardoe
b09b9ad8b9 Updating date & typos 2017-05-08 12:05:23 -07:00
Andrew Pardoe
bec67d690a Merge pull request #914 from AndrewPardoe/issue911
Clarify I.11 with regards to recommending smart pointers/owner<T>.
2017-05-08 11:09:19 -07:00
Andrew Pardoe
52eca9a174 Merge pull request #917 from scraimer/master
C.148 adding Reason and Example
2017-05-08 11:08:12 -07:00
Andrew Pardoe
2e1d9c34d4 Merge pull request #920 from cubbimew/issue899
CP.111 more precise motivation and examples
2017-05-08 11:05:28 -07:00
Andrew Pardoe
d5ea1fcc4f Merge pull request #922 from AndrewPardoe/issue-918
Fix anchors in C.147/148
2017-05-08 11:04:21 -07:00
Gabriel Dos Reis
52aa9ba997 Fix #903. 2017-05-08 10:50:03 -07:00
Andrew Pardoe
e354279e0e Fix anchors in C.147/148 2017-05-08 10:21:01 -07:00
Bjarne Stroustrup
ad6f863152 Added not about notation to Con.2
in response to #902
2017-05-07 15:59:55 -04:00
Sergey Zubkov
f41d36ff25 CP.111 more precise motivation and examples 2017-05-07 14:17:21 -04:00
Bledson Kivy
7c90bdba50 Intended heading level?
Following the heading levels throughout the doc, it seems these are typos.
2017-05-05 16:47:41 -03:00
Shalom Craimer
12f0954f66 Fixed the errors detected by Travis CI and @jwakely 2017-05-05 01:20:16 +03:00
Shalom Craimer
cdf2e7e5ea Fixed the errors detected by Travis CI and @jwakely 2017-05-05 00:56:29 +03:00
Jonathan Wakely
bdb5d27a10 Remove spaces before ptr-declarators in examples 2017-05-04 09:48:19 +01:00
Shalom Craimer
1c53b29a3a C.148 - Fixing Travis-reported errors discovered so far in the code example 2017-05-04 11:19:31 +03:00
Shalom Craimer
b6132db539 C.148 adding Reason and Example 2017-05-04 10:13:22 +03:00
Andrew Pardoe
343f40792a Clarify I.11 with regards to recommending smart pointers/owner<T>. 2017-05-01 15:32:28 -07:00
Sergey Zubkov
f0239407ad travis fixes 2017-05-01 15:51:44 -04:00
Andrew Pardoe
03c2b4699d Updating date 2017-05-01 12:03:31 -07:00
Jonathan Wakely
32d6313607 Improve example for ES.45
Fixes #895
2017-05-01 19:57:39 +01:00
Andrew Pardoe
a96fed9c99 Merge pull request #896 from tlanc007/master
ES.45/ES.46 renamed and reordered to match anchors found later in file
2017-05-01 11:10:57 -07:00
Gabriel Dos Reis
0ff5518dca Merge pull request #905 from ewoudvc/es24_toc_rule_correction
ES.24: have TOC rule match body rule
2017-05-01 11:07:32 -07:00
Andrew Pardoe
b41bea68c1 Merge pull request #909 from tvaneerd/patch-2
Note -> Not, are -> is
2017-05-01 11:07:16 -07:00
Gabriel Dos Reis
f9f3422ac5 Fix C.183. 2017-05-01 11:05:32 -07:00
Gabriel Dos Reis
918a5695c7 Address C.128: say 'avoid'. 2017-05-01 10:45:36 -07:00
Tony Van Eerd
481996c849 Note -> Not, are -> is 2017-04-30 22:32:46 -04:00
Bjarne Stroustrup
e0de4df83b added clarifying note for C.139 2017-04-30 13:33:35 -04:00
Bjarne Stroustrup
b3584cfa5f added reference to C.137 2017-04-30 12:18:42 -04:00
Bjarne Stroustrup
a6a087dfc5 regular added to glossary 2017-04-30 12:06:28 -04:00
Bjarne Stroustrup
64622d5cca testing
and fixing one "thinko"
2017-04-30 10:57:58 -04:00
ewoudvc
caa86ae38b GSL.assert: replace is by are (#908) 2017-04-28 16:34:25 +01:00
Jonathan Wakely
e3fe0c5b5e Fix indentation of NR.1 example 2017-04-28 13:31:20 +01:00
Ewoud Van Craeynest
10805fb7a1 ES.24: have TOC rule match body rule 2017-04-27 21:44:51 +02:00
Sergey Zubkov
94a7a3fd46 travis CI fixes, one more time 2017-04-26 22:08:13 -04:00
Bjarne Stroustrup
046d62c51e minor improvements to SL.io 2017-04-25 15:07:41 -04:00
Sergey Zubkov
c99a366bba travis CI fixes 2017-04-24 22:49:02 -04:00
Bjarne Stroustrup
4f9a6c89be banning exception specifications
a bit more abut exceptions; the beginnings of I/O
2017-04-24 17:41:18 -04:00
Bjarne Stroustrup
1e38eb8ae7 ban longjmp 2017-04-22 18:10:58 -04:00
Bjarne Stroustrup
5397c9c5fe very minor typo
testing
2017-04-21 15:18:21 -04:00
Bjarne Stroustrup
1b7d217cd1 nothing 2017-04-20 20:46:17 -04:00
Tal Lancaster
5306795214 ES.45/ES.46: renamed and reordered to match jump tags
The anchors later in the file were using 46 for narrowing and 45 for
magic.  Renamed and reordered the tags in the TOC to match.
2017-04-20 11:35:25 -06:00
Sergey Zubkov
2a098a2b39 travis CI fixes 2017-04-20 10:54:50 -04:00
Bjarne Stroustrup
df8a441dcf fix bug in C.9 example
a real-world example would be an improvement
2017-04-20 08:28:30 -04:00
Bjarne Stroustrup
d1ff56d07e date 2017-04-19 20:53:12 -04:00
Bjarne Stroustrup
cfa2fec1f2 C.137 2017-04-18 21:27:30 -04:00
Bjarne Stroustrup
6987bfd2f0 C.9 and C.133 2017-04-18 20:35:46 -04:00
Bjarne Stroustrup
05118054f6 NL.11 literals 2017-04-18 18:11:30 -04:00
Bjarne Stroustrup
e30bb60320 more xrefs 2017-04-18 17:51:49 -04:00
Louis Brandy
540c393501 Merge pull request #892 from lbrandy/master
Example of an inheritance hierarchy for C.120.
2017-04-18 12:05:29 -07:00
Sergey Zubkov
04537cdb11 travis CI fixes 2017-04-17 23:37:21 -04:00
Sergey Zubkov
74ab713700 travis CI and some typo fixes
had to drop runtime/printf from the checks because it bans strcpy
2017-04-17 23:07:21 -04:00
Bjarne Stroustrup
54f57d8d1b more language feature xrefs
These xrefs are menat part as teasers to get language-feature obsessed
programmers to look at the guidelines and partly to cover topics that
appears in several places. They are not meant to be complete
2017-04-17 21:01:51 -04:00
Bjarne Stroustrup
6fa4cb32cd more language feature xrefs 2017-04-17 17:05:07 -04:00
Bjarne Stroustrup
e144bd4f9b minor 2017-04-17 16:00:18 -04:00
Louis Brandy
29fdd0d30c Attempt to add an example (that is as non-controversial as possible) of an inheritance hierarchy to C.120 2017-04-17 12:23:22 -07:00
Andrew Pardoe
f1d3846300 updating date 2017-04-17 12:00:18 -07:00
hsutter
0ff543fe19 Addresses #568 2017-04-17 11:51:20 -07:00
hsutter
323912e609 A pass at improving F.52. Closes #884 2017-04-17 11:42:08 -07:00
Bjarne Stroustrup
6d01cfd99b more language term examples 2017-04-17 12:37:42 -04:00
Bjarne Stroustrup
c46bebc58f idea for language feature xref 2017-04-17 12:24:28 -04:00
Bjarne Stroustrup
1b5f6d0c97 change "concepts lite" to "concepts" 2017-04-17 11:12:41 -04:00
Bjarne Stroustrup
098dd3ee90 add example to NR.1 2017-04-16 21:50:52 -04:00
Bjarne Stroustrup
13ee61a3cb start of impact statements for profiles 2017-04-16 15:55:13 -04:00
Bjarne Stroustrup
fc5222ca26 Added a first cut of string guidelines 2017-04-16 14:50:07 -04:00
Bjarne Stroustrup
6bcfaa4fbe Clarify that finally() is a last resort
E.6 and E.19
2017-04-15 21:32:57 -04:00
Andrew Pardoe
a8572ad328 Update link to iso.org per #888 2017-04-15 09:23:47 -07:00
Sergey Zubkov
d71d95a4b6 travis CI fixes 2017-04-12 22:56:23 -04:00
Bjarne Stroustrup
0b58d04fde ES.84 2017-04-10 15:57:38 -04:00
Bjarne Stroustrup
6a3d61fd8d a few more fix-ups in ES.* 2017-04-09 15:15:48 -04:00
Bjarne Stroustrup
26d56a2f54 More changes to ES.*
break and continue
goto
fallthrough
when to use "default"
order of evaluation (C++17)
2017-04-09 12:16:58 -04:00
Bjarne Stroustrup
1f948653bb Cleanup of ES.7*
also ES.10: structured binding
and ES.28: eliminating an owning reference
2017-04-09 10:52:48 -04:00
Andrew Pardoe
960f6dad1c updating date 2017-04-04 16:38:57 -07:00
Andrew Pardoe
0aa9994e54 whitespace for formatting 2017-04-03 12:15:05 -07:00
Andrew Pardoe
5b1043104c Resolving issue #662 2017-04-03 12:07:43 -07:00
Bjarne Stroustrup
fbeff91d05 typos 2017-04-02 20:42:58 -04:00
Bjarne Stroustrup
cbb3de625e add example to F.21 2017-04-02 20:42:58 -04:00