Commit Graph

1981 Commits

Author SHA1 Message Date
bgloyer
596f1ee227
ES.46 Issue 1797 - narrowing to bool (#1824)
* ES.46 Issue 1797

* spacing

* remove spaces

* dereference ptr

* spacing

* used contextual conversions to bool wording
2021-09-30 11:05:14 -07:00
Fangjun Kuang
d28958ae66
Fix typos. (#1829) 2021-09-13 09:17:39 -04:00
char-lie
c4cdbe369e
Fix typo in "Using the GSL: A Tutorial and FAQ" (#1828)
Duplicated `is` is redundant.
2021-09-05 23:25:01 -04:00
bgloyer
375d452495
R.34-35 shared_ptr examples (#1808) 2021-08-29 14:01:17 -04:00
David Machaj
ddc8f3e7d6
Add CP.52 and CP.53 guidelines, closes #1805, closes #1806 (#1812)
* Add CP.52 and CP.53 guidelines

* Address some feedback on CP.52

* Fix PR break caused by code line longer than 100 characters in CP.53

* Fix spelling error and one line of trailing whitespace

* Tweaks to CP.53 based on feedback
2021-08-19 11:11:47 -07:00
bgloyer
ca2ad9dbca
Added update dictionary instructions (#1820) 2021-08-11 22:57:34 -04:00
ash
5bbf843942
T.61 example fixes (#1813) 2021-07-29 14:52:06 -04:00
Sergey Zubkov
fa726d5b0a make CI happier 2021-07-22 14:39:42 -04:00
Herb Sutter
786749e60c
Clarify "concrete type" and make type category descriptions consistent (closes #1780) (#1798)
* Clarify "concrete type" and make type category descriptions consistent (closes #1780)

* markdown fixup

Co-authored-by: Jonathan Wakely <cxx@kayari.org>

* Elaborated that we can't generally add comparison operators to C structs

Co-authored-by: Sergey Zubkov <cubbi@cubbi.com>
Co-authored-by: Jonathan Wakely <cxx@kayari.org>
2021-07-08 11:25:12 -07:00
Sergey Zubkov
2feba4fbd3 make CI happier 2021-06-27 23:52:42 -04:00
Gustav Jansson
652a93ef46
[Pro.safety] Changed lettered list to a numbered (isocpp#1800) (#1801)
* Changed lettered list to a numbered (isocpp##1800)

* Added blank line for CI (isocpp##1800)
2021-06-27 23:52:00 -04:00
Sergey Zubkov
bda7ff108f CI fixes 2021-06-18 17:03:45 -04:00
Herb Sutter
4c4fb37b43 Corrected enforcement of C.67 2021-06-17 11:45:01 -07:00
Herb Sutter
528cb9e832 Update C.67 and C.130 to address #1151 2021-06-17 11:33:14 -07:00
Herb Sutter
52e6263377 Add Tour2e example to C.126, closes #1794 2021-06-17 11:16:12 -07:00
Herb Sutter
402815345e Added suggestion to use a pointer member instead of a reference; closes #1783 2021-06-10 11:36:01 -07:00
Herb Sutter
03fc3a359b Closes #1791 2021-06-10 11:27:17 -07:00
Herb Sutter
d93489f3d4 Applying Jonathan's suggestion for #1792 2021-06-10 11:16:54 -07:00
Alessandro Gentilini
b96d861fd1
Add clarification at C.21 (#1792) 2021-06-10 11:14:58 -07:00
Marco Gartmann
da97de7160
Rewrite C.164 enforcement (#1789)
Rewrite C.164 enforcement to flag non-explicit conversion operators only.
2021-06-10 11:13:22 -07:00
Juha Reunanen
e2dbebed73
Do not allocate an excessive amount of memory in example code. (#1788)
This reverts commit de20b33dab.
2021-06-10 11:12:19 -07:00
Herb Sutter
e583929996 Updated Con.1 to make one function a definition, closes #1785
Also fixed "arguments" -> "parameters"
2021-05-13 11:48:48 -07:00
peno2
bfa349b648
Remove 2 redundant else, according to rule F.56 (#1766)
* Remove 2 redundant else, according to rule F.56

* Remove continue from example code

Update after pull request comment.
2021-05-13 11:41:42 -07:00
5chmidti
211f6cfe3a
Fix C.127 example (#1775)
- fix for D being abstract but trying to create an object of type D in make_unique<D>()
2021-05-13 11:39:14 -07:00
Herb Sutter
de20b33dab Restored *sizeof(int) after merging PR #1776 2021-05-13 11:36:50 -07:00
Juha Reunanen
bf63aca389
A mixed bag of minor fixes, mostly related to language use (I mean English, not C++) (#1776)
* Minor comment fix

* Minor language fix

* Minor language fix

* Minor clarification

* Minor language fix

* Minor language fix

* Remove whitespace for clarity

* Make whitespace consistent (again, it wasn't the "bad" here, right?)

* Minor language fix

* Change weird formatting for emphasis

* Fix (what I believe is) a slightly distracting typo

* Minor language fix

* Suggest to highlight even security vulnerabilities as a possible outcome of concurrency errors

* Minor language fix

* Suggest to add new section for a seemingly unrelated note

* Minor language fix

* Minor language fix (not sure what this intended to say in the first place?)

* Minor language fix

* Add minor remark

* Minor language improvement

* Minor language fix

* Point out a bad example

* Minor fixes

* Minor language fix

* Add missing period (the lack of which doesn't look bad here, but does a bit in the rendered html)

* Minor language fix

* Minor language fix

* Minor typo fix (but is this what was meant?)

* Minor language improvement (?)

* Minor language fix

* Minor language fix (?)

* Add missing closing quotation mark

* Minor language fix

* Minor language fix

* Remove extra dot (or was it supposed to be three dots instead?)

* Minor language fix

* Minor language fix

* Minor language fix

* Minor language fix

* Minor language improvement

* Minor formatting improvements

* Minor improvements

* Minor language fix

* More fixing

* Add missing parentheses (did I get it right?)

* Minor language fix (?)

* Minor language fix

* Minor language fix

* Fix language (but is this what was meant in the first place?)

* Update heading to match content (in particular, the example)

* Remove superfluous whitespace

* Update also the "bad" example to use int*
2021-05-13 11:34:30 -07:00
Bill Rose
8a0053d671
Update change_speed example in P.1 to use user-defined literal syntax (#1778)
Co-authored-by: Bill Rose <neptoess@gmail.com>
2021-05-13 11:30:53 -07:00
Kie
2541e809b6
[I.9] fix typo (#1787) 2021-05-10 00:55:53 -04:00
Juha Reunanen
58f91d7cf1
C.86: Improve language just a bit (#1774) 2021-04-06 09:47:06 -04:00
Juha Reunanen
52b0aa7cdf
C.other: Improve language just a bit (#1773) 2021-04-06 09:46:25 -04:00
Juha Reunanen
b933a61940
C.31: Improve language just a bit (#1772) 2021-04-06 09:45:23 -04:00
Juha Reunanen
c3baa7ce8b
C.66: Improve language just a bit (#1771) 2021-04-06 09:44:53 -04:00
Juha Reunanen
652b71b2c0
F.20: Improve language just a bit (#1768) 2021-04-05 22:24:33 -04:00
Juha Reunanen
402565d74e
F.52: Improve language just a bit (#1770) 2021-04-05 22:22:05 -04:00
Sergey Zubkov
077a29ee3c CI fixes 2021-04-05 15:11:05 -04:00
Herb Sutter
7849d7e7c4 Added F.56, closes #1752 2021-04-01 21:22:44 -07:00
Herb Sutter
77b4175785 Added C.12 to discourage const/reference data members
Would have been nice to put this after C.9 but item numbers are dense
around here.
2021-04-01 12:12:03 -07:00
Herb Sutter
4498e078e7 Refined spec for narrow to cover signedness promotions, closes #1726 2021-04-01 12:01:33 -07:00
Herb Sutter
c8e72981c4 Fixed misapplied edit for <=> 2021-04-01 11:41:27 -07:00
Herb Sutter
4f6e11940e Added bad/good example for C.89, closes #1727 2021-04-01 11:37:58 -07:00
nullptr-cpp
8bdb8fe0dc
Add '<=>' to comparison operators related rules (C.87, C.167) (#1759)
* Add '<=>' to comparison operators related rules (C.87, C.167)

C++20's three-way comparison operator should respect the same rules as other
comparison operators.

* Fix a minor typo

Co-authored-by: Jonathan Wakely <github@kayari.org>

Co-authored-by: Jonathan Wakely <github@kayari.org>
2021-04-01 11:12:18 -07:00
nullptr-cpp
5f75ea4b4b
C.63: Fix a minor typo (#1760)
In accordance with the title at line 4568, use `const&` instead of `const &`.
2021-03-25 11:08:46 -07:00
Sergey Zubkov
af44f95577 and another fix to md-split.py for CI 2021-03-18 13:19:45 -04:00
Sergey Zubkov
f36b3ccaa4 fix md-split.py for CI 2021-03-18 12:19:36 -04:00
Sergey Zubkov
1dd82988d7 make CI happier 2021-03-11 15:21:49 -05:00
Sergey Zubkov
ee28f50025 dict update for CI 2021-03-11 15:12:00 -05:00
Herb Sutter
4f0659fb75 Added CP.coro and CP.51, closes #1756 2021-03-11 11:37:45 -08:00
Herb Sutter
ccb7eff4ec CP.1: Made "bad" example consistent with now-updated "good" example 2021-03-11 11:07:31 -08:00
Martin
ffeca2a254
Change comparison to use int instead of double (#1758)
This allows the example to remain simple well not misleading a beginner
such a comparison is safe. Including an epsilon comparison or something
similar would overly complicate this example.

Co-authored-by: Martin O'Shea <martin.oshea@native-instruments.com>
2021-03-11 11:05:59 -08:00
JuliusBrueggemann
1caef9a7f1 Use the same phrasing in index and actual rule 2021-02-24 11:06:22 +00:00