StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Change comparison to use int instead of double (#1758)

Browse Source 
This allows the example to remain simple well not misleading a beginner
such a comparison is safe. Including an epsilon comparison or something
similar would overly complicate this example.

Co-authored-by: Martin O'Shea <martin.oshea@native-instruments.com>
This commit is contained in:
Martin 2021-03-11 20:05:59 +01:00 committed by GitHub
parent 1caef9a7f1
commit ffeca2a254
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CppCoreGuidelines.md
View File

@ -13945,10 +13945,10 @@ Although `cached_computation` works perfectly in a single-threaded environment,
##### Example, good
struct ComputationCache {
double cached_x = 0.0;
int cached_x = 0;
double cached_result = COMPUTATION_OF_ZERO;
double compute(double x) {
double compute(int x) {
if (cached_x != x) {
cached_x = x;
cached_result = computation(x);