Commit Graph

378 Commits

Author SHA1 Message Date
Wiktor Garbacz
c33f1fb03e Simplify casts
Drive-by: check for malloc failure in sapi:✌️:Array
PiperOrigin-RevId: 332446225
Change-Id: I375ea94845e04dffc3353d70737402daa66ae50a
2020-09-18 07:23:19 -07:00
Wiktor Garbacz
08a956a415 Use opaque void* instead of uint8_t* in Comms
PiperOrigin-RevId: 332441641
Change-Id: I09902e98726a0bd57b47d3454ddcb6ef05021d56
2020-09-18 06:48:57 -07:00
Wiktor Garbacz
9ffa5afba6 Remove unnecessary TLV struct
Drive-by: Zero-copy RecvString
PiperOrigin-RevId: 332412385
Change-Id: I169ffa78f016ec2d55c1a3677ea97beed095123c
2020-09-18 02:23:22 -07:00
Christian Blichmann
45c208b19a Update .clang-format to prefer & and * to be close to the type
PiperOrigin-RevId: 332412318
Change-Id: I4cd6d295ef68292c9412722829729142578c4c9f
2020-09-18 02:22:43 -07:00
Copybara-Service
c663427cf9 Merge pull request #49 from bohdanty:master
PiperOrigin-RevId: 332240434
Change-Id: I9e71cf3d3ab50e3a379e3c651b931ca95692666f
2020-09-17 08:36:07 -07:00
Copybara-Service
d4274251a6 Merge pull request #50 from Manwi23:master
PiperOrigin-RevId: 332214390
Change-Id: If9e87dc52cf1e5e2266135c38b6c4429f7f78e5f
2020-09-17 05:28:19 -07:00
Christian Blichmann
13c28403a6 Implement system include detection for CMake build
The Bazel build already queries the current toolchain for its system include
directories. This change brings feature parity and is necessary for systems
with unusual include locations.

PiperOrigin-RevId: 332195812
Change-Id: Ie81d614d21e90b4bd9edf2084ef80bf0d85dd750
2020-09-17 03:08:11 -07:00
Maciej Szawłowski
a68b851c2c Added TypeKind.CHAR_U handling in the generator.
PiperOrigin-RevId: 331988119
Change-Id: I8301c5041c32da185202ed34292e6a2988ecff46
2020-09-16 06:00:55 -07:00
Katarzyna Miernikiewicz
5eed4ec606
Merge branch 'master' into master 2020-09-15 18:26:58 +02:00
Copybara-Service
da41899797 Merge pull request #51 from doinachiroiu:master
PiperOrigin-RevId: 331767052
Change-Id: I286e746fec6248c88df563be00da9451ddd63eb7
2020-09-15 07:46:03 -07:00
Christian Blichmann
ed0086eb66 Fix dynamic binary startup on PPC and newer glibc (> 2.19)
This allows the `_llseek` syscall when it is defined.

PiperOrigin-RevId: 331498182
Change-Id: I2760b264e3a82000b38d278a9c280501a3dbc724
2020-09-14 01:18:33 -07:00
Bohdan
e8a15ea151 Moved tests to root folder, removed unused headers 2020-09-13 18:20:10 +03:00
Katarzyna Miernikiewicz
71e6237cf7 cast changes 2020-09-11 16:35:52 +00:00
Christian Blichmann
21f7373e76 Initial changes to support AArch64
This is a work in progress:
- Syscall tables need work
- Only tested on real hardware using one of our test hosts

As a drive-by, this change also enables the open source version to function on
POWER.

Another side-effect of this change is that the default policies no longer
check for different host architectures at runtime. On x86_64, we do not need
to check for PPC or AArch64 specifice and vice versa.

PiperOrigin-RevId: 331137472
Change-Id: Ic6d6be5cbe61d83dbe13d5a0be036871754b2eb8
2020-09-11 06:34:27 -07:00
Christian Blichmann
c19949eb7b Use inclusive language
PiperOrigin-RevId: 331116936
Change-Id: I7084b24440a1c78c0d70030da900330f0b8d954f
2020-09-11 03:14:12 -07:00
Christian Blichmann
6a1e4b881c Introduce config header to centralize CPU architecture checks
This allows us to remove some uses of macros.

Related changes:
- Make it clear that we support hosting sandboxed binaries from 64-bit
  processes only. CPU architectures are x86-64 and POWER64 (little endian).
- Introduced CPU architecture macros, abstracting away compiler specifics

PiperOrigin-RevId: 330918134
Change-Id: Ife7ad5f14723eec9f68055127b0583b8aecd38dd
2020-09-10 05:48:00 -07:00
Kevin Hamacher
1f8e88586b Log details when executor fails to open the sandboxee binary
PiperOrigin-RevId: 330680717
Change-Id: I4ec855861196177321783dc94f2e05a28e84d512
2020-09-09 02:12:29 -07:00
Sandboxed API Team
776e34502a Internal cleanup migrating StatusOr.
PiperOrigin-RevId: 330561315
Change-Id: Ie8d8857e7fa5819be3358b26425790ede97c99f8
2020-09-08 12:24:35 -07:00
doinachiroiu
1869fe515f Required changes resolved 2020-09-03 14:59:54 +00:00
Christian Blichmann
fdf0483ca0 Migrate to open-source absl::StatusOr<>
This removes our own fork of `absl::StatusOr<>`. Sandboxed API still includes
a custom matcher for Googletest, as that is not open source yet. For
compatibility, the `statusor.h` header is still retained and now aliases
`sapi::StatusOr<>` to `absl::StatusOr<>`.

PiperOrigin-RevId: 329916309
Change-Id: I0544b73a9e312dce499bc4128c28457e04ab9929
2020-09-03 07:40:48 -07:00
Sandboxed API Team
23da55c19a Internal BUILD refactoring
PiperOrigin-RevId: 329720214
Change-Id: I25fbb94dea17db3bdca6438d17508fa304d9706f
2020-09-03 07:40:33 -07:00
Katarzyna Miernikiewicz
490bc569ed changed copying files to patching 2020-09-01 11:06:12 +00:00
Sandboxed API Team
1c833d6f25 Internal cleanup migrating StatusOr.
PiperOrigin-RevId: 329304527
Change-Id: Id6c141272df54c4e165829d690f9f5b2e9ee90cc
2020-08-31 08:13:29 -07:00
doinachiroiu
7e22952c42 Setup error handling modified 2020-08-31 11:48:19 +00:00
doinachiroiu
531850afc2 Required changes resolved 2020-08-31 11:17:15 +00:00
Bohdan Tyshchenko
9803d0549f Changed README, Bazel deps and different parts of code according to the review 2020-08-31 02:19:00 -07:00
Sandboxed API Team
cfac8eb2d9 Internal cleanup migrating StatusOr.
PiperOrigin-RevId: 329250595
Change-Id: I0447d8154a57b1132981b116f02b4d5bceedfd4c
2020-08-31 00:13:54 -07:00
Katarzyna Miernikiewicz
28089de353 workaround to avoid manually copying library files 2020-08-28 15:27:23 +00:00
Wiktor Garbacz
c53f2a900f Automated rollback of commit e7a195ce42.
PiperOrigin-RevId: 328918626
Change-Id: Iabe93ec7062ea6e750e4185e2b0b672a37111ee7
2020-08-28 04:49:41 -07:00
doinachiroiu
905f86a0ab Small README update regarding variables names 2020-08-27 16:59:58 +00:00
doinachiroiu
b2351ec639 Small coding style corrections 2020-08-27 16:55:55 +00:00
doinachiroiu
60b3b5057c Small README correction 2020-08-27 16:49:09 +00:00
doinachiroiu
4336c005d3 Added output format flag and made other required changes 2020-08-27 16:46:59 +00:00
doinachiroiu
bb623d4c0b Required changes resolved 2020-08-27 12:54:57 +00:00
Katarzyna Miernikiewicz
2c50bea22c more style changes 2020-08-27 08:46:12 +00:00
Katarzyna Miernikiewicz
1b0fbc89bb style fix 2020-08-27 08:39:59 +00:00
Katarzyna Miernikiewicz
4f80af5d1c minor changes 2020-08-27 08:38:57 +00:00
Katarzyna Miernikiewicz
88844fc958 changed README.md 2020-08-26 15:13:37 +00:00
doinachiroiu
5ae99706e2 Added PFFFT_ROOT_DIR 2020-08-26 15:03:25 +00:00
doinachiroiu
c8d07aeaa5 Changing paths for propertly usage of the submodule 2020-08-26 14:56:19 +00:00
doinachiroiu
b08726540a Added PFFFT submodule - master directory 2020-08-26 14:25:11 +00:00
doinachiroiu
139723d3b8 Added LICENSE & coding changes required 2020-08-26 14:18:31 +00:00
Katarzyna Miernikiewicz
9f120598c1 added requested changes 2020-08-26 12:17:18 +00:00
doinachiroiu
8f21b0e931 Coding style update 2020-08-26 11:23:33 +00:00
Sandboxed API Team
e7a195ce42 Automated rollback of commit 82c56775ef.
PiperOrigin-RevId: 328340042
Change-Id: Ib225f8012fb373c74e3f1b3e6201b2daca7da40b
2020-08-25 09:01:22 -07:00
Katarzyna Miernikiewicz
ba88cd3499 changed VLA to vectors 2020-08-25 14:53:53 +00:00
Wiktor Garbacz
82c56775ef StatusOr cleanups
PiperOrigin-RevId: 328318284
Change-Id: I207570c0fee6797dbc8995d36ef2130b0bff28fa
2020-08-25 06:22:05 -07:00
Katarzyna Miernikiewicz
032053d55d minor fix 2020-08-25 10:20:00 +00:00
Katarzyna Miernikiewicz
050f0af19a minor change 2020-08-25 09:50:19 +00:00
Katarzyna Miernikiewicz
6554f635fc some of the requested changes made 2020-08-24 15:01:42 +00:00