Anthony Bilinski
0d366a5790
chore(build): Enable all warnings on qTox libraries as well
...
warnings interface was only being linked to qtox_static, so were not being
applied to e.g. util. Link it to each library as well as qtox_static so that
they all inherit all the warnings.
2022-03-24 04:19:41 -07:00
Anthony Bilinski
9da8ec9926
chore(build): Comply with Wshadow in audio lib
2022-03-24 04:19:41 -07:00
Anthony Bilinski
270286b38c
refactor(audio): Move getVolume and volumeAvailable to qreal from float
...
Reduces casting back and forth between types.
2022-03-24 04:19:41 -07:00
Anthony Bilinski
8337b935f9
refactor(audio): Remove unused OpenAL::outputVolume
2022-03-24 04:19:41 -07:00
Anthony Bilinski
27f19ec2fa
fix(History): Deep copy QByteArrays from SQL selects
...
We already deep copy all other data types. Especially with Qt types like
QByteArray, having a deep copy to start is important since it shallow
copies on any subsequent copy, so the callback provider only gets a
shallow copy in the QByteArray of the temporary data from SQLite.
2022-03-24 03:09:12 -07:00
Anthony Bilinski
efc641efd7
feat(Settings): Add GUI notice for global settings upgrade failure
...
Due to new MessageBoxManager, Settings now has the ability to show errors
during init.
2022-03-24 02:14:21 -07:00
Anthony Bilinski
b24faabf42
refactor(GUI): Move remaining messsage box functionality to new class
...
* Pass MessageBoxManager instantiation around instead of relying on a singleton
* Mock MessageBoxManager for unit tests when needed, since they don't have a
QApplication which is required for creating QWidgets
* Remove GUI class, which didn't have a clear purpose
2022-03-24 02:14:20 -07:00
Anthony Bilinski
3bd85452da
refactor(GUI): Remove GUI::getMainWidget
...
It was just dispatching to Nexus::getDesktopGUI - call it directly instead,
for now.
2022-03-24 02:14:20 -07:00
Anthony Bilinski
b57e6c6fc4
refactor(GUI): Remove GUI setWindowTitle
...
Widget is the only caller, let it set its own title. Wrap inherited setTitle to
prepend "qTox". Check for thread is not needed since it is only called
from Widget's slots.
2022-03-24 02:14:20 -07:00
Anthony Bilinski
94d0f29603
refactor(GUI): Remove GUI::themeReload, give responsibility to Style
...
Style already has themeChanged, which was unused. GUI's themeReload just
dispatches to Style, which is already piped to GUI classes. Give the signal
to Style itself so that classes can connect to that, rather than relying on
GUI's singleton.
2022-03-24 02:14:20 -07:00
Anthony Bilinski
3444fed0ac
refactor(GUI): Remove GUI setEnabled, call on Widget directly
...
Nexus is the only caller and has access to Widget. Because only Nexus
calls it, and Nexus runs on GUI thread, remove check and queued
connection.
2022-03-24 02:14:20 -07:00
Anthony Bilinski
e4552cf905
chore(CI): Add support for building toxcore and toxext for macOS
...
CMAKE_OSX_DEPLOYMENT_TARGET has no effect when not building for macOS.
2022-03-21 20:02:15 -07:00
Anthony Bilinski
02f384a7d2
chore(CI): Add support for building qrencode for macOS
...
CMAKE_OSX_DEPLOYMENT_TARGET has no effect when not building for macOS.
2022-03-21 19:16:49 -07:00
Anthony Bilinski
e6075c278d
chore(CI): Add support for building msgpack-c for macOS
...
CMAKE_OSX_DEPLOYMENT_TARGET has no effect when not building for macOS.
2022-03-21 19:16:49 -07:00
Anthony Bilinski
f9b8a8a05f
chore(CI): Add support for building ffmpeg for macOS
2022-03-21 19:16:49 -07:00
Anthony Bilinski
a94304148e
chore(CI): Add support for building libexif for macOS
2022-03-21 19:16:41 -07:00
Anthony Bilinski
b4636c8174
chore(CI): Add support for building openal for macOS
...
CMAKE_OSX_DEPLOYMENT_TARGET has no effect when not building for macOS.
MACOSX_RPATH must be set explicitly for OpenAL to be found. It is default using newer cmake, but OpenAL is using cmake 2.6.
2022-03-21 19:16:41 -07:00
Anthony Bilinski
ad862ca50e
chore(CI): Add support for building openssl for macOS
2022-03-21 19:16:41 -07:00
Anthony Bilinski
c7ac0fdc3f
chore(CI): Add support for building opus for macOS
2022-03-21 19:16:41 -07:00
Anthony Bilinski
59fb97e2a3
chore(CI): Add support for building sodium for macOS
2022-03-21 19:16:41 -07:00
Anthony Bilinski
d3bebab0b7
chore(CI): Add support for building sqlcipher for macOS
2022-03-21 19:16:37 -07:00
Anthony Bilinski
35d35a33f2
chore(CI): Add support for building VPX for macOS
...
Manually set library id name because it defaults to "libvpx.7.dylib",
for some reason, which is not found by qTox or tests.
2022-03-21 17:45:08 -07:00
Anthony Bilinski
b067aae207
refactor: Move Style global shared state into class
2022-03-19 21:28:21 -07:00
Anthony Bilinski
d7b67081e5
refactor(history): Separate db upgrade logic from History
...
Allows for cleaner testability of upgrade logic and reduces the overall size
and clutter of History.
2022-03-19 21:27:40 -07:00
Anthony Bilinski
2a2b079992
feat(core): Add error parsing for Tox_Err_Options_New
2022-03-18 22:20:13 -07:00
Anthony Bilinski
a5660fb6e3
feat(core): Add error parsing for Toxav_Err_Bit_Rate_Set
2022-03-18 22:20:13 -07:00
Anthony Bilinski
47a05c7592
feat(core): Add error parsing for Toxav_Err_Call
2022-03-18 22:20:13 -07:00
Anthony Bilinski
47a20f6061
feat(core): Add error parsing for Toxav_Err_Call_Control
2022-03-18 22:20:12 -07:00
Anthony Bilinski
6c9c380915
feat(core): Add error parsing for Tox_Err_File_Send_Chunk
2022-03-18 22:20:12 -07:00
Anthony Bilinski
978bcde572
feat(core): Add error parsing for Tox_Err_File_Control
2022-03-18 22:20:12 -07:00
Anthony Bilinski
040beae56a
feat(core): Add error parsing for Tox_Err_File_Get
2022-03-18 22:20:12 -07:00
Anthony Bilinski
aff5663351
feat(core): Extend and deduplicate Tox_Err_File_Send error parsing
2022-03-18 22:20:12 -07:00
Anthony Bilinski
350fa9b462
refactor: Don't handle default switch case of error enums
...
Allows for a compile error if enum cases are unhandled. Stil handles a
cast value passed in if the switch matches none.
2022-03-18 22:20:12 -07:00
Anthony Bilinski
b09796a54c
refactor(core): Move toxcore error parsing out of core.pp to utility
...
To be used by coreav and corefile as well.
2022-03-18 22:20:11 -07:00
Anthony Bilinski
ad6b510417
fix(macos): Represent autorun state in UI persistently
...
Check file setting rather than reporting a global value that isn't persisted
across client restart.
2022-03-18 17:02:06 -07:00
Anthony Bilinski
009369118f
fix(macos): Fix macOS autorun not loading at start
...
macOS system.log was reporting "Unknown key for integer: RunAtLoad" and
not loading qTox at start despite
~/Library/LaunchAgents/chat.tox.qtox.autorun.plist being present.
Changing the type from an int to a bool causes it to load successfully
on boot.
Fix #2814
2022-03-18 17:02:04 -07:00
Anthony Bilinski
4c969a9277
chore(CI): Move QrEncode build from autotools to cmake
...
Autotools version failed to configure on macOS, and QrEncode's README says "If
the configure script does not work well, try to use CMake." Cmake works for
both macOS and Windows.
2022-03-18 00:51:49 -07:00
Anthony Bilinski
6c85492f17
chore(CI): Add macOS VPX patch to allow setting mmacosx-version-min
...
VPX overrides the user setting by default, preventing a newer macOS from
building for an older macOS.
2022-03-18 00:51:49 -07:00
Anthony Bilinski
05faddf526
chore(CI): Rename Windows vpx.patch to vpx-windows.patch
...
Avoid conflict with different VPX patch needed for macos
2022-03-18 00:51:49 -07:00
Anthony Bilinski
502ccb1e1b
chore(CI): Add macOS platform detection for build scripts
2022-03-18 00:51:49 -07:00
Anthony Bilinski
90210a9826
chore(CI): Backup NSIS ShellExecAsUser plugin
...
As was done in the previous ANSI version prior to
beb38fa33b
For reasons covered here:
beb38fa33b (r68688468)
2022-03-16 21:36:12 -07:00
Anthony Bilinski
5de5403964
fix(corefile): Close files of broken file transfers
...
Fix #6500
2022-03-16 03:18:17 -07:00
Anthony Bilinski
42b4385c35
chore(CI): Use platform detection script in Windows dep build scripts
...
Allows future macOS configuration in each individual build script to not all be
duplicated. Also deduplicates current Windows arg checking and config setting.
2022-03-15 22:39:07 -07:00
Anthony Bilinski
5ac0dee3a8
chore(CI): Add script for handling platform compile args
2022-03-15 22:39:07 -07:00
Anthony Bilinski
c828a16b7b
feat(CI): Run clang-tidy check in CI
2022-03-15 08:19:53 -07:00
Anthony Bilinski
73aa1f3f48
refactor: Comply with Clang's Wunused-parameter
2022-03-15 08:19:53 -07:00
Anthony Bilinski
3d7a0d249d
refactor: Comply with Clang's Wunused-const-variable
2022-03-15 08:19:53 -07:00
Anthony Bilinski
acc46370ca
refactor: Comply with Clang's Wunused-private-field
2022-03-15 08:19:53 -07:00
Anthony Bilinski
6e7ca76911
refactor: Comply with Clang's Wdouble-promotion
2022-03-15 08:19:53 -07:00
Anthony Bilinski
0e8582c88e
refactor: Comply with Clang's Wmismatched-tags
...
Fix #6042
2022-03-15 08:19:53 -07:00