Michael Park
33e24fb389
F.19: s/T&&/TP&&/
2015-12-11 15:29:43 -05:00
hsutter
b873f02285
Merge pull request #406 from Alexolut/patch-3
...
added spaces around operators.
2015-12-11 08:17:08 -08:00
hsutter
e28faccbf3
Merge pull request #426 from ascherer/fix-const-ness
...
Fix `const`-ness consistency.
2015-12-11 08:16:14 -08:00
hsutter
e1800948cb
Merge pull request #432 from pmalek/master
...
Small typo
2015-12-11 08:15:25 -08:00
hsutter
e93771fdd4
Merge pull request #435 from Alexolut/patch-4
...
Fixed typos, made names consistent.
2015-12-11 08:14:53 -08:00
hsutter
e7756aa5f2
Merge pull request #441 from mpark/P3
...
P.3: Fixed an inaccurate description of `for (const auto& x : v)`.
2015-12-11 08:12:59 -08:00
hsutter
9955c0702f
Merge pull request #448 from mpark/rule
...
Consistently replaced `Rule S.N` with a more widely used `S.N`.
2015-12-11 08:11:36 -08:00
Kristoffel Pirard
d314de001b
[fix] typo
2015-12-11 15:25:43 +01:00
Gabriel Dos Reis
1a2609391b
Merge pull request #447 from mpark/F.4
...
F.4: Fixed a trivial style issue.
2015-12-11 06:14:52 -08:00
Michael Park
4de7d427c2
Consistently replaced Rule S.N
with a more widely used S.N
.
2015-12-11 09:04:36 -05:00
Michael Park
3c33b1f925
F.4: Fixed a trivial style issue.
2015-12-11 08:29:28 -05:00
Michael Park
e1d61e4655
I.25: Marked center
and draw
as const
.
2015-12-11 08:10:37 -05:00
Michael Park
6e39add6a6
P.3: Fixed an inaccurate description of for (const auto& x : v)
.
2015-12-11 02:14:57 -05:00
hsutter
ccacbd6d54
Closes #440
2015-12-10 22:41:19 -08:00
Michael Park
b8b88bf4ec
NL.5: Fixed typo s/typename/template/
.
2015-12-10 17:29:43 -05:00
hsutter
b4a0bd4310
Update date
2015-12-09 19:27:48 -08:00
Alexolut
58eef51608
Fixed typos, made names consistent.
2015-12-09 17:47:48 +03:00
hsutter
f07be3e8fb
Fixed typo in T.81 - issue #434
2015-12-08 07:33:28 -08:00
Andreas Scherer
08b9149086
Fix const
-ness consistency.
...
The majority of `const`-ness have the code-word joined with a hyphen to
its 'ness'. Make two slightly different versions consistent with this.
2015-12-08 09:20:47 +01:00
Sergey Zubkov
bc3d47768a
typs: s/literated/littered s/likelyhood/likelihood
2015-12-07 22:21:36 -05:00
Bjarne Stroustrup
729db042f1
clarification of F.42
2015-12-05 21:25:46 -05:00
Bjarne Stroustrup
518304ed63
ES.33: another warning against macros
2015-12-05 18:33:36 -05:00
Patryk Małek
7c68566196
Small typo
2015-12-05 20:50:08 +01:00
Rob Adams
a013348a7e
Calling delete on a FILE* created with fopen is ill-advised. Uses a
...
custom deleter.
2015-12-04 16:24:41 -08:00
Gabriel Dos Reis
ed59160a47
Merge pull request #430 from ascherer/fix-note-on-ranges
...
Fix note on ranges.
2015-12-04 05:31:22 -08:00
Gabriel Dos Reis
e7f76036f2
Merge pull request #429 from ascherer/consistent-enforcement
...
Consistent Enforcement paragraphs.
2015-12-04 05:30:44 -08:00
Gabriel Dos Reis
ef03d8b700
Merge pull request #428 from ascherer/typeset-NaN
...
Consistent formatting of 'NaN'.
2015-12-04 05:30:00 -08:00
Andreas Scherer
9ca047b49e
Fix note on ranges.
2015-12-04 11:12:52 +01:00
Andreas Scherer
37071453cb
Consistent Enforcement paragraphs.
2015-12-04 11:08:16 +01:00
Andreas Scherer
5067b9789a
Consistent formatting of 'NaN'.
2015-12-04 11:01:57 +01:00
Andreas Scherer
10aea497d7
Validate rendered HTML.
...
Replace 'illegal' characters in `<a>`nchors with more neutral items.
The Markdown code is put through `pandoc -s --smart ...`
and the resulting HTML is positively tested by the
[W3C validator](https://validator.w3.org/#validate_by_upload ).
2015-12-04 10:55:49 +01:00
hsutter
87e3e47da7
Slightly better text for previous commit
2015-12-03 06:26:11 -08:00
hsutter
3fa4b5623b
Added xref to Rf-out per issue #390
2015-12-03 06:24:22 -08:00
hsutter
936d321266
Extended Type.8 enforcement per issue #348
2015-12-02 12:46:44 -08:00
hsutter
b16ef02365
Extended Sd-factory example per issue #310
2015-12-02 12:42:04 -08:00
hsutter
7e81a238e0
Updated Bounds.4 as suggested in issue #267
2015-12-02 12:36:23 -08:00
hsutter
d81adf4a8e
Added guidance to make function objects cheap to copy and pass by value
2015-12-02 12:31:03 -08:00
hsutter
fe7a9dfe48
Expanded F.19 enforcement to forward exactly once (issue 128)
2015-12-02 12:28:20 -08:00
hsutter
247be64de6
Fixed invoke() example to not forward the functor, to reflect other discussion
2015-12-02 12:25:58 -08:00
hsutter
ac773e44d4
Updated R.3 to refer to #Rf-out
2015-12-02 12:18:18 -08:00
hsutter
ceaddf311e
Added comments to P.6 to address Issue 9
2015-12-02 12:12:49 -08:00
hsutter
866df49181
Manually merged PR 145 for C.150 improvement
2015-12-02 12:07:43 -08:00
hsutter
19ee5fc18f
Added suppression syntax note
2015-12-02 12:05:27 -08:00
hsutter
ec9065bdfb
Updated C.134 to call out const and add more rationale (issue 302)
2015-12-02 12:01:40 -08:00
hsutter
fbd4acd526
Added enforcement to not move from & parameters (issue 316)
2015-12-02 11:46:22 -08:00
hsutter
c101fc7ac4
Updated C.35 to address Issue 375
2015-12-02 11:25:32 -08:00
hsutter
4a9e41d766
Added smartptrconcepts as link to Lifetime paper (Issue 407)
2015-12-02 11:14:24 -08:00
hsutter
49afa391e5
Added F.18 body and clarification from issue 398
2015-12-02 11:07:46 -08:00
Titus Winters
41eb8f28e7
Identifiers in enum class can overlap.
...
Reverting Capitalization of Red/Purple/Blue in enum class example.
2015-12-01 15:23:06 -05:00
hsutter
6228e99a51
Separated F.15 into F.15-21: in, inout, consume, forward, out, multi-out
2015-12-01 09:07:52 -08:00
hsutter
08b83eaea0
Renumbered F.16-19 -> F.22-25
...
For better topical grouping and to make room to break up F.15 into
smaller items
2015-12-01 08:33:42 -08:00
hsutter
1922e46ac7
Merged F.40 into F.15 (issue #1
2015-12-01 08:25:56 -08:00
hsutter
9e7bd3d4c4
Merged F.25 into F.15 (issue #1 )
2015-12-01 08:08:10 -08:00
hsutter
89bf79e00c
Merged F.24 into F.15 (issue #1 )
2015-12-01 08:04:50 -08:00
hsutter
7d3ff3c0b1
Merged F.23 into F.15 (issue #1 )
2015-12-01 07:58:37 -08:00
hsutter
59eacc8aad
Merged F.22 into F.15 (issue #1 )
2015-12-01 07:54:46 -08:00
hsutter
7fb7db3f0d
Merged F.21 into F.15 (issue #1 )
2015-12-01 07:48:46 -08:00
hsutter
65dc9e9c37
Merged F.20 into F.15 (issue #1 )
2015-12-01 07:42:11 -08:00
Andriy Grygorenko
5990abead1
F.27: Example fix
...
It is usually a bad idea to share mutable objects between threads, which leads to a race condition or unnecessary thread contention.,
2015-11-27 20:19:32 -05:00
Eliyahu Ravuna
282a11de26
The vector was missing template arguments. Fixed
...
Thank you for the feedback in #402 .
char replaced with uint8_t.
2015-11-27 08:10:16 +02:00
Alexolut
76824f8d1d
added spaces around operators.
2015-11-26 17:02:28 +03:00
Alexolut
e238597f6c
fixed a typos because of zero-based indexing
...
Another misunderstanding: how container can be modified (side-effect in a call of `f(&v[i])` ) if we passing only an address to element, not a address to container?
2015-11-25 11:19:08 +03:00
Matthias Kluwe
66ca2b5f6a
Fix grammar in I.22
2015-11-24 18:34:56 +01:00
Alexolut
ac40133baa
fix typos
2015-11-24 18:59:18 +03:00
Jordan Harris
f211ce714c
Fix grammar in Appendix C...
...
Discussion: Make base class destructors public and virtual, or protected and nonvirtual
2015-11-20 14:00:57 -05:00
Eliyahu Ravuna
dda7a868b1
Suggested example for PER.4
2015-11-20 03:31:37 +02:00
hsutter
4abbd0618f
Improved F.41
...
Added potential C++17 example based on EWG direction in Kona
2015-11-18 20:28:38 -08:00
Gabriel Dos Reis
de57702fdd
Merge pull request #386 from RicoAntonioFelix/master
...
Correction of minor errors...
2015-11-18 16:05:42 -08:00
RicoAntonioFelix
3140dde428
Added missing capture clause in lambda expression and missing variable name from declaration of file object...
2015-11-18 19:02:14 -04:00
Gabriel Dos Reis
bbbb922dd0
Merge pull request #389 from darrnshn/master
...
Minor fixes to NL.8
2015-11-18 13:44:00 -08:00
Gabriel Dos Reis
0330fcb265
Merge pull request #394 from tituswinters/p.7
...
Don't ruin the complexity of your interface with checking.
2015-11-18 13:43:16 -08:00
tituswinters
549da18a72
Update CppCoreGuidelines.md
...
Typo in the clarification. Don't ruin the complexity of your thing with added checks. :)
2015-11-18 07:28:30 -05:00
Titus Winters
2bd1f7a94d
Fix the "enum class" example (which was backwards and broken).
2015-11-17 17:54:57 -05:00
Titus Winters
937488887f
Don't ruin the complexity of your interface with checking.
2015-11-17 16:22:21 -05:00
Gabriel Dos Reis
fe811ed63a
Merge pull request #393 from tituswinters/p.2
...
Add a little to the "Don't use non-standard extensions discussion."
2015-11-17 13:13:27 -08:00
Titus Winters
b3e6c82ade
Add a little to the "Don't use non-standard extensions discussion."
2015-11-17 16:07:50 -05:00
Titus Winters
21815d7ba0
Changes that seem editorial or (hopefully) non-controversial.
2015-11-17 15:37:04 -05:00
Darren Shen
63e5e23e2c
Fix NL.8 typo
2015-11-14 15:17:33 +11:00
Andrew Pardoe
ca22f65232
Merge pull request #387 from darrnshn/master
...
Fix minor formatting issues
2015-11-12 14:57:55 -08:00
Andrew Pardoe
cc3ffb50af
Merge pull request #385 from timp3289/patch-1
...
Fixed typo
2015-11-12 14:56:18 -08:00
Darren Shen
92458af3fa
Fix minor formatting
2015-11-12 20:02:50 +11:00
timp3289
31016ad113
Fixed typo
2015-11-11 21:30:29 +11:00
Richard Holmes
f13a89539e
Fix F.16 (Use T* or owner<T*> to designate a single object) to use consistent variable name in the example provided.
2015-11-08 22:37:30 -06:00
Sergey Zubkov
f0091dbc56
typo: s/preformance/performance
2015-11-04 22:08:32 -05:00
Neil MacIntosh
5bb3b3f732
Updated description of *_view to reference span.
2015-11-04 14:17:24 -08:00
Neil MacIntosh
af48243d0a
Updated FAQ entry about string_span/string_view.
2015-11-04 14:13:01 -08:00
Neil MacIntosh
0a9cdd34b6
Grammar fixes after span rename.
2015-11-04 14:11:47 -08:00
Neil MacIntosh
0eaee02da9
Rename: array_view=>span, string_view=>string_span.
2015-11-04 13:53:09 -08:00
Bjarne Stroustrup
7df274bcbe
etc
...
just a few of my assignments; I'll get better at keeping track
2015-11-03 18:11:46 -05:00
Gabriel Dos Reis
98dd36e921
Merge pull request #369 from villasv/master
...
C.43: rewording and examples suggested in #344
2015-11-03 02:05:30 -08:00
Victor Villas
ebd3a33d1d
C.43: rewording and examples suggested in #344
2015-11-03 00:28:24 -05:00
Eliyahu Ravuna
1dc02e15a7
Enforcement rule for I.3: Avoid singletons
...
Proposal revised as agreed in #266 .
2015-11-02 22:08:31 +02:00
Gabriel Dos Reis
8275f69ce3
Merge pull request #327 from ulilaube/fixcrossref
...
Fixcrossref
2015-11-01 11:16:26 -08:00
Gabriel Dos Reis
3e2aec11bf
Merge pull request #372 from wwalexander/patch-1
...
Fix misplaced end parenthesis in NL.17.Reason
2015-11-01 10:57:51 -08:00
Gabriel Dos Reis
ee793dfb38
Merge pull request #371 from drusk/es31_typos
...
Fixed some typos in section ES.31.
2015-11-01 10:47:21 -08:00
Will Alexander
57b16ed800
Fix misplaced end parenthesis in NL.17.Reason
2015-11-01 05:45:11 +00:00
drusk
31d4985179
Fixed some typos in section ES.31.
2015-10-29 19:53:44 -07:00
Brett
d3dd1c683b
capitalize "resource acquisition is initialization"
2015-10-30 15:30:09 +13:00
Kalman Keri
6029fc813d
Replacing problematic code example in ES.41
2015-10-28 09:32:23 +01:00
uli
bf306f81cb
Rules T.11 and T.124 used the same cross reference anchor Rt-std.
...
Rules SF.1 and SF.2 used the same cross reference anchor Rs-suffix.
There is no rule F.54 with anchor Rf-local-ref-ref (yet?). Broken reference removed.
Sections TPG.concepts and GSL.concepts used the same anchor SS-concepts.
Section C.ctor and its own subsection C.ctor.ctor used the same anchor SS-ctor.
2015-10-26 16:45:52 +01:00
Gabriel Dos Reis
792b831e7a
Merge pull request #341 from ascherer/fix-typos
...
Fix typos
2015-10-26 06:58:11 -07:00
Gabriel Dos Reis
a4b400e9eb
Merge pull request #349 from alrekr/master
...
Typo
2015-10-26 06:55:09 -07:00
Gabriel Dos Reis
2c72daaab7
Merge pull request #358 from khatharr/master
...
A few spelling and grammar fixes R.22 and ES.23
2015-10-26 06:54:26 -07:00
Kálmán Kéri
42bbbf6a2d
ES.23: two corrected typos in code example
2015-10-26 10:08:43 +01:00
Khatharr
d0ac3dc3bc
A few spelling and grammar fixes R.22 and ES.23
2015-10-24 16:32:50 -07:00
Malthe Høj-Sunesen
6d992f9b79
Typo
2015-10-20 12:28:52 +02:00
Andreas Scherer
302b9848d4
Fix errors in Resource section.
2015-10-18 16:57:25 +02:00
Andreas Scherer
ff623adc6b
Mismatching and missing quotes.
...
And other problems fixed.
2015-10-18 16:50:08 +02:00
Andreas Scherer
4c55ed4662
Errors in enum section.
2015-10-18 16:22:38 +02:00
Andreas Scherer
31ce56e75f
Three more bugs fixed.
2015-10-18 16:20:12 +02:00
Andreas Scherer
545c7c40e3
Correct multiple problems in related sentences.
2015-10-18 16:12:14 +02:00
Andreas Scherer
3e8dc12982
Several typos fixed.
...
Missing or superfluous characters corrected.
Rewording to avoid "problems requires tools".
...
2015-10-18 16:00:21 +02:00
Andreas Scherer
69405d3d15
Remove in-text C++ comment sign.
2015-10-18 12:34:21 +02:00
Andreas Scherer
7c25281c38
Fix singular/plural mismatches.
...
Either the rules eliminate, or the rule eliminates.
Multiple 'Date' classes have default dates.
...
2015-10-18 12:33:37 +02:00
Andreas Scherer
6571ede5e7
Invert single occurrence of closing brace after comma.
2015-10-18 12:32:39 +02:00
Andreas Scherer
41f1c30d1c
Add missing closing brace.
2015-10-18 12:30:07 +02:00
Andreas Scherer
8221bd9016
Fix missing backticks for std-code.
2015-10-18 12:28:41 +02:00
Herb Sutter
a076dede74
Added FAQ.10 for Markdown
2015-10-16 11:00:25 -07:00
Andreas Scherer
daf2595009
Fix typos and add internal links.
...
Two hours of semi-automatic digestion of the C++ Guidelines result
in a host of small changes. Eight intermediate commits make up this
squashed monster.
First I ran 'aspell -l en_US -c CppCoreGuidelines.md' and interactively
corrected several trivial typos. Then I spent a short hour inside Vim to
improve the spacing by looking for '[a-z] [a-z]' plus the odd typo.
Only after reading the 'how to contribute' section, I started to create
smaller patches. Continuing by reading the .md-file on formatted form, I
added a markdown link to the associated 'LICENSE' in the introduction.
Then I scanned section 'SF' and fixed typos. Next I spotted a single
problem with a French accent. After adding another internal link from
the FAQ section to the Abstract, I finished the day by reading and
correcting section CPL.
2015-10-15 15:08:50 +02:00
Gabriel Dos Reis
9653bdb38f
Merge pull request #297 from dhood/copyedit
...
Various copy editing changes up to I.6
2015-10-15 03:02:36 -07:00
Deanna Hood
6dbdc9d33e
Copy edit
2015-10-15 10:44:40 +01:00
Gabriel Dos Reis
2bbc1c249e
Merge pull request #333 from ulilaube/fixmarkup
...
Fix markup
2015-10-15 01:46:21 -07:00
uli
c3877a41af
Convert LaTeX-quotes to ordinary ASCII quotes.
...
Added missing backticks.
Removed extra }.
Consistent backticks for const added.
Typo fixed.
Missing equality signs in HTML-markup added.
2015-10-15 10:38:37 +02:00
Andrew Pardoe
abed1970b5
Update tag in I4 based on Issue #329
2015-10-14 14:19:24 -07:00
Gabriel Dos Reis
57a5446625
Merge pull request #326 from ralphtandetzky/patch-1
...
Fixed grammatical error.
2015-10-13 09:08:18 -07:00
Ralph Tandetzky
81635bad4e
Fixed grammatical error.
2015-10-13 15:01:47 +02:00
Thibault Kruse
5d1d990cd9
minor style fixes
2015-10-13 12:33:26 +02:00
xtofl
be59e3c73e
[fix] markdown backtick mismatch
2015-10-12 20:44:06 +02:00
Gabriel Dos Reis
b369145220
Merge pull request #319 from tkruse/pr/291
...
Added example to NL 9
2015-10-12 04:24:29 -07:00
richelbilderbeek
a86ae876a2
Added example to NL 9
2015-10-11 12:15:23 +02:00
Eliyahu Ravuna
a7459b4164
Typo fixed in C.165
2015-10-11 00:21:19 +03:00
Bjarne Stroustrup
592d67ea12
using std:;swap();
...
C.165 added.
Also: glossary extended.
Please review both.
2015-10-10 14:57:13 -04:00
Bjarne Stroustrup
70a19387fe
add reference to RTTI
2015-10-09 17:51:40 -04:00
Bjarne Stroustrup
72821c0f88
more minor issues
...
static_cast/dynamic_cast- not really satisfactory
2015-10-09 15:34:43 -04:00
Bjarne Stroustrup
1b79ede5c5
minor changes to do with functions
...
f(void)
void main()
final
2015-10-09 14:36:23 -04:00
Gabriel Dos Reis
552855c17a
Merge pull request #296 from kpx1894/kpx1894-patch-1
...
fixes to code examples in C.61
2015-10-09 10:54:47 -07:00
Gabriel Dos Reis
96dfc9f96e
Merge pull request #306 from mitro42/fix_discussion_dtorneverfail
...
Fixed code indentation, numbering and typo in Discussion: Destructors…
2015-10-09 10:54:00 -07:00
Gabriel Dos Reis
72630e3d60
Merge pull request #308 from kjpgit/master
...
s/constructor/destructor
2015-10-09 05:42:46 -07:00
kjpgit
537e15d0af
C40: correct enforcement wording
2015-10-08 09:18:10 -05:00
mitro42
f909c0fc02
Fixed typos
2015-10-08 12:12:36 +01:00
Bjarne Stroustrup
91109eb8ab
A few clarifications
...
especially to do with initializations
the beginnings of a glossary
2015-10-07 21:56:44 -04:00
mitro42
c827bddcd5
Fixed code indentation, numbering and typo in Discussion: Destructors, deallocation, and swap must never fail
2015-10-07 22:35:17 +01:00
kpx1894
0902d5d137
fixes to code examples in C.61
...
Two argument comparison operator in both code examples for "C.61: A copy operation should copy" has a body of single argument member operator. This fix keeps comparison operator outside class, but corrects its body.
2015-10-06 09:39:00 +01:00
Thibault Kruse
8a4550c8f9
Minor style issues
2015-10-05 14:15:58 +02:00
Thibault Kruse
ad2717f7fa
Unnecessary ';'
2015-10-05 13:55:11 +02:00
Thibault Kruse
2a907f088d
Code indent 4 spaces instead of tabs
2015-10-05 13:55:11 +02:00
Thibault Kruse
31fec52f4f
Use Only alphanumerics for anchor-ids
2015-10-05 13:55:11 +02:00
Thomas Köppe
2f6c3d5c2b
[GSL.view] Simplify explanation of lack of "null references".
2015-10-05 12:38:30 +01:00
Thomas Köppe
7143050ef6
[GSL.view] Make wording around null pointers and null references more precise.
2015-10-05 12:38:30 +01:00
Thibault Kruse
a519dfc560
consistent code formatting whitespaces
2015-10-05 13:03:01 +02:00
Thibault Kruse
4ba88ae0ea
consistently opening braces for multiline function def on new line
2015-10-05 12:57:18 +02:00
Gabriel Dos Reis
cb3bf9d989
Merge pull request #275 from tkruse/fix-mdstyle16
...
fix minor style issues
2015-10-05 03:56:20 -07:00
Gabriel Dos Reis
04d69d8268
Merge pull request #278 from tkruse/fix-mdstyle19
...
Text Style: Unnecessary blank, puntuation, linebreak after comma
2015-10-05 03:54:10 -07:00
Gabriel Dos Reis
d21b1f1b65
Merge pull request #277 from tkruse/fix-mdstyle18
...
consistently no whitespace padding inside round parentheses
2015-10-05 03:51:41 -07:00
Thibault Kruse
fcfa485671
Text Style: Unnecessary blank, puntuation, linebreak after comma
2015-10-05 08:50:53 +02:00
Thibault Kruse
7dca435e71
consistently no whitespace padding inside round parentheses
2015-10-05 08:50:50 +02:00
Thibault Kruse
806e40b214
missing indent
2015-10-05 08:50:41 +02:00
Thibault Kruse
572f9c6cbf
??? for placeholder
2015-10-05 08:50:40 +02:00
Thibault Kruse
b8254dcf96
fix mix of tabs and spaces
2015-10-05 08:50:40 +02:00
Eliyahu Ravuna
9c129ec89c
Feedback of Jared in #283 incorporated into I.4
2015-10-05 01:46:28 +03:00
Gabriel Dos Reis
ca107da14c
Merge pull request #279 from fkaelberer/patch-2
...
Fix ES.103 example
2015-10-04 11:20:07 -07:00
Gabriel Dos Reis
620eda5c3c
Merge pull request #281 from fkaelberer/patch-3
...
Fix minor typos and spacing
2015-10-04 11:17:51 -07:00
Eliyahu Ravuna
78581f2ae6
std::chrono::duration example for I.4
...
Make interfaces precisely and strongly typed.
2015-10-04 20:12:10 +03:00
Felix Kälberer
56c319d46a
Fix minor typos and spacing
2015-10-03 18:55:07 +02:00
Felix Kälberer
1de6e77b15
Fix ES.103 example
...
```
int area(int h, int w) { return h*w; }
auto a = area(10'000'000 * 100'000'000); // bad
```
The `*` in the second line should be a comma
2015-10-03 16:47:24 +02:00
Thibault Kruse
d458c57d08
fix duplicate anchor IDs
2015-10-02 18:08:46 +02:00
Thibault Kruse
b5d8ef8be7
Fix missing lines/ bad indent
2015-10-02 17:42:28 +02:00
Eliyahu Ravuna
8050963a06
Access memory predictably - Revised according to the feedback in #256
...
Capitalization revised according to the feedback in #256 .
(Access memory predictably)
2015-10-02 16:13:59 +03:00
Gabriel Dos Reis
57d06f2138
Merge pull request #261 from Eliyahu-Ravuna/patch-8
...
As agreed in #255 , commits squashed (ES.100)
2015-10-02 06:05:42 -07:00
Eliyahu Ravuna
c4b3b8b0c6
As agreed in #255 , commits squashed (ES.100)
...
As agreed in #255 , two commits squashed.
(ES.100: Don't mix signed and unsigned arithmetic)
2015-10-02 16:02:20 +03:00
Eliyahu Ravuna
ad3d1dc631
Change agreed in #253
...
As agreed in #253 , three commits squashed into one.
(Suggested 'return containers by value' example + Title made more concise)
2015-10-02 15:55:31 +03:00
Gabriel Dos Reis
4d1c32f298
Merge pull request #219 from tkruse/mdast-idempot
...
Achieve mdast idempotency (4-space markdown indent, single empty lines)
2015-10-02 03:37:36 -07:00
Gabriel Dos Reis
149a681188
Fix forward links in NL
...
Fix #241 .
2015-10-02 03:31:10 -07:00
Thibault Kruse
d844553169
Code blocks consistently use 4 spaces markdown indent (via mdast)
...
Exception is 8space indent for code inside bullet lists (also handled by mdast)
Changes code fences as well to 4-space indent.
This does not affect C++ indent within code blocks (mdast does not touch that either way).
2015-10-02 12:17:40 +02:00
Thibault Kruse
e291947e25
fix consecutive blank lines (mdast output).
2015-10-02 12:17:04 +02:00
Gabriel Dos Reis
00d542f777
Fix misplaced override
specifier
...
Fixed #248 .
2015-10-02 03:12:47 -07:00
Gabriel Dos Reis
c4088e053b
Merge pull request #237 from david-mitchell/patch-1
...
Fix grammar.
2015-10-02 03:04:10 -07:00
Gabriel Dos Reis
bdc863dcda
Merge pull request #258 from axelstudios/master
...
Fixed minor typos
2015-10-02 02:54:48 -07:00
Gabriel Dos Reis
2536585830
Merge pull request #257 from RicoAntonioFelix/master
...
Added capture in lambda expression...
2015-10-02 02:54:00 -07:00
Gabriel Dos Reis
a615bdeb19
Merge pull request #254 from Eliyahu-Ravuna/patch-3
...
Typo fixed in 'Use templates to express containers'
2015-10-02 02:52:27 -07:00
Alex Swindler
23b1257817
Fixed minor typos
2015-10-01 21:12:20 -06:00
RicoAntonioFelix
af18193511
Added capture in lambda expression...
2015-10-01 21:32:09 -04:00
drusk
80f93640ce
Fixed minor typo in section P.2.
2015-10-01 16:08:39 -07:00
Eliyahu Ravuna
6dbcabc974
Typo fixed in 'Use templates to express containers'
2015-10-02 00:47:39 +03:00
Gabriel Dos Reis
1ab6344b44
Merge pull request #218 from Jiwan/Jiwan-change-nullptr-passing-exemple
...
Fixed minor error in I.12: Declare a pointer that must not be null as not_nul
2015-10-01 03:14:00 -07:00
Gabriel Dos Reis
6746027209
Merge pull request #242 from tkruse/fix-minisections
...
Replace **strong** fake headers with real markdown headers
2015-10-01 03:11:02 -07:00
spacewander
9d4a7627c7
fix C.over index error
2015-10-01 17:56:02 +08:00
Thibault Kruse
e4ea6c5374
Replace **strong** fake headers with real markdown headers carrying section semantics
2015-09-30 22:26:44 +02:00
Thibault Kruse
d5295a8d9d
Fix broken and fragile rendering of Bibliography
2015-09-30 20:36:03 +02:00
Thibault Kruse
4b1f9ad99c
fix missing closing parens (in test())
2015-09-30 20:36:03 +02:00
David Mitchell
3d3d43d60f
Fix grammar.
2015-09-30 10:18:58 -07:00
David Mitchell
d8f54449d6
Fix typo.
2015-09-30 10:02:48 -07:00
Jiwan
e41b65cca1
Fixed a minor error in an example in I.12.
2015-09-30 15:33:25 +02:00
Emmanuel Briot
cc45432b01
Minor typo fixes
2015-09-30 12:05:07 +02:00
Gabriel Dos Reis
812fb8f314
Merge pull request #221 from david-mitchell/patch-9
...
Fix typo.
2015-09-29 17:43:43 -07:00
Gabriel Dos Reis
b7940d2ef4
Merge pull request #220 from david-mitchell/patch-8
...
Fix typo.
2015-09-29 17:43:13 -07:00
Gabriel Dos Reis
a39f61bc5c
Merge pull request #223 from delta-nry/patch-1
...
Correct and clarify FAQ.59 and FAQ.60
2015-09-29 17:42:35 -07:00
Gabriel Dos Reis
cedd9c6481
Merge pull request #209 from jlaire/typos-and-other-fixes
...
Typos and other fixes
2015-09-29 17:40:02 -07:00
Gabriel Dos Reis
d3d0426b39
Merge pull request #228 from david-mitchell/patch-10
...
Fix verb agreement.
2015-09-29 17:32:05 -07:00
Gabriel Dos Reis
b8c9ad47ac
Merge pull request #230 from david-mitchell/patch-12
...
Fix awkward wording.
2015-09-29 17:31:17 -07:00
David Mitchell
7103785b20
Fix awkward wording.
2015-09-29 16:55:56 -07:00
David Mitchell
7d82c95191
Add missing punctuation.
2015-09-29 16:50:55 -07:00
David Mitchell
5560508b28
Fix verb agreement.
2015-09-29 16:48:24 -07:00
Johannes Laire
3f160967b6
More small fixes
2015-09-30 00:42:58 +02:00
Johannes Laire
74b5debe8c
Add an example
2015-09-30 00:42:27 +02:00
Johannes Laire
9a976c8a85
Fix bugs in examples
2015-09-30 00:42:27 +02:00
Johannes Laire
d01a414fed
Typo fixes
2015-09-30 00:42:27 +02:00
Johannes Laire
7e6734ade4
Small fixes to markdown formatting
2015-09-30 00:41:38 +02:00
Nathan Yee
4befe68ea6
Correct and clarify FAQ.59 and FAQ.60
2015-09-29 15:35:38 -07:00
David Mitchell
e1810cf164
Fix typo.
2015-09-29 14:57:08 -07:00
David Mitchell
632e4ef544
Fix typo.
2015-09-29 14:55:43 -07:00
Herb Sutter
8a1d622671
Added dyn_array vs. dynarray to FAQ
2015-09-29 09:09:38 -07:00
Brian Rodriguez
7112881429
T.40 typo: find
to find_if
...
`std::find` accepts a value, not a function object. `std::find_if` was the intended function.
2015-09-29 12:06:21 -04:00
Gabriel Dos Reis
1ad595e1a6
Merge pull request #212 from tkruse/fix-mdstyle12
...
Fix code snippets that do not compile, or mark them with ???
2015-09-29 09:03:38 -07:00
Herb Sutter
474d0d3e6b
Elaborated on some of the FAQs
2015-09-29 09:01:29 -07:00
Thibault Kruse
314cff005c
Fix code snippets that do not compile, or mark them with at least one ???
2015-09-29 17:57:48 +02:00
Herb Sutter
2528acd017
Added GSL type-specific FAQs
2015-09-29 08:55:09 -07:00
Gabriel Dos Reis
8a1ff8bb3c
Merge pull request #196 from david-mitchell/patch-4
...
Fix typo.
2015-09-29 08:51:21 -07:00
Gabriel Dos Reis
16a332330c
Merge pull request #197 from david-mitchell/patch-5
...
Improve wording and structure of paragraph.
2015-09-29 08:50:06 -07:00
Gabriel Dos Reis
7fa4b587b1
Merge pull request #201 from jwakely/patch-2
...
Change gsl:: qualification to lowercase
2015-09-29 08:45:04 -07:00
Gabriel Dos Reis
48c3c3b549
Merge pull request #211 from tkruse/fix-mdstyle11
...
fix bad mix of tabs and spaces
2015-09-29 08:41:29 -07:00
Thibault Kruse
4b0c6702bb
fix bad mix of tabs and spaces
2015-09-29 11:44:07 +02:00
Thibault Kruse
5a449f4bd8
bad char instead of minus
2015-09-29 11:39:22 +02:00
Thibault Kruse
33f832e090
typo
2015-09-29 11:39:22 +02:00
Thibault Kruse
fca180e978
Fix code that does not compile
2015-09-29 11:39:22 +02:00
Thibault Kruse
a4c8444032
Minor fix: remove blank inside html tags
2015-09-29 11:39:22 +02:00
Gabriel Dos Reis
93736f8e41
Merge pull request #137 from trebconnell/final_action
...
Change casing of Final_action to final_action
2015-09-29 02:19:00 -07:00
Gabriel Dos Reis
1a3b28260f
Merge pull request #207 from tryfinally/patch-2
...
typo fixes: constxp -> constexpr, spaces
2015-09-29 02:15:12 -07:00
Gabriel Dos Reis
5302819df0
Merge pull request #188 from tkruse/fix-mdstyle7
...
Some style issues
2015-09-29 02:14:20 -07:00
rkawulak
7e4a683c96
Lots of minor fixes (typos, code errors, formatting, etc.)
2015-09-29 10:35:26 +02:00
Muhammad Zahalqa
45ff180fde
typo fixes
...
ES.45
2015-09-29 10:24:15 +03:00
Thibault Kruse
95ed869751
fix: code within bullets must be indented 8 spaces
...
See http://meta.stackexchange.com/questions/3792/how-to-nest-code-within-a-list-using-markdown
2015-09-29 09:16:10 +02:00
Thibault Kruse
946ffee133
fix bad code indentation
2015-09-29 09:15:39 +02:00
Thibault Kruse
56db9e88a4
minor markdown style fixes
2015-09-29 09:15:39 +02:00
Thibault Kruse
5ac1676b10
Remove trailing whitespace, as it can be unintentionally interpreted as meaningful after bullet lists
2015-09-29 09:15:13 +02:00
Gabriel Dos Reis
f34bc55c73
Merge pull request #194 from tkruse/fix-mdstyle8
...
Fix markdwn issues that confuse mdast markdown linter
2015-09-28 23:58:13 -07:00
Gabriel Dos Reis
7c4b526325
Merge pull request #199 from david-mitchell/patch-7
...
Fix typo.
2015-09-28 23:56:03 -07:00
Johannes Laire
4bea8b4573
Fix typo
2015-09-29 08:36:37 +02:00
Thibault Kruse
777f7bc5fb
fix code blocks indented with tab (4 spaces instead)
2015-09-29 01:44:26 +02:00
Thibault Kruse
8adf569a57
Fix style issues that confuse the mdast linter (and need to be fixed anyways)
2015-09-29 01:44:26 +02:00
Treb Connell
462590319a
Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines into final_action
...
Conflicts:
CppCoreGuidelines.md
2015-09-28 15:23:12 -07:00
Treb Connell
04637619de
Change 'finally object' to 'final_action object'
2015-09-28 15:20:19 -07:00
Herb Sutter
4b6fb49772
Added a FAQ section
2015-09-28 12:32:50 -07:00
Jonathan Wakely
53dc924649
Change gsl:: qualification to lowercase
2015-09-28 19:36:07 +01:00
David Mitchell
d7f7ca5ab4
Fix typo.
2015-09-28 10:23:19 -07:00
David Mitchell
46e867e9c6
Improve wording and structure of paragraph.
...
To be grammatically correct, the phrase "Confusion about what meaning a T* is the source" should have had a doubled "is", which would have been awkward, so the sentence has been reworded.
The second and third sentences were inverted. Prior to the inversion, the sentence starting with "For example" initially appeared to be expanding on the debuggability of not_null, rather than providing an example of how using separate names improves code quality.
2015-09-28 09:54:11 -07:00
David Mitchell
aad584c8b1
Fix typo.
2015-09-28 09:16:20 -07:00
Thibault Kruse
a7dc7d1fa6
Put header-anchors in header. For Compliance, correctness, consistency
...
The anchor would else point to the end of the previous section
Also this causes issues with tools ensuring a blank line before a header.
2015-09-28 10:10:42 +02:00
Thibault Kruse
35161a3d04
Consistent Space between anchor and header
2015-09-27 21:45:30 +02:00
Thibault Kruse
7b422eac3f
fix header inside anchor
2015-09-27 21:45:14 +02:00
Thibault Kruse
12db7f8757
Fix html anchors for links
2015-09-27 21:44:42 +02:00
Thibault Kruse
78b66f4eae
Obsolete question marks
2015-09-27 21:04:32 +02:00
Thibault Kruse
452f587a4d
bad indentation, mark missing example with ???
2015-09-27 21:04:32 +02:00
Thibault Kruse
c2266bd8e4
fix bad indentation, causes bullet list to become code block
2015-09-27 21:04:32 +02:00
Thibault Kruse
411a5749e4
typos
2015-09-27 21:04:32 +02:00
Thibault Kruse
104d2327d5
fix markdown style
2015-09-27 21:04:32 +02:00
Gabriel Dos Reis
4f76723995
Merge pull request #155 from tkruse/fix-mdstyle5
...
Fix typos and minor style problems
2015-09-27 11:55:34 -07:00
Thibault Kruse
a68ace40df
use markdown link instead of html link
2015-09-27 20:48:09 +02:00
Thibault Kruse
7c0d7830e2
typos
...
Conflicts:
CppCoreGuidelines.md
2015-09-27 20:48:09 +02:00
Thibault Kruse
90b62edaf0
Ambiguous indentation within unordered list
2015-09-27 20:47:15 +02:00
Thibault Kruse
0855efaa1d
fix mixup of indentation strategies inside same codeblocks
2015-09-27 20:46:07 +02:00
Gabriel Dos Reis
1e49b7b7a3
Merge pull request #174 from tkruse/fix-mdstyle3
...
Fix minor style issues around bullet lists and Enforcement sections
2015-09-27 11:04:26 -07:00
Gabriel Dos Reis
e4b961394c
Merge pull request #160 from certik/number_fix
...
Fix numbers in sections to be consistent with TOC
2015-09-27 10:58:42 -07:00
Thibault Kruse
c4f09f2d19
Fix / Consistent Enforcement sections
2015-09-27 19:37:29 +02:00
Thibault Kruse
7f20741f38
Fix missing / bad indent or style within bullet list
2015-09-27 19:34:00 +02:00
Thibault Kruse
d2ea0766b0
make headlines within list 1st level list (else they are prone to be part of earlier bullet
2015-09-27 19:32:34 +02:00
Gabriel Dos Reis
07ae55a037
Merge pull request #164 from tkruse/fix-mdstyle6
...
Fix mdstyle6
2015-09-27 10:02:14 -07:00
Gabriel Dos Reis
521200397e
Merge pull request #165 from tkruse/links-without-spaces
...
Fix: Consistently name anchors for links without spaces
2015-09-27 09:59:04 -07:00
Gabriel Dos Reis
12ee68f8d2
Merge pull request #171 from RicoAntonioFelix/master
...
Corrected typographical errors...
2015-09-27 09:56:52 -07:00
Thibault Kruse
b2a4132cf2
Fix / Consistent Enforcement sections
2015-09-27 18:55:53 +02:00
Thibault Kruse
c83bdc5495
fix double hash and missing Discussion
2015-09-27 18:55:52 +02:00
Thibault Kruse
8b0460d899
remove bad chars
2015-09-27 18:55:41 +02:00
Thibault Kruse
cc492c1e56
add missing ???
2015-09-27 18:55:30 +02:00
Thibault Kruse
cb4ee8e286
Fix: Consistently name anchors for links without spaces
2015-09-27 18:53:26 +02:00
Gabriel Dos Reis
f2c4d1459c
Merge pull request #162 from tkruse/fix-biblio
...
fix citations/references/bibliography.
2015-09-27 09:46:46 -07:00
Gabriel Dos Reis
ca57720e30
Merge pull request #161 from tkruse/fix-comma
...
fix blank after comma
2015-09-27 09:44:35 -07:00
Gabriel Dos Reis
3c3b204b75
Merge pull request #163 from tkruse/fix-anchors
...
Markdown fix anchors and move Header text outside anchor
2015-09-27 09:39:49 -07:00
Gabriel Dos Reis
1b944fade2
Merge pull request #166 from tryfinally/patch-1
...
typo fix: ES.5 + ES.6 retension -> retention
2015-09-27 09:36:12 -07:00
Gabriel Dos Reis
4f7b740d94
Merge pull request #168 from tkruse/fix-backtick
...
add missing backticks
2015-09-27 09:35:00 -07:00
Mikhail Maltsev
4bc790c522
Indent some code examples for correct rendering
2015-09-27 19:14:13 +03:00
RicoAntonioFelix
a2473a5c69
Corrected typographical error...
2015-09-27 11:46:30 -04:00
RicoAntonioFelix
1652fb6d56
Corrected typographical error...
2015-09-27 11:28:54 -04:00
Thibault Kruse
46e313c256
add missing backticks (breaks formatting else because of underscore in std::memory_order)
2015-09-27 13:56:22 +02:00
Muhammad Zahalqa
c9b7b8aa06
typo fix: ES.5 + ES.6 retension -> retention
...
renesion usually applied to magnetic tapes.
2015-09-27 12:46:24 +03:00
Thibault Kruse
758f3101fc
Markdown fix anchors: Move Header text outside anchor, else header becomes an ugly noop link (also for Consistency)
2015-09-27 10:00:49 +02:00
Thibault Kruse
18bd7f3c92
fix citations/references/bibliography.
2015-09-27 09:59:59 +02:00
Thibault Kruse
e558cf9919
fix blank after comma
2015-09-27 09:56:42 +02:00
Ondřej Čertík
88e881c197
Fix numbers in sections to be consistent with TOC
...
The sections R.24, R.30 - R.37 had incorrect numbers in the text. Also R.30 was
after R.31. This is now fixed.
2015-09-26 19:17:22 -06:00
Andrew Pardoe
2a50e98a19
Addressed issue #123
2015-09-26 18:13:22 -07:00
Andrew Pardoe
bb95e9839d
Addressing issue #51
2015-09-26 18:10:54 -07:00
Piotr Padlewski
b8e9216bca
Update CppCoreGuidelines.md
...
Destructors are always marked as noexcept (unless noexcept(false)) using this word here is ambigious.
2015-09-26 15:46:41 -07:00
Gabriel Dos Reis
572119b71d
Merge pull request #157 from prazek/patch-1
...
Update CppCoreGuidelines.md
2015-09-26 15:11:44 -07:00
Egor Pugin
9222fd1b1f
Fix typo.
2015-09-26 14:00:52 +03:00
Egor Pugin
240bc0ea0c
Private constructor does not allow to create derived classes.
2015-09-26 13:59:26 +03:00
Gabriel Dos Reis
bf8f1b8f49
Merge pull request #139 from trebconnell/fixtypos
...
Fix typos
2015-09-26 00:57:45 -07:00
Gabriel Dos Reis
9e25b93a18
Merge pull request #148 from RicoAntonioFelix/master
...
Minor fixes to clean up the document...
2015-09-26 00:46:47 -07:00
Piotr Padlewski
4ad6d50f86
Update CppCoreGuidelines.md
2015-09-26 00:36:35 -07:00
Evan Teran
e508837f42
Correcting minor typo
2015-09-26 00:05:15 -04:00
RicoAntonioFelix
c7a820e219
Corrected spelling error...
2015-09-25 22:20:40 -04:00
RicoAntonioFelix
eef63f5188
Capitalize for consistency...
2015-09-25 22:16:53 -04:00