StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Updated Bounds.4 as suggested in issue #267

Browse Source
This commit is contained in:
hsutter 2015-12-02 12:36:23 -08:00
parent d81adf4a8e
commit 7e81a238e0
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
CppCoreGuidelines.md
View File

@ -12692,17 +12692,23 @@ These functions all have bounds-safe overloads that take `span`. Standard types
void f()
{
array<int, 10> a, b;
memset(a.data(), 0, 10); // BAD, and contains a length error
memcmp(a.data(), b.data(), 10); // BAD, and contains a length error
memset(a.data(), 0, 10); // BAD, and contains a length error (length = 10 * sizeof(int))
memcmp(a.data(), b.data(), 10); // BAD, and contains a length error (length = 10 * sizeof(int))
}
Also, `std::array<>::fill()` or `std::fill()` or even an empty initializer are better candidate than `memset()`.
##### Example, good
void f()
{
array<int, 10> a, b;
memset(a, 0); // OK
memcmp({a, b}); // OK
array<int, 10> a, b, c{}; // c is initialized to zero
a.fill(0);
fill(b.begin(), b.end(), 0); // std::fill()
fill(b, 0); // std::fill() + Ranges TS
if ( a == b ) {
}
}
##### Example