mirror of
https://github.com/irungentoo/toxcore.git
synced 2024-03-22 13:30:51 +08:00
dd8a568141
**What are we doing?** We are moving towards stateless callbacks. This means that when registering a callback, you no longer pass a user data pointer. Instead, you pass a user data pointer to tox_iterate. This pointer is threaded through the code, passed to each callback. The callback can modify the data pointed at. An extra indirection will be needed if the pointer itself can change. **Why?** Currently, callbacks are registered with a user data pointer. This means the library has N pointers for N different callbacks. These pointers need to be managed by the client code. Managing the lifetime of the pointee can be difficult. In C++, it takes special effort to ensure that the lifetime of user data extends at least beyond the lifetime of the Tox instance. For other languages, the situation is much worse. Java and other garbage collected languages may move objects in memory, so the pointers are not stable. Tox4j goes through a lot of effort to make the Java/Scala user experience a pleasant one by keeping a global array of Tox+userdata on the C++ side, and communicating via protobufs. A Haskell FFI would have to do similarly complex tricks. Stateless callbacks ensure that a user data pointer only needs to live during a single function call. This means that the user code (or language runtime) can move the data around at will, as long as it sets the new location in the callback. **How?** We are doing this change one callback at a time. After each callback, we ensure that everything still works as expected. This means the toxcore change will require 15 Pull Requests.
52 lines
1.7 KiB
Markdown
52 lines
1.7 KiB
Markdown
This folder contains the input file (``tox.in.h``) that has to be used to generate the ``tox.h`` api with: https://github.com/iphydf/apidsl
|
|
|
|
# Minimal requirements
|
|
|
|
There are some minimal requirements to contribute to ``tox.h``:
|
|
* unix environment
|
|
* ``astyle`` ``>=2.03``
|
|
* [``apidsl``](https://github.com/iphydf/apidsl) (you can use provided service with curl instead)
|
|
|
|
## Quick way
|
|
|
|
If you want to do it quickly and you don't have time for anything other than copypasting commands, you should have ``curl`` installed.
|
|
|
|
|
|
1. Make sure that you have ``curl`` and ``>=astyle-2.03`` installed
|
|
2. Modify [``tox.in.h``](/other/apidsl/tox.in.h)
|
|
3. Run command below ↓
|
|
|
|
Command to run from ``toxcore`` directory (quick way, involves using curl):
|
|
```bash
|
|
# For tox.h:
|
|
curl -X POST --data-binary @- https://apidsl.herokuapp.com/apidsl \
|
|
< other/apidsl/tox.in.h \
|
|
| astyle --options=other/astyle/astylerc \
|
|
> toxcore/tox.h
|
|
# For toxav.h:
|
|
curl -X POST --data-binary @- https://apidsl.herokuapp.com/apidsl \
|
|
< other/apidsl/toxav.in.h \
|
|
| astyle --options=other/astyle/astylerc \
|
|
> toxav/toxav.h
|
|
```
|
|
|
|
You may want to make sure with ``git diff`` that changes made in ``tox.h`` reflect changes in ``tox.in.h``.
|
|
|
|
And you're done.
|
|
|
|
|
|
## Manually
|
|
|
|
If you prefer to have more control over what is happening, there are steps below:
|
|
|
|
1. Install [``apidsl``](https://github.com/iphydf/apidsl)
|
|
2. Install ``astyle``, version 2.03 or later.
|
|
3. Modify [``tox.in.h``](/other/apidsl/tox.in.h)
|
|
4. Use ``apidsl`` ``??``
|
|
5. Parse generated ``tox.h`` with astyle, minimal command for it would be:
|
|
```bash
|
|
astyle --options=other/astyle/astylerc toxcore/tox.h
|
|
```
|
|
|
|
**Always pass output from ``apidsl`` through astyle.**
|