iphydf
0aa2840164
Group #include directives in 3-4 groups.
...
1. Current module (if C file).
2. Headers from current library.
3. Headers from other library (e.g. toxcore includes in toxav).
4. System headers.
2016-09-13 00:32:02 +01:00
Jfreegman
27a1626084
Comment intentional switch fallthroughs
2016-09-07 17:48:01 -04:00
iphydf
ad26560516
Improve static and const correctness.
...
- Any non-externally-visible declarations should be `static`.
- Casting away the `const` qualifier from pointers-to-const is
dangerous. All but one instance of this are now correct. The one
instance where we can't keep `const` is one where toxav code actually
writes to a chunk of memory marked as `const`. This code also assumes
4 byte alignment of data packets. I don't know whether that is a valid
assumption, but it's likely unportable, and *not* obviously correct.
- Replaced empty parameter lists with `(void)` to avoid passing
parameters to it. Empty parameter lists are old style declarations for
unknown number and type of arguments.
- Commented out (as `#if DHT_HARDENING` block) the hardening code that
was never executed.
- Minor style fix: don't use `default` in enum-switches unless the number
of enumerators in the default case is very large. In this case, it was
2, so we want to list them both explicitly to be warned about missing
one if we add one in the future.
- Removed the only two function declarations from nTox.h and put them
into nTox.c. They are not used outside and nTox is not a library.
2016-09-06 11:54:37 +01:00
iphydf
a9fbdaf46b
Do not use else after return.
...
http://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code
2016-09-02 11:02:56 +01:00
iphydf
77db27331e
Sort #includes in all source files.
2016-09-01 16:35:46 +01:00
iphydf
633da98ae6
Add braces to all if statements.
2016-08-31 20:04:16 +01:00
iphydf
13ae9e9a93
Move logging to a callback.
...
This removes the global logger (which by the way was deleted when the first tox
was killed, so other toxes would then stop logging). Various bits of the code
now carry a logger or pass it around. It's a bit less transparent now, but now
there is no need to have a global logger, and clients can decide what to log and
where.
2016-08-27 01:16:14 +01:00
irungentoo
1d91699e8e
Fixed use of it after free.
2015-12-15 15:12:38 -05:00
irungentoo
6a494e2cbd
Astyle.
2015-11-03 13:42:05 -05:00
irungentoo
b23819a4d1
Fixed some memory related bugs.
2015-10-23 22:54:22 +02:00
Eniz Vukovic
d6fdf16520
New Adaptive BR algorithm, cleanups and fixes
2015-10-10 23:54:23 +02:00
mannol
c641b0fceb
Updated with upstream
2015-08-09 12:39:21 +02:00
irungentoo
553f3ea513
Fixed some strange build issues.
2015-07-20 22:21:53 -04:00
GrayHatter
ce9003d432
send_message() is too global to be non-static
2015-07-08 15:09:19 -07:00
mannol
3100042a2b
Updated with master
2015-05-22 23:22:31 +02:00
mannol
64037017cc
Fix bug
2015-05-12 22:16:00 +02:00
mannol
b2b11f0fba
Added many test and fixed various warnings
2015-04-30 00:40:30 +02:00
mannol
9bba7a0434
Done
2015-04-29 01:01:25 +02:00
mannol
1bfd93e64a
Finished refactoring
2015-04-22 02:09:37 +02:00
mannol
3fd0ee5f08
Final touchups
2015-04-21 02:31:12 +02:00
mannol
d1fd3e36a6
Updated with upstream
2015-04-17 19:19:58 +02:00
mannol
9c003c9dd2
Video works now
2015-04-08 01:00:19 +02:00
mannol
a4fae8ffd4
Started testing transfer
2015-03-22 00:22:40 +01:00
mannol
45e8807c1e
Make toxav thread safe
2015-03-01 18:45:04 +01:00
mannol
29601feb76
New msi protocol
2015-02-21 01:07:22 +01:00
mannol
efe31ec92f
Removed extra msi header and started testing
2015-02-20 00:23:38 +01:00
mannol
6e259d5fcb
Msi should be done; toxav.c need a cleanup and adjustments
2015-02-18 23:23:46 +01:00
mannol
483a6ffa32
Added 2 new headers into msi for buffer control
2015-02-17 23:34:40 +01:00
irungentoo
c6a59e64b7
Updated types in Messenger callbacks to fit with the ones in the new api.
...
Friend number changed from int32_t to uint32_t.
Some lengths changed to size_t.
2015-02-17 15:49:22 -05:00
mannol
7329f3b3d4
Fixed header protectors and cleaning up the msi
2015-02-16 23:30:20 +01:00
mannol
8c245affb1
Started adjusting msi backend to new api
2015-02-15 22:41:10 +01:00
irungentoo
ee3adf2641
Fixed memory leak.
2015-02-08 16:23:05 -05:00
irungentoo
7e7b7f6c33
Fixed memory leak.
2015-02-06 15:13:36 -05:00
mannol
1450c22d01
Current progress
2015-01-24 23:29:54 +01:00
irungentoo
8deb032b2d
Merge branch 'mutex-1' of https://github.com/mannol/toxcore
2014-11-29 16:09:24 -05:00
mannol
e62ded3a6d
More av cleanup
2014-11-29 13:42:19 +01:00
irungentoo
279c33c01a
Merge branch 'master' of https://github.com/mannol/toxcore
2014-11-24 20:24:59 -05:00
mannol
386c9748d4
av refactor
2014-11-18 00:46:46 +01:00
irungentoo_trip
9c480acecf
Fixed possible threading issues.
2014-10-25 09:01:15 -07:00
Tux3 / Mlkj / !Lev.uXFMLA
ea4320733f
Fix use-after-free of toxav's TimerHandler
...
If msi.c:timer_terminate_session frees "handler", then when msi.c:timer_poll's thread resumes, there WILL be a use after free of "handler", with a likely segfault.
This use after free causes a crash in qTox, see tux3/qTox#534
2014-10-25 12:29:10 +02:00
xor2003
1b60fbed56
Trying to fix TimerHandler *handler memory leak
2014-10-17 11:26:22 +04:00
irungentoo
c43526be9c
Fixed memory leak.
2014-09-21 14:55:23 -04:00
Tux3 / Mlkj / !Lev.uXFMLA
35da73beff
Fix exceptional leak in msi.c
2014-09-10 19:31:34 +02:00
cgar
2bb2bc4163
spelling corrections
2014-09-09 20:31:37 -04:00
irungentoo
aaaeac8f3d
Merge branch 'master' of https://github.com/mannol1/toxcore
...
Conflicts:
toxav/toxav.c
2014-08-04 13:49:53 -04:00
mannol
733c509582
Fix some toxav warnings
2014-08-04 00:15:00 +02:00
irungentoo
e1158be5a6
Fixed segfault.
2014-07-28 09:58:53 -04:00
irungentoo
ab4673e873
Merge branch 'mannol1-master'
2014-07-26 21:26:32 -04:00
mannol
54e7d29589
Make codec settings dynamic
2014-07-26 19:29:49 +02:00
notsecure
f6bca8e928
fix warnings
2014-07-23 13:26:55 -04:00
notsecure
fffe72bcaa
fix mannol
2014-07-23 13:24:51 -04:00
irungentoo
511d197e8c
Fixed warning.
2014-07-22 11:24:47 -04:00
irungentoo
6ede3e8ad4
Merge branch 'master' of https://github.com/mannol1/toxcore
2014-07-22 11:20:55 -04:00
mannol
0cf9f27b70
This should fix test failing
2014-07-21 22:11:59 +02:00
mannol
79115259a8
Fixed conflicts
2014-07-21 04:10:05 +02:00
mannol
1aeeef58b2
Improved protocol and cleaned code a bit
2014-07-21 01:10:57 +02:00
irungentoo
f0a172f198
Set some functions as static, fixed warning.
2014-07-19 22:08:05 -04:00
irungentoo
271f03a717
Call now gets terminated when other person times out.
2014-07-10 18:20:07 -04:00
irungentoo
bd4c142e38
Fixed some timer related issues.
2014-07-08 14:39:23 -04:00
irungentoo
7ce9816e40
Fixed threading bug that could cause segfaults.
2014-07-08 12:04:13 -04:00
irungentoo
9874173d71
Fixed deadlock.
2014-07-08 11:51:27 -04:00
irungentoo
95d737cb5f
Fixed segfault and other possible bugs in msi.c
...
toxav should no longer have weird behaviour when a dead call times out.
2014-07-07 23:19:56 -04:00
mannol
9af7c335e7
This might be causing problems
2014-07-05 17:36:12 +02:00
mannol
8b9d3992a4
Make rtp & codec actions thread-safe
2014-07-05 15:11:25 +02:00
irungentoo
2a70d29440
Merge branch 'master' of https://github.com/mannol1/toxcore
2014-07-03 12:13:03 -04:00
mannol
db88e7de61
Fix removed missing include
2014-07-03 17:56:55 +02:00
irungentoo
aa1194ab3e
Merge branch 'mannol1-master'
2014-07-03 11:13:11 -04:00
mannol
f8a2a865dc
Resolved conflicts when merging upstream
2014-07-03 17:08:38 +02:00
mannol
d3560a3a77
Removed redundant code and fixed toxav codec actions being called when call inactive
2014-07-03 16:58:00 +02:00
irungentoo
c4f0650ae3
Fixed const related warnings.
2014-07-02 16:04:41 -04:00
irungentoo
bd6f8a2186
Merge branch 'mannol1-master'
2014-06-28 22:29:39 -04:00
mannol
aeaf997ca5
Removed redundant encryption and asserts
2014-06-28 04:13:38 +02:00
irungentoo
0d98869f3c
Fixed calling msi_reject more than once possibly causing issues.
2014-06-26 17:52:42 -04:00
irungentoo
ac4def6cd8
Fixed possible bug if more than one ringing msi packet was sent to us.
2014-06-26 17:42:37 -04:00
irungentoo
2735b4a8de
Fixed segfault that happened because calls could be hanged up more
...
than once.
2014-06-26 17:05:13 -04:00
notsecure
97c548bc80
unrelated: got rid of some warnings
2014-06-23 15:17:28 -04:00
irungentoo
139cfa7aeb
Merge branch 'master' of https://github.com/mannol1/toxcore
2014-06-22 19:54:40 -04:00
mannol
6f46dd5afd
Removed hamful code
2014-06-23 00:22:01 +02:00
mannol
77150081ba
Merged upstream
2014-06-22 02:41:32 +02:00
mannol
5c0b6c8117
Added tolerance to VAD and lowered Jitter buffer default value
2014-06-21 19:04:00 +02:00
irungentoo
bc62510a76
Merge branch 'tux3-cppcheck-style'
2014-06-20 22:36:16 -04:00
Tux3 / Mlkj / !Lev.uXFMLA
3044bd8101
Fix CppCheck style errors
...
#if 0 the content of toxav/msi.c : int stringify_message(MSIMessage
*msg, char *dest)
This function has no effect and does not seem to be used for actively
waiting.
Fix various other style errors, reduce scope when possible, avoid
redundant writes, clarify operator priorities, etc.
2014-06-20 21:43:21 +02:00
irungentoo
db724df189
Merge branch 'av-fix' of https://github.com/nurupo/InsertProjectNameHere into nurupo-av-fix
2014-06-18 19:46:39 -04:00
irungentoo
a82cbfff6a
Preparation work to make onion packets go through TCP.
2014-06-18 19:44:49 -04:00
Maxim Biro
741ad009e0
Removed IRC references
2014-06-18 17:58:01 -04:00
Tux3 / Mlkj / !Lev.uXFMLA
78bd8b3f17
Fix possible nullptr dereferences in toxav/msi.c
2014-06-18 21:33:11 +02:00
irungentoo
750c75a47d
Astyled code.
2014-06-15 10:36:57 -04:00
irungentoo
9684339ab9
Merge branch 'mannol1-master'
2014-05-31 15:36:37 -04:00
mannol
fa203aa1ad
We gon let it burn burn burn
2014-05-31 21:02:50 +02:00
mannol
d7c1157375
Fixed byte order and removed log functions from misc_tools
2014-05-31 17:27:22 +02:00
irungentoo
ab44440f37
Merge branch 'master' of https://github.com/mannol1/ProjectTox-Core into mannol1-master
2014-05-30 19:11:28 -04:00
mannol
2ebefb85b7
Fixed potential memleaks
2014-05-31 00:29:43 +02:00
mannol
e0ed51b2dc
Apparently i forgot the most important thing...
2014-05-30 00:02:47 +02:00
mannol
08ddce44d8
Rearranged mutex actions. Now allow calling av actions from callbacks
2014-05-29 23:57:58 +02:00
mannol
20ab02cf4b
Double-free on timeout fix
2014-05-29 22:51:45 +02:00
irungentoo
82e38883a2
Merge branch 'mannol1-Multicalls' into multi-av
2014-05-25 12:27:48 -04:00
mannol
08ca08dcd9
Small fix
2014-05-24 16:40:17 +02:00
mannol
565e95301f
Tests works and some fixes
2014-05-24 16:02:01 +02:00
Maxim Biro
d9f5e01bd7
Fixed memory allocation type inconsistency
2014-05-21 23:00:48 -04:00
mannol
0620d1f064
GOGOGO
2014-05-20 00:48:53 +02:00
