Commit Graph

508 Commits (4153bf1f8c172fcb58593193238b0a928e58e61e)

Author SHA1 Message Date
Daniel Cheng ed3dd33df3 Update Google C++ styleguide
- Guidance for return values (prefer return by value, return by
  reference, then return by pointer in that order)
- Mandate curly braces around the body of a control statement,
  providing one exception for historical reasons (`if` with no `else`,
  and `if` + body fits completely in a single line or the `if` fits in
  one line and the body fits in another separate line).
2020-11-10 22:26:05 -08:00
FaresSalem 61bf629373
Update style guideline URL 2020-10-06 17:15:25 +02:00
Titus Winters 96f6a64d30
Merge pull request #577 from zetafunction/how-does-this-work-again
Update C++ styleguide
2020-09-25 13:27:34 -04:00
Daniel Cheng 3919c347aa Update C++ styleguide
- add section for inclusive language.
- move include-what-you-use to a new section.
- clarify usage of absl::optional for by-value vs by-reference params.
- document usage of `` as a code-indexing hint
- note that enclosing identifiers in `` can help code indexers.
2020-09-25 00:29:52 -07:00
Google Python team ddccc0fbeb Project import generated by Copybara.
PiperOrigin-RevId: 332885552
2020-09-23 01:40:40 +00:00
Google Python team f84020eeec Project import generated by Copybara.
PiperOrigin-RevId: 332244028
2020-09-17 17:49:28 +00:00
Michael Diamond 32916a92da
Add owners for the Java and Shell guides, and alphabetize the list. 2020-09-16 02:20:35 -07:00
Google Python team 25e977d641 Project import generated by Copybara.
PiperOrigin-RevId: 325456551
2020-08-07 17:22:26 +00:00
Google Python team 7645d63652 Project import generated by Copybara.
PiperOrigin-RevId: 325285627
2020-08-06 19:35:13 +00:00
Tony Ruscoe 5142f2245c
Add CODEOWNER for HTML/CSS style guide 2020-08-03 14:44:16 +01:00
Gregory P. Smith 10748b8973
Merge pull request #570 from allight/inclusive
Update language to comply with Android's inclusive language guidance (remove "dummy").
2020-07-28 18:40:58 -07:00
Alex Light 6c31e522d9 Update language to comply with Android's inclusive language guidance
See https://source.android.com/setup/contribute/respectful-code for
reference

cpplint.py is copied into AOSP from this github version so update it
here first.

Bug: 161896447
Test: None (comments only)
2020-07-28 18:21:22 -07:00
Gregory P. Smith 718c32728d
own Python things. 2020-07-24 14:19:55 -07:00
Jonathan B Coe 5ed7df0018
Add jbcoe as CODEOWNER for C# style guide 2020-07-23 18:37:53 +01:00
Samuel Freilich aede323223
Merge pull request #569 from google/sfreilich-codeowners
Add CODEOWNERS file
2020-07-23 13:13:09 -04:00
Samuel Freilich 4a9b9c2232
Add CODEOWNERS file
Since this repository contains style guides managed by different owners/teams, it might be convenient to have a way to allow maintainers to get notified about PRs for specific files. GitHub's code owners feature provides a way to do that:
https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners

Adding myself to this for the Lisp Style Guide.
2020-07-23 08:38:58 -04:00
Google Python team f87ee8407a Project import generated by Copybara.
PiperOrigin-RevId: 321580967
2020-07-17 22:33:14 +00:00
Google Python team 1b367e11d1 Project import generated by Copybara.
PiperOrigin-RevId: 320248352
2020-07-08 20:12:26 +00:00
Google Python team ea180f7259 Project import generated by Copybara.
PiperOrigin-RevId: 320107176
2020-07-08 02:37:59 +00:00
Google Python team 19518af929 Project import generated by Copybara.
PiperOrigin-RevId: 318489724
2020-07-08 00:10:45 +00:00
Google Python team 59def00435 Project import generated by Copybara.
PiperOrigin-RevId: 318884292
2020-07-07 23:41:53 +00:00
Gregory P. Smith 64de8439e3
Remove blacklist/whitelist from cpplint.py (#562)
Remove blacklist/whitelist from cpplint.py

Merges pull request #562 from @nealrichardson.
2020-06-19 13:33:54 -07:00
Neal Richardson 08268efb06
Remove blacklist/whitelist from cpplint.py 2020-06-19 13:27:01 -07:00
Jonathan B Coe b448694ab3
Remove more markdown that GitHub cannot handle 2020-06-04 15:05:36 +01:00
Jonathan B Coe edd630a9ee
Remove markdown not recognised by GitHub
Remove `{.good}` and `{.bad}` and replace with comments.
2020-06-04 13:30:29 +01:00
Titus Winters f3a418ef09
Merge pull request #559 from jbcoe/gh-pages
Add Google C# style guide
2020-06-04 08:11:36 -04:00
Jonathan Coe fa44b1c518 Add Google C# style guide 2020-06-03 21:09:58 +01:00
Titus Winters 8416dda837
Merge pull request #555 from zetafunction/restore-toc
[C++ styleguide] Restore table of contents
2020-05-27 08:59:46 -04:00
Daniel Cheng d8467c6dcf [C++ styleguide] Restore table of contents
This was mistakenly dropped when updating the styleguide from the
internal C++ styleguide.
2020-05-27 01:07:22 +00:00
Samuel Freilich 4258a92c2c
Merge pull request #334 from ebzzry/gh-pages
Fix typo
2020-05-26 20:46:50 -04:00
Samuel Freilich 276f2d9f1e
Merge pull request #266 from svetlyak40wt/patch-1
Fixed "full hairy example" of formatting control string in Common Lisp style guide
2020-05-26 20:38:42 -04:00
Samuel Freilich 29b6d576f4
Merge pull request #375 from ebzzry/gh-pages
Fix typos in the lisp guide
2020-05-26 20:38:03 -04:00
Titus Winters 1c41bbf09e
Merge pull request #553 from zetafunction/cpp-styleguide-update
Update C++ styleguide
2020-05-26 14:29:34 -04:00
Daniel Cheng 7a7a2f510e Update C++ styleguide
Major changes:
- discourage const references when the input parameter must outlive the
  call
- drop ban on mutable references
- allow rvalue-qualified methods in certain situations
- allow C-style cast when casting to void
- disallow postfix increment/decrement operators unless postfix
  semantics are required
- allow designated initializers in C++20-compliant form
- disallow macro-style naming for enumerator constant for new code
- disallow spaces inside parentheses for conditionals

The change itself is largely automated, with a few manual adjustments:
- manually restore the TOC placeholder
- removed trailing whitespace
2020-05-20 17:14:04 +00:00
Google Shell Style team 35fd3f0167 Project import generated by Copybara.
PiperOrigin-RevId: 312117514
2020-05-18 13:58:13 -07:00
Isaac Good 7a59e424c8
Merge pull request #549 from google/change_HEAD
Project import generated by Copybara.
2020-05-12 23:36:27 -07:00
Isaac Good d2227f2ef3 Project import generated by Copybara.
PiperOrigin-RevId: 311271037
2020-05-12 23:35:59 -07:00
Isaac Good 95d408ee11
Merge pull request #546 from google/shell_canonical
Add a canonical link to update the URL for the Shell guide
2020-04-29 22:53:04 -07:00
Isaac Good 415bb8d713 Add a canonical link to update the URL for the Shell guide 2020-04-29 22:30:48 -07:00
Isaac Good 43f20c3611
Merge pull request #544 from google/change_HEAD
Project import generated by Copybara.
2020-04-24 20:05:42 -07:00
Mike Frysinger f76ff3e96a Project import generated by Copybara.
PiperOrigin-RevId: 306352475
2020-04-24 22:05:30 -04:00
Mark Mentovai 305ac8725a
Hide “This site is open source. Improve this page.” footer
This hides the message shown at the bottom of pages served from
https://google.github.io/styleguide.
2020-02-28 11:03:30 -05:00
Mike Frysinger 250bd6a4b0
Merge pull request #534 from google/change_HEAD
Project import generated by Copybara.
2020-02-27 18:21:26 -05:00
Mike Frysinger 7c26f834f9 Project import generated by Copybara.
PiperOrigin-RevId: 297665437
2020-02-27 18:18:58 -05:00
Gregory P. Smith 056962e73a
Working out the useless else disables (#526 from dseomn copybara)
Project import generated by Copybara.
2020-02-20 16:13:54 -08:00
Google Python team 8cf92f8fb8 Project import generated by Copybara.
PiperOrigin-RevId: 296280631
2020-02-20 17:50:37 -05:00
Isaac Good bb1169c19f
Merge pull request #525 from google/change_HEAD
Project import generated by Copybara.
2020-02-19 15:28:47 -08:00
Isaac Good 546ea3979d Project import generated by Copybara.
PiperOrigin-RevId: 296049105
2020-02-19 15:26:16 -08:00
Isaac Good 2497bbd092
Merge pull request #523 from google/shell_redirect
Add shell style sheet with redirect
2020-02-18 16:30:32 -08:00
Isaac Good c6a4f62edd Add shell style sheet with redirect 2020-02-18 16:29:47 -08:00