StarMirror/sandboxed-api
1
0
Fork 0
mirror of https://github.com/google/sandboxed-api.git synced 2024-03-22 13:11:30 +08:00
Code Issues Projects Releases Wiki Activity
1,395 Commits 1 Branch 3 Tags 144 MiB
180aa03603
Commit Graph

43 Commits

Author SHA1 Message Date
Wiktor Garbacz
34f129dc51 Comms: Always use the inline buffer 
PiperOrigin-RevId: 606974170
Change-Id: I5f384bfd1b0cd5fecf493162bc40f17860b5975b
 2024-02-14 07:12:51 -08:00
Wiktor Garbacz
37a7432178 Remove deprecated comms functions 
PiperOrigin-RevId: 568510723
Change-Id: I517d739e44cb61eec8b0fd9fe6aa473e1bb8ec06
 2023-09-26 05:45:27 -07:00
Sandboxed API Team
ee7b76f592 Automated rollback of commit 4ae281b6a2. 
PiperOrigin-RevId: 567287128
Change-Id: Ia12646e9ad1ebc94f6e26ae1b893b885c0908ca9
 2023-09-21 06:17:56 -07:00
Wiktor Garbacz
4ae281b6a2 Remove deprecated comms functions 
PiperOrigin-RevId: 567239465
Change-Id: Ic890404fa8b7e9797b2399a3b346c1339fbe133a
 2023-09-21 02:31:16 -07:00
Wiktor Garbacz
1cf45be7df Refactor Comms to split out listening/connecting part 
Deprecated APIs slated for removal after migration of internal
clients.

PiperOrigin-RevId: 566598245
Change-Id: I5d7b920f3a788d4eccc6e78f239b660ba903adcc
 2023-09-19 05:14:09 -07:00
Wiktor Garbacz
3ea315858d Remove mutexes from Comms 
It was never fully thread-safe.
e.g. calling SendProtoBuf concurrently from 2 threads
could result in a data race.
Also not all users need the thread-safety thus it's better left off to be done externally by the ones that require it.

PiperOrigin-RevId: 562548941
Change-Id: Ie32dfca366be9e0c32841e55b688907f4f5f7704
 2023-09-04 07:00:57 -07:00
Jaeden Quintana
e23acfd7e7 Made slight optimizations in Sandbox2's comms. 
The optimizations are:
* Reduced the number of calls to `write` (originating from `SendTLV()`) from 3 to 1-2 (depending on size of the payload).
* Reduced the number of calls to `read()` (originating from `RecvTLV()`) from 3 to 2.

PiperOrigin-RevId: 561750509
Change-Id: I81bc092edf602e12c85ee97bd2e77b587b750d65
 2023-08-31 13:50:26 -07:00
Wiktor Garbacz
37f00991b9 Final round of IWYU fixes for Sandbox2 
PiperOrigin-RevId: 560077736
Change-Id: Id810db20b0042b8cd4f8f7a352b2cc571de51b71
 2023-08-25 06:50:29 -07:00
Wiktor Garbacz
edde724ab9 Internal change 
PiperOrigin-RevId: 559996678
Change-Id: I25a18212dc2ab15dd106cffea6132bea4a3b842d
 2023-08-24 23:55:35 -07:00
Wiktor Garbacz
127176d72f Bulk IWYU and build_cleaner fixes 
PiperOrigin-RevId: 559733768
Change-Id: Ia38f4c176e9f0abbfdb3a8f1109f482d8870eb0f
 2023-08-24 06:23:36 -07:00
Wiktor Garbacz
6986af58bb IWYU fixes 
PiperOrigin-RevId: 559444773
Change-Id: If92cdc4f978a22bfdbd61b0c9e0b43ea272bca8d
 2023-08-23 09:04:00 -07:00
Sandboxed API Team
9f2ba9d6a1 Comms constructor for non abstract sockets 
Allows to create a Comms with unix domain sockets that are not abstract. This allows to use Comms to talk across network namespaces

PiperOrigin-RevId: 518854724
Change-Id: I4fd65466bba9512f448b73bde367f38a0fbb584d
 2023-03-23 07:34:32 -07:00
Christian Blichmann
8d04efa62d contrib: Replace uses of CHECK_NOTNULL 
Abseil's standard name for this is `ABSL_DIE_IF_NULL`.

PiperOrigin-RevId: 483648443
Change-Id: I9d6826443be72b30f71c18972436fa5f9c05048a
 2022-10-25 05:50:59 -07:00
Christian Blichmann
79b6784b82 #Cleanup: Consistently use std::make_unique 
PiperOrigin-RevId: 480597371
Change-Id: I145586382ad7a7694384cc672986132376a47465
 2022-10-12 05:23:42 -07:00
Wiktor Garbacz
cb8efdc270 Sandbox2: Graciously handle mapping over Comms/Exec fds 
Try to move the affected FDs transparently to avoid conflict.

PiperOrigin-RevId: 480105375
Change-Id: I0cd093fce120505d1cd4a1d081b3c0e63bf0210a
 2022-10-10 09:39:01 -07:00
Oliver Kunz
d0f5f547cb Patch sandbox2/comms module to build for Android. 
PiperOrigin-RevId: 435318451
Change-Id: If0e40bab30f3cb68d7e79f26d2336c638742f1ac
 2022-03-17 05:27:07 -07:00
Oliver Kunz
077203fcf2 Change to proto2::MessageLite and resolve reflextion for mobile builds 
PiperOrigin-RevId: 432164927
Change-Id: I0821cf443393b0bb16a68fc5750a9633a3f27725
 2022-03-03 04:48:30 -08:00
Sandboxed API Team
59b942b256 Add a little more logging to failure cases. 
PiperOrigin-RevId: 427459159
Change-Id: I34b6027cccfc4b3903ef4deeb9c133598b6667d4
 2022-02-09 06:54:07 -08:00
Christian Blichmann
d451478e26 Change license link to HTTPS URL 
PiperOrigin-RevId: 424811734
Change-Id: If5ea692edc56ddc9c99fd478673df41c0246e9cc
 2022-01-28 01:39:09 -08:00
Sandboxed API Team
ebe4475348 Fix typo in log line that displayed decimals with 0x prefix 
PiperOrigin-RevId: 421547286
Change-Id: Ie088bb7871629db919f34f365eb9b6ab7fe65917
 2022-01-13 06:20:47 -08:00
Christian Blichmann
fd20eb0b4d Reorder error logging before Terminate() 
Calling `Terminate()` issues additional syscalls that may clobber the `errno`
value. Reordering the log statements ensures we actually log the initial error
in `read()`/`write()`.

PiperOrigin-RevId: 387576942
Change-Id: I0f9c8c6001e6dc4ca098abe02cd251029f92a737
 2021-07-29 07:12:02 -07:00
Wiktor Garbacz
78d749380b Fix a data race in Comms 
PiperOrigin-RevId: 374397564
Change-Id: I630a7587242b7b25364aa66158d86d53aff5c343
 2021-05-18 05:48:54 -07:00
Christian Blichmann
55a8373ec3 Avoid sanitizer macros use Abseil's where necessary 
Using C++17 means we can get rid of many `#ifdef`s by using `if constexpr`.
This way, we ensure that both branches compile and still retain zero runtime
overhead.

Note that open source builds of Sandboxed API do not ship with sanitizer
configurations yet. This will be added in follow-up changes.

PiperOrigin-RevId: 354932160
Change-Id: I3678dffc47ea873919f0a8c01f3a7d999fc29a5b
 2021-02-01 07:11:15 -08:00
Christian Blichmann
1459cc612e Cleanup, fix OSS Bazel build 
Bazel 4.0.0 is less lenient in handling escape sequences.

PiperOrigin-RevId: 353827443
Change-Id: I972841464449ed2262a0ef486343ae1ed444ad3c
 2021-01-26 02:29:08 -08:00
Christian Blichmann
75bbd0e1c1 Internal change 
Only externally visible changes should be a few changed includes as well as
some formatting changes.

PiperOrigin-RevId: 353226662
Change-Id: Iebf5be13774efcbd94c5d5a17b9b27e47275b229
 2021-01-22 06:01:34 -08:00
Christian Blichmann
dbaf95c724 Move utility code into sandboxed_api/util 
This change should make it less confusing where utility code comes from.
Having it in two places made sense when we were debating whether to publish
Sandbox2 separately, but not any longer.

Follow-up changes will move `sandbox2/util.h` and rename the remaining
`sandbox2/util` folder.

PiperOrigin-RevId: 351601640
Change-Id: I6256845261f610e590c25e2c59851cc51da2d778
 2021-01-13 09:25:52 -08:00
Christian Blichmann
c3ac45be3e Reimplement raw logging to avoid Abseil internals 
The defined raw logging macros should be compatible with Abseil and
we can remove our version once Abseil releases theirs.

PiperOrigin-RevId: 347354273
Change-Id: I178a89cfd2e19bcd707a06fa9dfd7b767e2b654b
 2020-12-14 03:34:02 -08:00
Wiktor Garbacz
f91f843f50 Use size_t/uintptr_t instead of uintptr_t or uint64_t where appropriate 
PiperOrigin-RevId: 332449107
Change-Id: I623c320c7f31bb73b92799dfbeb9a1e8ce0cdb3b
 2020-09-18 07:45:03 -07:00
Wiktor Garbacz
08a956a415 Use opaque void* instead of uint8_t* in Comms 
PiperOrigin-RevId: 332441641
Change-Id: I09902e98726a0bd57b47d3454ddcb6ef05021d56
 2020-09-18 06:48:57 -07:00
Wiktor Garbacz
9ffa5afba6 Remove unnecessary TLV struct 
Drive-by: Zero-copy RecvString
PiperOrigin-RevId: 332412385
Change-Id: I169ffa78f016ec2d55c1a3677ea97beed095123c
 2020-09-18 02:23:22 -07:00
Christian Blichmann
c19949eb7b Use inclusive language 
PiperOrigin-RevId: 331116936
Change-Id: I7084b24440a1c78c0d70030da900330f0b8d954f
 2020-09-11 03:14:12 -07:00
Sandboxed API Team
23da55c19a Internal BUILD refactoring 
PiperOrigin-RevId: 329720214
Change-Id: I25fbb94dea17db3bdca6438d17508fa304d9706f
 2020-09-03 07:40:33 -07:00
Wiktor Garbacz
c53f2a900f Automated rollback of commit e7a195ce42. 
PiperOrigin-RevId: 328918626
Change-Id: Iabe93ec7062ea6e750e4185e2b0b672a37111ee7
 2020-08-28 04:49:41 -07:00
Sandboxed API Team
e7a195ce42 Automated rollback of commit 82c56775ef. 
PiperOrigin-RevId: 328340042
Change-Id: Ib225f8012fb373c74e3f1b3e6201b2daca7da40b
 2020-08-25 09:01:22 -07:00
Wiktor Garbacz
82c56775ef StatusOr cleanups 
PiperOrigin-RevId: 328318284
Change-Id: I207570c0fee6797dbc8995d36ef2130b0bff28fa
 2020-08-25 06:22:05 -07:00
Sandboxed API Team
5de6b84111 Internal change 
PiperOrigin-RevId: 317068509
Change-Id: I268381ca50eabed88b189bf79ccc9313e5b7d9ae
 2020-06-18 03:19:01 -07:00
Christian Blichmann
f6c3db4c6e Replace sapi::Status with absl::Status 
PiperOrigin-RevId: 297614681
Change-Id: I89fe1357a172ed4d28df6dd84b80fee364ce1c14
 2020-02-27 09:24:12 -08:00
Christian Blichmann
441201884a Update license header with recommended best practices 
PiperOrigin-RevId: 290250533
Change-Id: Ic34b253446463cf971a055b70a242df93a598ee3
 2020-01-17 05:05:29 -08:00
Wiktor Garbacz
207b2d9a95 Remove stale comment 
PiperOrigin-RevId: 248715509
Change-Id: I7aa3f4388920e39a79ac349890de403ac3384504
 2019-05-17 07:21:31 -07:00
Wiktor Garbacz
6cbaaead8b Make StatusMatcher more flexible 
PiperOrigin-RevId: 244879203
Change-Id: I5f7994130a898e84f041b18c0b5313d7e8b32780
 2019-04-23 10:30:45 -07:00
Christian Blichmann
f04be9276f Formatting fixes and include file hygiene. 
PiperOrigin-RevId: 240346890
Change-Id: I1a9617f10a62a848b6314a6196512e016ae02643
 2019-03-26 07:54:21 -07:00
Sandboxed API Team
5aa13876a4 Formatting fixes. 
PiperOrigin-RevId: 239159980
Change-Id: Ic6185368392622bf3f4c661e37f6b9fcca0d60a6
 2019-03-19 03:41:32 -07:00
Christian Blichmann
177b969e8c
Sandboxed API OSS release. 
PiperOrigin-RevId: 238996664
Change-Id: I9646527e2be68ee0b6b371572b7aafe967102e57

Signed-off-by: Christian Blichmann <cblichmann@google.com>
 2019-03-18 19:00:48 +01:00