StarMirror/sandboxed-api
1
0
Fork 0
mirror of https://github.com/google/sandboxed-api.git synced 2024-03-22 13:11:30 +08:00
Code Issues Projects Releases Wiki Activity

Use an env var instead of -logtostderr

Browse Source 
This should make it easier to migrate away from gflags.

PiperOrigin-RevId: 444834240
Change-Id: If9717131b7a803a8459992b68933491a0945182e
This commit is contained in:
Christian Blichmann 2022-04-27 06:00:05 -07:00 committed by Copybara-Service
parent 1a856e1932
commit a420682099
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sandboxed_api/sandbox.h
View File

@ -114,12 +114,17 @@ class Sandbox {
protected: protected:
// Gets the arguments passed to the sandboxee. // Gets extra arguments to be passed to the sandboxee.
virtual void GetArgs(std::vector<std::string>* args) const { virtual void GetArgs(std::vector<std::string>* args) const {
args->push_back("--logtostderr=true"); // Do nothing by default.
} }
private: private:
// Gets the environment variables passed to the sandboxee.
virtual void GetEnvs(std::vector<std::string>* envs) const {
envs->push_back("GOOGLE_LOGTOSTDERR=1");
}
// Returns the sandbox policy. Subclasses can modify the default policy // Returns the sandbox policy. Subclasses can modify the default policy
// builder, or return a completely new policy. // builder, or return a completely new policy.
virtual std::unique_ptr<sandbox2::Policy> ModifyPolicy( virtual std::unique_ptr<sandbox2::Policy> ModifyPolicy(
@ -131,11 +136,10 @@ class Sandbox {
// - absolute: will be used as is. // - absolute: will be used as is.
virtual std::string GetLibPath() const { return ""; } virtual std::string GetLibPath() const { return ""; }
// Gets the environment variables passed to the sandboxee.
virtual void GetEnvs(std::vector<std::string>* envs) const {}
// Modifies the Executor object if needed. // Modifies the Executor object if needed.
virtual void ModifyExecutor(sandbox2::Executor* executor) {} virtual void ModifyExecutor(sandbox2::Executor* executor) {
// Do nothing by default.
}
// Provides a custom notifier for sandboxee events. May return nullptr. // Provides a custom notifier for sandboxee events. May return nullptr.
virtual std::unique_ptr<sandbox2::Notify> CreateNotifier() { return nullptr; } virtual std::unique_ptr<sandbox2::Notify> CreateNotifier() { return nullptr; }