mirror of
https://github.com/google/sandboxed-api.git
synced 2024-03-22 13:11:30 +08:00
Move log warning about non-namespaced stacktraces
PiperOrigin-RevId: 554493643 Change-Id: I27755322edcd7c0191cd125ec8ffdace18a6460c
This commit is contained in:
parent
4890c86cec
commit
48bbb06fe7
|
@ -1213,11 +1213,6 @@ absl::StatusOr<std::unique_ptr<Policy>> PolicyBuilder::TryBuild() {
|
|||
output->SetNamespace(std::make_unique<Namespace>(
|
||||
allow_unrestricted_networking_, std::move(mounts_), hostname_,
|
||||
allow_mount_propagation_));
|
||||
} else {
|
||||
// Not explicitly disabling them here as this is a technical limitation in
|
||||
// our stack trace collection functionality.
|
||||
LOG(WARNING) << "Using policy without namespaces, disabling stack traces on"
|
||||
<< " crash";
|
||||
}
|
||||
|
||||
output->collect_stacktrace_on_signal_ = collect_stacktrace_on_signal_;
|
||||
|
|
|
@ -16,13 +16,11 @@
|
|||
|
||||
#include "sandboxed_api/sandbox2/sandbox2.h"
|
||||
|
||||
#include <csignal>
|
||||
#include <memory>
|
||||
#include <string>
|
||||
#include <vector>
|
||||
|
||||
#include "absl/base/call_once.h"
|
||||
#include "absl/log/check.h"
|
||||
#include "absl/log/log.h"
|
||||
#include "absl/status/status.h"
|
||||
#include "absl/status/statusor.h"
|
||||
#include "absl/time/time.h"
|
||||
|
@ -108,6 +106,11 @@ void Sandbox2::Launch() {
|
|||
internal::SandboxPeer::spawn_fn_ = Sandbox2Peer::Spawn;
|
||||
});
|
||||
|
||||
// This is a technical limitation in our stack trace collection
|
||||
// functionality.
|
||||
LOG_IF(WARNING, !policy_->GetNamespace())
|
||||
<< "Using policy without namespaces, disabling stack traces on crash";
|
||||
|
||||
monitor_ = CreateMonitor();
|
||||
monitor_->Launch();
|
||||
}
|
||||
|
|
|
@ -23,6 +23,7 @@
|
|||
#include <utility>
|
||||
|
||||
#include "absl/base/macros.h"
|
||||
#include "absl/log/check.h"
|
||||
#include "absl/status/statusor.h"
|
||||
#include "sandboxed_api/sandbox2/comms.h"
|
||||
#include "sandboxed_api/sandbox2/executor.h"
|
||||
|
|
Loading…
Reference in New Issue
Block a user