StarMirror/sandboxed-api
1
0
Fork 0
mirror of https://github.com/google/sandboxed-api.git synced 2024-03-22 13:11:30 +08:00
Code Issues Projects Releases Wiki Activity

Explicit Comms constructor with default params

Browse Source 
This is to abstract the FD number away, so that we can change the way the FD number is chosen/communicated.

PiperOrigin-RevId: 479282707
Change-Id: Ic6726bcd0a17e97bde60804476ecbca2ffbf6525
This commit is contained in:
Wiktor Garbacz 2022-10-06 04:55:22 -07:00 committed by Copybara-Service
parent 5b61445de9
commit 3198ff06d3
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
sandboxed_api/sandbox2/comms.h
View File

@ -44,6 +44,8 @@ namespace sandbox2 {
class Comms { class Comms {
public: public:
struct DefaultConnectionTag {};
// Default tags, custom tags should be <0x80000000. // Default tags, custom tags should be <0x80000000.
static constexpr uint32_t kTagBool = 0x80000001; static constexpr uint32_t kTagBool = 0x80000001;
static constexpr uint32_t kTagInt8 = 0x80000002; static constexpr uint32_t kTagInt8 = 0x80000002;
@ -73,6 +75,8 @@ class Comms {
// sandbox2::Comms object at the server-side). // sandbox2::Comms object at the server-side).
static constexpr int kSandbox2ClientCommsFD = 1023; static constexpr int kSandbox2ClientCommsFD = 1023;
static constexpr DefaultConnectionTag kDefaultConnection = {};
// This object will have to be connected later on. // This object will have to be connected later on.
explicit Comms(const std::string& socket_name); explicit Comms(const std::string& socket_name);
@ -83,6 +87,9 @@ class Comms {
// Takes ownership over fd, which will be closed on object's destruction. // Takes ownership over fd, which will be closed on object's destruction.
explicit Comms(int fd); explicit Comms(int fd);
// Instantiates a pre-connected object using the default connection params.
explicit Comms(DefaultConnectionTag) : Comms(kSandbox2ClientCommsFD) {}
~Comms(); ~Comms();
// Binds to an address and make it listen to connections. // Binds to an address and make it listen to connections.