StarMirror/sandboxed-api
1
0
Fork 0
mirror of https://github.com/google/sandboxed-api.git synced 2024-03-22 13:11:30 +08:00
Code Issues Projects Releases Wiki Activity

added useful logs in unit tests

Browse Source
This commit is contained in:
Andrei Medar 2020-08-13 15:58:47 +00:00
parent 11ea152d3c
commit 18f58da954
2 changed files with 26 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
oss-internship-2020/sapi_lodepng/README.md
View File

@ -11,5 +11,5 @@ TODO
- check if security policy can be stricter - check if security policy can be stricter
- ~~use addDirectoryAt instead of addDirectory~~ - ~~use addDirectoryAt instead of addDirectory~~
- ~~modify tests assertions~~ - ~~modify tests assertions~~
- add useful prints to unit tests - ``add useful prints to unit tests``

45
oss-internship-2020/sapi_lodepng/main_unit_test.cc
View File

@ -38,14 +38,14 @@ std::string images_path = std::filesystem::current_path().string();
TEST(initSandbox, basic) { TEST(initSandbox, basic) {
SapiLodepngSandbox sandbox(images_path); SapiLodepngSandbox sandbox(images_path);
ASSERT_THAT(sandbox.Init(), IsOk()); ASSERT_THAT(sandbox.Init(), IsOk()) << "Error during sandbox init";
} }
// generate an image, encode it, decode it and compare the pixels with the // generate an image, encode it, decode it and compare the pixels with the
// initial values // initial values
TEST(generate_image, encode_decode_compare_one_step) { TEST(generate_image, encode_decode_compare_one_step) {
SapiLodepngSandbox sandbox(images_path); SapiLodepngSandbox sandbox(images_path);
ASSERT_THAT(sandbox.Init(), IsOk()); ASSERT_THAT(sandbox.Init(), IsOk()) << "Error during sandbox init";
LodepngApi api(&sandbox); LodepngApi api(&sandbox);
// generate the values // generate the values
@ -74,7 +74,7 @@ TEST(generate_image, encode_decode_compare_one_step) {
sapi_image.PtrBefore(), sapi_width.GetValue(), sapi_image.PtrBefore(), sapi_width.GetValue(),
sapi_height.GetValue())); sapi_height.GetValue()));
ASSERT_THAT(result, Eq(0)); ASSERT_THAT(result, Eq(0)) << "Result from encode32_file not 0";
// after the image has been encoded, decode it to check that the // after the image has been encoded, decode it to check that the
// pixel values are the same // pixel values are the same
@ -86,10 +86,10 @@ TEST(generate_image, encode_decode_compare_one_step) {
sapi_image_ptr.PtrBoth(), sapi_width2.PtrBoth(), sapi_image_ptr.PtrBoth(), sapi_width2.PtrBoth(),
sapi_height2.PtrBoth(), sapi_filename.PtrBefore())); sapi_height2.PtrBoth(), sapi_filename.PtrBefore()));
ASSERT_THAT(result, Eq(0)); ASSERT_THAT(result, Eq(0)) << "Result from decode32_file not 0";
EXPECT_THAT(sapi_width2.GetValue(), Eq(width)); EXPECT_THAT(sapi_width2.GetValue(), Eq(width)) << "Widths differ";
EXPECT_THAT(sapi_height2.GetValue(), Eq(height)); EXPECT_THAT(sapi_height2.GetValue(), Eq(height)) << "Heights differ";
// the pixels have been allocated inside the sandboxed process // the pixels have been allocated inside the sandboxed process
// memory, so we need to transfer them to this process. // memory, so we need to transfer them to this process.
@ -106,7 +106,8 @@ TEST(generate_image, encode_decode_compare_one_step) {
img_len(sapi_width2.GetValue(), sapi_height2.GetValue())); img_len(sapi_width2.GetValue(), sapi_height2.GetValue()));
sapi_pixels.SetRemote(sapi_remote_out_ptr.GetValue()); sapi_pixels.SetRemote(sapi_remote_out_ptr.GetValue());
ASSERT_THAT(sandbox.TransferFromSandboxee(&sapi_pixels), IsOk()); ASSERT_THAT(sandbox.TransferFromSandboxee(&sapi_pixels), IsOk())
<< "Error during transfer from sandboxee";
// after the memory has been transferred, we can access it // after the memory has been transferred, we can access it
// using the GetData function // using the GetData function
@ -114,7 +115,7 @@ TEST(generate_image, encode_decode_compare_one_step) {
// now, we can compare the values // now, we can compare the values
for (size_t i = 0; i < img_len(width, height); ++i) { for (size_t i = 0; i < img_len(width, height); ++i) {
EXPECT_THAT(pixels_ptr[i], Eq(image[i])); EXPECT_THAT(pixels_ptr[i], Eq(image[i])) << "Pixels values differ";
} }
} }
@ -123,7 +124,7 @@ TEST(generate_image, encode_decode_compare_one_step) {
// memory and then getting the actual pixel values. // memory and then getting the actual pixel values.
TEST(generate_image, encode_decode_compare_two_steps) { TEST(generate_image, encode_decode_compare_two_steps) {
SapiLodepngSandbox sandbox(images_path); SapiLodepngSandbox sandbox(images_path);
ASSERT_THAT(sandbox.Init(), IsOk()); ASSERT_THAT(sandbox.Init(), IsOk()) << "Error during sandbox init";
LodepngApi api(&sandbox); LodepngApi api(&sandbox);
// generate the values // generate the values
@ -156,7 +157,7 @@ TEST(generate_image, encode_decode_compare_two_steps) {
sapi_image.PtrBefore(), sapi_width.GetValue(), sapi_image.PtrBefore(), sapi_width.GetValue(),
sapi_height.GetValue())); sapi_height.GetValue()));
ASSERT_THAT(result, Eq(0)); ASSERT_THAT(result, Eq(0)) << "Result from encode32 call not 0";
// the new array (pointed to by sapi_png_ptr) is allocated // the new array (pointed to by sapi_png_ptr) is allocated
// inside the sandboxed process so we need to transfer it to this // inside the sandboxed process so we need to transfer it to this
@ -166,7 +167,8 @@ TEST(generate_image, encode_decode_compare_two_steps) {
sapi_png_array.SetRemote(sapi_remote_out_ptr.GetValue()); sapi_png_array.SetRemote(sapi_remote_out_ptr.GetValue());
ASSERT_THAT(sandbox.TransferFromSandboxee(&sapi_png_array), IsOk()); ASSERT_THAT(sandbox.TransferFromSandboxee(&sapi_png_array), IsOk())
<< "Error during transfer from sandboxee";
// write the image into the file (from memory) // write the image into the file (from memory)
SAPI_ASSERT_OK_AND_ASSIGN( SAPI_ASSERT_OK_AND_ASSIGN(
@ -174,7 +176,7 @@ TEST(generate_image, encode_decode_compare_two_steps) {
api.lodepng_save_file(sapi_png_array.PtrBefore(), sapi_pngsize.GetValue(), api.lodepng_save_file(sapi_png_array.PtrBefore(), sapi_pngsize.GetValue(),
sapi_filename.PtrBefore())); sapi_filename.PtrBefore()));
ASSERT_THAT(result, Eq(0)); ASSERT_THAT(result, Eq(0)) << "Result from save_file call not 0";
// now, decode the image using the 2 steps in order to compare the values // now, decode the image using the 2 steps in order to compare the values
sapi::v::UInt sapi_width2, sapi_height2; sapi::v::UInt sapi_width2, sapi_height2;
@ -187,9 +189,10 @@ TEST(generate_image, encode_decode_compare_two_steps) {
api.lodepng_load_file(sapi_png_ptr2.PtrBoth(), sapi_pngsize2.PtrBoth(), api.lodepng_load_file(sapi_png_ptr2.PtrBoth(), sapi_pngsize2.PtrBoth(),
sapi_filename.PtrBefore())); sapi_filename.PtrBefore()));
ASSERT_THAT(result, Eq(0)); ASSERT_THAT(result, Eq(0)) << "Result from load_file call not 0";
EXPECT_THAT(sapi_pngsize.GetValue(), Eq(sapi_pngsize2.GetValue())); EXPECT_THAT(sapi_pngsize.GetValue(), Eq(sapi_pngsize2.GetValue()))
<< "Png sizes differ";
// transfer the png array // transfer the png array
sapi::v::RemotePtr sapi_remote_out_ptr2(sapi_png_ptr2.GetValue()); sapi::v::RemotePtr sapi_remote_out_ptr2(sapi_png_ptr2.GetValue());
@ -197,7 +200,8 @@ TEST(generate_image, encode_decode_compare_two_steps) {
sapi_png_array2.SetRemote(sapi_remote_out_ptr2.GetValue()); sapi_png_array2.SetRemote(sapi_remote_out_ptr2.GetValue());
ASSERT_THAT(sandbox.TransferFromSandboxee(&sapi_png_array2), IsOk()); ASSERT_THAT(sandbox.TransferFromSandboxee(&sapi_png_array2), IsOk())
<< "Error during transfer from sandboxee";
// after the file is loaded, decode it so we have access to the values // after the file is loaded, decode it so we have access to the values
// directly // directly
@ -208,10 +212,10 @@ TEST(generate_image, encode_decode_compare_two_steps) {
sapi_height2.PtrBoth(), sapi_png_array2.PtrBefore(), sapi_height2.PtrBoth(), sapi_png_array2.PtrBefore(),
sapi_pngsize2.GetValue())); sapi_pngsize2.GetValue()));
ASSERT_THAT(result, Eq(0)); ASSERT_THAT(result, Eq(0)) << "Result from decode32 call not 0";
EXPECT_THAT(sapi_width2.GetValue(), Eq(width)); EXPECT_THAT(sapi_width2.GetValue(), Eq(width)) << "Widths differ";
EXPECT_THAT(sapi_height2.GetValue(), Eq(height)); EXPECT_THAT(sapi_height2.GetValue(), Eq(height)) << "Heights differ";
// transfer the pixels so they can be used // transfer the pixels so they can be used
sapi::v::RemotePtr sapi_remote_out_ptr3(sapi_png_ptr3.GetValue()); sapi::v::RemotePtr sapi_remote_out_ptr3(sapi_png_ptr3.GetValue());
@ -220,13 +224,14 @@ TEST(generate_image, encode_decode_compare_two_steps) {
sapi_pixels.SetRemote(sapi_remote_out_ptr3.GetValue()); sapi_pixels.SetRemote(sapi_remote_out_ptr3.GetValue());
ASSERT_THAT(sandbox.TransferFromSandboxee(&sapi_pixels), IsOk()); ASSERT_THAT(sandbox.TransferFromSandboxee(&sapi_pixels), IsOk())
<< "Error during transfer from sandboxee";
unsigned char *pixels_ptr = sapi_pixels.GetData(); unsigned char *pixels_ptr = sapi_pixels.GetData();
// compare values // compare values
for (size_t i = 0; i < img_len(width, height); ++i) { for (size_t i = 0; i < img_len(width, height); ++i) {
EXPECT_THAT(pixels_ptr[i], Eq(image[i])); EXPECT_THAT(pixels_ptr[i], Eq(image[i])) << "Pixel values differ";
} }
} }