Anthony Bilinski
47a05c7592
feat(core): Add error parsing for Toxav_Err_Call
2022-03-18 22:20:13 -07:00
Anthony Bilinski
47a20f6061
feat(core): Add error parsing for Toxav_Err_Call_Control
2022-03-18 22:20:12 -07:00
Anthony Bilinski
6c9c380915
feat(core): Add error parsing for Tox_Err_File_Send_Chunk
2022-03-18 22:20:12 -07:00
Anthony Bilinski
978bcde572
feat(core): Add error parsing for Tox_Err_File_Control
2022-03-18 22:20:12 -07:00
Anthony Bilinski
040beae56a
feat(core): Add error parsing for Tox_Err_File_Get
2022-03-18 22:20:12 -07:00
Anthony Bilinski
aff5663351
feat(core): Extend and deduplicate Tox_Err_File_Send error parsing
2022-03-18 22:20:12 -07:00
Anthony Bilinski
350fa9b462
refactor: Don't handle default switch case of error enums
...
Allows for a compile error if enum cases are unhandled. Stil handles a
cast value passed in if the switch matches none.
2022-03-18 22:20:12 -07:00
Anthony Bilinski
b09796a54c
refactor(core): Move toxcore error parsing out of core.pp to utility
...
To be used by coreav and corefile as well.
2022-03-18 22:20:11 -07:00
Anthony Bilinski
ad6b510417
fix(macos): Represent autorun state in UI persistently
...
Check file setting rather than reporting a global value that isn't persisted
across client restart.
2022-03-18 17:02:06 -07:00
Anthony Bilinski
009369118f
fix(macos): Fix macOS autorun not loading at start
...
macOS system.log was reporting "Unknown key for integer: RunAtLoad" and
not loading qTox at start despite
~/Library/LaunchAgents/chat.tox.qtox.autorun.plist being present.
Changing the type from an int to a bool causes it to load successfully
on boot.
Fix #2814
2022-03-18 17:02:04 -07:00
Anthony Bilinski
4c969a9277
chore(CI): Move QrEncode build from autotools to cmake
...
Autotools version failed to configure on macOS, and QrEncode's README says "If
the configure script does not work well, try to use CMake." Cmake works for
both macOS and Windows.
2022-03-18 00:51:49 -07:00
Anthony Bilinski
6c85492f17
chore(CI): Add macOS VPX patch to allow setting mmacosx-version-min
...
VPX overrides the user setting by default, preventing a newer macOS from
building for an older macOS.
2022-03-18 00:51:49 -07:00
Anthony Bilinski
05faddf526
chore(CI): Rename Windows vpx.patch to vpx-windows.patch
...
Avoid conflict with different VPX patch needed for macos
2022-03-18 00:51:49 -07:00
Anthony Bilinski
502ccb1e1b
chore(CI): Add macOS platform detection for build scripts
2022-03-18 00:51:49 -07:00
Anthony Bilinski
90210a9826
chore(CI): Backup NSIS ShellExecAsUser plugin
...
As was done in the previous ANSI version prior to
beb38fa33b
For reasons covered here:
beb38fa33b (r68688468)
2022-03-16 21:36:12 -07:00
Anthony Bilinski
5de5403964
fix(corefile): Close files of broken file transfers
...
Fix #6500
2022-03-16 03:18:17 -07:00
Anthony Bilinski
42b4385c35
chore(CI): Use platform detection script in Windows dep build scripts
...
Allows future macOS configuration in each individual build script to not all be
duplicated. Also deduplicates current Windows arg checking and config setting.
2022-03-15 22:39:07 -07:00
Anthony Bilinski
5ac0dee3a8
chore(CI): Add script for handling platform compile args
2022-03-15 22:39:07 -07:00
Anthony Bilinski
c828a16b7b
feat(CI): Run clang-tidy check in CI
2022-03-15 08:19:53 -07:00
Anthony Bilinski
73aa1f3f48
refactor: Comply with Clang's Wunused-parameter
2022-03-15 08:19:53 -07:00
Anthony Bilinski
3d7a0d249d
refactor: Comply with Clang's Wunused-const-variable
2022-03-15 08:19:53 -07:00
Anthony Bilinski
acc46370ca
refactor: Comply with Clang's Wunused-private-field
2022-03-15 08:19:53 -07:00
Anthony Bilinski
6e7ca76911
refactor: Comply with Clang's Wdouble-promotion
2022-03-15 08:19:53 -07:00
Anthony Bilinski
0e8582c88e
refactor: Comply with Clang's Wmismatched-tags
...
Fix #6042
2022-03-15 08:19:53 -07:00
Anthony Bilinski
877ef4ae5b
feat(style): Add clang-tidy config
...
Starting with just two rules for arg naming
2022-03-15 08:19:53 -07:00
Anthony Bilinski
cabcf4111f
refactor(style): Match declaration and definition argument names
...
Conform with readability-named-parameter and
readability-inconsistent-declaration-parameter-name
2022-03-15 08:19:53 -07:00
Anthony Bilinski
47d52f9977
chore(CI): Fix gitstats cloning by cloning with https
...
To resolve the error:
The unauthenticated git protocol on port 9418 is no longer supported.
2022-03-15 07:07:52 -07:00
Anthony Bilinski
b894531cdb
fix(tests): Mock Settings for SmileyPack test
...
Settings upgrades global settings on construction, which can cause the
SmileyPack test to be inconsistent based on file system state.
Fix #6530
2022-03-15 01:32:16 -07:00
Anthony Bilinski
e5f16d812e
chore(macOS): Remove support for old AvFoundation
...
We no longer need conditional support for the older API since our minimum supported version is now 10.15.
2022-03-14 14:48:41 -07:00
Anthony Bilinski
16aeb5f572
refactor(model): Rename Contact and ContactId to Chat and ChatId
...
* Referring to groups generically as contacts is confusing.
* Friends are referred to as contacts in many places either as more
neutral wording, or to avoid using the keyword friend as a variable
name. Calling Contact Chat allows contact to be used for Friends.
2022-03-14 12:44:37 -07:00
Anthony Bilinski
cf5be40511
refactor(Style): Move fonts storage from array to std::map
...
Strongly enforces ordering instead of being based off comments, and logically
represents the relation better.
2022-03-14 10:43:26 -07:00
Anthony Bilinski
b9c4b0075c
refactor(Style): Move Style enums to enum class
2022-03-13 16:00:48 -07:00
Anthony Bilinski
0c967725df
refactor: Remove Settings singleton
...
* Make main.cpp's toxSave free functions into a ToxSave class so that it can be
given Settings on construction.
* Add void* to IPC callbacks so that classes can get back to themselves.
2022-03-13 16:00:48 -07:00
Anthony Bilinski
61b3cb528a
refactor: Remove CameraSource singleton
...
Grossly expose it publicly from Nexus for the time being since Profile is
sometimes constructed from main, while Nexus is also a singleton. So
CameraSource can't be constructed in main and be passed in to Nexus on
construction. This should be temporary, until Nexus's singleton is
removed as well.
2022-03-13 16:00:48 -07:00
Anthony Bilinski
9bf17acca6
chore(CI): Handle build scripts called with relative paths with spaces
...
foo=dirname "$0" only works if the script is called with an absolute path and
that path contains no spaces. Add quotes everywhere to contain spaces in
directory names or file names, and add realpath to get the absolute path
regardless of call path.
Not necessarily needed, but like in e405868037
it can avoid some annoying issues when e.g. that script was called with a
relative path in CI.
2022-03-13 06:20:44 -07:00
Anthony Bilinski
3c7ee98bc1
chore(CI): Set bash flags at start of scripts
2022-03-13 06:20:44 -07:00
Anthony Bilinski
69514319fd
chore(CI): Rename Windows build scripts to be used commonly by macOS
2022-03-13 06:20:25 -07:00
Anthony Bilinski
b82580c814
fix(chat): Undo removing of chat message insertion
...
Inadvertently removed in 919c6c9fe7
2022-03-13 06:05:25 -07:00
Anthony Bilinski
dd9524085f
fix(settings): Heal invalid ToxPk saved to Personal Settings
...
Fix #6506
2022-03-13 05:28:44 -07:00
Anthony Bilinski
1206da2b05
refactor(ToxPk): Don't define model's ToxPk, ToxId, GroupId from tox.h
...
Since they exist in saved settings and the chat database, they are their own
size. assert that it matches tox.h's size in Core constructor, though.
2022-03-13 05:28:41 -07:00
Anthony Bilinski
813643adbf
fix(chat): Stop spellcheck from leaking messages to logs
2022-03-13 04:46:46 -07:00
Anthony Bilinski
ba17b5130c
Revert "chore(CI): Disable online tests in all but one CI job"
...
This reverts commit fd2997c2db
.
Core tests are no longer online, so no longer are flaky nor tie up many
minutes of test runner time. So re-enable for all jobs.
2022-03-13 03:21:27 -07:00
Anthony Bilinski
7d773930c1
feat(tests): Merge core and core_online tests
...
Re-use tox instances between tests to avoid re-bootstrapping or re-requesting
friendship, saving time. Test case order within core_test is now important.
2022-03-13 03:21:09 -07:00
Anthony Bilinski
5f870c28e5
feat(test): Bootstrap core_test off second local tox instance
...
Allows core_test to be run without internet, and makes it much faster
and less flaky in CI.
Also split socks5 and http tests.
2022-03-13 03:21:05 -07:00
Anthony Bilinski
6f3fb30f24
feat(test): Add mock bootstrap list generator
2022-03-13 01:50:47 -08:00
Anthony Bilinski
7395c1cb3f
refactor(model): Fix case of IBootstrapListGenerator::getBootstrapNodes
2022-03-13 00:42:33 -08:00
Anthony Bilinski
faa72d567e
fix(core): Correct getSelfDhtId's toxcore API
2022-03-13 00:42:07 -08:00
Anthony Bilinski
47328cc6bf
refactor: Remove SmileyPack singleton
2022-03-12 16:28:06 -08:00
Anthony Bilinski
7d40bcf43d
refactor: Remove DocumentCache singleton
...
Leaf of our evil singleton tree.
2022-03-11 11:26:14 -08:00
Anthony Bilinski
0afc11fafc
chore(build): Migrate existing warning handling to new warnings project
2022-03-11 10:22:13 -08:00