StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity
1,917 Commits 14 Branches 4 Tags 216 MiB
b5412f5922
Commit Graph

1590 Commits

Author SHA1 Message Date
Joshua T. Fisher
1d54448aeb Editing P.9: "Don't waste time or space" Example Text (#1439) 
* Initial rewrite

* Fixed a couple of inaccuracies and minor grammar mistakes

Thanks to twitter user @lunasorcery for these changes!

* Added toLower to dictionary
 2019-06-20 11:12:29 -07:00
shaneasd
d456ccf274 Fix comment in C.128 example (#1449) 2019-06-18 10:22:50 -04:00
beinhaerter
4b414458cf I.13: grammar and hint to std::string_view (#1443) 
- "a C-style, zero-terminated strings" is wrong, it must be either "C-style, zero-terminated strings" or "a C-style, zero-terminated string"
- added hint to `std::string_view
 2019-06-13 08:38:55 -04:00
beinhaerter
040ea419cc I.10: structured bindings is now available (#1442) 
- C++17 is already available
- synchronize with F.21:
  - put quotes around "structured bindings"
  - remove link to proposal
 2019-06-13 08:38:09 -04:00
alexcamposruiz
2d40c3ac2c Add example code for T.48 (#1422) 
* Add example code for T.48

* Fix whitespace in end of line

* Use better syntax for concept constraint

* Revert "Use better syntax for concept constraint"

This reverts commit f071920d7f.
 2019-05-30 11:21:43 -07:00
jkorinth
4c35d4c022 Fix C.120 good example (#1426) 
C.120 has a good example which violates C.128 by specifying both virtual and override for methods.
closes #1425
 2019-05-28 11:11:33 -04:00
Louis Cloete
6c92f514f4 Remove extra asterisk in example in C.60 (#1430) 
closes #1429
 2019-05-28 09:01:27 -04:00
Louis Cloete
29dedc49af Inserts a missing backtick in C.49 (#1428) 
Below heading "Example, better still" there was a missing backtick after gsl::string_span
 2019-05-20 08:14:08 +01:00
Sergey Zubkov
dbc554cbc5 update date 2019-05-02 14:53:28 -04:00
Herb Sutter
9948bdc157
Update ES.23 to allow = initialiization (#1416) 
* Update ES.23 to allow = initialiization

* Silencing Travis

* Changed title back to original, it's fine

* Add note about explicit
 2019-05-02 11:47:00 -07:00
Dave Smith
a9242c8dae Improve A.all (#1413) 
* reword the A.1 rule title
* add candidate content for the A.1 rule
* make minor improvements to the A.2 note
* simplify wording in the first bullet of A.4's Reason
 2019-05-02 11:18:07 -07:00
hsutter
fc27313b75 Adopting fixes from PR 1411 2019-05-02 11:12:08 -07:00
hsutter
959b556aac Restored cached_computation description 2019-05-02 11:06:03 -07:00
Dave Smith
1a9a35d2d9 Tighten up CP.1 (#1405) 
* Tighten up CP.1

* balanced verb usage in first sentence
* changed third sentence to "libraries not using threads", as I
  believe this was the original author's intended meaning.
* clarified "this" in fourth sentence
* cut wordiness of "thanks to the magic of cut-and-paste", as it
  added no value
* changed "Example" heading to "Example, bad"
* added "bad:" comment above statics in the example
* added an explanatory sentence immediately after the example
* changed "works perfectly in a single-threaded" after example to
  "works as intended in a single threaded".  Also balanced the
  structure of the two comma separated phrases inside this sentence.
* strengthened parenthetical explanation in second bullet of "could
  be made safe" section

* Correct grammar mistake pointed out by @cubbimew

* Remove specific cache details in CP.1 per @hsutter's request
 2019-05-02 11:05:35 -07:00
hsutter
41b5bac211 Revert "Fixed typo in ES.22" 
This reverts commit 976ee508a4.
 2019-04-27 07:47:59 -07:00
hsutter
976ee508a4 Fixed typo in ES.22 2019-04-27 07:45:45 -07:00
Florian Thake
385199cc90 Added bad and good example to NR.5 in CppCoreGuidelines.md (#1401) 
* Added bad and goof example to NR.5 in CppCoreGuidelines.md

Added bad and good example to NR.5 Don’t: Don’t do substantive work in a constructor; instead use two-phase initialization.
I think it could be suitable.

* adjusted coding style

* removed extra space

* removed one more whitespace

* removed spaces before note to make it a blank line

* made Cleanup method from bad example return void

* some changes after review comments

- removed try catch
- removed defaulted dtor
- changed int to size_t, removed check for even.
- Expects() for invariant check
- typo

* spell check adjustment

* moved comment up for met the line length

* changed variablename in good example

... they were named same after removed the try catch scope

* changed afer comments

- changed check_size() function to a static member function 
- fixed comment mentioning the default contract violation behavior.
 2019-04-25 11:21:50 -07:00
Kyle
0f57785d2b C.129 Small fixes (#1406) 
* C.129 Fix typos and conjugation

I noticed some grammatical errors in this section and fixed them to match my interpretation of the author's intention.

* One more fix

Pluralization
 2019-04-15 14:06:50 -04:00
Aleksander
6a6321fcbf ES.49: added lvalue in std::forward description (#1404) 2019-04-15 14:05:36 -04:00
Aleksander
9f5a67fda7 ES.42: index in an example was not declared (#1403) 2019-04-15 13:22:20 -04:00
Paul Romano
1f6042f66c Fix typo in some of the NL rules, "thus rule" -> "this rule" (#1402) 2019-04-10 10:45:57 -04:00
hsutter
35cfe0c984 Closes #1397 2019-04-04 11:28:59 -07:00
hsutter
9275e7da09 Fixed typo in previous commit, closes #1395 2019-04-04 11:27:40 -07:00
hsutter
85e6aef5d6 Closes #1395 2019-04-04 11:26:37 -07:00
hsutter
274d65818d Closes #1392 2019-04-04 11:16:34 -07:00
hsutter
4b7cd81ad0 Closes #1392 2019-04-04 11:16:05 -07:00
Taewon Park
7ddf721500 Fix wrong <a> tags in Pro.bounds and Pro.lifetime (#1399) 
Replaced "href" attribute to "name" of <a> tags in Pro.bounds and Pro.lifetime sections, to make the anchors to them work correctly
 2019-04-02 10:11:29 -04:00
Sergey Zubkov
73f37745b1 fix typo 2019-04-01 11:54:39 -04:00
Saad
08659db9e1 MD typo fix (#1396) 2019-03-25 10:06:33 +00:00
hsutter
c072184052 Closes #1370 2019-03-21 11:36:55 -07:00
hsutter
142fc6ad33 Closes #1367 2019-03-21 11:18:21 -07:00
Amir Livneh
e3da8a1fd9 Add example for E.28 (#1385) 2019-03-21 11:06:02 -07:00
Dave Smith
c2a5785d7e Remove elements that don't add value in ES.84 (#1390) 2019-03-21 11:04:49 -07:00
Dave Smith
8301421762 Tighten up the intro to CP (#1391) 2019-03-21 11:03:38 -07:00
Amir Livneh
a8c7b7c5a8 Fix grammar in T.41 (#1389) 2019-03-12 10:48:32 -04:00
Amir Livneh
bd3f3d5d25 Fix grammar in Con.2 (#1388) 2019-03-12 10:47:57 -04:00
Amir Livneh
422a190f57 Fix typo in T.22 (#1387) 2019-03-12 10:47:22 -04:00
Amir Livneh
aa25be7d6b Make sentence in T.41 complete (#1386) 2019-03-12 10:46:43 -04:00
Amir Livneh
ba2dbc5edf Fix calls to malloc() with 2 arguments (#1377) 
* Fix calls to malloc() with 2 arguments
 2019-03-09 19:17:33 -05:00
Amir Livneh
f67e91d295 Use memoizes instead of mnemonizes in the context of caching (#1383) 
* Use `memoizes` instead of `mnemonizes` in the context of caching

While apparently, 'mnemonizes' is a word, I don't think it's the best choice here.

* Update isocpp.dic
 2019-03-09 19:15:27 -05:00
Amir Livneh
c1beff1941 Fix grammar in T.11 (#1380) 2019-03-09 17:37:00 -05:00
Amir Livneh
43f4390185 Fix grammar in T.13 (#1379) 2019-03-09 17:36:35 -05:00
Amir Livneh
8ff099d2d2 Fix grammar (#1378) 2019-03-09 17:35:49 -05:00
Amir Livneh
7d092e37aa Remove extra parenthesis (#1375) 2019-03-09 17:32:40 -05:00
Amir Livneh
7511b40996 Use 'an' instead of 'a' where appropriate (#1374) 2019-03-09 17:30:53 -05:00
Amir Livneh
571ab494a8 Use consistent tense and remove repetition in E introduction (#1372) 2019-03-08 09:16:56 -05:00
Amir Livneh
e93462e1d7 Fix capitalization in CP.200 (#1373) 2019-03-08 09:15:50 -05:00
Amir Livneh
6d94ce30dd Fix grammar in E.4 note (#1371) 2019-03-08 09:14:51 -05:00
Sergey Zubkov
1c0ddef508 fix travis CI, update date 2019-03-07 15:14:44 -05:00
hsutter
5d2c09aa48 Closes #1355 2019-03-07 12:00:41 -08:00
hsutter
fcba85fb48 Closes #1332 2019-03-07 11:51:28 -08:00
hsutter
5276dc55c8 Closes #1330 2019-03-07 11:49:28 -08:00
Martín Knoblauch Revuelta
4d0a2a2aef Fix union example taken from TC++PL4 (#1357) 
The code fails to set the type when a number value is assigned to a (formerly) string value. As a result, later access to the value or destruction of the object cause undefined behaviour (access to arbitrary memory address and/or heap corruption). The string field of the union is accessed, but its the number what is there…

It's also wrong in the book!

The fact that this bug has survived so long pretty much proves the point that code with unions is hard to get right ;-)

Oh, by the way, in order to test this, I had to add a constructor. Though, I'm not including it in the change. I suppose this just stuff we take for granted in the "// …" comment.
 2019-03-07 11:41:53 -08:00
Amir Livneh
f5689ada23 Remove unused parameter in ES.62 example (#1353) 2019-03-07 11:40:39 -08:00
hsutter
48cdedb31e Changed to sentence 2019-03-07 11:39:25 -08:00
Amir Livneh
7674f9c649 Fix capitalization in ES.56 note (#1349) 
* Fix capitalization in ES.56 note

* Make proper sentence
 2019-03-07 11:37:43 -08:00
Amir Livneh
9a703fa02b Don't reuse variable name in ES.50 example (#1348) 
Reusing the name 'i' violates ES.12 and distracts from the point of the example.
 2019-03-07 11:36:49 -08:00
Amir Livneh
8a1780e841 Fix punctuation in CP.1 (#1366) 2019-03-04 08:49:26 -05:00
Amir Livneh
a2f5f77b1c Fix spacing in CP.4 example (#1365) 2019-03-04 08:49:11 -05:00
Amir Livneh
002d8b8301 Fix typos (#1364) 2019-03-04 08:48:51 -05:00
Amir Livneh
b933b03329 Fix punctuation in ES.77 (#1363) 2019-03-02 15:21:27 -05:00
Amir Livneh
5750f1ee86 Fix typo in ES.86 example (#1362) 2019-03-02 15:21:03 -05:00
Amir Livneh
35db3bf123 Fix typo in ES.87 (#1361) 2019-03-02 15:20:22 -05:00
Martín Knoblauch Revuelta
4f97d37239 Fix args. of == and != operators in C.100 (#1359) 
Obviously, the comparisons are intended to compare `Sorted_vector`s, not `T` values
 2019-02-28 04:08:16 -05:00
Amir Livneh
5190ea51a3 Fix capitalization in ES.61 enforcement (#1350) 
* Fix capitalization in ES.61 enforcement

* Fix grammar
 2019-02-27 09:39:09 -05:00
Amir Livneh
2056a14da7 Fix grammar in ES.50 (#1352) 2019-02-26 17:35:52 -05:00
Amir Livneh
a10668dc1d Fix spacing in ES.63 example (#1351) 2019-02-26 17:35:34 -05:00
Amir Livneh
d6a6e7092a Remove superfluous word in ES.42 enforcement (#1347) 2019-02-26 17:31:09 -05:00
Amir Livneh
882e9539fa Fix grammar in ES.42 (#1346) 2019-02-26 17:30:30 -05:00
Amir Livneh
c83acbc347 Fix comment grammar in ES.40 example (#1345) 2019-02-26 17:29:57 -05:00
Amir Livneh
9f0e9fe0a3 Fix grammar (#1344) 2019-02-26 17:29:00 -05:00
Amir Livneh
edac03725a Remove unnecessary hyphenation (#1343) 2019-02-26 17:28:38 -05:00
Amir Livneh
a95daa781e Fix comment stating incorrect assigned variable (#1342) 2019-02-26 17:27:48 -05:00
Amir Livneh
8c141fcfa5 Fix typo (#1341) 2019-02-26 17:25:00 -05:00
Amir Livneh
feae4d6c15 Fix grammar (#1340) 2019-02-21 14:04:18 -05:00
Amir Livneh
abad343557 Fix indentation in example (#1339) 2019-02-20 18:11:53 -05:00
Sergey Zubkov
358bef703e closes #1337 2019-02-19 15:37:53 -05:00
Matthew Dews
65aa7232e8 Fix typo (#1338) 2019-02-19 14:33:32 -05:00
Amir Livneh
f2b517eac2 Fix grammar (#1336) 2019-02-19 14:33:11 -05:00
Amir Livneh
ff8934c39b Fix grammar (#1335) 2019-02-19 14:32:39 -05:00
Amir Livneh
e0830c7c3b Remove redundant word (#1334) 2019-02-19 14:32:19 -05:00
Amir Livneh
94eadbb7eb Fix grammar (#1333) 2019-02-19 14:31:15 -05:00
Amir Livneh
4797c26d4b Fix grammar (#1331) 2019-02-19 14:30:47 -05:00
Amir Livneh
1fd6ce78c2 Fix typo and grammar (#1329) 2019-02-16 08:08:58 -05:00
Amir Livneh
c9f1066756 Fix grammar (#1327) 2019-02-15 09:45:50 -05:00
hsutter
684635eecd Closes #1322 
Add an Enforcement rule for prefix inc/dec functions. Try to phrase it
to reduce noisiness.
 2019-02-14 11:13:42 -08:00
Franz Hollerer
f7ef39f0d6 issue #1236 - there is no reason to use the Hungarian notation in C (#1326) 2019-02-14 14:02:35 -05:00
hsutter
fb1d4c9189 Closes #1319 2019-01-31 11:23:16 -08:00
mpherg
cbbe6071ce Standardize example and note headers (minor) (#1318) 
* Standardize example headings

Some example headings used "Example, [good,bad]" and others used
"Example; [good,bad]" (note the comma verses semicolon). The vast
majority of the headings used the comma version, so this commit
normalizes all example headings to use a comma instead of a semicolon.

* Standardize note heading level

Two of the "Note" headings were set to level four, but the rest are at
level 5. Fix the level fours to make them level fives.
 2019-01-31 14:13:57 -05:00
hsutter
b38d065e45 Cleaned up a code example comment 2019-01-17 09:38:14 -08:00
hsutter
373765b827 Closes #1317 
Fixed section heading to match item
 2019-01-16 16:07:40 -08:00
hsutter
4ed280b080 Closes #1315 2019-01-16 16:05:41 -08:00
Dave Smith
1805589141 Pro.bounds: Correct impact wording (minor) (#1316) 2019-01-16 19:01:16 -05:00
hsutter
fd9c725549 Update for #1306 2019-01-10 11:34:56 -08:00
hsutter
88a9ba0640 Closes #1311 2019-01-10 11:11:12 -08:00
beinhaerter
4e8ab7ae86 F.21 wording changed to current status of the standard (#1313) 2019-01-10 14:01:22 -05:00
Mark Abraham
e58bce6f6a Fix typo in ES.102 (#1312) 
The value -2 is signed, so the word "unsigned" is clearly wrong.  The
text notes that negative subscripts are a source of surprises and
bugs, so the correction to "negative" seems to reflect Bjarne's
original intent.
 2019-01-10 14:00:55 -05:00
Honggyu Kim
526f14f56a Prefer bullet points to a long sentence in SL section (#1310) 
It'd be better to have bullet points than writing the points in a long
sentence even with description in parenthesis.
 2019-01-10 14:00:12 -05:00
Max Bozzi
dd8fc629d7 Remove claims that "constexpr functions are pure" (#1307) 
F.4 and F.8 made this erroneous claim as parts of notes which are
entirely removed.
 2019-01-03 14:05:55 -05:00
hsutter
714bec5010 Updated date 2019-01-03 11:01:46 -08:00
Marzo Sette Torres Junior
f971ad2f17 Fixing tagged union example (#1301) 
It did not compile previously due to missing type specifier on placement new.
 2018-12-19 15:52:05 +00:00
Jonathan Wakely
d822f80d5d Fix whitespace errors in code, to make Travis CI pass 2018-12-19 15:51:17 +00:00
Andriy Berestovskyy
a7fc6f6d4e Fix a typo (#1300) 2018-12-18 14:19:06 -05:00
hsutter
0fe73c966d Fixed typo 
Thanks @dalg24!
 2018-12-16 11:47:32 -08:00
hsutter
d6d7d749c3 Minor rewording 2018-12-13 11:35:36 -08:00
hsutter
334c902a13 Adding suggestion in #1283 comment thread 
Thanks, Mike!
 2018-12-13 11:34:49 -08:00
Sergey Zubkov
41b10255c4 date update 2018-12-07 11:06:45 -05:00
Herb Sutter
6e3d2d2c22 Closes #1297 2018-12-06 15:07:23 -05:00
Herb Sutter
4fa9d4019f Minor edits to #1291 2018-12-06 14:36:40 -05:00
Chris Guzak
407fcc0eac update to I.4: Make interfaces precisely and strongly typed (#1291) 
* updates to I.4: Make interfaces precisely and strongly typed

* Update enforcement list

* address PR feedback from blakehawkins
 2018-12-06 14:33:38 -05:00
Kyle
0181ab40a7 Fix example in C.51 (#1294) 
The example looks like it previously used i to represent date, but now the variable is called d. I updated the use and related parameters to match.
 2018-11-29 12:02:41 -05:00
Sergey Zubkov
50b9cefe39 travis CI and typo fixes 2018-10-16 18:08:01 -04:00
Bjarne Stroustrup
dd67c99f1f made C.con a bit less incomplate 
More will eventually come
 2018-10-13 12:03:32 -04:00
Bjarne Stroustrup
1103509895 A philosophical rule/caution 2018-10-13 10:55:06 -04:00
Bjarne Stroustrup
0f61a4be4e typos 2018-10-12 15:29:21 -04:00
Bjarne Stroustrup
417d512fea clarifications for #1267 
references to resource handles
 2018-10-12 15:27:55 -04:00
Bjarne Stroustrup
11f58787b8 minor clarifications 
for #1268 and #1267
 2018-10-12 15:12:49 -04:00
Bjarne Stroustrup
2cfcd878c4 fiexed C.49 
remover contradiction to C.45 (#1092) ) and mention string_view
 2018-10-12 14:48:17 -04:00
Bjarne Stroustrup
8825798df6 clarify rules for {} initialization 
in response to #1279
 2018-10-12 13:53:24 -04:00
hsutter
61cdce115e Improved description of F.3 example 
The example in F.3 is not really long, but it is complex
 2018-10-11 12:09:41 -07:00
hsutter
3fbc0b35a4 Closes #1265, make the chaining exception more visible 2018-10-11 11:33:49 -07:00
Alexander Knorre
7733c326b2 No double deletion (#1278) 2018-10-11 11:04:27 -07:00
Martin
0b275097b6 Fixed a typo within ES.23 2018-10-10 20:49:09 +01:00
tcorbat
e81d770bdc Fix broken link to Lifetime paper (#1274) 2018-10-03 08:38:23 -07:00
Sergey Zubkov
30a0e1bef7 closes #1239 2018-09-30 21:24:00 -04:00
Sergey Zubkov
8915f05950 travis CI fixes 2018-09-23 16:02:45 -04:00
hsutter
fa7b1fe41f Fixed Lifetime.pdf link 2018-09-20 18:33:26 -07:00
hsutter
f02b24a71a Update Lifetime profile to 1.0 2018-09-20 18:32:38 -07:00
hsutter
ecfd61c8d8 Clarify C.128 
Improved readability of primary paragraph.
Added Discussion section of the classes of errors being addressed.
 2018-09-13 13:22:23 -07:00
hsutter
104cd63a37 Closes #1257 
Fixed example
 2018-09-06 11:59:34 -07:00
hsutter
60e19d76a4 Closes #1254 2018-09-06 11:52:03 -07:00
beinhaerter
5b372a99d8 Fixes Issue #1253: wrong link in SS-bounds to Res-simple (#1255) 
Replaced Res-simple with Res-ptr.
 2018-09-06 14:44:06 -04:00
Sergey Zubkov
1e12aba7af missing a return *this in a copy-assignment 2018-09-06 07:30:45 -04:00
Sergey Zubkov
faad9d8b56 one more typo 2018-09-05 20:19:03 -04:00
Sergey Zubkov
73057d3b0b travis CI fixes and typos 2018-09-05 20:01:36 -04:00
Sergey Zubkov
b16eb424e9 typo: funct1_tau -> func1_tau 2018-09-05 19:40:24 -04:00
Bjarne Stroustrup
e75a7056c4 Resolving #1146 
explaining SCARY and referencing the SCARY paper
 2018-09-03 17:25:44 -04:00
Bjarne Stroustrup
a0bc2d71ca resolving #1137 
clarification
 2018-09-03 17:02:01 -04:00
Bjarne Stroustrup
647aa80f0d applying #1139 
more references to C++17
 2018-09-03 16:45:26 -04:00
Bjarne Stroustrup
79a5b08ad9 resolve #1175 
I added a note
 2018-09-03 14:51:03 -04:00
Bjarne Stroustrup
5cabda84d7 resolve #1185 
implicit operator functions
 2018-09-03 14:28:01 -04:00
Bjarne Stroustrup
d3c3e3aa98 resolve #1209, #814, and #167 
noexcept and destructors
 2018-09-03 13:50:10 -04:00
Bjarne Stroustrup
f3e7dbac6e Resolution of #1228 
explicitly discouraging the use of # and ##
 2018-09-03 11:56:48 -04:00
Bjarne Stroustrup
c11001f0a6 resolving #1238 about style 
The caveat is added only to the subset of rules where it appears to be
relevant
 2018-09-03 10:20:20 -04:00
Bjarne Stroustrup
dd4cae0260 Resolve #1241 about returning T&& 2018-09-03 10:04:48 -04:00
hsutter
e31a85dc2d Closes #1251 2018-08-13 11:27:45 -07:00
Neil MacIntosh
0c7a349342 Fix example for ES.70 (#1252) 
As per #574, fixes the example in ES.70 to emphasize good use of a switch over a sequence of if-else-if statements.
 2018-08-13 11:25:57 -07:00
hsutter
d1def3290c Tweaked PR 1249 post-merge to cover copy assignment too 2018-08-13 11:18:52 -07:00
Andrzej Krzemieński
08f67de9fb Updated C.67 and C.130 (#1249) 
* Updated C.67 and C.130

This addresses https://github.com/isocpp/CppCoreGuidelines/issues/1246.

* fixed typeos

* updated dictionary
 2018-08-13 11:17:23 -07:00
Jonathan Wakely
42f8fa5f84 Use H3 heading for C.140 instead of H2 
Fixes #1250
 2018-08-10 17:38:16 +01:00
martysama0134
513a5fd624 Fix example good in ES.42, count to a.size() (#1245) 
* Fix example good in ES.42, count to a.size()

* Fix typos in ES.64 and Con.1

* Fix Example bad in T.3, no value in subscript
 2018-08-06 08:06:32 -07:00
jeffreylindsey
6dd14321c1 GSL grammar fix, added missing plurality in full name (#1243) 
* Renamed all appropriate instances of "guideline support library" to "guidelines support library".

* Renamed additional instances of "guideline support library" to "guidelines support library" in remaining files.
 2018-08-06 08:04:40 -07:00
jeffreyai
04b2fabb9b Change 'lifetime profile' to 'lifetime safety profile' and fix the bad/broken links (#1240) 
'lifetime profile' is only used twice with bad/broken links. 'lifetime safety' and 'lifetime safety profile' are used more frequently, and make more sense.
 2018-07-12 08:22:14 -04:00
Sergey Zubkov
cb08aa24a4
s/more that two/more than two 2018-06-25 16:16:40 -04:00
hsutter
e0ecfc83b7 Closes 1220 2018-06-18 11:47:53 -07:00
hsutter
a488f1d8b5 Added F.48, closes #1219 2018-06-18 11:44:29 -07:00
hsutter
c0a2efdfe8 Closes #1218 2018-06-18 11:40:39 -07:00
hsutter
1283da9afa Closes #1216 2018-06-18 11:35:08 -07:00
hsutter
28e9f02550 Let's =default to avoid an out of line definition question 2018-06-18 11:26:40 -07:00
hsutter
aa645b0372 Closes #1214 
Added virtual dtor to make the example standalone
 2018-06-18 11:25:16 -07:00
Richard Evans
0d0026e61e Correct Dewhurst link to reference found in discussion for C.47 2018-06-11 14:33:26 +01:00
kugelrund
dea3b94f12
Clarify result of lower_bound 
The previous formulation made it sound like the return value is always `last` if `val` is not in the range, which might lead to confusion.
 2018-05-26 10:03:29 +02:00
Jonathan Wakely
4af8321e91 Fix "an reasonable" typo 
Fixes #1211
 2018-05-15 15:25:23 +01:00
Gabriel Dos Reis
599fb02d12
Merge pull request #1208 from mabuchner/1207-cp-31-memory-corruption-from-example 
Pass parameter as reference in CP.31 example
 2018-05-14 11:10:24 -07:00
Sergey Zubkov
a866b000d3
it's deletion -> its deletion 2018-05-10 12:05:09 -04:00
Sergey Zubkov
4e58fb87f7
typo: "nothing to do with sync" -> "nothing to do with stdasync" 2018-05-08 08:46:51 -04:00
mbuchner
7261f5d2fb Pass parameter as reference in CP.31 example 
Fixes #1207.
 2018-05-08 09:25:01 +02:00
Gabriel Dos Reis
20d9f42674
Merge pull request #1198 from ianhattendorf/SL-str-12-cpp-14 
SL.str.12: s suffix is available in C++14
 2018-04-30 11:16:47 -07:00
Gabriel Dos Reis
046b2a0833
Merge pull request #1201 from mabuchner/1200-es-102-odd-loop-condition-in-second-example 
Fix ES.102 odd loop condition in example
 2018-04-30 11:15:32 -07:00
Gabriel Dos Reis
46ecdd6830
Merge pull request #1202 from gumb0/patch-1 
Remove unnecessary comments from C.42 examples
 2018-04-30 11:13:26 -07:00
Andrei Maiboroda
ff4a3069a1
Fix comments in C.42 examples 2018-04-25 18:27:19 +02:00
Andrei Maiboroda
2ee3fff631
Fix typo in C.44 2018-04-25 18:21:54 +02:00
Ian Hattendorf
d49c720e98 Fix typo in error handling intro 2018-04-20 16:12:32 +01:00
Ian Hattendorf
69d48f76c7 E.14 an->a is->are fixes 2018-04-20 16:12:32 +01:00
Ian Hattendorf
2cedd99f32 Remove whitespace at the end of lines 2018-04-20 16:12:32 +01:00
mbuchner
53c0bd2bd1 Fix ES.102 odd loop condition in example 2018-04-20 09:46:27 +02:00
Ian Hattendorf
ee64b7ec17
SL.str.12: s suffix is available in C++14 
std::literals::string_literals::operator""s is available since C++14
while std::pair class template argument deduction is available since
C++17
 2018-04-19 19:10:26 -07:00
hsutter
1e4dba2c0b Renamed NL.10 to "prefer underscore_style names" 2018-04-16 11:34:59 -07:00
hsutter
93ac723f6b Fixed rest of T.12 example following up #1189 2018-04-16 11:26:15 -07:00
Alexander “weej” Jones
15008e8432 Fix T.12's incorrect usage of vector::begin() (#1189) 2018-04-16 11:25:22 -07:00
hsutter
a5e28d4a61 Updated intro wording 2018-04-16 11:22:40 -07:00
Andrew Pardoe
b21b125d42 Capitalization error 2018-04-16 11:15:57 -07:00
hsutter
b3d2f853f7 Changed "method" to "function" in three places for consistency 2018-04-16 11:14:25 -07:00
hsutter
cea965f610 Reworded "consume" to "will-move-from" parameters 
To improve clarity since the wording was causing confusion
 2018-04-16 11:06:48 -07:00
Gabriel Dos Reis
99b997b6f0
Merge pull request #1179 from jwakely/issue-1177 
Fix comment to match code
 2018-04-09 11:17:13 -07:00
Chris Guzak
e5f28e4095 SF.11, Header files should be self-contained (#1181) 
* SF.11 Header files should be self-sufficient added

* PR feedback addressed

* explain more

* update reason baed on PR feedback

* add VS code dir to .gitignore

* more PR feedback
 2018-04-09 11:16:18 -07:00
Gabriel Dos Reis
85db0de16c
Merge pull request #1183 from beinhaerter/formatting 
Formatting in C.46
 2018-04-05 15:28:25 -07:00
Werner Henze
0cb724fe20 Fixed link for "avoid conversion operators" 2018-04-04 19:59:41 +02:00
Werner Henze
b724f71473 Formatting "explicit" as code 2018-04-04 19:53:07 +02:00
Jason Mercer
c0264f3831 fixed scale factor for millimeters (#1182) 2018-04-03 15:01:57 -04:00
Jonathan Wakely
e721ee53cb Fix comment to match code 
Also fix missing references and add cross-reference to F.22.

Fixes #1177
 2018-03-27 12:16:21 +01:00
Jonathan Wakely
dbe8bf0207 Fix typo 
Fixes #1176
 2018-03-27 11:45:16 +01:00
Andrew Pardoe
9ac22abe0a Adding note suggested by @jwakely in #1165 2018-03-26 12:03:46 -07:00
Andrew Pardoe
b9fe28cc2a update date 2018-03-26 11:55:31 -07:00
Jonathan Wakely
ba25a26294 Rephrase C.21 to talk about declaring not defining (#1152) 
* Rephrase C.21 to talk about declaring not defining

Add examples.

Fixes #870.

* Define special functions, clarify default constructor effects
 2018-03-26 11:15:03 -07:00
fekir
ab5f9c18bd catch by reference in all samples (#1154) 2018-03-26 11:13:49 -07:00
Stephan Weller
2c3d9921b6 Replace erroneous public keyword by private in C.129. (#1166) 2018-03-26 11:13:11 -07:00
beinhaerter
edf13aabc0 Note that C.46 does not apply for copy/move ctors (#1169) 
* Note that C.46 does not apply for copy/move ctors

* moved Note section before Enforcement section
 2018-03-26 11:12:03 -07:00
Gabriel Dos Reis
644e0f5b5e
Merge pull request #1164 from ChrisGuzak/ChrisGuzak-sizeof-not_max 
use sizeof(buffer) instead of MAX
 2018-03-22 16:15:32 -07:00
echeij
6ed138076d Fixed get_string example in F.21 (#1160) 
In the 'all values as return value' example in F.21, the passed istream was not used in the function.
 2018-03-14 10:14:07 -04:00