Commit Graph

753 Commits

Author SHA1 Message Date
Andrew Pardoe
d6143fb6c7 Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines 2016-04-24 09:51:14 -07:00
Andrew Pardoe
e19e0575c0 Merge branch 'fix-linelength' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-linelength 2016-04-24 09:48:24 -07:00
Andrew Pardoe
27dc740789 Merge pull request #593 from ubique/span-c-style-traversal-example
Fix span C-style traversal example
2016-04-24 09:43:26 -07:00
Andrew Pardoe
11718e96a2 Merge branch 'check-badchars' of https://github.com/tkruse/CppCoreGuidelines into tkruse-check-badchars 2016-04-24 09:23:48 -07:00
Boris Smidt
122ce83509 fixed markdown style errors 2016-04-24 17:51:54 +02:00
Boris Smidt
757737e86d changed tabs into 4 spaces 2016-04-24 17:44:02 +02:00
rafzi
109f00847a Fix bounds.3 example 2016-04-23 22:36:45 +02:00
Bjarne Stroustrup
e8dea3807a replaced the concurrency section
a couple of dozen new rules;
introduced raii_thread and detached_thread.
ntroduced the beginnings of lifetime and ownership safety.
2016-04-23 12:11:46 -04:00
Bjarne Stroustrup
d76d8c31ef "do no harm"
a philosophical addition
2016-04-23 11:51:17 -04:00
Thibault Kruse
d7bab1ab0f Fix whitespace around operator 2016-04-23 14:16:59 +02:00
Thibault Kruse
da92068a5f Shorten Fix longest C++ lines longer than 100 chars 2016-04-23 11:41:51 +02:00
Dmitry Banschikov
5ece97ed68 Fix span C-style traversal example 2016-04-22 19:26:58 +03:00
Thibault Kruse
321e411e4f Fix further typographic mistakes 2016-04-18 20:53:12 +02:00
Andreas Scherer
6353ff2c8f Undo typographic apostrophes.
Double- and single-quotes (apostrophes) are written in their "straight"
versions. The task of replacing them by their typographic versions is
left to the Markdown renderer, e.g., `pandoc --smart ...`.
2016-04-18 20:53:12 +02:00
Andreas Scherer
b83449a33b Consistent use of double-hyphen for en-dash.
Use `--` for all occurrences of en-dashes. All UTF-8 dashes are reduced
to this convention. Let the Markdown renderer cope with the correct
expansion of such items, e.g., `pandoc --smart ...`.
2016-04-18 20:53:12 +02:00
Andrew Pardoe
111dcfada1 Merge pull request #589 from tkruse/remark-fix
Remark fix
2016-04-18 07:16:19 -07:00
Andrew Pardoe
2a95737285 Merge branch 'style-fix26' of https://github.com/tkruse/CppCoreGuidelines into tkruse-style-fix26 2016-04-18 07:13:27 -07:00
Thibault Kruse
91a731a6f8 Remove last 2 tab instances, Flag all tabs as warning breaking travis build 2016-04-17 18:56:29 +02:00
Thibault Kruse
0491ccb880 Remove superfluous newlines 2016-04-17 18:33:52 +02:00
Thibault Kruse
34d6c79f06 Escape slashes to fix footnote warnings 2016-04-17 18:32:58 +02:00
Thibault Kruse
d9562f683d typo Int -> int 2016-04-17 18:00:44 +02:00
Thibault Kruse
e8675ea23a unify dummy function names 2016-04-17 18:00:44 +02:00
Thibault Kruse
c4698f22fe Consistently use simple function name for meaningless functions 2016-04-17 18:00:11 +02:00
Thibault Kruse
e910836f3b typo 2016-04-17 18:00:11 +02:00
Thibault Kruse
1863a750c0 whitespace 2016-04-17 18:00:11 +02:00
Thibault Kruse
0695f5968d fix ellipses encoding 2016-04-17 18:00:11 +02:00
Thibault Kruse
19c0e77a6e Fix whitespace around operators and commas 2016-04-17 11:25:26 +02:00
Thibault Kruse
a9c42279bb delete trailing whitespace 2016-04-17 11:25:18 +02:00
Thibault Kruse
55083af21e fix line length 2016-04-17 11:25:07 +02:00
Thibault Kruse
46b4a20881 Minor style: convert tabs to spaces 2016-04-17 11:24:48 +02:00
d3fault
8382c216d7 Fix tiny typo in CP.2 2016-04-12 21:08:25 -07:00
Andrew Pardoe
68af55caaf Removing the rest of the unnecessary escapes 2016-04-11 14:27:00 -07:00
Roman
6ea1422dd6 Update CppCoreGuidelines.md
Must be `int* p = new int[12]; delete[] p;`
2016-04-11 14:41:58 +04:00
Andrew Pardoe
7255e7d2f0 Testing formatting on bibliography 2016-04-10 12:37:59 -07:00
Thibault Kruse
006832159c Consistent References Blocks 2016-04-09 11:40:11 +02:00
Thibault Kruse
f9ebe1fc9a Fix missing open braces escape and missing backticks 2016-04-09 11:29:21 +02:00
Thibault Kruse
c8a18317c1 whitespaces fixes, by remark tool 2016-04-09 11:29:00 +02:00
Andrew Pardoe
033918b998 Updating date 2016-04-07 17:01:36 -07:00
uli
4af6b1e5e0 The table of contents was missing several chapters. The TOC now correctly reflects the order of the chapters in the document. 2016-04-06 14:40:28 -07:00
uli
88a6c1d790 The rule name ES.40 was used twice. 2016-04-06 14:40:28 -07:00
Andrew Pardoe
1c3c35b0f5 Updating date 2016-04-05 18:48:55 +00:00
johan lundberg
11275aa086 Add links to GSL, structure to README.md 2016-03-26 10:52:37 +01:00
jmihalicza
f48dac72bd P.10 typo
Sumething -> Something
2016-03-25 12:04:54 +01:00
Steven Peters
2a7fab1697 CppCoreGuidelines.md spelling error
stared_ptr -> shared_ptr
2016-03-23 15:24:19 -07:00
tvaneerd
7a4fbef370 remove use of == on doubles
could use an epsilon, but that just distracts from the point of the example, so changed double to int instead
2016-03-22 11:51:30 -04:00
Andrew Pardoe
7a8cac8dbc Changed { { hack to proper liquid template fix 2016-03-20 17:24:56 -07:00
Andrew Pardoe
aa82e03ac8 Updated date` 2016-03-20 16:56:07 -07:00
Patryk Małek
9b2b07d8f3 Updated comments after updating variable names 2016-03-20 19:07:51 +01:00
hsutter
dd3d73f643 Closed #537 2016-03-20 10:05:28 -07:00
Andrew Pardoe
0e9d6502f8 Merge pull request #552 from ltowarek/patch-2
Fix broken links in I.13
2016-03-20 09:56:24 -07:00
Andrew Pardoe
aa7f978f3c Merge pull request #551 from ltowarek/patch-1
Fix broken links in P.8
2016-03-20 09:55:23 -07:00
Andrew Pardoe
98aee93b0a Merge pull request #546 from tvaneerd/patch-1
== instead of =
2016-03-20 09:53:52 -07:00
Andrew Pardoe
1c686854e2 Merge pull request #536 from Marat-Tanalin/master
Typos
2016-03-20 09:48:56 -07:00
Andrew Pardoe
89cd79db3f Merge pull request #531 from tituswinters/per-opt
A more numeric reason for targeted optimization.
2016-03-20 09:27:17 -07:00
Andrew Pardoe
f01b4aac2e Merge pull request #528 from tituswinters/per-editorial
Expanding missing text for PER and CP sections, some editorial cleanup
2016-03-20 09:25:43 -07:00
Andrew Pardoe
033d3ec0eb Merge pull request #521 from jeanphilippeD/Minor-typo
Add missing word 'from'
2016-03-20 09:22:14 -07:00
Andrew Pardoe
3fe4e40ae9 Merge pull request #520 from PiotrSliwa/F.53
More comprehensive example and enforcements for F.53
2016-03-20 09:20:48 -07:00
Lukasz Towarek
cf8d521437 Fix broken links in I.13 2016-03-15 21:18:38 +01:00
Lukasz Towarek
70c4997f84 Fix broken links in P.8 2016-03-15 20:38:06 +01:00
tvaneerd
5e855a2de4 == instead of =
really should be +/- epsilon, or change double to int
2016-03-15 08:53:02 -04:00
hsutter
bcb93bd803 Updated RF.rules 2016-03-14 15:41:36 -07:00
Marat Tanalin
8e8d437123 Typos
expecially => especially (This is expecially important for)
deafault => default (This is what a deafault == would do)
+ `==` marked-down as code.
2016-02-26 23:37:26 +03:00
psliwa
c680191bf9 F.53: Fixed after review. 2016-02-24 13:37:43 +01:00
hsutter
a4cfded181 Editorial: Moved ES.60 into proper order 2016-02-22 09:29:32 -08:00
hsutter
1b3efdf1e8 Rewrote ES.56, closed #514 2016-02-22 09:28:41 -08:00
Titus Winters
92091c4b81 A more numeric reason for targeted optimization. 2016-02-17 10:57:02 -05:00
Titus Winters
e8f5dac762 Add note on brace-init for type conversion. 2016-02-17 10:41:13 -05:00
Titus Winters
ea1ed17c1c Bad editorial fix. 2016-02-16 16:54:26 -05:00
Titus Winters
b93b851568 Editorial updates for PER, CP.
Especially some descriptive text for conurrency, races, lock-free
programming.
2016-02-16 16:51:38 -05:00
Bjarne Stroustrup
23b7ceab9c a bit of fillout in the template section 2016-02-15 15:38:10 -05:00
hsutter
fd2dc97baf Closed #527 2016-02-15 11:31:45 -08:00
Bjarne Stroustrup
af86ae575e some minor fixes in the class hierarchy section
closing issue 524
2016-02-13 18:06:11 -05:00
Bjarne Stroustrup
e7f6ecc470 hat to do if you can't use exceptions 2016-02-13 17:19:08 -05:00
Bjarne Stroustrup
dfd29f3963 immutability
Added immutability under "Philosophy" and fleshed out the Con section
2016-02-13 14:35:22 -05:00
jeanphilippeD
b99f3765c7 Add missing word 'from' 2016-02-05 22:38:21 +00:00
psliwa
f11db25628 Minor improvement. 2016-02-04 11:06:55 +01:00
psliwa
fdd91e959a F.53: Minor fix. 2016-02-04 11:05:16 +01:00
Bjarne Stroustrup
f1fcc0fe68 added a not to C.170 2016-02-03 21:21:10 -05:00
psliwa
4fc0beafc3 F.53: More comprehensive example and enforcements. 2016-02-03 18:27:31 +01:00
Bjarne Stroustrup
3eca774fc7 a few cross references relating to operators 2016-02-02 16:36:12 -05:00
Bjarne Stroustrup
31d3dac828 C.168
define operators in the namespace of their operands
2016-02-02 16:14:46 -05:00
Andrew Pardoe
3e57e3603a Merge branch 'es-editorial' of https://github.com/tituswinters/CppCoreGuidelines into tituswinters-es-editorial 2016-02-01 21:42:41 -08:00
Andrew Pardoe
36c209a374 Merging PR486 2016-02-01 21:34:22 -08:00
Marat Tanalin
210455c1c6 23 typos
transfering => transferring (ownership transfering APIs)
prefent => prevent (to prefent range errors)
standarization => standardization (active discussion in standarization)
effectivily => effectively (This effectivily means)
declarate => declared (Flag classes declarate with `struct`)
Mimimize => Minimize (Mimimize the chance of untended access.)
The The => The (The The standard-library containers)
contaiers => containers (Users of hashed contaiers)
defie => define (to defie a specialization)
ibrary => library (combine standard-ibrary specializations)
specoalists => specialists ("cleverness" for non-specoalists)
yur => your (don't invent yur own names)
deploymenta => deployment (deploymenta and use of such tools)
suprises => surprises (perennial source of suprises and bugs)
implementating  => implementing (essential for implementating)
movesemantics => move semantics (movesemantics and certain rare
optimizations)
assingment => assignment (copying only part of an object using
assingment)
user => used (type can be user for a wide variety)
Templatizing => Templating (Templatizing a class hierarchy)
sourcefiles => source files (declarations used in multiple sourcefiles)
[2 times]
alternatives.These => alternatives. These (// space between sentences)
its => it’s (the first time its called)
LanguagesC++ => Languages — C++ ([C++03]: ISO/IEC 14882:2003(E),
Programming LanguagesC++)
2016-02-02 05:21:20 +03:00
Bjarne Stroustrup
ad97ba3fdb Dealt with issue 516
added C.8 and C.9 to clarify access conventions
2016-02-01 16:19:39 -05:00
Gabriel Dos Reis
6e812c1588 Merge pull request #498 from tituswinters/editorial-2
Editorial changes for PER, CP, E, and T.
2016-02-01 11:25:22 -08:00
Andrew Pardoe
8452e8ae84 Merge pull request #490 from dkorolev/master
Declaring one name per declaration.
2016-02-01 10:33:04 -08:00
Andrew Pardoe
0712b24c91 Merge pull request #510 from ZhangWangda/patch-1
fix typo
2016-02-01 10:25:01 -08:00
Andrew Pardoe
366150957b Merge pull request #513 from cmello/master
passes -> passed
2016-02-01 10:23:31 -08:00
Marat Tanalin
a67f8d3c27 Typos
wil => will;
developemnt => development.
2016-02-01 19:38:31 +03:00
Bjarne Stroustrup
5547b43c4b a few issues 2016-01-31 21:43:50 -05:00
Bjarne Stroustrup
df9aca5ec3 a bit of fill-in and cleanup 2016-01-31 17:32:14 -05:00
Cesar Mello
c041ced2c0 passes -> passed 2016-01-27 16:39:09 -02:00
ZhangWangda
67bf6a14ab fix typo
add a missing bracket
2016-01-26 14:20:38 -05:00
Bjarne Stroustrup
379938d743 rule against std::move()
ES.55
maybe the rule could be phrased more precisely
2016-01-26 14:12:59 -05:00
Bjarne Stroustrup
99673eb1f4 overloading vs default arguments
prefer default arguments and flag inconsistent default arguments on
virtual functions
2016-01-26 13:29:36 -05:00
hsutter
4748906ec1 c/assigned to/modified in F.7 and R.30 2016-01-25 11:27:11 -08:00
hsutter
94b567d2b8 Updated F.7 and R.30 based on 2016-01-25 telecon discussion 2016-01-25 11:25:56 -08:00
hsutter
ad66f6ecda Tweaked F.7 enforcement 2016-01-25 11:05:25 -08:00
hsutter
815cdbbe72 Refined Enforcement for F.7 2016-01-25 10:02:54 -08:00
Bjarne Stroustrup
1d6e7a6e6b many minor changes to the F section 2016-01-24 17:40:22 -05:00
hsutter
63316bc0dc Corrected F.54, part 2 2016-01-12 12:04:32 -08:00
hsutter
b97f67cd60 Corrected F.54 example 2016-01-12 12:02:59 -08:00
Titus Winters
20ed3d12fd Editorial changes for PER, CP, E, and T. 2016-01-12 13:28:08 -05:00
hsutter
7ae6ad4eb7 Completed and corrected Meyers book references 2016-01-11 13:59:02 -08:00
hsutter
3668c8c491 Added F.54 to never capture this implicitly 2016-01-11 11:00:27 -08:00
Jeremy Voorhis
dd683abae7 Fix typographical error (variable name) in example for C.30. 2016-01-10 19:47:36 -08:00
hsutter
935a5ee325 Closed #485. 2016-01-07 07:17:14 -08:00
hsutter
e4f908093d Closed #484. 2016-01-07 07:14:12 -08:00
Dima
2d9c0582ad Another minor grammar fix. 2016-01-06 23:23:30 -08:00
Dima
7ae316c605 Minor grammar fix. 2016-01-06 23:20:52 -08:00
Dima
6a39167b86 Declaring one name per declaration. 2016-01-06 22:31:13 -08:00
Titus Winters
d653d5e89c (Hopefully) editorial cleanup for Sec ES. 2016-01-06 14:44:01 -05:00
hsutter
46f38a7917 Closed #388. 2016-01-01 10:48:34 -08:00
hsutter
2bea1b9d30 Closed #442. 2015-12-31 17:18:35 -08:00
hsutter
8758eabcbf Folded duplicate C.6 into Con.2 and addressed PR #438. 2015-12-29 11:25:08 -08:00
hsutter
7cd72691e8 Improved R.3 note wording to help address PR #417. 2015-12-29 11:15:04 -08:00
hsutter
13c8df9abc Applied suggestion in PR #414. 2015-12-29 11:07:37 -08:00
hsutter
41751f548c Merge pull request #409 from agrygorenko/F-27-patch
F.27: Example fix
2015-12-29 13:57:07 -05:00
hsutter
47a1405707 Applied suggestion in PR #343. 2015-12-29 10:46:58 -08:00
hsutter
f013c1b22d Applied suggestion in PR #298. 2015-12-29 10:39:36 -08:00
hsutter
3586cf7d0e Applied suggestion in PR #273. 2015-12-29 10:35:29 -08:00
hsutter
6c47693b58 Applied suggestion in PR #268. 2015-12-29 10:28:57 -08:00
hsutter
50e89327bb Applied the suggestion in PR #238. 2015-12-29 10:25:42 -08:00
hsutter
12dd788e1d Applied suggestion in PR #213. 2015-12-29 10:23:47 -08:00
hsutter
4b15a57f96 Applied the suggestion in PR #198. 2015-12-29 10:21:05 -08:00
hsutter
10d1d9dbc5 Addressed PR #140. 2015-12-29 10:15:43 -08:00
hsutter
c9e015ce1f Addressed PR 52. 2015-12-29 09:29:06 -08:00
hsutter
9c2aba298c Closed #436. 2015-12-28 10:49:07 -08:00
hsutter
c6891262a7 Tweaked PR #481. 2015-12-28 10:20:58 -08:00
Andrew Pardoe
3f99f673d4 Wording in Intro and Philosophy 2015-12-28 12:41:37 -05:00
Gabriel Dos Reis
9b9a71bf18 Merge pull request #439 from mpark/P1
P.1: Minor fixes to the examples.
2015-12-26 00:10:54 -08:00
hsutter
7d99f7605a Closed #478. 2015-12-24 10:47:18 -08:00
hsutter
238ffceb62 Closed #477.' 2015-12-23 11:38:26 -08:00
hsutter
dc5cb14536 Closed #294. 2015-12-23 11:32:46 -08:00
hsutter
2d8377aab5 Closes #133. 2015-12-23 10:46:19 -08:00
Michael Park
a26d6c98d5 P.1: Fixed incorrect use of std::find. 2015-12-22 21:34:36 -05:00
Michael Park
3b29134985 P.1: The index result of a std::find-like loop needs to be initialized to -1. 2015-12-22 21:34:36 -05:00
hsutter
21b28d91ef Merge pull request #465 from tituswinters/f.6
Clarify f.6 note on noexcept and allocation
2015-12-22 19:43:38 -05:00
hsutter
d5cbcd23ec Merge pull request #472 from Alexolut/patch-7
fixed typos
2015-12-22 19:41:30 -05:00
hsutter
a1f7cdfc6e Merge pull request #473 from mpark/C.61
C.61: Fixed example to use `new[]` instead to allocate an array.
2015-12-22 19:39:37 -05:00
Sergey Zubkov
3f51ca23fa typos s/insigth/insight s/reders/readers s/psource/source 2015-12-21 22:27:40 -05:00
Bjarne Stroustrup
c07d9189d7 C.167: Use an operator for an operation with its conventional meaning
issue #290
2015-12-21 20:25:52 -05:00
Bjarne Stroustrup
b1c907387f ES.65 Don't slice 2015-12-21 19:59:47 -05:00
hsutter
afdaa1d110 Closed #437. 2015-12-21 16:55:31 -08:00
hsutter
f0e29f0492 Closed #423. 2015-12-21 16:50:36 -08:00
hsutter
9e0b9f435e Closes #189. 2015-12-21 16:38:42 -08:00
hsutter
9c93ba6c5f Closed #108. 2015-12-21 16:21:33 -08:00
hsutter
6156e95782 Closed #83. 2015-12-21 16:18:38 -08:00
Michael Park
d78a1b81a0 C.61: Fixed example to use new[] instead to allocate an array. 2015-12-21 13:01:55 -05:00