Commit Graph

810 Commits

Author SHA1 Message Date
Thibault Kruse
04345df6d0 remove duplicate constructor 2016-08-17 17:53:42 +02:00
Thibault Kruse
0997489573 bad signature 2016-08-17 17:53:42 +02:00
Thibault Kruse
b9f41b5cd0 missing template argument 2016-08-17 17:53:42 +02:00
Thibault Kruse
0b15a43c54 missing comma 2016-08-17 17:53:42 +02:00
Thibault Kruse
dc683521ee wrong sample class 2016-08-17 17:53:42 +02:00
Thibault Kruse
01b66d9a7e unique variable names in example 2016-08-17 17:53:42 +02:00
Thibault Kruse
bf11606c1a completely implement assignOperator 2016-08-17 17:53:42 +02:00
Thibault Kruse
165c61e7ce bad signature
# Conflicts:
#	CppCoreGuidelines.md
2016-08-17 17:53:42 +02:00
Thibault Kruse
005e546d63 bad return type 2016-08-17 17:53:41 +02:00
Thibault Kruse
2a9d0a43b8 dodgy example code 2016-08-17 17:53:41 +02:00
Thibault Kruse
360ba610d1 Fix many typos 2016-08-17 17:40:13 +02:00
Gabriel Dos Reis
d4da142302 Merge pull request #678 from alex-weej/patch-3
Typos in NL.7
2016-08-17 08:35:06 -07:00
Alexander “weej” Jones
43f6b85fbc Typos in NL.7 2016-08-17 16:15:00 +01:00
Alexander “weej” Jones
ca4b223a27 Typo "intelligible" 2016-08-17 16:13:55 +01:00
Andrew Pardoe
3dcc0e6976 Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines 2016-08-15 11:48:38 -07:00
Andrew Pardoe
745b148ba7 Merge PR #643 2016-08-15 11:48:02 -07:00
Gabriel Dos Reis
5ced8d0e16 Merge pull request #605 from anthonywilliams/master
Fix some typos in the concurrency section
2016-08-15 11:45:02 -07:00
ypyf
866abafb07 fixed typo 2016-08-15 13:56:17 +08:00
Pim Schellart
e708b8856d Fix link 2016-08-09 08:24:32 -04:00
Lars Volker
91ceea287c Fix typo 2016-08-06 19:28:55 +02:00
Bjarne Stroustrup
a0a1d8615c some cleanup in NL and SL 2016-07-28 20:08:07 -04:00
Gabriel Dos Reis
72a58497a9 Merge pull request #648 from cubbimew/travis-fixes
fix Travis CI issues caused by recent direct commits
2016-07-28 09:24:26 -07:00
Bjarne Stroustrup
a5cd446ccf minor cleanup of exception section
Closing issue 313 on E.25 for now
2016-07-28 10:51:47 -04:00
Bjarne Stroustrup
441070c203 PRO->PRO and CON->Con
they are not acronyms
2016-07-28 09:07:25 -04:00
Sergey Zubkov
7890037c8d fix Travis CI issues caused by recent direct commits 2016-07-27 21:30:55 -04:00
Bjarne Stroustrup
141356db52 F.21 and GSL and Etc.
The cleanup continues.
Note the caller-allocates example in F.21.
Note the attempted cleanup of the Enforcement section of F.7: too many
ands and ors; did I get it right?
Note the simplification of the treatment of char* in the GSL section;
char* is considered a pointer to a single char, rather than a C-style
string; viable?
2016-07-27 16:08:21 -04:00
Florin Iucha
3876d12c63 Fix a few typos 2016-07-24 23:08:18 -04:00
Bjarne Stroustrup
d155244c70 a few minor changes 2016-07-21 16:27:25 -04:00
Bjarne Stroustrup
1b026e5492 Slight cleanup in profiles section 2016-07-21 11:31:53 -04:00
Bjarne Stroustrup
cb5bab9ae5 C.129
rationale and examples added
2016-07-20 15:35:41 -04:00
Bjarne Stroustrup
df88742f7d int->if 2016-07-19 20:28:36 -04:00
Bjarne Stroustrup
25deeba3b5 T.140 2016-07-19 16:49:44 -04:00
Bjarne Stroustrup
6d1de28c91 template rule cleanup 2016-07-19 14:42:02 -04:00
Bjarne Stroustrup
c553535fb8 fixing typos
adding "concept" markers, hopefully to minimize confusion
2016-07-18 21:10:52 -04:00
Bjarne Stroustrup
bf5635d085 a few changes to "Templates"
and a definition of "Library"
2016-07-18 15:50:43 -04:00
Bjarne Stroustrup
2950a03589 Cleanup of the template section
More cleanup is needed
The new T.41 is interesting
2016-07-17 20:49:06 -04:00
Bjarne Stroustrup
ae8c320cdf Update and extension of enumeration section 2016-07-16 18:13:43 -04:00
Bjarne Stroustrup
39eaac7317 Cleanup of P and I
P.11 added
2016-07-16 15:17:33 -04:00
Bjarne Stroustrup
e63549f287 Improve F.22 2016-07-16 13:50:38 -04:00
Gabriel Dos Reis
7c9ec43f8b Merge pull request #642 from galik/SL.50fix-typos
Fix typos in SL.50
2016-07-13 13:37:49 -07:00
Sergey Zubkov
ba8ccd35a5 Fix Travis CI by reverting "Better comment for implicit conversion example"
This reverts commit c2f54b5ed1.
2016-07-13 15:15:23 -04:00
galik
b290556127 Fix typos in SL.50 2016-07-13 19:15:04 +01:00
Andrew Pardoe
c2f54b5ed1 Better comment for implicit conversion example 2016-07-11 13:36:03 -07:00
Andrew Pardoe
c9bd992a92 Merge pull request #635 from grzebiel/master
use proper argument for creation of span from array
2016-07-11 12:13:14 -07:00
grzebiel
f4ad185de5 visualy align comments 2016-07-09 23:14:47 +02:00
Jeff Hutchison
ddc0093d7e Fix the URL to isocpp.org. 2016-06-27 06:35:07 -04:00
grzebiel
470a603239 use proper argument for creation of span from array 2016-06-25 23:51:52 +02:00
tal
5d19b4b875 CP.2_617: Switched to an alternate form of span<>. 2016-05-23 14:41:16 -07:00
tal
54bd880898 C.33_610: changed owner<T>* to owner<T*> per issue 610
Did not change the owner<T> to owner<T*> in the Enforcement section.
2016-05-19 10:25:37 -07:00
tal
c3e45c9403 R.3_609: changed owner<T> to owner<T*> in R.3 per issue #609 2016-05-18 18:21:00 -07:00
Anthony Williams
60e3875e63 Fix some typos in the concurrency section 2016-05-09 13:52:32 +01:00
eyal bari
e41f3f85f8 fix mixed index / iterator loop condition
replaced end with size
2016-05-03 11:02:33 +03:00
Sergey Zubkov
d7d39b4c98 update FAQ.55 2016-04-26 21:28:47 -04:00
Thibault Kruse
0ad523eecf fix cpplint style warnings 2016-04-24 22:32:11 +02:00
Thibault Kruse
765ebd6fbc fix slanted quotes 2016-04-24 22:25:05 +02:00
Andrew Pardoe
3b93c16fbd Merge pull request #596 from tkruse/style-fix27
Style fix27
2016-04-24 09:58:29 -07:00
Andrew Pardoe
11ee7e5626 Merge branch 'patch-1' of https://github.com/rafzi/CppCoreGuidelines into rafzi-patch-1 2016-04-24 09:53:53 -07:00
Andrew Pardoe
d6143fb6c7 Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines 2016-04-24 09:51:14 -07:00
Andrew Pardoe
e19e0575c0 Merge branch 'fix-linelength' of https://github.com/tkruse/CppCoreGuidelines into tkruse-fix-linelength 2016-04-24 09:48:24 -07:00
Andrew Pardoe
27dc740789 Merge pull request #593 from ubique/span-c-style-traversal-example
Fix span C-style traversal example
2016-04-24 09:43:26 -07:00
Andrew Pardoe
11718e96a2 Merge branch 'check-badchars' of https://github.com/tkruse/CppCoreGuidelines into tkruse-check-badchars 2016-04-24 09:23:48 -07:00
Boris Smidt
122ce83509 fixed markdown style errors 2016-04-24 17:51:54 +02:00
Boris Smidt
757737e86d changed tabs into 4 spaces 2016-04-24 17:44:02 +02:00
rafzi
109f00847a Fix bounds.3 example 2016-04-23 22:36:45 +02:00
Bjarne Stroustrup
e8dea3807a replaced the concurrency section
a couple of dozen new rules;
introduced raii_thread and detached_thread.
ntroduced the beginnings of lifetime and ownership safety.
2016-04-23 12:11:46 -04:00
Bjarne Stroustrup
d76d8c31ef "do no harm"
a philosophical addition
2016-04-23 11:51:17 -04:00
Thibault Kruse
d7bab1ab0f Fix whitespace around operator 2016-04-23 14:16:59 +02:00
Thibault Kruse
da92068a5f Shorten Fix longest C++ lines longer than 100 chars 2016-04-23 11:41:51 +02:00
Dmitry Banschikov
5ece97ed68 Fix span C-style traversal example 2016-04-22 19:26:58 +03:00
Thibault Kruse
321e411e4f Fix further typographic mistakes 2016-04-18 20:53:12 +02:00
Andreas Scherer
6353ff2c8f Undo typographic apostrophes.
Double- and single-quotes (apostrophes) are written in their "straight"
versions. The task of replacing them by their typographic versions is
left to the Markdown renderer, e.g., `pandoc --smart ...`.
2016-04-18 20:53:12 +02:00
Andreas Scherer
b83449a33b Consistent use of double-hyphen for en-dash.
Use `--` for all occurrences of en-dashes. All UTF-8 dashes are reduced
to this convention. Let the Markdown renderer cope with the correct
expansion of such items, e.g., `pandoc --smart ...`.
2016-04-18 20:53:12 +02:00
Andrew Pardoe
111dcfada1 Merge pull request #589 from tkruse/remark-fix
Remark fix
2016-04-18 07:16:19 -07:00
Andrew Pardoe
2a95737285 Merge branch 'style-fix26' of https://github.com/tkruse/CppCoreGuidelines into tkruse-style-fix26 2016-04-18 07:13:27 -07:00
Thibault Kruse
91a731a6f8 Remove last 2 tab instances, Flag all tabs as warning breaking travis build 2016-04-17 18:56:29 +02:00
Thibault Kruse
0491ccb880 Remove superfluous newlines 2016-04-17 18:33:52 +02:00
Thibault Kruse
34d6c79f06 Escape slashes to fix footnote warnings 2016-04-17 18:32:58 +02:00
Thibault Kruse
d9562f683d typo Int -> int 2016-04-17 18:00:44 +02:00
Thibault Kruse
e8675ea23a unify dummy function names 2016-04-17 18:00:44 +02:00
Thibault Kruse
c4698f22fe Consistently use simple function name for meaningless functions 2016-04-17 18:00:11 +02:00
Thibault Kruse
e910836f3b typo 2016-04-17 18:00:11 +02:00
Thibault Kruse
1863a750c0 whitespace 2016-04-17 18:00:11 +02:00
Thibault Kruse
0695f5968d fix ellipses encoding 2016-04-17 18:00:11 +02:00
Thibault Kruse
19c0e77a6e Fix whitespace around operators and commas 2016-04-17 11:25:26 +02:00
Thibault Kruse
a9c42279bb delete trailing whitespace 2016-04-17 11:25:18 +02:00
Thibault Kruse
55083af21e fix line length 2016-04-17 11:25:07 +02:00
Thibault Kruse
46b4a20881 Minor style: convert tabs to spaces 2016-04-17 11:24:48 +02:00
d3fault
8382c216d7 Fix tiny typo in CP.2 2016-04-12 21:08:25 -07:00
Andrew Pardoe
68af55caaf Removing the rest of the unnecessary escapes 2016-04-11 14:27:00 -07:00
Roman
6ea1422dd6 Update CppCoreGuidelines.md
Must be `int* p = new int[12]; delete[] p;`
2016-04-11 14:41:58 +04:00
Andrew Pardoe
7255e7d2f0 Testing formatting on bibliography 2016-04-10 12:37:59 -07:00
Thibault Kruse
006832159c Consistent References Blocks 2016-04-09 11:40:11 +02:00
Thibault Kruse
f9ebe1fc9a Fix missing open braces escape and missing backticks 2016-04-09 11:29:21 +02:00
Thibault Kruse
c8a18317c1 whitespaces fixes, by remark tool 2016-04-09 11:29:00 +02:00
Andrew Pardoe
033918b998 Updating date 2016-04-07 17:01:36 -07:00
uli
4af6b1e5e0 The table of contents was missing several chapters. The TOC now correctly reflects the order of the chapters in the document. 2016-04-06 14:40:28 -07:00
uli
88a6c1d790 The rule name ES.40 was used twice. 2016-04-06 14:40:28 -07:00
Andrew Pardoe
1c3c35b0f5 Updating date 2016-04-05 18:48:55 +00:00
johan lundberg
11275aa086 Add links to GSL, structure to README.md 2016-03-26 10:52:37 +01:00
jmihalicza
f48dac72bd P.10 typo
Sumething -> Something
2016-03-25 12:04:54 +01:00
Steven Peters
2a7fab1697 CppCoreGuidelines.md spelling error
stared_ptr -> shared_ptr
2016-03-23 15:24:19 -07:00
tvaneerd
7a4fbef370 remove use of == on doubles
could use an epsilon, but that just distracts from the point of the example, so changed double to int instead
2016-03-22 11:51:30 -04:00
Andrew Pardoe
7a8cac8dbc Changed { { hack to proper liquid template fix 2016-03-20 17:24:56 -07:00
Andrew Pardoe
aa82e03ac8 Updated date` 2016-03-20 16:56:07 -07:00
Patryk Małek
9b2b07d8f3 Updated comments after updating variable names 2016-03-20 19:07:51 +01:00
hsutter
dd3d73f643 Closed #537 2016-03-20 10:05:28 -07:00
Andrew Pardoe
0e9d6502f8 Merge pull request #552 from ltowarek/patch-2
Fix broken links in I.13
2016-03-20 09:56:24 -07:00
Andrew Pardoe
aa7f978f3c Merge pull request #551 from ltowarek/patch-1
Fix broken links in P.8
2016-03-20 09:55:23 -07:00
Andrew Pardoe
98aee93b0a Merge pull request #546 from tvaneerd/patch-1
== instead of =
2016-03-20 09:53:52 -07:00
Andrew Pardoe
1c686854e2 Merge pull request #536 from Marat-Tanalin/master
Typos
2016-03-20 09:48:56 -07:00
Andrew Pardoe
89cd79db3f Merge pull request #531 from tituswinters/per-opt
A more numeric reason for targeted optimization.
2016-03-20 09:27:17 -07:00
Andrew Pardoe
f01b4aac2e Merge pull request #528 from tituswinters/per-editorial
Expanding missing text for PER and CP sections, some editorial cleanup
2016-03-20 09:25:43 -07:00
Andrew Pardoe
033d3ec0eb Merge pull request #521 from jeanphilippeD/Minor-typo
Add missing word 'from'
2016-03-20 09:22:14 -07:00
Andrew Pardoe
3fe4e40ae9 Merge pull request #520 from PiotrSliwa/F.53
More comprehensive example and enforcements for F.53
2016-03-20 09:20:48 -07:00
Lukasz Towarek
cf8d521437 Fix broken links in I.13 2016-03-15 21:18:38 +01:00
Lukasz Towarek
70c4997f84 Fix broken links in P.8 2016-03-15 20:38:06 +01:00
tvaneerd
5e855a2de4 == instead of =
really should be +/- epsilon, or change double to int
2016-03-15 08:53:02 -04:00
hsutter
bcb93bd803 Updated RF.rules 2016-03-14 15:41:36 -07:00
Marat Tanalin
8e8d437123 Typos
expecially => especially (This is expecially important for)
deafault => default (This is what a deafault == would do)
+ `==` marked-down as code.
2016-02-26 23:37:26 +03:00
psliwa
c680191bf9 F.53: Fixed after review. 2016-02-24 13:37:43 +01:00
hsutter
a4cfded181 Editorial: Moved ES.60 into proper order 2016-02-22 09:29:32 -08:00
hsutter
1b3efdf1e8 Rewrote ES.56, closed #514 2016-02-22 09:28:41 -08:00
Titus Winters
92091c4b81 A more numeric reason for targeted optimization. 2016-02-17 10:57:02 -05:00
Titus Winters
e8f5dac762 Add note on brace-init for type conversion. 2016-02-17 10:41:13 -05:00
Titus Winters
ea1ed17c1c Bad editorial fix. 2016-02-16 16:54:26 -05:00
Titus Winters
b93b851568 Editorial updates for PER, CP.
Especially some descriptive text for conurrency, races, lock-free
programming.
2016-02-16 16:51:38 -05:00
Bjarne Stroustrup
23b7ceab9c a bit of fillout in the template section 2016-02-15 15:38:10 -05:00
hsutter
fd2dc97baf Closed #527 2016-02-15 11:31:45 -08:00
Bjarne Stroustrup
af86ae575e some minor fixes in the class hierarchy section
closing issue 524
2016-02-13 18:06:11 -05:00
Bjarne Stroustrup
e7f6ecc470 hat to do if you can't use exceptions 2016-02-13 17:19:08 -05:00
Bjarne Stroustrup
dfd29f3963 immutability
Added immutability under "Philosophy" and fleshed out the Con section
2016-02-13 14:35:22 -05:00
jeanphilippeD
b99f3765c7 Add missing word 'from' 2016-02-05 22:38:21 +00:00
psliwa
f11db25628 Minor improvement. 2016-02-04 11:06:55 +01:00
psliwa
fdd91e959a F.53: Minor fix. 2016-02-04 11:05:16 +01:00
Bjarne Stroustrup
f1fcc0fe68 added a not to C.170 2016-02-03 21:21:10 -05:00
psliwa
4fc0beafc3 F.53: More comprehensive example and enforcements. 2016-02-03 18:27:31 +01:00
Bjarne Stroustrup
3eca774fc7 a few cross references relating to operators 2016-02-02 16:36:12 -05:00
Bjarne Stroustrup
31d3dac828 C.168
define operators in the namespace of their operands
2016-02-02 16:14:46 -05:00
Andrew Pardoe
3e57e3603a Merge branch 'es-editorial' of https://github.com/tituswinters/CppCoreGuidelines into tituswinters-es-editorial 2016-02-01 21:42:41 -08:00
Andrew Pardoe
36c209a374 Merging PR486 2016-02-01 21:34:22 -08:00
Marat Tanalin
210455c1c6 23 typos
transfering => transferring (ownership transfering APIs)
prefent => prevent (to prefent range errors)
standarization => standardization (active discussion in standarization)
effectivily => effectively (This effectivily means)
declarate => declared (Flag classes declarate with `struct`)
Mimimize => Minimize (Mimimize the chance of untended access.)
The The => The (The The standard-library containers)
contaiers => containers (Users of hashed contaiers)
defie => define (to defie a specialization)
ibrary => library (combine standard-ibrary specializations)
specoalists => specialists ("cleverness" for non-specoalists)
yur => your (don't invent yur own names)
deploymenta => deployment (deploymenta and use of such tools)
suprises => surprises (perennial source of suprises and bugs)
implementating  => implementing (essential for implementating)
movesemantics => move semantics (movesemantics and certain rare
optimizations)
assingment => assignment (copying only part of an object using
assingment)
user => used (type can be user for a wide variety)
Templatizing => Templating (Templatizing a class hierarchy)
sourcefiles => source files (declarations used in multiple sourcefiles)
[2 times]
alternatives.These => alternatives. These (// space between sentences)
its => it’s (the first time its called)
LanguagesC++ => Languages — C++ ([C++03]: ISO/IEC 14882:2003(E),
Programming LanguagesC++)
2016-02-02 05:21:20 +03:00
Bjarne Stroustrup
ad97ba3fdb Dealt with issue 516
added C.8 and C.9 to clarify access conventions
2016-02-01 16:19:39 -05:00
Gabriel Dos Reis
6e812c1588 Merge pull request #498 from tituswinters/editorial-2
Editorial changes for PER, CP, E, and T.
2016-02-01 11:25:22 -08:00
Andrew Pardoe
8452e8ae84 Merge pull request #490 from dkorolev/master
Declaring one name per declaration.
2016-02-01 10:33:04 -08:00
Andrew Pardoe
0712b24c91 Merge pull request #510 from ZhangWangda/patch-1
fix typo
2016-02-01 10:25:01 -08:00
Andrew Pardoe
366150957b Merge pull request #513 from cmello/master
passes -> passed
2016-02-01 10:23:31 -08:00
Marat Tanalin
a67f8d3c27 Typos
wil => will;
developemnt => development.
2016-02-01 19:38:31 +03:00
Bjarne Stroustrup
5547b43c4b a few issues 2016-01-31 21:43:50 -05:00
Bjarne Stroustrup
df9aca5ec3 a bit of fill-in and cleanup 2016-01-31 17:32:14 -05:00
Cesar Mello
c041ced2c0 passes -> passed 2016-01-27 16:39:09 -02:00