Commit Graph

1143 Commits

Author SHA1 Message Date
Bjarne Stroustrup
2839c87890 add example to R.20
addresses #1015
2017-09-17 17:54:33 -04:00
Neil MacIntosh
b87d21b662 Merge pull request #1018 from Cleroth/patch-1
Avoid `std::endl` :)
2017-09-11 11:24:33 -07:00
Gabriel Dos Reis
6d5a219e66 Merge pull request #1023 from marzojr/master
Fixing memory handling in E.5 example
2017-09-11 11:22:06 -07:00
Gabriel Dos Reis
26f3ee9cfd Fix #998. 2017-09-11 10:48:20 -07:00
Gabriel Dos Reis
7146b55d30 Fix #1008. 2017-09-11 10:36:50 -07:00
Sebastian Valle
9840eefacf CP.2: Fixed a typo in the async example code. (#1030)
span a task -> spawn a task
2017-08-21 18:01:00 +01:00
tg-m
7a3d3c5a29 Fix issue #1026 (#1027) 2017-08-18 15:59:16 +01:00
Ivan Baidakou
c2456ccf5b Fix typo: Public -> public (#1025) 2017-08-13 13:22:06 +01:00
Andrew Pardoe
c04e3657fb Updating date 2017-08-11 10:41:03 -07:00
Marzo Sette Torres Junior
0bb69d80e6 Fixing memory handling in E.5 example
Instead of constructing an array, it constructs and deletes a single double, and accesses elements as if it had constructed an array.
2017-08-08 16:37:19 +02:00
Cleroth
d51a304e0a Update CppCoreGuidelines.md 2017-08-06 21:36:48 +02:00
TalLancaster
e61f111301 Per C.66: a global edit adding noexcept to move constructor/assignment examples (#1016) 2017-08-06 15:25:29 +01:00
Cleroth
43f378c6b3 Avoid std::endl :) 2017-08-06 11:04:41 +02:00
Gabriel Dos Reis
4ffab15e77 Merge pull request #1012 from franzhollerer/aligning_case_with_switch
aligning case with switch
2017-08-01 17:05:57 -07:00
Gabriel Dos Reis
e5e7082efa Merge pull request #1013 from franzhollerer/opening_brace_in_same_line_as_switch
opening brace in same line with switch statement to be aligned with NL.17
2017-08-01 17:05:24 -07:00
Björn Schäpers
378370e20d Fix typo in ES.84 2017-08-01 12:24:51 +02:00
Franz Hollerer
1cc009bb57 placing opening brace in same line with switch statement to be aligned with NL.17 2017-07-31 21:23:43 +02:00
Franz Hollerer
83561b15eb aligning case with switch 2017-07-31 21:21:09 +02:00
Andrew Pardoe
82755da679 Fixing NL.17 per issue #1002 discussion 2017-07-31 11:29:09 -07:00
Ben
4b6e6eb190 Fix example in C.61 2017-07-27 03:40:16 +02:00
Benoît Blanchon
150744a8d3 Fix example in CP.21 (#1007) 2017-07-25 11:32:29 -04:00
Jonathan Bohren
69f749bf7f Fixing typo / improving language in NR.3 (#1005)
Current text has a plurality typo ("separates" vs "separate"), modified version more precisely conveys the idea.
2017-07-25 08:15:49 +01:00
Jonathan Wakely
9c9d8d2dfc Separate good example from bad
Fixes #1001
2017-07-24 20:36:44 +01:00
Gabriel Dos Reis
8249a49c69 Merge pull request #625 from GlassAndOneHalf/example-update
Issue #624 ES.34 Add Example.
2017-07-24 11:57:50 -07:00
hsutter
f0935e33b1 Closes #315 2017-07-24 11:52:25 -07:00
hsutter
f01bded2a1 Elminated 's' typo 2017-07-24 11:41:03 -07:00
hsutter
a55cd51662 Fixed typos introduced when 'fixing' PR merge 2017-07-24 11:40:33 -07:00
jeanphilippeD
1d8ed2b59e Fix CP.3 to allow local reasoning and compilation without error (#951)
* Fix CP.3 to allow local reasoning and compilation without error

(CP.3: Minimize explicit sharing of writable data)

Use 'ES.28: Use lambdas for complex initialization,
especially of const variables' to ensure we can see from the body
of the function that the function called in async only require const
parameter.

This ensure that if a non local change to the function signature
(making the const parameter non const) it will result in a compilation
error.

Added necessary construct and compiled with https://godbolt.org/g/tjGXbV

* Update CppCoreGuidelines.md
2017-07-24 11:38:45 -07:00
Gabriel Dos Reis
0de765443a Merge pull request #974 from Talkless/patch-1
Fix if statement for checking error condition
2017-07-24 11:28:32 -07:00
Jonathan Wakely
898f819b00 Add [Abrahams01] bibliography entry for exception-safety (#991)
Link to it when talking about the strong and basic exception-safety
guarantees.

Add it to the dictionary.
2017-07-24 19:26:03 +01:00
Gabriel Dos Reis
45fff26517 Merge pull request #976 from willwray/patch-1
Fix Inconsistent definition of czstring in comments
2017-07-24 11:25:18 -07:00
Jonathan Wakely
7e7e1d8926 Move period outside parenthesis 2017-07-20 20:05:42 +01:00
Gabriel Dos Reis
cf223f3cb8 Merge pull request #992 from isocpp/broken-links
Replace broken links to #Rf-pass-ref-ref and #Rf-pass-ref-move
2017-07-20 09:26:55 -07:00
Gabriel Dos Reis
2a1472657f Merge pull request #990 from isocpp/issue-989
Remove confusing "copy" in discussion of move ops
2017-07-20 09:24:48 -07:00
Abigail
56df32bd95 Fix typo in C.8 (#985) 2017-07-20 13:22:38 +01:00
Jonathan Wakely
3924087459 Replace broken links to #Rf-pass-ref-ref and #Rf-pass-ref-move 2017-07-20 13:16:07 +01:00
Jonathan Wakely
3a6466f09c Fix anchor links with double hash symbols 2017-07-20 12:53:27 +01:00
Jonathan Wakely
598e6f99b6 Fix cross-references to [C++03] and [C++CS]
Anchors should be #Cplusplus03 and #CplusplusCS not #C++03 and #C++CS.
2017-07-20 12:46:57 +01:00
Jonathan Wakely
498eb97dd2 Remove repetition of "as well"
Fixes #983
2017-07-20 12:39:15 +01:00
Jonathan Wakely
1143bfab79 Remove confusing "copy" in discussion of move ops
Fixes #989
2017-07-20 12:35:16 +01:00
Andrew Pardoe
bf7d7da165 updating date 2017-07-18 09:36:10 -04:00
michaelz85
e9b627f209 C.64 fixed typo (#987) 2017-07-17 12:29:22 +01:00
Jonathan Wakely
24b733f0b9 NL.17 fix typo
Fixes #982
2017-07-12 13:38:40 +01:00
Felix Kälberer
d26dde2a4f Fix Fibonacci sequence
A number sequence called `fib` should be the Fibonacci sequence or have a different name.

https://en.wikipedia.org/wiki/Fibonacci_number
2017-07-06 22:24:32 +02:00
Andrew Pardoe
f6ba91e90a update date 2017-07-03 09:22:01 -07:00
Will Wray
5ffabce718 Fix Inconsistent definition of czstring in comments
Comments in sections  SL.str.3 and GSL.view disagree on whether czstring may be the nullptr.

This PR fixes the first comment definition in SL.str.3 that czstring `is a C-style string that is not the nullptr`

### SL.str.3: Use zstring or czstring to refer to a C-style, zero-terminated, sequence of characters
```
void f1(zstring s);     // s is a C-style string or the nullptr
void f1(czstring s);    // s is a C-style string that is not the nullptr
```
### GSL.view: Views
`zstring` // a `char*` supposed to be a C-style string; that is, a zero-terminated sequence of `char` or `nullptr`
`czstring` // a `const char*` supposed to be a C-style string; that is, a zero-terminated sequence of const `char` or `nullptr`
2017-07-03 12:13:40 -04:00
Vincas Dargis
0b1b5bbac8 Fix if statement for checking error condition
Example mentions that it handles error, and errors are commonly non-zero values.

Closes #970
2017-07-01 19:29:35 +03:00
Andrew Pardoe
66fc5d4f5c Merge branch 'master' of https://github.com/isocpp/CppCoreGuidelines 2017-06-26 10:51:38 -07:00
Andrew Pardoe
7ba2317992 Updating date 2017-06-26 10:51:23 -07:00
Andrew Pardoe
a3860f3cc2 Merge pull request #971 from tkruse/style-fixes2
Style fixes for compile-time, run-time and similar
2017-06-25 10:23:34 -07:00