StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Fix if statement for checking error condition

Browse Source 
Example mentions that it handles error, and errors are commonly non-zero values.

Closes #970
This commit is contained in:
Vincas Dargis 2017-07-01 19:29:35 +03:00 committed by GitHub
parent 863dcae05e
commit 0b1b5bbac8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CppCoreGuidelines.md
View File

@ -1738,7 +1738,7 @@ If you can't use exceptions (e.g. because your code is full of old-style raw-poi
int val;
int error_code;
tie(val, error_code) = do_something();
if (error_code == 0) {
if (error_code) {
// ... handle the error or exit ...
}
// ... use val ...
@ -1747,7 +1747,7 @@ This style unfortunately leads to uninitialized variables.
A facility [structured bindings](http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2016/p0144r1.pdf) to deal with that will become available in C++17.
auto [val, error_code] = do_something();
if (error_code == 0) {
if (error_code) {
// ... handle the error or exit ...
}
// ... use val ...