hsutter
63316bc0dc
Corrected F.54, part 2
2016-01-12 12:04:32 -08:00
hsutter
b97f67cd60
Corrected F.54 example
2016-01-12 12:02:59 -08:00
Titus Winters
20ed3d12fd
Editorial changes for PER, CP, E, and T.
2016-01-12 13:28:08 -05:00
hsutter
7ae6ad4eb7
Completed and corrected Meyers book references
2016-01-11 13:59:02 -08:00
hsutter
3668c8c491
Added F.54 to never capture this implicitly
2016-01-11 11:00:27 -08:00
Jeremy Voorhis
dd683abae7
Fix typographical error (variable name) in example for C.30.
2016-01-10 19:47:36 -08:00
hsutter
935a5ee325
Closed #485 .
2016-01-07 07:17:14 -08:00
hsutter
e4f908093d
Closed #484 .
2016-01-07 07:14:12 -08:00
Dima
2d9c0582ad
Another minor grammar fix.
2016-01-06 23:23:30 -08:00
Dima
7ae316c605
Minor grammar fix.
2016-01-06 23:20:52 -08:00
Dima
6a39167b86
Declaring one name per declaration.
2016-01-06 22:31:13 -08:00
Titus Winters
d653d5e89c
(Hopefully) editorial cleanup for Sec ES.
2016-01-06 14:44:01 -05:00
hsutter
46f38a7917
Closed #388 .
2016-01-01 10:48:34 -08:00
hsutter
2bea1b9d30
Closed #442 .
2015-12-31 17:18:35 -08:00
hsutter
8758eabcbf
Folded duplicate C.6 into Con.2 and addressed PR #438 .
2015-12-29 11:25:08 -08:00
hsutter
7cd72691e8
Improved R.3 note wording to help address PR #417 .
2015-12-29 11:15:04 -08:00
hsutter
13c8df9abc
Applied suggestion in PR #414 .
2015-12-29 11:07:37 -08:00
hsutter
41751f548c
Merge pull request #409 from agrygorenko/F-27-patch
...
F.27: Example fix
2015-12-29 13:57:07 -05:00
hsutter
47a1405707
Applied suggestion in PR #343 .
2015-12-29 10:46:58 -08:00
hsutter
f013c1b22d
Applied suggestion in PR #298 .
2015-12-29 10:39:36 -08:00
hsutter
3586cf7d0e
Applied suggestion in PR #273 .
2015-12-29 10:35:29 -08:00
hsutter
6c47693b58
Applied suggestion in PR #268 .
2015-12-29 10:28:57 -08:00
hsutter
50e89327bb
Applied the suggestion in PR #238 .
2015-12-29 10:25:42 -08:00
hsutter
12dd788e1d
Applied suggestion in PR #213 .
2015-12-29 10:23:47 -08:00
hsutter
4b15a57f96
Applied the suggestion in PR #198 .
2015-12-29 10:21:05 -08:00
hsutter
10d1d9dbc5
Addressed PR #140 .
2015-12-29 10:15:43 -08:00
hsutter
c9e015ce1f
Addressed PR 52.
2015-12-29 09:29:06 -08:00
hsutter
9c2aba298c
Closed #436 .
2015-12-28 10:49:07 -08:00
hsutter
c6891262a7
Tweaked PR #481 .
2015-12-28 10:20:58 -08:00
Andrew Pardoe
3f99f673d4
Wording in Intro and Philosophy
2015-12-28 12:41:37 -05:00
Gabriel Dos Reis
9b9a71bf18
Merge pull request #439 from mpark/P1
...
P.1: Minor fixes to the examples.
2015-12-26 00:10:54 -08:00
hsutter
7d99f7605a
Closed #478 .
2015-12-24 10:47:18 -08:00
hsutter
238ffceb62
Closed #477.'
2015-12-23 11:38:26 -08:00
hsutter
dc5cb14536
Closed #294 .
2015-12-23 11:32:46 -08:00
hsutter
2d8377aab5
Closes #133 .
2015-12-23 10:46:19 -08:00
Michael Park
a26d6c98d5
P.1: Fixed incorrect use of std::find
.
2015-12-22 21:34:36 -05:00
Michael Park
3b29134985
P.1: The index result of a std::find
-like loop needs to be initialized to -1.
2015-12-22 21:34:36 -05:00
hsutter
21b28d91ef
Merge pull request #465 from tituswinters/f.6
...
Clarify f.6 note on noexcept and allocation
2015-12-22 19:43:38 -05:00
hsutter
d5cbcd23ec
Merge pull request #472 from Alexolut/patch-7
...
fixed typos
2015-12-22 19:41:30 -05:00
hsutter
a1f7cdfc6e
Merge pull request #473 from mpark/C.61
...
C.61: Fixed example to use `new[]` instead to allocate an array.
2015-12-22 19:39:37 -05:00
Sergey Zubkov
3f51ca23fa
typos s/insigth/insight s/reders/readers s/psource/source
2015-12-21 22:27:40 -05:00
Bjarne Stroustrup
c07d9189d7
C.167: Use an operator for an operation with its conventional meaning
...
issue #290
2015-12-21 20:25:52 -05:00
Bjarne Stroustrup
b1c907387f
ES.65 Don't slice
2015-12-21 19:59:47 -05:00
hsutter
afdaa1d110
Closed #437 .
2015-12-21 16:55:31 -08:00
hsutter
f0e29f0492
Closed #423 .
2015-12-21 16:50:36 -08:00
hsutter
9e0b9f435e
Closes #189 .
2015-12-21 16:38:42 -08:00
hsutter
9c93ba6c5f
Closed #108 .
2015-12-21 16:21:33 -08:00
hsutter
6156e95782
Closed #83 .
2015-12-21 16:18:38 -08:00
Michael Park
d78a1b81a0
C.61: Fixed example to use new[]
instead to allocate an array.
2015-12-21 13:01:55 -05:00
Bjarne Stroustrup
26fc14cc8a
operator&
...
C.166 Overload unary `&` only as part of a system of smart pointers and
references
2015-12-21 12:25:56 -05:00
Alexolut
a6051b2058
fixed typos
2015-12-19 12:43:36 +03:00
Gabriel Dos Reis
fac322ee67
Merge pull request #471 from mpark/C.40
...
C.40: Fixed a couple of typos.
2015-12-18 08:51:24 -08:00
Michael Park
8916eddfa5
C.40: Fixed a couple of typos.
2015-12-18 16:34:59 +00:00
Michael Park
d423e855b5
C.ctor: Fixed typo.
2015-12-18 16:23:27 +00:00
Gabriel Dos Reis
b1f33a48a2
Merge pull request #469 from mpark/C.37
...
C.37: Added a note about implicit declaration of `noexcept` for destructors
2015-12-18 08:14:14 -08:00
Michael Park
f90b15dd7a
C.37: Added a note about implicit declaration of noexcept
for destructors.
2015-12-18 16:05:22 +00:00
Michael Park
5f7432b131
C.36: Fixed a couple of typos.
2015-12-18 15:24:23 +00:00
uli
26e006b148
Section C.over was marked as a chapter.
...
The chapter on templates T was also abbreviated as TPG and TCP.
Anchor names corrected.
Rule T.26 was designated as T.27.
Missing ) added.
added missing references
The rules T.12 and T.13 were designated as T.14 and T.15 in the summary.
2015-12-17 12:38:59 +01:00
Michael Park
d1abdd220c
C.30: Fixed a typo in the example.
2015-12-17 01:58:43 +00:00
Gabriel Dos Reis
023d60ce8b
Merge pull request #463 from tituswinters/f.4
...
Don't mix future runtime customization constexpr.
2015-12-15 09:22:28 -08:00
Titus Winters
3918d16274
Revise according to GDRs suggestion in PR 463.
2015-12-15 12:08:22 -05:00
Titus Winters
6de4da0793
Clarify f.6 note on noexcept and allocation
...
The bigger picture issue of "What context is your code executing in?"
and "What type of code are the core guidelines addressing?" should be
handled separately with text in the overview.
2015-12-15 11:59:20 -05:00
Titus Winters
fea884184e
Blend new F.47 into existing text.
2015-12-15 11:48:04 -05:00
Titus Winters
7615d3076d
Add F.47 - Assignment operators return T&
...
As discussed in
https://github.com/isocpp/CppCoreGuidelines/issues/422
2015-12-15 11:43:58 -05:00
Titus Winters
60706af58d
Don't mix future runtime customization constexpr.
...
As discussed in https://github.com/isocpp/CppCoreGuidelines/issues/420
2015-12-15 11:30:04 -05:00
Alexolut
b831fedb4a
fixed typos
2015-12-15 12:06:19 +03:00
Andrew Pardoe
ef18df66e8
Update TOC in In.sec
2015-12-14 14:31:40 -08:00
Herb Sutter
0198926d53
Addressed issue #134
2015-12-14 14:44:43 -05:00
Andrew Pardoe
67f8609657
Merge pull request #458 from tkruse/fix-toc2
...
Fix item order in second Table of contents
2015-12-14 08:01:12 -08:00
Alexolut
c0a4d1a087
changed dot operator to arrow.
2015-12-14 14:58:27 +03:00
Thibault Kruse
24df4ed549
Fix item order in second Table of contents
2015-12-13 22:30:13 +01:00
Andrew Pardoe
1356a6d046
Fixed a comment that looks like a Liquid tag
2015-12-13 12:04:04 -08:00
Andrew Pardoe
73915ab827
Update date
2015-12-13 11:50:57 -08:00
Andrew Pardoe
d33cfd97dd
Merge PR 425
2015-12-13 11:32:45 -08:00
Michael Park
ba6c91c8fc
Swapped the order between F.50
and F.46
.
2015-12-13 16:51:07 +00:00
Gabriel Dos Reis
b43ff9b63c
Merge pull request #453 from mpark/tabs
...
Removed tabs as specified in `CONTRIBUTING.md`
2015-12-12 21:38:52 -08:00
Gabriel Dos Reis
b4260e6fa9
Fix data member names
...
Rename `fx` to `x`, `fy` to `y`, `fz` to `z`, and `fe` to `e` to match
names used in the narative and other member function.
Fix pull request #456 .
2015-12-12 21:36:11 -08:00
hsutter
782e070fcd
Merge pull request #451 from mpark/F.21
...
F.21: Fixed order of arguments to `make_tuple`.
2015-12-12 17:49:40 -08:00
hsutter
e7833ab1fe
Merge pull request #450 from mpark/F.19
...
F.19: `s/T&&/TP&&/`
2015-12-12 17:48:56 -08:00
hsutter
893d11e6f5
Fixed F.16 references to -consume
...
This replaces PR #452
2015-12-12 17:46:45 -08:00
hsutter
72143e71ab
Merge pull request #454 from mpark/F.27
...
F.27: Fixed typo `s/treads/threads/` in example.
2015-12-12 17:45:07 -08:00
Andrew Pardoe
2107d2852e
Revert "Add header for gh-pages rendering"
...
This reverts commit 294b2495f1
.
2015-12-12 15:06:42 -08:00
Andrew Pardoe
294b2495f1
Add header for gh-pages rendering
2015-12-12 14:56:27 -08:00
Michael Park
642cec4555
F.27: Fixed typo s/treads/threads/
in example.
2015-12-11 16:38:24 -05:00
unknown
704f6cc339
Add reference to s-const in index
2015-12-11 13:34:14 -08:00
Michael Park
06348247d9
Align comments that were aligned by tabs.
2015-12-11 16:27:30 -05:00
Michael Park
1a850815d3
Replaced all tab characters with 4 spaces.
2015-12-11 16:27:30 -05:00
Michael Park
9b61e8e324
F.21: Fixed order of arguments to make_tuple
.
2015-12-11 15:44:49 -05:00
Michael Park
33e24fb389
F.19: s/T&&/TP&&/
2015-12-11 15:29:43 -05:00
hsutter
b873f02285
Merge pull request #406 from Alexolut/patch-3
...
added spaces around operators.
2015-12-11 08:17:08 -08:00
hsutter
e28faccbf3
Merge pull request #426 from ascherer/fix-const-ness
...
Fix `const`-ness consistency.
2015-12-11 08:16:14 -08:00
hsutter
e1800948cb
Merge pull request #432 from pmalek/master
...
Small typo
2015-12-11 08:15:25 -08:00
hsutter
e93771fdd4
Merge pull request #435 from Alexolut/patch-4
...
Fixed typos, made names consistent.
2015-12-11 08:14:53 -08:00
hsutter
e7756aa5f2
Merge pull request #441 from mpark/P3
...
P.3: Fixed an inaccurate description of `for (const auto& x : v)`.
2015-12-11 08:12:59 -08:00
hsutter
9955c0702f
Merge pull request #448 from mpark/rule
...
Consistently replaced `Rule S.N` with a more widely used `S.N`.
2015-12-11 08:11:36 -08:00
Kristoffel Pirard
d314de001b
[fix] typo
2015-12-11 15:25:43 +01:00
Gabriel Dos Reis
1a2609391b
Merge pull request #447 from mpark/F.4
...
F.4: Fixed a trivial style issue.
2015-12-11 06:14:52 -08:00
Michael Park
4de7d427c2
Consistently replaced Rule S.N
with a more widely used S.N
.
2015-12-11 09:04:36 -05:00
Michael Park
3c33b1f925
F.4: Fixed a trivial style issue.
2015-12-11 08:29:28 -05:00
Michael Park
e1d61e4655
I.25: Marked center
and draw
as const
.
2015-12-11 08:10:37 -05:00
Michael Park
6e39add6a6
P.3: Fixed an inaccurate description of for (const auto& x : v)
.
2015-12-11 02:14:57 -05:00
hsutter
ccacbd6d54
Closes #440
2015-12-10 22:41:19 -08:00
Michael Park
b8b88bf4ec
NL.5: Fixed typo s/typename/template/
.
2015-12-10 17:29:43 -05:00
hsutter
b4a0bd4310
Update date
2015-12-09 19:27:48 -08:00
Alexolut
58eef51608
Fixed typos, made names consistent.
2015-12-09 17:47:48 +03:00
hsutter
f07be3e8fb
Fixed typo in T.81 - issue #434
2015-12-08 07:33:28 -08:00
Andreas Scherer
08b9149086
Fix const
-ness consistency.
...
The majority of `const`-ness have the code-word joined with a hyphen to
its 'ness'. Make two slightly different versions consistent with this.
2015-12-08 09:20:47 +01:00
Sergey Zubkov
bc3d47768a
typs: s/literated/littered s/likelyhood/likelihood
2015-12-07 22:21:36 -05:00
Bjarne Stroustrup
729db042f1
clarification of F.42
2015-12-05 21:25:46 -05:00
Bjarne Stroustrup
518304ed63
ES.33: another warning against macros
2015-12-05 18:33:36 -05:00
Patryk Małek
7c68566196
Small typo
2015-12-05 20:50:08 +01:00
Rob Adams
a013348a7e
Calling delete on a FILE* created with fopen is ill-advised. Uses a
...
custom deleter.
2015-12-04 16:24:41 -08:00
Gabriel Dos Reis
ed59160a47
Merge pull request #430 from ascherer/fix-note-on-ranges
...
Fix note on ranges.
2015-12-04 05:31:22 -08:00
Gabriel Dos Reis
e7f76036f2
Merge pull request #429 from ascherer/consistent-enforcement
...
Consistent Enforcement paragraphs.
2015-12-04 05:30:44 -08:00
Gabriel Dos Reis
ef03d8b700
Merge pull request #428 from ascherer/typeset-NaN
...
Consistent formatting of 'NaN'.
2015-12-04 05:30:00 -08:00
Andreas Scherer
9ca047b49e
Fix note on ranges.
2015-12-04 11:12:52 +01:00
Andreas Scherer
37071453cb
Consistent Enforcement paragraphs.
2015-12-04 11:08:16 +01:00
Andreas Scherer
5067b9789a
Consistent formatting of 'NaN'.
2015-12-04 11:01:57 +01:00
Andreas Scherer
10aea497d7
Validate rendered HTML.
...
Replace 'illegal' characters in `<a>`nchors with more neutral items.
The Markdown code is put through `pandoc -s --smart ...`
and the resulting HTML is positively tested by the
[W3C validator](https://validator.w3.org/#validate_by_upload ).
2015-12-04 10:55:49 +01:00
hsutter
87e3e47da7
Slightly better text for previous commit
2015-12-03 06:26:11 -08:00
hsutter
3fa4b5623b
Added xref to Rf-out per issue #390
2015-12-03 06:24:22 -08:00
hsutter
936d321266
Extended Type.8 enforcement per issue #348
2015-12-02 12:46:44 -08:00
hsutter
b16ef02365
Extended Sd-factory example per issue #310
2015-12-02 12:42:04 -08:00
hsutter
7e81a238e0
Updated Bounds.4 as suggested in issue #267
2015-12-02 12:36:23 -08:00
hsutter
d81adf4a8e
Added guidance to make function objects cheap to copy and pass by value
2015-12-02 12:31:03 -08:00
hsutter
fe7a9dfe48
Expanded F.19 enforcement to forward exactly once (issue 128)
2015-12-02 12:28:20 -08:00
hsutter
247be64de6
Fixed invoke() example to not forward the functor, to reflect other discussion
2015-12-02 12:25:58 -08:00
hsutter
ac773e44d4
Updated R.3 to refer to #Rf-out
2015-12-02 12:18:18 -08:00
hsutter
ceaddf311e
Added comments to P.6 to address Issue 9
2015-12-02 12:12:49 -08:00
hsutter
866df49181
Manually merged PR 145 for C.150 improvement
2015-12-02 12:07:43 -08:00
hsutter
19ee5fc18f
Added suppression syntax note
2015-12-02 12:05:27 -08:00
hsutter
ec9065bdfb
Updated C.134 to call out const and add more rationale (issue 302)
2015-12-02 12:01:40 -08:00
hsutter
fbd4acd526
Added enforcement to not move from & parameters (issue 316)
2015-12-02 11:46:22 -08:00
hsutter
c101fc7ac4
Updated C.35 to address Issue 375
2015-12-02 11:25:32 -08:00
hsutter
4a9e41d766
Added smartptrconcepts as link to Lifetime paper (Issue 407)
2015-12-02 11:14:24 -08:00
hsutter
49afa391e5
Added F.18 body and clarification from issue 398
2015-12-02 11:07:46 -08:00
Titus Winters
41eb8f28e7
Identifiers in enum class can overlap.
...
Reverting Capitalization of Red/Purple/Blue in enum class example.
2015-12-01 15:23:06 -05:00
hsutter
6228e99a51
Separated F.15 into F.15-21: in, inout, consume, forward, out, multi-out
2015-12-01 09:07:52 -08:00
hsutter
08b83eaea0
Renumbered F.16-19 -> F.22-25
...
For better topical grouping and to make room to break up F.15 into
smaller items
2015-12-01 08:33:42 -08:00
hsutter
1922e46ac7
Merged F.40 into F.15 (issue #1
2015-12-01 08:25:56 -08:00
hsutter
9e7bd3d4c4
Merged F.25 into F.15 (issue #1 )
2015-12-01 08:08:10 -08:00
hsutter
89bf79e00c
Merged F.24 into F.15 (issue #1 )
2015-12-01 08:04:50 -08:00
hsutter
7d3ff3c0b1
Merged F.23 into F.15 (issue #1 )
2015-12-01 07:58:37 -08:00
hsutter
59eacc8aad
Merged F.22 into F.15 (issue #1 )
2015-12-01 07:54:46 -08:00
hsutter
7fb7db3f0d
Merged F.21 into F.15 (issue #1 )
2015-12-01 07:48:46 -08:00
hsutter
65dc9e9c37
Merged F.20 into F.15 (issue #1 )
2015-12-01 07:42:11 -08:00
Andriy Grygorenko
5990abead1
F.27: Example fix
...
It is usually a bad idea to share mutable objects between threads, which leads to a race condition or unnecessary thread contention.,
2015-11-27 20:19:32 -05:00
Eliyahu Ravuna
282a11de26
The vector was missing template arguments. Fixed
...
Thank you for the feedback in #402 .
char replaced with uint8_t.
2015-11-27 08:10:16 +02:00
Alexolut
76824f8d1d
added spaces around operators.
2015-11-26 17:02:28 +03:00
Alexolut
e238597f6c
fixed a typos because of zero-based indexing
...
Another misunderstanding: how container can be modified (side-effect in a call of `f(&v[i])` ) if we passing only an address to element, not a address to container?
2015-11-25 11:19:08 +03:00