mirror of
https://github.com/isocpp/CppCoreGuidelines.git
synced 2024-03-22 13:30:58 +08:00
T.40 typo: find
to find_if
`std::find` accepts a value, not a function object. `std::find_if` was the intended function.
This commit is contained in:
parent
1ad595e1a6
commit
7112881429
|
@ -9058,9 +9058,9 @@ In general, passing function objects give better performance than passing pointe
|
||||||
sort(v, greater<>); // function object
|
sort(v, greater<>); // function object
|
||||||
|
|
||||||
bool greater_than_7(double x) { return x>7; }
|
bool greater_than_7(double x) { return x>7; }
|
||||||
auto x = find(v, greater_than_7); // pointer to function: inflexible
|
auto x = find_if(v, greater_than_7); // pointer to function: inflexible
|
||||||
auto y = find(v, [](double x) { return x>7; }); // function object: carries the needed data
|
auto y = find_if(v, [](double x) { return x>7; }); // function object: carries the needed data
|
||||||
auto y = find(v, Greater_than<double>(7)); // function object: carries the needed data
|
auto y = find_if(v, Greater_than<double>(7)); // function object: carries the needed data
|
||||||
|
|
||||||
??? these lambdas are crying out for auto parameters -- any objection to making the change?
|
??? these lambdas are crying out for auto parameters -- any objection to making the change?
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue
Block a user