StarMirror/CppCoreGuidelines
1
0
Fork 0
mirror of https://github.com/isocpp/CppCoreGuidelines.git synced 2024-03-22 13:30:58 +08:00
Code Issues Projects Releases Wiki Activity

Merge pull request #326 from ralphtandetzky/patch-1

Browse Source 
Fixed grammatical error.
This commit is contained in:
Gabriel Dos Reis 2015-10-13 09:08:18 -07:00
commit 57a5446625
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CppCoreGuidelines.md
View File

@ -9135,7 +9135,7 @@ A lot of people, myself included, like to experiment with `std::memory_order`, b
Even vendors mess this up: Microsoft had to fix their `shared_ptr` (weak refcount decrement wasn't synchronized-with the destructor, if I recall correctly, although it was only a problem on ARM, not Intel)
and everyone (gcc, clang, Microsoft, and intel) had to fix their `compare_exchange_*` this year, after an implementation bug caused losses to some finance company and they were kind enough to let the community know.
It should definitely mention that `volatile` does not provide atomicity, does not synchronize between threads, and does not prevent instruction reordering (neither compiler nor hardware), and simply has nothing to do with concurrency.
It should definitely be mentioned that `volatile` does not provide atomicity, does not synchronize between threads, and does not prevent instruction reordering (neither compiler nor hardware), and simply has nothing to do with concurrency.
if (source->pool != YARROW_FAST_POOL && source->pool != YARROW_SLOW_POOL) {
THROW(YARROW_BAD_SOURCE);