From 81635bad4e3bd251f16a173d82a12bc152fb24fc Mon Sep 17 00:00:00 2001 From: Ralph Tandetzky Date: Tue, 13 Oct 2015 15:01:47 +0200 Subject: [PATCH] Fixed grammatical error. --- CppCoreGuidelines.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CppCoreGuidelines.md b/CppCoreGuidelines.md index 1cdd7c6..72008cd 100644 --- a/CppCoreGuidelines.md +++ b/CppCoreGuidelines.md @@ -9136,7 +9136,7 @@ A lot of people, myself included, like to experiment with `std::memory_order`, b Even vendors mess this up: Microsoft had to fix their `shared_ptr` (weak refcount decrement wasn't synchronized-with the destructor, if I recall correctly, although it was only a problem on ARM, not Intel) and everyone (gcc, clang, Microsoft, and intel) had to fix their `compare_exchange_*` this year, after an implementation bug caused losses to some finance company and they were kind enough to let the community know. -It should definitely mention that `volatile` does not provide atomicity, does not synchronize between threads, and does not prevent instruction reordering (neither compiler nor hardware), and simply has nothing to do with concurrency. +It should definitely be mentioned that `volatile` does not provide atomicity, does not synchronize between threads, and does not prevent instruction reordering (neither compiler nor hardware), and simply has nothing to do with concurrency. if (source->pool != YARROW_FAST_POOL && source->pool != YARROW_SLOW_POOL) { THROW(YARROW_BAD_SOURCE);