Crzyrndm
c3296db932
Revert "Another easy 15-20% by not searching with no references"
...
This reverts commit 3ae31fadc3
2018-07-30 07:22:45 +12:00
Crzyrndm
544e90c975
fix spectacular typo
...
- Using rgba for comparison is still faster, but it does help correctness when you compare two different instances
2018-07-30 07:07:32 +12:00
Crzyrndm
3ae31fadc3
Another easy 15-20% by not searching with no references
2018-07-29 23:28:02 +12:00
Crzyrndm
e6a84c0cf0
Optimise modifying a new format to reduce garbage collection runs
2018-07-29 22:10:56 +12:00
Crzyrndm
b4f695b3ea
fixing warnings
2018-07-29 17:33:22 +12:00
Crzyrndm
5a5db1a50b
use std::find and don't double iterate the list
...
- ~5% perf improvement in img2xlsx example
2018-07-29 16:48:18 +12:00
Crzyrndm
f64dbc00c4
string compare is slow, use rgba member instead
2018-07-29 16:24:09 +12:00
Crzyrndm
dd6f338419
Remove memory growth based on row count
...
- Nested unordered_map was the cause of a significant memory/cell spike.
- added cell_reference hash, lookup by cell_reference to make memory usage proportional to cell count only
2018-07-29 11:43:23 +12:00
Crzyrndm
138c90883b
Modify writer benchmark to make comparisons between column and row usage
...
- Cut time to write a sheet with many rows by not calling highest_row inside a loop over the rows (On^2 -> On)
- Observation: more memory is used / cell as the number of rows increases
2018-07-29 10:11:00 +12:00
Crzyrndm
d93e470a52
Suppress GCC maybe-uninitialized warning
...
Signal to noise ratio is very high, and the #pragma suppressions for optional aren't working for GCC8
2018-07-28 14:54:49 +12:00
Thomas Fussell
94faf01b72
Merge pull request #320 from sukoi26/SheetFormatPr
...
SheetformatPr issue #287
2018-07-24 23:42:51 -04:00
Thomas Fussell
8f39375f4c
revert unwise data structure change
2018-07-24 23:08:44 -04:00
Thomas Fussell
cbe50f4681
Fix some issues after merge
2018-07-23 00:13:20 -04:00
Thomas Fussell
0af7ad88e1
Merge branch 'tasmail-master-shared-strings-performance' into dev
...
remove less than comparators
fix conflicts
2018-07-23 00:10:16 -04:00
sukoi26
8f4248d9c3
change SheetFormatPr
...
change "defaultRowHeight" not optional
2018-07-22 18:44:31 +02:00
Crzyrndm
6562c41ae1
fix typo in Cmake lists
2018-07-21 12:38:33 +12:00
Crzyrndm
fede2d3168
fix Clang CI warnings
2018-07-21 12:33:58 +12:00
Crzyrndm
ad24d9485d
Resolve CI warning about using an uninitialised variable
2018-07-21 12:19:15 +12:00
Crzyrndm
761eee3e5f
Merge pull request #314 from Crzyrndm/dev-CI-build-modifications-PR
...
Travis CI improvements
Resolves #147
2018-07-21 12:04:56 +12:00
Crzyrndm
4dae88f004
Merge pull request #311 from Crzyrndm/dev-unimplemented-functions-PR
...
Implementations for unimplemented functions
2018-07-21 11:31:25 +12:00
Crzyrndm
f035b9041e
Merge pull request #310 from Crzyrndm/dev-reorder-wb-relations-PR
...
Resolves #279
2018-07-21 11:13:05 +12:00
sukoi26
a2dc4a34f1
update bestFit commit
...
error compiling std::vector<std::string>
2018-07-19 13:53:54 +02:00
sukoi26
4f9e8ab37f
bestFit change
...
remove from skip_attributes list
2018-07-19 12:49:32 +02:00
Crzyrndm
0aee6fd9b1
Cleanup some cmake modifications
2018-07-16 19:41:40 +12:00
Crzyrndm
ad759ae4f7
fix for build failure with GCC8{-std=c++17}
2018-07-16 19:08:19 +12:00
Crzyrndm
b9b47672ea
cxx_std_14 and co aren't available until cmake v3.8
2018-07-16 18:52:21 +12:00
Crzyrndm
5671167d1d
add cmake option XLNT_CXX_LANG to set the targetted cxx standard
...
- valid options are 11, 14, and 17
- default is 14
- cmake will error if an invalid value is provided
- requires cmake >= 3.10.* to take effect in visual studio
2018-07-15 21:23:22 +12:00
Crzyrndm
25d75cb5c3
complete the compiler set (gcc 6/7/8 + clang 4/5/6)
2018-07-14 21:27:54 +12:00
Crzyrndm
11573f45e6
Resolve remaining warnings
2018-07-14 20:25:10 +12:00
Crzyrndm
9a33210144
Resolve warnings about global ctors and an unused variable
...
-- while unlikely to become an issue, ordering of ctors across source files is undefined and debugging issues related to it is not easy so just avoid that issue
2018-07-14 19:54:31 +12:00
Crzyrndm
d4cc538faf
remove -Werror from clang build to allow CI to run through
...
-- fixing CI warnings 1 at a time would be a complete waste of time
-- blacklist some of the overkill warnings
2018-07-14 19:02:12 +12:00
Crzyrndm
ddab6551b0
Add tests for functionality added to implement declared functionality
2018-07-13 17:14:07 +12:00
Crzyrndm
03020cc793
improved hyperlink implementation
...
- hyperlinks to cells and ranges are complete
- hyperlink::display is now set as well as the cell value (in excel these can be different)
-- if a cell is empty, display is equal to value text
-- if a cell has a value, display can be just about anything
- This version copies excel in that display is completely ignored once value is set
- All hyperlink tests are now part of the cell test suite (not the worksheet test suite which the majority were previously located)
2018-07-13 17:14:07 +12:00
Crzyrndm
054f509f7a
fix missing return statement
2018-07-13 17:14:06 +12:00
Crzyrndm
1390d6a76e
unimplemented functions in range and path
2018-07-13 17:14:06 +12:00
Crzyrndm
3d9e887d4a
unimplemented functions under utils/
2018-07-13 17:14:05 +12:00
Crzyrndm
95ca51e5c8
unimplemented functions under styles/
2018-07-13 17:14:05 +12:00
Crzyrndm
49c4e725dc
All unimplemented functions under cell/
2018-07-13 17:14:05 +12:00
Crzyrndm
0d1bca3fd4
Remove hidden dependency on unordered map extraction order
...
Issue #279
2018-07-13 12:43:21 +12:00
Crzyrndm
7458426111
return by const ref
2018-07-13 12:43:21 +12:00
Crzyrndm
53c193433f
Ensure worksheets get a unique internal filename
...
Issue #279
2018-07-13 12:43:20 +12:00
Crzyrndm
dcf50cb4cd
return by const reference when possible
2018-07-13 12:43:20 +12:00
Crzyrndm
cf8991a234
no need to recreate the uri
2018-07-13 12:43:19 +12:00
Crzyrndm
322490b397
re-write workbook::reorder_relationships
...
Issue #279
2018-07-13 12:43:19 +12:00
Crzyrndm
1ab25fa7fc
Merge branch 'dev' into dev-Issue298
2018-07-13 11:21:13 +12:00
Crzyrndm
7160b7494d
Merge pull request #305 from Crzyrndm/dev-iterator-improvements-2
...
Remove uses of std::iterator (deprecated in C++17) + improvements
2018-07-13 11:14:19 +12:00
sukoi26
28a71572cf
update #290
...
suggested by Crzyrndm
2018-07-10 09:32:34 +02:00
Crzyrndm
399b5e3775
Resolve CI build failure
2018-07-10 14:43:22 +12:00
Crzyrndm
b95919323d
add more tests for worksheet iterator, add operator--
...
* operator-- completes the naive bidirectional iterator requirements
* tests for various construction and assignment behaviours
* tests for iteration and dereferencing behaviours
2018-07-10 12:40:56 +12:00
Crzyrndm
04b50d9b8e
worksheet_iterator - operator* const overloads
...
Users may still want to dereference a const iterator (note: not a const_iterator).
Also use the "reference" typedef to ensure there is only 1 source of information
2018-07-10 12:40:54 +12:00
