Commit Graph

1674 Commits

Author SHA1 Message Date
Thomas Fussell
c89c4d951a
Merge pull request #493 from adamhooper/issue-492-stream-empty-row
Streaming: skip empty rows in has_cell()/read_cell()
2021-01-02 12:36:10 -05:00
Thomas Fussell
ac771ac7e7 translate travis to circleci 2021-01-02 12:32:51 -05:00
Thomas Fussell
3127e9c016
Merge branch 'master' into issue-492-stream-empty-row 2021-01-02 10:46:19 -05:00
Thomas Fussell
a96c288036 fix time struct warning on gcc 2021-01-02 10:42:21 -05:00
Emmanuel Pescosta
3225f357dd
workbook: Throw if index in (const) sheet_by_index is out of range
The documentation of (const) sheet_by_index already mentions that
invalid_parameter exception will be thrown if the index is out of
range, but the implementation was missing.
2020-12-02 11:06:56 +01:00
Emmanuel Pescosta
9df7c83ca6
worksheet: Add method to check if the worksheet is empty
A worksheet is considered empty if it doesn't have any cells.
2020-12-02 10:59:29 +01:00
kira
687af90735 Memory leaks fix 2020-11-20 15:24:47 +03:00
dependabot[bot]
a50ec35ded
Bump node-fetch from 2.6.0 to 2.6.1
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-12 17:12:09 +00:00
胡剑波
e9a9946856 Fixed multiple cell throw exception. 2020-08-25 19:57:07 +08:00
胡剑波
dc9f550429 Fix the missing count of fonts and throw an exception. 2020-08-25 16:40:33 +08:00
胡剑波
e8dd38d0d6 Fix throwing exception when duplicate shared strings occur. 2020-08-25 15:08:20 +08:00
胡剑波
dafdfa3ebb Add the function of getting table hidden attributes. 2020-08-25 13:32:21 +08:00
胡剑波
0ecad78c1d Fixed an exception thrown when parsing external links. 2020-08-25 09:00:22 +08:00
Thomas Fussell
3c7122a78c
Merge pull request #490 from 50ty/patch-2
Fix XLNT_INCLUDE_INSTALL_DIR
2020-08-20 14:59:22 -04:00
胡剑波
4da7183b1c Fixed an exception that was thrown when the namespace in the external link is a web address. 2020-08-12 16:36:30 +08:00
Adam Hooper
319c4197c1
Streaming: skip empty rows in has_cell()/read_cell()
Previously, an empty row would mess with the parser: if we're in an
empty row, our helper methods don't detect us as being in the "row" _or_
in the "sheetData". So `has_cell()` would return false when it
shouldn't. Similarly, `read_cell()` wouldn't skip rows; so `read_cell()`
would return an invalid cell when placed in an empty row, causing a
segfault when the caller tried to use the cell.

Callers must take care to call `has_next()` before `read_next()`. In
the future, perhaps we can make `read_next()` return a `std::optional`
and nix `has_next()` altogether?

[Closes #492]
2020-07-28 15:29:12 -04:00
Stefan Rommel
cdb50bbd6b
Fix XLNT_INCLUDE_INSTALL_DIR
Otherwise, XLNT_INCLUDE_INSTALL_DIR is not set correctly and find_package(Xlnt) results to an error:
 ```
CMake Error at /usr/lib64/cmake/xlnt/XlntConfig.cmake:23 (message):
  File or directory include referenced by variable XLNT_INCLUDE_DIR does not
  exist !
Call Stack (most recent call first):
  /usr/lib64/cmake/xlnt/XlntConfig.cmake:41 (set_and_check)
  CMakeLists.txt:4 (find_package)
```
The content of the line 41 of /usr/lib64/cmake/xlnt/XlntConfig.cmake is: `set_and_check(XLNT_INCLUDE_DIR "include")`. 

I'm using the Arch Linux user repository package https://aur.archlinux.org/packages/xlnt/.
The used build manual is described here: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=xlnt.
2020-07-16 21:29:06 +02:00
Thomas Fussell
8d2a8e161b
Merge pull request #467 from Crzyrndm/experimental/serialisation
locale aware double->string conversions
2020-06-08 19:40:08 -04:00
JCrawfy
06801f7d36 derp, need typename too 2020-04-26 15:54:49 +12:00
JCrawfy
6c5a5a5dae and same issue with is_convertible 2020-04-26 15:49:05 +12:00
JCrawfy
f1042c5119 enable_if_t isn't a thing in C++11 2020-04-26 15:47:53 +12:00
JCrawfy
504fed3585 another missing header 2020-04-26 15:40:56 +12:00
JCrawfy
9d9d5de511 add missing include 2020-04-26 15:27:51 +12:00
JCrawfy
556d3358e9 fix bad commit 2020-04-26 14:53:15 +12:00
JCrawfy
d30e705f83 fix most (all?) the places where string<->double conversions are performed
strod / stod / to_string and all related friends are dependant on current locale for how they format a number
2020-04-25 14:00:58 +12:00
JCrawfy
dfb8f1518e Revert "redo serialisation by using a sorted vector instead of a lookup for each possible row/column combination"
This reverts commit 63484f8b8f.
2020-04-25 11:15:23 +12:00
JCrawfy
63484f8b8f redo serialisation by using a sorted vector instead of a lookup for each possible row/column combination
Not tested, definitely not as correct as previous implementation
2020-04-25 11:00:39 +12:00
JCrawfy
9136d21845 move the simplified cell_reference and cell structs out to a header
the standard xlnt::cell and xlnt::cell_reference have plenty of extra functionality that just slows things down during (de)serialisation
These intermediate structs can be used to minimise overhead before transforming to the final type
2020-04-25 11:00:39 +12:00
JCrawfy
1069c17fbe fixup comment in parser 2020-04-25 11:00:39 +12:00
JCrawfy
e8e29e9c18 resolve some warnings (unintialised variables), remove warning suppression 2020-04-25 11:00:39 +12:00
Thomas Fussell
d1d9553d4e
Merge pull request #454 from Tectu/master
Remove superfluous semicolon
2020-03-25 14:16:20 -04:00
Joel Bodenmann
4e0333ac91 Remove superfluous semicolon 2020-03-25 13:16:02 +01:00
Thomas Fussell
568ac85346
release v1.5.0 2020-03-21 15:19:37 -04:00
Thomas Fussell
05fb0ceaf6
revert version bump 2020-03-21 15:18:59 -04:00
Thomas Fussell
80b94549a7
edit version bump path 2020-03-21 15:16:20 -04:00
Thomas Fussell
7c0d64248c
move release files to root for now 2020-03-21 15:15:32 -04:00
Thomas Fussell
b118d8f1f2
bump version to 1.5.0 2020-03-21 15:13:22 -04:00
Thomas Fussell
7e1e8cb1a1
release v1.5.0 2020-03-21 14:58:12 -04:00
Thomas Fussell
c3a1f1da95
fix release name 2020-03-21 14:57:06 -04:00
Thomas Fussell
0f178e46c8
fix release title 2020-03-21 14:52:26 -04:00
Thomas Fussell
138fb967bc
improve consistency with previous releases 2020-03-21 14:49:58 -04:00
Thomas Fussell
0a2a618663
Merge pull request #452 from tfussell/automate-releases
Automate releases
2020-03-21 14:40:49 -04:00
Thomas Fussell
a07c8c0c10
flesh out package.json [ci skip] 2020-03-21 14:39:22 -04:00
Thomas Fussell
8e451f24e3
empty commit [ci skip] 2020-03-21 14:36:57 -04:00
Thomas Fussell
92577d6cac
update github deploy token 2020-03-21 14:36:45 -04:00
Thomas Fussell
5602edbd2d
add packaging and release deployment workflow 2020-03-21 14:25:39 -04:00
Thomas Fussell
9a18cd9fcd
disable npm 2020-03-21 11:02:03 -04:00
Thomas Fussell
252dd76616
initial implementation 2020-03-21 10:59:00 -04:00
Thomas Fussell
2f5934f60e
Merge pull request #447 from Crzyrndm/feature/benchmark
microbenchmarks for double<->string conversion, serialisation improvements
2020-03-20 18:02:37 -04:00
Thomas Fussell
6c52e52487
Merge pull request #451 from amiremohamadi/fix-cell-reference-parsing
fix cell reference parsing
2020-03-20 16:16:40 -04:00