Commit Graph

1389 Commits

Author SHA1 Message Date
sukoi26
4f07495abb
optimize latest commit missing a test 2017-11-06 14:12:08 +01:00
TataMata
6b668fd04e
Fix for the "index out of bounds" exception while reading styles
There was a bug introduced in version 1.2 in reading styles. As from the Office Open XML documentation:
Every cell will have a reference to one <xf> in the <cellXfs> collection. This is direct formatting for the cell. To apply a style to the cell, the <xf> references the style using the xfId attribute. The xfId attribute is an index into the <cellStyleXFs> collection, which collects the cell styles available to the user. The <cellStyleXFs> contains one <xf> for each style. Each such <xf> is tied to its name via an index (in its xfId attribute) from the <cellStyles> collection. 
Existing implementation simply tried to fetch a style name by using index in the styles vector causing an index_out_of_range exception for each xfId that was ot of bounds of cellStyles collection. What was needed is to match the xfId attribute of the cellStyle element.
2017-11-06 12:00:51 +01:00
TataMata
b899c9db5c
Fix bug in cell style assingment
There was a bug introduced in version 1.2 in reading styles. As from the Office Open XML documentation:
2017-11-06 11:55:06 +01:00
sukoi26
caeadfc83c optimize code empty row cell 2017-11-04 23:41:48 +01:00
sukoi26
4a3e711a1b bug introduce by the commit continue work on #230, improves style/xf handling
as the style exist it is rewritten in cellStyleXfs and cellXfs,
with  the fillId test for format and style. remove the test and use only the format.
2017-11-04 18:12:38 +01:00
Aaron Bishop
0201f22237 fix const correctness error 2017-11-02 17:07:01 -04:00
Thomas Fussell
c4a2bb8c6d Revert "add row height and column width serialization tests"
This reverts commit dc4befd867.
2017-10-30 19:53:39 -04:00
Thomas Fussell
29abdfa702 Merge branch 'master' into dev 2017-10-30 19:44:32 -04:00
Thomas Fussell
5b8820d2cd
Merge pull request #240 from shamanas/master
Setting the height of a row now produces the expected result.
2017-10-30 19:41:05 -04:00
Thomas Fussell
470c655df6 fix empty row height/cell width, #235 2017-10-30 19:36:24 -04:00
Thomas Fussell
dc4befd867 add row height and column width serialization tests 2017-10-30 17:23:14 -04:00
Thomas Fussell
06b315b352 add interface to worksheet and range for clearing cells entirely, not just their values, for #232 2017-10-26 13:45:56 -04:00
Thomas Fussell
0e0bf0f8a1 continue work on #230, improves style/xf handling 2017-10-26 12:54:54 -04:00
Alexandros Naskos
7f08c77a90 Empty row properties are now written correctly. Setting a row's height now also causes customHeight to be emitted. 2017-10-25 15:04:51 +03:00
Thomas Fussell
0dcd56ebc9 (xlntpyarrow) check builder append return status and use double cell values instead of long double 2017-09-28 09:05:23 -04:00
Thomas Fussell
75de03745b start fixing serialization for #230 2017-09-28 08:55:16 -04:00
Thomas Fussell
34270f2333 specify return type of lambda to prevent compiler error 2017-09-27 17:39:59 -04:00
Thomas Fussell
e910666c56 include missing header in path_helper 2017-09-27 17:35:35 -04:00
Thomas Fussell
919c65ceea Merge pull request #229 from downwash/master
Fix for issue #228: Worksheet ID is not always unique
2017-09-27 17:32:40 -04:00
vervbe
c05b9f33c1 Fix for issue #228: Worksheet ID is not always unique
- Worksheet ID now generated from the maximum of existing IDs
- Worksheet ID no longer copied from existing sheet
- Added tests
2017-09-26 08:33:06 +02:00
Thomas Fussell
751599b44c add special case for numeric type cells with a date number format 2017-09-13 12:02:17 -04:00
Thomas Fussell
4c2c7a5859 add missing header for std::tolower 2017-09-13 11:03:18 -04:00
Thomas Fussell
b2adee9fd3 implement upper case date/time handling, closes #221, closes #222, related to #220 2017-09-13 10:47:18 -04:00
Thomas Fussell
a9b1e2af4a forgot to add new option for libstudxml too 2017-09-13 10:30:38 -04:00
Thomas Fussell
f27df9732c add option to enable linking with static C runtime when compiling with MSVC, #214 2017-09-13 10:20:51 -04:00
Thomas Fussell
81812d6e29 implement sheet view selection consumption, closes #164 2017-09-13 09:36:42 -04:00
Thomas Fussell
9d71dda531 ensure only exceptions derived from xlnt::exception are thrown by library code plus some minor code cleanup, closes #163 2017-09-13 08:48:22 -04:00
Thomas Fussell
bc1e3656c7 Merge branch 'master' into dev 2017-09-12 16:22:36 -04:00
Thomas Fussell
c214c6ca0b Merge pull request #225 from hrsantiago/master
Parse readingOrder
2017-09-12 16:21:04 -04:00
Henrique Santiago
ea5c741bfe Parse readingOrder 2017-09-12 17:04:52 -03:00
Thomas Fussell
985cfd28b4 swap readthedocs badge with gitbook badge [ci skip] 2017-09-10 09:45:06 -04:00
Thomas Fussell
954f4b84cd prevent exception on unhandled attributes 2017-09-10 09:36:53 -04:00
Thomas Fussell
bf3e278ea1 change two missed long double literals into doubles 2017-09-10 09:36:04 -04:00
Thomas Fussell
a21d659247 Merge pull request #218 from sukoi26/dev
Dev:  atttribut s optimize code
2017-09-08 23:16:01 -04:00
Thomas Fussell
299fc7d572 Merge branch 'dev' into dev 2017-09-08 23:15:06 -04:00
Thomas Fussell
94e19a6c70 Merge branch 'master' into dev 2017-09-08 23:10:05 -04:00
Thomas Fussell
b1aac2c863 Create CODE_OF_CONDUCT.md 2017-09-08 23:09:35 -04:00
Thomas Fussell
396e6eb948 fix clang warnings 2017-09-08 22:59:19 -04:00
Thomas Fussell
12007fe2d8 change cell numeric value type from long double to double, closes #201 2017-09-08 21:05:34 -04:00
Thomas Fussell
7d0cf59286 correct off-by-one error in range dimension calculation, closes #213 2017-09-08 20:47:10 -04:00
Thomas Fussell
0d125b1534 encapsulate stateful stringstream string to float conversion into a separate struct 2017-09-08 20:10:46 -04:00
Thomas Fussell
fcd68dba8f optimize cell memory usage. big improvement! 2017-09-08 19:41:34 -04:00
Thomas Fussell
716a81a19f optimize hot code paths 2017-09-08 19:08:38 -04:00
Thomas Fussell
bbdace8b44 use memoization to replace cached static qnames 2017-09-08 18:03:56 -04:00
Thomas Fussell
85010f9f11 memoize calls to xml::qname builder 2017-09-08 17:39:59 -04:00
Thomas Fussell
53d7dbb67e install generated man page 2017-09-08 17:07:25 -04:00
Thomas Fussell
b065cea22f Merge branch 'dev' of github.com:tfussell/xlnt into dev 2017-09-08 17:02:40 -04:00
Thomas Fussell
20d3a1dc98 generate man page from docs
generate man page from docs
2017-09-08 17:00:11 -04:00
Thomas Fussell
fff2feccd2 update licenses 2017-09-08 15:26:47 -04:00
Thomas Fussell
7ed14246b2 clean up cmake files and add d suffix to xlnt debug library, closes #214 2017-09-08 14:33:18 -04:00