diff --git a/source/cell/cell.cpp b/source/cell/cell.cpp index de6c6c8a..b2a4af9c 100644 --- a/source/cell/cell.cpp +++ b/source/cell/cell.cpp @@ -1032,7 +1032,7 @@ void cell::comment(const class comment &new_comment) // todo: make this cell_position.first += get_width() instead if (get_worksheet().has_column_properties(get_column())) { - cell_position.first += get_worksheet().get_column_properties(get_column()).width; + cell_position.first += static_cast(get_worksheet().get_column_properties(get_column()).width); } else { diff --git a/source/detail/xlsx_consumer.cpp b/source/detail/xlsx_consumer.cpp index d79ab1f1..61ce2dba 100644 --- a/source/detail/xlsx_consumer.cpp +++ b/source/detail/xlsx_consumer.cpp @@ -792,26 +792,11 @@ void xlsx_consumer::read_workbook() } } - if (parser().attribute_present("defaultThemeVersion")) - { - parser().attribute("defaultThemeVersion"); - } - - // todo: turn these structures into a method like skip_attribute(string name, bool optional) - if (parser().attribute_present("backupFile")) - { - parser().attribute("backupFile"); - } - - if (parser().attribute_present("showObjects")) - { - parser().attribute("showObjects"); - } - - if (parser().attribute_present("filterPrivacy")) - { - parser().attribute("filterPrivacy"); - } + skip_attribute("codeName"); + skip_attribute("defaultThemeVersion"); + skip_attribute("backupFile"); + skip_attribute("showObjects"); + skip_attribute("filterPrivacy"); parser().next_expect(xml::parser::event_type::end_element, xmlns, "workbookPr"); } @@ -2403,5 +2388,13 @@ void xlsx_consumer::read_block(const std::unordered_map &rel_chain); + void skip_attribute(const std::string &name); + /// /// The ZIP file containing the files that make up the OOXML package. /// diff --git a/source/workbook/workbook.cpp b/source/workbook/workbook.cpp index 218c1c03..e97e62b9 100644 --- a/source/workbook/workbook.cpp +++ b/source/workbook/workbook.cpp @@ -28,7 +28,7 @@ #include #include -#ifdef WIN32 +#ifdef _MSC_VER #include // utf-8 -> utf-16 conversion #endif diff --git a/third-party/botan b/third-party/botan index 923a95d5..523b2a4c 160000 --- a/third-party/botan +++ b/third-party/botan @@ -1 +1 @@ -Subproject commit 923a95d546df5b6d31f39b0af900d0361fb2e6a6 +Subproject commit 523b2a4ca48fa5cf04ea371aabe7167ce2e5cd13