mirror of
https://github.com/irungentoo/toxcore.git
synced 2024-03-22 13:30:51 +08:00
ad26560516
- Any non-externally-visible declarations should be `static`. - Casting away the `const` qualifier from pointers-to-const is dangerous. All but one instance of this are now correct. The one instance where we can't keep `const` is one where toxav code actually writes to a chunk of memory marked as `const`. This code also assumes 4 byte alignment of data packets. I don't know whether that is a valid assumption, but it's likely unportable, and *not* obviously correct. - Replaced empty parameter lists with `(void)` to avoid passing parameters to it. Empty parameter lists are old style declarations for unknown number and type of arguments. - Commented out (as `#if DHT_HARDENING` block) the hardening code that was never executed. - Minor style fix: don't use `default` in enum-switches unless the number of enumerators in the default case is very large. In this case, it was 2, so we want to list them both explicitly to be warned about missing one if we add one in the future. - Removed the only two function declarations from nTox.h and put them into nTox.c. They are not used outside and nTox is not a library.
89 lines
2.6 KiB
C
89 lines
2.6 KiB
C
/* misc_tools.c
|
|
*
|
|
* Miscellaneous functions and data structures for doing random things.
|
|
*
|
|
* Copyright (C) 2013 Tox project All Rights Reserved.
|
|
*
|
|
* This file is part of Tox.
|
|
*
|
|
* Tox is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 3 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* Tox is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with Tox. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#ifdef HAVE_CONFIG_H
|
|
#include "config.h"
|
|
#endif
|
|
|
|
#include <stdint.h>
|
|
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#ifdef TOX_DEBUG
|
|
#include <assert.h>
|
|
#endif // TOX_DEBUG
|
|
|
|
// You are responsible for freeing the return value!
|
|
uint8_t *hex_string_to_bin(const char *hex_string)
|
|
{
|
|
// byte is represented by exactly 2 hex digits, so lenth of binary string
|
|
// is half of that of the hex one. only hex string with even length
|
|
// valid. the more proper implementation would be to check if strlen(hex_string)
|
|
// is odd and return error code if it is. we assume strlen is even. if it's not
|
|
// then the last byte just won't be written in 'ret'.
|
|
size_t i, len = strlen(hex_string) / 2;
|
|
uint8_t *ret = malloc(len);
|
|
const char *pos = hex_string;
|
|
|
|
for (i = 0; i < len; ++i, pos += 2) {
|
|
sscanf(pos, "%2hhx", &ret[i]);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
int cmdline_parsefor_ipv46(int argc, char **argv, uint8_t *ipv6enabled)
|
|
{
|
|
int argvoffset = 0, argi;
|
|
|
|
for (argi = 1; argi < argc; argi++) {
|
|
if (!strncasecmp(argv[argi], "--ipv", 5)) {
|
|
if (argv[argi][5] && !argv[argi][6]) {
|
|
char c = argv[argi][5];
|
|
|
|
if (c == '4') {
|
|
*ipv6enabled = 0;
|
|
} else if (c == '6') {
|
|
*ipv6enabled = 1;
|
|
} else {
|
|
printf("Invalid argument: %s. Try --ipv4 or --ipv6!\n", argv[argi]);
|
|
return -1;
|
|
}
|
|
} else {
|
|
printf("Invalid argument: %s. Try --ipv4 or --ipv6!\n", argv[argi]);
|
|
return -1;
|
|
}
|
|
|
|
if (argvoffset != argi - 1) {
|
|
printf("Argument must come first: %s.\n", argv[argi]);
|
|
return -1;
|
|
}
|
|
|
|
argvoffset++;
|
|
}
|
|
}
|
|
|
|
return argvoffset;
|
|
}
|