toxcore/auto_tests/run_auto_test.h
iphydf 2570ddcb17
Fix errors on error paths found by oomer.
* Use-after-free because we free network before dht in one case.
* Various unchecked allocs in tests (not so important).
* We used to not check whether ping arrays were actually allocated in DHT.
* `ping_kill` and `ping_array_kill` used to crash when passing NULL.

Also:
* Added an assert in all public API functions to ensure tox isn't NULL.
  The error message you get from that is a bit nicer than "Segmentation
  fault" when clients (or our tests) do things wrong.
* Decreased the sleep time in iterate_all_wait from 20ms to 5ms.
  Everything seems to still work with 5ms, and this greatly decreases
  the amount of time spent per test run, making oomer run much faster.
2020-05-02 21:47:08 +01:00

141 lines
4.2 KiB
C

#include <stdlib.h> // calloc, free
#include "check_compat.h"
#include "../testing/misc_tools.h"
#include "../toxcore/Messenger.h"
#include "../toxcore/mono_time.h"
static bool all_connected(uint32_t tox_count, Tox **toxes)
{
for (uint32_t i = 0; i < tox_count; i++) {
if (tox_self_get_connection_status(toxes[i]) == TOX_CONNECTION_NONE) {
return false;
}
}
return true;
}
static bool all_friends_connected(uint32_t tox_count, Tox **toxes)
{
for (uint32_t i = 0; i < tox_count; i++) {
const size_t friend_count = tox_self_get_friend_list_size(toxes[i]);
for (size_t j = 0; j < friend_count; j++) {
if (tox_friend_get_connection_status(toxes[i], j, nullptr) == TOX_CONNECTION_NONE) {
return false;
}
}
}
return true;
}
static void iterate_all_wait(uint32_t tox_count, Tox **toxes, State *state, uint32_t wait)
{
for (uint32_t i = 0; i < tox_count; i++) {
tox_iterate(toxes[i], &state[i]);
state[i].clock += wait;
}
/* Also actually sleep a little, to allow for local network processing */
c_sleep(5);
}
static uint64_t get_state_clock_callback(Mono_Time *mono_time, void *user_data)
{
const State *state = (const State *)user_data;
return state->clock;
}
static void set_mono_time_callback(Tox *tox, State *state)
{
// TODO(iphydf): Don't rely on toxcore internals.
Mono_Time *mono_time = ((Messenger *)tox)->mono_time;
state->clock = current_time_monotonic(mono_time);
mono_time_set_current_time_callback(mono_time, get_state_clock_callback, state);
}
static void run_auto_test(uint32_t tox_count, void test(Tox **toxes, State *state), bool chain)
{
printf("initialising %u toxes\n", tox_count);
Tox **toxes = (Tox **)calloc(tox_count, sizeof(Tox *));
State *state = (State *)calloc(tox_count, sizeof(State));
ck_assert(toxes != nullptr);
ck_assert(state != nullptr);
for (uint32_t i = 0; i < tox_count; i++) {
state[i].index = i;
toxes[i] = tox_new_log(nullptr, nullptr, &state[i].index);
ck_assert_msg(toxes[i], "failed to create %u tox instances", i + 1);
set_mono_time_callback(toxes[i], &state[i]);
}
if (chain) {
printf("each tox adds adjacent toxes as friends\n");
for (uint32_t i = 0; i < tox_count; i++) {
for (uint32_t j = i - 1; j != i + 3; j += 2) {
if (j >= tox_count) {
continue;
}
uint8_t public_key[TOX_PUBLIC_KEY_SIZE];
tox_self_get_public_key(toxes[j], public_key);
Tox_Err_Friend_Add err;
tox_friend_add_norequest(toxes[i], public_key, &err);
ck_assert(err == TOX_ERR_FRIEND_ADD_OK);
}
}
} else {
printf("toxes all add each other as friends\n");
for (uint32_t i = 0; i < tox_count; i++) {
for (uint32_t j = 0; j < tox_count; j++) {
if (i != j) {
uint8_t public_key[TOX_PUBLIC_KEY_SIZE];
tox_self_get_public_key(toxes[j], public_key);
Tox_Err_Friend_Add err;
tox_friend_add_norequest(toxes[i], public_key, &err);
ck_assert(err == TOX_ERR_FRIEND_ADD_OK);
}
}
}
}
printf("bootstrapping all toxes off toxes[0]\n");
uint8_t dht_key[TOX_PUBLIC_KEY_SIZE];
tox_self_get_dht_id(toxes[0], dht_key);
const uint16_t dht_port = tox_self_get_udp_port(toxes[0], nullptr);
for (uint32_t i = 1; i < tox_count; i++) {
Tox_Err_Bootstrap err;
tox_bootstrap(toxes[i], "localhost", dht_port, dht_key, &err);
ck_assert(err == TOX_ERR_BOOTSTRAP_OK);
}
do {
iterate_all_wait(tox_count, toxes, state, ITERATION_INTERVAL);
} while (!all_connected(tox_count, toxes));
printf("toxes are online\n");
do {
iterate_all_wait(tox_count, toxes, state, ITERATION_INTERVAL);
} while (!all_friends_connected(tox_count, toxes));
printf("tox clients connected\n");
test(toxes, state);
for (uint32_t i = 0; i < tox_count; i++) {
tox_kill(toxes[i]);
}
free(state);
free(toxes);
}