mirror of
https://github.com/irungentoo/toxcore.git
synced 2024-03-22 13:30:51 +08:00
0becafd272
Fixes #572. As discussed in the issue, there's a risk that toxcore may not hold the maximum bitrates libvpx supports, if toxcore insists on using integer type. I initially proposed to have another flag in set(), so that we can use unsigned type instead. iphydf came up with a better solution, that is splitting the original functions, one for audio, one for video. Now, we could safely replace int32_t with uint32_t. Also: clean video_bit_rate_invalid() Though this is not a part of issue #572, as it's used in the toxav_bit_rate_set(), i cleaned the code. As mannol said, there should be a check. Uint32_t is large enough to hold the maximum bitrates libvpx supports, but user may pass a value larger than uint while smaller than uint32_t. Thanks to the reminding from nurupo, it's no longer a stub function. Bitrate error enums are shared for both audio and video https://github.com/TokTok/c-toxcore/pull/578#issuecomment-360095609, just as iphydf said. |
||
|---|---|---|
| .. | ||
| BUILD | ||
| check_compat.h | ||
| conference_test.c | ||
| crypto_test.c | ||
| dht_test.c | ||
| encryptsave_test.c | ||
| file_saving_test.c | ||
| helpers.h | ||
| Makefile.inc | ||
| messenger_test.c | ||
| monolith_test.cpp | ||
| network_test.c | ||
| onion_test.c | ||
| resource_leak_test.c | ||
| save_friend_test.c | ||
| self_conference_title_change_test.c | ||
| selfname_change_conference_test.c | ||
| simple_conference_test.c | ||
| skeleton_test.c | ||
| TCP_test.c | ||
| tox_many_tcp_test.c | ||
| tox_many_test.c | ||
| tox_one_test.c | ||
| tox_strncasecmp_test.c | ||
| tox_test.c | ||
| toxav_basic_test.c | ||
| toxav_many_test.c | ||
| version_test.c | ||