mirror of
https://github.com/irungentoo/toxcore.git
synced 2024-03-22 13:30:51 +08:00
864b4aa01f
For coverity, which continues to think we're overrunning buffers when at this point it's easy to prove we're not. Here would be the corrected coverity finding: 6. Condition packet_length <= 105 /* 1 + 32 * 2 + 24 + 16 */, taking false branch. 7. Condition packet_length > 1024, taking false branch. Now packet_length must be > 105 and <= 1024. 12. Condition len1 == packet_length - (89 /* 1 + 32 * 2 + 24 */) - 16, taking true branch. len1 must be > 0 (105 - 89 - 16) and <= 919 (1024 - 89 - 16). 14. decr: Decrementing len1. The value of len1 is now between 0 and 919 (inclusive). This is where coverity goes wrong: it thinks len1 could be up to 2147483629. 15. buffer access should be OK. Coverity thinks it's not. |
||
|---|---|---|
| .. | ||
| analysis | ||
| astyle | ||
| bootstrap_daemon | ||
| docker | ||
| emscripten | ||
| fun | ||
| pkgconfig | ||
| proxy | ||
| rpm | ||
| bootstrap_node_packets.c | ||
| bootstrap_node_packets.h | ||
| BUILD.bazel | ||
| DHT_bootstrap.c | ||
| DHTnodes | ||
| make_single_file | ||
| Makefile.inc | ||
| osx_build_script_toxcore.sh | ||
| print-version | ||
| tox-warning.png | ||
| tox.png | ||
| version-sync | ||
| windows_build_script_toxcore.sh | ||
