A couple of minor reasons, combined warrant a PR imo:
a) fileChunkRequested is a better signal name than fileRequestChunkReceived, and I don't want to break consistency by reordering words for just this signal
b) "request chunk" is parsed by English speakers as a verb-object combination,
implying sending the request, not receiving, whereas "chunk requested" is
parsed (more correctly) as an adjective-noun combo (in particular, request is
a noun not a verb), and thus reads far more like "hey heads up we just got a request"
For instance some tests/testing code had some callbacks to *receive* chunk requests, and they were called "tox_file_request_chunk"... to receive a chunk, not request it. Now they're called "tox_file_chunk_request".
So yeah...
This function can be used to seek an incoming file tranfer right
before accepting it.
It is meant to be used to resume incomplete file tranfers by clients.
file_id is a 32byte identifier that can be used by users to identify
file tranfers across core/client restarts in order to resume broken
file tranfers.
In avatar tranfers it corresponds to the hash of the avatar.
Added tox_file_get_file_id() function to api to obtain the file_id
of an ongoing file transfer.
If not set, core will generate a random one.
The first commit's message is:
TOX_STATUS -> TOX_USER_STATUS, is more specific
This is the 2nd commit message:
I pretty strongly believe tox_iteration needs to be renamed to a verb
There are several other noun functions in the API, but none of them *do* things.
I think even tox_do is better than tox_iteration.
tox_do_interval is one possibility, but I'm open to suggestions.
This is the 3rd commit message:
private_key -> secret_key
This is more consistent with modern/NaCl/elliptic cryptography, and also "pk", meaning public key, is all over other toxcore code and documentation. This will eliminate ambiguity.
This is the 4th commit message:
Rename some functions for pseudo-namespace consistency
The enum change results in long enum types, but I think consistency trumps
having a few less characters.
This is the 5th commit message:
TOX_FILE_KIND -> TOX_FILE_TYPE
This is more of an English thing than a consistency thing, but
TOX_FILE_KIND sounds funnier/stranger to me than TOX_FILE_TYPE.
This is the 6th commit message:
More specific file control function names
This is the 7th commit message:
Rename custom packet functions for pseudo-namespace consistency
This also has the issue with long enums... but I still think consistent enum names are better
This is the 8th commit message:
Rename functions for pseudo-namespace consistency
This is the 9th commit message:
Consistency with https://github.com/sonOfRa/tox4j/blob/master/doc/core-design.md#naming-conventions and the rest of the api
This is the 10th commit message:
Fix errors in previous function rename commits
This is the 11th commit message:
Shorten one error enum name
Roman Proskuryakov
irungentoo
Jfreegman
Roman Pasichnyk
Dubslow
iphydf
Impyy
saneki