Commit Graph

126 Commits

Author SHA1 Message Date
irungentoo
88986f793a Prevented possible MITM attack.
Friends must now send to themselves at least one encrypted ping packet
every 5 seconds.

If no encrypted ping packets are recieved from a friend within 10
seconds the connection is killed.
2013-08-19 07:00:59 -04:00
irungentoo
88ea4659e9 Properly fixed possible realloc with size zero problem. 2013-08-18 10:27:03 -04:00
Sean Qureshi
1986e6b7f4 Ran it through astyle 2013-08-18 01:48:36 -07:00
Sean Qureshi
17d3878174 Added minor error checking in Core, this helps prevent CERT MEM04-C; CWE-131 2013-08-18 01:26:11 -07:00
Sean Qureshi
71bc275284 Fixed a core memory leak 2013-08-18 00:23:50 -07:00
irungentoo
f259ab5fa7 Fixed bug. 2013-08-17 11:30:48 -04:00
irungentoo
7d092c3467 Added dynamic memory allocation to crypto connections.
Also fixed some possible bugs in Messenger.c
2013-08-17 11:16:08 -04:00
Michael Rose
d1d24c123d Messenger stores / loads nickname
new toxic command to show nickname (mynick)
2013-08-17 11:59:28 +02:00
irungentoo
1207304f0b Metadata collection prevention part 2 of ???
Improved friend request sending.

As a side effect friend requests should now be routed less than before.

See added comments for details.
2013-08-16 18:57:00 -04:00
irungentoo
88ff81d9de Passed everything through astyle. 2013-08-16 13:11:09 -04:00
irungentoo
b15230583c Fixed loading and a small problem with the length of crypto requests. 2013-08-15 20:56:22 -04:00
Florian Hahn
3590f0a521 Check return value of realloc_friendlist and return FAERR_NOMEM on error 2013-08-15 15:34:27 +02:00
irungentoo
8eb8fb2ab5 Messenger fix from pr #461. 2013-08-14 09:52:03 -04:00
Chris Hall
cf5ad56a4a fixing minor memory leak of friendlist 2013-08-14 17:35:15 +12:00
Chris Hall
0590d8325c removing unnecessary function pointer _isset variables 2013-08-14 17:27:10 +12:00
irungentoo
63efa44dfa Attempt to quickly fix a test. 2013-08-13 19:36:02 -04:00
irungentoo
06ccdb5b91 Simple XOR checksum added to address. 2013-08-13 19:07:59 -04:00
irungentoo
4132cdff49 clarified comment. 2013-08-13 18:30:14 -04:00
irungentoo
73163f6c98 Friend requests with different nospam fix and added saving/loading of nospam. 2013-08-13 17:25:52 -04:00
irungentoo
97f449a2f1 Fixed spam problem. (I broke the API so this will not build)
The friend address is what the byte string that you give away for people
to add you will be called.

1. Every friend address now contains a number set by the friend. This is
to prevent someone from randomly spamming people in the DHT with friend
requests and makes it so you need the person to actually give you the
address in some way to send the friend request. This number is expected
to be encrypted with the friend request. All requests that do not
contain this number will be rejected. This means the spammer can no
longer use the DHT to collect lists of valid addresses to spam. It also
enables users to quickly change the number in case a spammer gets hold
of the address and starts spamming it.

2. A 2 byte checksum will be added (not implemented yet) to prevent
people from accidentally adding random strings as friends. (NOTE that
this has nothing to do with the spam problem I just decided to add a
placeholder for it now.)
2013-08-13 09:32:31 -04:00
irungentoo
cb4f67b37a Merge pull request #441 from slvr/timer
Timer Subsystem
2013-08-13 04:14:01 -07:00
Andreas Schneider
6b06431e9b core: Fix a possible buffer overflow using getself_name().
If the passed buffer is smaller than MAX_NAME_LENGTH then, you
will probably overflow it.
2013-08-13 09:50:51 +02:00
slvr
a0c6296d6c Resolve Merge Conflict 2013-08-12 23:47:15 +01:00
slvr
be840b46b9 Merge remote-tracking branch 'upstream/master' into timer
Conflicts:
	core/Messenger.c
2013-08-12 23:08:48 +01:00
slvr
a56d87cd3f remember to call timer_poll 2013-08-12 14:54:40 +01:00
slvr
c6b496d85b Messenger Timer 2013-08-12 14:44:59 +01:00
slvr
f3511db29b Added LAN discovery timer 2013-08-12 14:19:25 +01:00
alek900
8d3e68b74d Added support for userdata in callbacks 2013-08-12 14:23:46 +02:00
Chris Hall
4293c4b1e6 Messenger refactor - redid work from pull request 79
Moves static state out of Messenger.c and into a Messenger struct
Purely stylistic, no functional changes were made.

This commit also changed all the callers of Messenger as they now have
to pass an instance of the Messenger struct to messenger functions.

Also removed some uses of the 'static' keyword at the beginning of
function definitions when the function was already declared static, as
these caused gcc to whine.
2013-08-12 21:37:38 +12:00
alek900
ed3b036862 Send our current status and name to friend that just came online.
Our username and status might have changed while our friend was offline.
2013-08-11 23:10:12 +02:00
Maxim Biro
e427197580 Fixed a mistake 2013-08-11 16:56:02 -04:00
Maxim Biro
eaa7d3e0a0 Replaced friendstatus with connectionstatus 2013-08-11 14:57:47 -04:00
irungentoo
3a2d453165 Merge pull request #429 from dparnell/pristine
Fixed m_sendmessage to return the ID of the message sent
2013-08-11 06:59:26 -07:00
Daniel Parnell
6c0db66a01 Fixed m_sendmessage to return the ID of the message sent 2013-08-11 22:15:07 +10:00
alek900
851c52571f m_addfriend triggerd m_callback_friendstatus with a friendid thats not returned yet from m_addfriend 2013-08-11 13:02:02 +02:00
slvr
da8ef89e9d Merge remote-tracking branch 'upstream/master' into pr 2013-08-10 19:20:56 +01:00
slvr
7f27fcaf37 tabs -> spaces 2013-08-10 11:27:36 +01:00
irungentoo
341de59bb6 Fixed possible bug. 2013-08-09 20:32:51 -04:00
slvr
951dbc1258 Updated initMessenger 2013-08-10 00:54:43 +01:00
slvr
6052b1f119 network_registerhandler 2013-08-10 00:43:50 +01:00
Maxim Biro
f0786d1fcd Returned the length check 2013-08-09 19:20:23 -04:00
Maxim Biro
0f8eea89fa Introduced data pointer and data_length 2013-08-09 17:03:37 -04:00
Maxim Biro
9dd691d106 Changed the way statusmessage is allocated 2013-08-09 17:03:30 -04:00
Maxim Biro
c6d06ae6ee Moved some checks around 2013-08-09 16:28:12 -04:00
Maxim Biro
19bbed475d Extracted repeated code into a function 2013-08-09 16:17:56 -04:00
irungentoo
cd730b532a Merge pull request #403 from jin-eld/fix-friend-status-callback
Fix typo in function name which results in missing symbol
2013-08-08 14:15:00 -07:00
jin-eld
24bebf57d0 Fix typo in function name which results in missing symbol 2013-08-09 00:03:14 +03:00
irungentoo
5024bab930 Merge pull request #400 from JFreegman/master
Added actions/alternative type of messages
2013-08-08 12:40:15 -07:00
Jfreegman
8719f46645 added actions/alternate messages 2013-08-08 15:00:30 -04:00
irungentoo
9634a23437 Merge branch 'master' of https://github.com/nurupo/InsertProjectNameHere into nurupo-master
Conflicts:
	core/Messenger.c
2013-08-08 14:39:27 -04:00