iphydf
814c12a6f4
cleanup: Add dynamically derived array sizes to the API.
2024-01-07 14:43:57 +00:00
iphydf
226b23be12
cleanup: Add explicit array sizes to toxencryptsave.
...
Also mark arrays as `[]` instead of `*`.
2024-01-07 13:27:38 +00:00
iphydf
ddda605509
fix: Don't crash if RNG init failed.
...
`system_random()` can fail and return NULL, which should be handled by
toxencryptsave functions.
Also synced function comments between .h and .c file for toxencryptsave.
2022-04-03 20:46:44 +00:00
iphydf
cc31ff07fa
feat: Add support for custom random number generator.
...
This can be used by fuzzers to make RNG-driven code deterministic (i.e.
based on the fuzzer input).
2022-04-01 14:06:05 +00:00
iphydf
88ae190aca
cleanup: Split the huge TCP client packet handler.
...
Also enable cppcheck in both C and C++ mode.
2022-03-19 11:06:50 +00:00
iphydf
b13590a86d
cleanup: Mark all local non-pointers as const where possible.
2022-02-23 19:30:01 +00:00
iphydf
6be655c56c
cleanup: Return boolean constants, not ints from bool functions.
2022-02-22 17:50:17 +00:00
iphydf
e7bc611dac
cleanup: Enable most cppcheck warnings as errors.
...
Cleaned up some of the warnings it gives. Disabled the ones that are
less useful for us at this time.
2022-02-21 17:17:36 +00:00
iphydf
a9ccf1be26
cleanup: Remove all implicit bool conversions in if-conditions.
...
Note to reviewer: please review carefully. This was done manually.
2022-02-21 15:10:22 +00:00
iphydf
87c38ece30
cleanup: Avoid implicit bool conversions in logical operators.
2022-02-18 10:24:31 +00:00
iphydf
933c6b7517
refactor: Compare pointers in if conditions to nullptr.
...
Don't use implicit ptr-to-bool conversion.
2022-02-17 19:55:29 +00:00
iphydf
7f0395b746
chore: Make the last few remaining top level comments doxygen style.
2022-02-04 23:25:45 +00:00
iphydf
7f94e411a9
chore: Add cpplint to the CI.
2022-01-17 23:42:38 +00:00
iphydf
73484d8995
cleanup: Use calloc instead of malloc for struct allocations.
...
`malloc` is used only for byte/int arrays. Also, we no longer allow plain
`void *` allocations. Every allocation should have a real value type.
2022-01-09 22:42:50 +00:00
iphydf
24f49fc917
chore: Fix up a few source code comment and style issues.
...
Tokstyle no longer allows:
* Includes inside an `extern "C"`
* Comments on function definition and declaration to be different.
* Doxygen comments commenting on other doxygen comments.
2021-12-21 18:14:53 +00:00
iphydf
f49ea44daa
cleanup: Remove crypto_pwhash import.
...
Vanilla nacl builds won't have toxencryptsave.
2021-12-15 17:16:35 +00:00
iphydf
6b75f8b889
chore: Remove config.h.
...
This aligns the autotools build with the cmake build, which doesn't have
a config.h file. It also removes the ambiguity of config.h and
other/bootstrap_daemon/src/config.h.
2021-12-15 10:26:50 +00:00
iphydf
5c53e6a30f
chore: Add autotools build; exempt crypto_pwhash from tokstyle.
2021-12-13 18:47:45 +00:00
iphydf
30c939e4ab
cleanup: Fix some clang-tidy warnings and make them errors.
...
The android warnings are disabled now because they suggest using
linux-only extensions of libc. Useful for android indeed, but we're
targeting non-android and non-linux systems as well.
2021-12-10 15:21:27 +00:00
iphydf
d930ecca4c
chore: Run infer static analyser on circle ci builds.
...
Also running some other analysis that we used to have on Travis.
2021-12-06 20:25:50 +00:00
iphydf
11ad5471b9
Use spdx license identifier instead of GPL blurb.
2020-03-14 13:06:19 +00:00
iphydf
605dfe882c
Consistently use camel case enum names.
...
Including in tests and implementation files.
2018-10-09 17:33:37 +00:00
iphydf
473cde24d8
Update copyright to 2018.
2018-08-26 18:57:29 +00:00
iphydf
8739f7fccb
Make tox.c unambiguously parseable.
...
Rules:
1. Constants are uppercase names: THE_CONSTANT.
2. SUE[1] types start with an uppercase letter and have at least one
lowercase letter in it: The_Type, THE_Type.
3. Function types end in "_cb": tox_friend_connection_cb.
4. Variable and function names are all lowercase: the_function.
This makes it easier for humans reading the code to determine what an
identifier means. I'm not convinced by the enum type name change, but I
don't know a better rule. Currently, a lot of enum types are spelled like
constants, which is confusing.
[1] struct/union/enum
2018-07-05 23:09:28 +00:00
iphydf
12365a7cc9
Fixes to the imported sodium sources to compile without warnings.
2018-06-25 20:09:53 +00:00
iphydf
be797d4b03
Move system header includes from network.h to network.c
2018-05-20 15:42:42 +00:00
iphydf
92ffad1a72
Use nullptr as NULL pointer constant instead of NULL or 0.
...
This changes only code, no string literals or comments.
2018-01-30 23:35:50 +00:00
iphydf
d26f0eb3bc
Change toxencryptsave API to never overwrite pass keys.
2017-12-29 23:24:54 +00:00
iphydf
8d81c5625d
Implement missing TES constant functions.
...
Fixes #503 .
2017-03-30 20:18:00 +00:00
iphydf
8f96ca6d86
Update license headers and remove redundant file name comment.
...
"All rights reserved" was incorrect. The project was licensed under GPL3,
which means a lot of rights are licensed to everybody in the world, i.e.
not reserved to the "Tox Project".
2017-01-19 00:01:44 +00:00
iphydf
8f1dbaa2c5
Set up autotools build to build against vanilla NaCl.
...
Fixes #363 .
2017-01-08 15:27:26 +00:00
iphydf
2328cb74ab
Improve documentation of crypto_core.
2016-12-22 10:26:59 +00:00
iphydf
ce29c8e7ec
Wrap all sodium/nacl functions in crypto_core.c.
2016-12-22 10:26:59 +00:00
iphydf
c5ced9b2d8
Remove unused get/set salt/key functions from toxencryptsave.
2016-12-19 15:48:24 +00:00
iphydf
4cf69996cc
Add apidsl file for toxencryptsave.
...
This breaks the toxencryptsave API. It hides the Tox_Pass_Key struct
definition.
2016-12-13 14:24:40 +00:00
Gregory Mullen (grayhatter)
51139a080c
v0.0.0 => v0.0.1
2016-09-28 12:12:39 -07:00
iphydf
a9fbdaf46b
Do not use else after return.
...
http://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code
2016-09-02 11:02:56 +01:00
iphydf
77db27331e
Sort #includes in all source files.
2016-09-01 16:35:46 +01:00
iphydf
633da98ae6
Add braces to all if statements.
2016-08-31 20:04:16 +01:00
iphydf
459f8f2013
Check code formatting on Travis.
...
We run astyle on Travis and check if there is a diff. The build terminates if
git finds a difference.
2016-08-12 01:00:00 +01:00
Gregory Mullen (GrayHatter)
9628f9d171
added the dropped ;
2016-02-13 20:53:30 -08:00
Gregory Mullen (GrayHatter)
58ebf7a5b6
added versioning to toxencryptsave
2016-02-13 20:50:16 -08:00
irungentoo
dfe5d9b256
Fixes.
...
Fixed bug from merged PR.
Don't build useless files when building with libsodium.
2016-01-30 17:23:15 -05:00
irungentoo
3f6a8f10bb
Allow empty keys in toxencryptsave.
2015-05-27 19:54:04 -04:00
irungentoo
51c5810d72
These parameters should have been const.
2015-05-26 12:57:14 -04:00
irungentoo
abff31d2ad
Merge branch 'master' of https://github.com/dubslow/toxcore
2015-04-01 19:57:31 -04:00
Dubslow
f7beee495e
Make keys into a struct for more programmer safety
2015-03-31 21:16:04 -05:00
Dubslow
9b66c57bd0
Fix minor code duplication
2015-03-31 19:30:09 -05:00
irungentoo
99e0fde297
Merge branch 'master' of https://github.com/dubslow/toxcore
2015-03-31 19:44:51 -04:00
Dubslow
e998aca8f7
Fix toxencryptsave to be consistent with new_api
...
Upon my own decision, the two tox_encryped_new convenience functions were removed due to basically needing two different sets of error codes.
At iphydf's suggestion the corresponding tox_get_encrypted_savedata convenience functions were removed as well.
2015-03-31 18:31:23 -05:00
