jfreegman
015305a088
Merge moderation portion of new groupchats codebase
2022-03-30 20:09:50 -04:00
iphydf
7db0c80c93
test: Add DHT and tox_events fuzz tests to the cmake build.
2022-03-29 22:57:23 +00:00
iphydf
f39aac09e6
feat: Allow custom network functions.
...
The idea here is to have a `Network` object that contains functions for
network operations and an optional userdata object that can manage those
network operations. This allows e.g. a fuzzer to replace the network
functions with no-ops or fuzzer inputs, reducing the need for `#ifdef`s.
2022-03-29 22:03:26 +00:00
iphydf
e4558a287c
perf: Make time move a lot faster in fuzzing runs.
2022-03-27 22:52:35 +00:00
iphydf
478ef39b39
test: Add some support functions to make writing fuzzers easier.
2022-03-27 18:43:41 +00:00
sudden6
bc006beb4e
cleanup: split CMakeLists.txt and add some missing targets
2022-03-27 20:09:10 +02:00
sudden6
48fb45887f
try to save the fuzzed save file again
...
This should test some additional code paths.
2022-03-26 14:09:04 +01:00
iphydf
1928704065
test: Add fuzzer tests to the bazel build.
2022-03-25 18:48:41 +00:00
iphydf
2dcb946e62
cleanup: Reduce scope of array-typed variables where possible.
...
Cimple cannot actually find these without also causing false positives,
but I found them with cimple before removing the code causing false
positives again.
2022-03-21 12:02:46 +00:00
iphydf
c3a938e38c
cleanup: Avoid memset on structs.
...
Most of these were safe (some were not), but even the safe ones can
become unsafe (non-portable) later on when adding pointer or float members.
2022-03-19 12:32:36 +00:00
iphydf
cff9a18e39
cleanup: Split util.c out of the network library.
...
Also, don't include ccompat.h in header files. Instead, explicitly
include it in .c files.
2022-03-04 10:33:11 +00:00
iphydf
163e9c3b03
cleanup: Remove more boolean conversions (and a bugfix).
...
These were found by the new stronger type check in cimple. The one
bugfix is in `crypto_sha512_cmp`, which used to think `crypto_verify_32`
returns bool while actually it's -1/0/1.
2022-02-26 00:03:56 +00:00
iphydf
093927ba4f
test: Add mallocfail and proxy test to our coverage runs.
2022-02-25 01:55:28 +00:00
sudden6
e42441e3cf
chore: remove DHT_test.c since it's unused
2022-02-22 22:30:27 +01:00
iphydf
6be655c56c
cleanup: Return boolean constants, not ints from bool functions.
2022-02-22 17:50:17 +00:00
iphydf
b7f95bbe70
cleanup: Remove any disallowed casts.
...
The ones in toxav weren't needed. The ones in network.c are
non-trivially correct. Now, the code is more easily verifiable.
2022-02-22 02:19:29 +00:00
iphydf
f98137d697
refactor: Move tox_new_log to auto_test_support.
...
This is only used in auto tests.
2022-02-21 17:39:10 +00:00
iphydf
86a528a37a
chore: Add a .clang-format that mostly agrees with astyle.
2022-02-21 16:16:16 +00:00
iphydf
6a6bc029de
cleanup: Remove unused execution trace library.
2022-02-19 11:44:13 +00:00
iphydf
84a03bc2ed
cleanup: Enable tokstyle's -Wlarge-struct-params.
2022-02-18 10:49:46 +00:00
iphydf
7b2f6c34c6
cleanup: Apply stronger type checks and fix errors.
...
Found a bug, too: file recv and chunk events were intermittently
converting to `uint32_t`, losing precision.
2022-02-17 22:34:56 +00:00
Maxim Biro
25216f86e7
Don't attempt to install the same package twice
2022-02-13 22:54:10 -05:00
sudden6
acf85eee46
fix: remove bogus asserts in fuzzer harness
2022-02-14 00:38:42 +01:00
iphydf
a3cd1102f7
perf: Reduce minimal encoding size of packed events.
...
We're using a union-like encoding now with an enum telling which union
member to set.
2022-02-12 17:44:44 +00:00
iphydf
10f86f6c00
cleanup: Add more nonnull and nullable annotations.
2022-02-09 20:03:34 +00:00
iphydf
2ed9b1927f
doc: Add doxygen configuration and netlify publishing.
2022-02-05 15:59:45 +00:00
jfreegman
5619b5e056
Make more functions take const pointers to IP_Port
...
We additionally now make local copies of the IP_Port param instead
of modifying the passed argument
2022-02-03 11:17:29 -05:00
iphydf
fcabbd2ed4
chore: Disable some cimple warnings for now.
...
So we can push the latest cimple to toktok-stack and then start fixing
the warnings.
2022-02-03 01:50:23 +00:00
iphydf
5fbcbb6c83
cleanup: Remove uses of strcpy and sprintf.
...
Use of `strcpy` in these particular cases was safe, but it's hard to
tell and also useless. `strcpy` would effectively need to do another
`strlen` which we already did.
Also removed sprintf, which was also safe in this case but it's easier to
be "obviously safe", especially for static analysers.
2022-01-17 18:25:40 +00:00
iphydf
044ae636a3
chore: Mark unsafe code as testonly.
...
We want to ensure that nobody links against testing code in production.
2022-01-16 09:10:53 +00:00
iphydf
685b78d31d
chore: Add asan/tsan bazel builds.
...
These have all dependencies built with asan/tsan, so they can do deeper
sanity checks such as checking what opus is doing with our buffers.
The asan check currently fails for me locally, so these are not yet set
to be required for PRs to be merged.
2022-01-12 20:33:21 +00:00
jfreegman
360acd0f42
Replace all instances of atoi with strtol
...
atoi doesn't check if the conversion from string to int succeeded
which doesn't allow us to do proper error handling.
We also now make sure that the port argument is a valid port
in addition to being properly converted
2022-01-12 14:08:45 -05:00
iphydf
9b7279ab24
chore: Run tokstyle with 3 cores.
...
This seems to be the sweet spot for the current tokstyle implementation.
4 cores gives the same speedup, 5 also, 6 makes it slower, and 2 also
makes it slower.
2022-01-12 18:52:46 +00:00
iphydf
c1b32bd7a1
chore: Enable compiler layering check.
...
This ensures that we're explicit about what we depend on and avoids
transitive dependencies.
2022-01-11 15:26:32 +00:00
sudden6
e04b890817
add scripts to run the fuzzing process
...
This adds scripts and Dockerfiles to run the fuzzing process standalone
or with OSS-Fuzz/ClusterFuzzLite integrations.
2022-01-10 21:05:51 +01:00
sudden6
7dd8dbd897
intercept network, crypto and time
...
This fuzzing harness must be as deterministic as possible for the fuzzer
to detect additional coverage reliably.
2022-01-10 21:05:49 +01:00
sudden6
9eb88798a3
add fuzzing harnesses
...
Toxsave harness ported to libFuzzer interface.
New harness for bootstrap phase.
2022-01-10 20:57:00 +01:00
zugz (tox)
64a48c0e78
cleanup: Remove hardening code from DHT
2021-12-30 00:00:01 +00:00
iphydf
6b75f8b889
chore: Remove config.h.
...
This aligns the autotools build with the cmake build, which doesn't have
a config.h file. It also removes the ambiguity of config.h and
other/bootstrap_daemon/src/config.h.
2021-12-15 10:26:50 +00:00
iphydf
74bc87f277
test: Make ERROR logging fatal in tests.
...
This doesn't currently work, because we get a lot of errors during tests.
This should not happen. Either those errors are warnings, or something is
wrong with either the code or the test.
2021-12-14 13:00:25 +00:00
iphydf
5c53e6a30f
chore: Add autotools build; exempt crypto_pwhash from tokstyle.
2021-12-13 18:47:45 +00:00
iphydf
cdc0286050
cleanup: Minor fixes in test code.
...
* Buffer overrun in auto test.
* Resource leak in AFL test code.
2021-12-07 17:13:58 +00:00
iphydf
d930ecca4c
chore: Run infer static analyser on circle ci builds.
...
Also running some other analysis that we used to have on Travis.
2021-12-06 20:25:50 +00:00
iphydf
f8ab32aaa4
Add a check that we don't have any unused functions.
...
This check puts all of our code in a C++ anonymous namespace, which is
effectively making all functions `static`. This allows the compiler to
determine that a function is unused, so we can delete it.
2020-05-02 22:00:09 +01:00
iphydf
f3c6fc6771
Add execution trace option for debugging.
...
Use `cmake -DEXECUTION_TRACE=ON` to use it.
2020-04-27 23:10:27 +00:00
iphydf
f0ae0511c2
Make afl_toxsave.c a bit more portable; fix memleak.
...
malloc.h doesn't exist on most platforms, and certainly not in stdc. No
functions from malloc.h are actually used here, and stdlib.h is enough.
2020-04-05 09:08:44 +00:00
sudden6
6732e5ef2f
Add basic test adapter for AFL
2020-03-24 16:49:41 +01:00
iphydf
11ad5471b9
Use spdx license identifier instead of GPL blurb.
2020-03-14 13:06:19 +00:00
iphydf
e671490989
Use rules_cc instead of native cc_library rules.
2020-03-12 12:20:54 +00:00
iphydf
28baf9632f
Remove testing/av_test.c.
...
It's a maintenance burden. Nobody uses this. It depends on an ancient
version of opencv that less and less systems actually have.
2020-03-02 21:07:55 +00:00
