iphydf
32b68cffca
cleanup: Some more test cleanups, removing overly smart code.
2024-01-10 12:42:37 +00:00
iphydf
b148a2afff
chore: Simplify msvc build using vcpkg.
2024-01-06 12:27:31 +00:00
iphydf
5cac6d7eb1
cleanup: Move tox_get_system out of the public API.
...
It's not released, yet, and this function is a pain. We don't want it
going forward.
2024-01-05 19:29:59 +00:00
iphydf
ef4897a898
cleanup: Upgrade to clang-tidy-17 and fix some warnings.
2023-12-27 01:05:47 +00:00
iphydf
766e62bc89
chore: Use pkg_search_module directly in cmake.
...
The `pkg_use_module` was doing magic we used to use, but no longer need.
2023-12-26 01:14:50 +00:00
iphydf
00ff078f91
cleanup: Use target_link_libraries directly in cmake.
...
Instead of using `target_link_modules`, which does magic that we no
longer need, because we only have 1 library we install, and all binaries
we build link statically because they need access to internal symbols.
2023-12-26 00:24:08 +00:00
iphydf
c58928cc89
chore: Add IMPORTED_TARGET to pkg-config packages.
...
Also use `PRIVATE` for `target_link_libraries`. This helps avoid
implicit transitive dependencies.
2023-12-26 00:04:07 +00:00
iphydf
895a6af122
cleanup: Remove NaCl support.
...
We now depend on libsodium unconditionally. Future work will require
functions from libsodium, and nobody we're aware of uses the nacl build
for anything other than making sure it still works on CI.
2023-12-25 00:36:38 +00:00
iphydf
447666d1a1
chore: Disable targets for cross-compilation.
...
This way we can do bazel build //... when cross-compiling.
2023-12-24 00:20:13 +00:00
iphydf
425216d9ec
fix: Correct a use-after-free and fix some memory leaks.
...
Also: use `find_package` to find gtest. This fixes the coverage build to
include unit tests.
2023-12-21 17:17:51 +00:00
iphydf
4e603bb613
refactor: Use enum-from-int rule from tokstyle.
...
These functions are a bit clearer and don't need to change if enum
values change.
See https://github.com/TokTok/hs-tokstyle/pull/212 for the relevant
linter implementation.
2023-12-19 20:53:15 +00:00
iphydf
89b6450d66
test: Add check-c run to bazel build.
...
Makes iterating on both check-c and the toxcore code easier.
2023-12-15 23:09:24 +00:00
iphydf
7cfe35dff2
cleanup: Remove explicit layering_check feature.
...
It's default in .bazelrc now.
2023-11-23 23:55:57 +00:00
iphydf
6be29f01e5
chore: Add more logging to loading conferences from savedata.
...
Better error messages than "something went wrong in type 20".
Also fix bazel-asan/tsan builds.
https://github.com/tweag/rules_nixpkgs/issues/442 is blocking fuzz
tests under asan.
2023-11-08 15:51:11 +00:00
iphydf
82276ef5ac
cleanup: Fix GCC compatibility.
2023-11-07 12:18:22 +00:00
iphydf
24b54722ae
fix: Ensure we have allocators available for the error paths.
2023-09-11 21:43:43 +00:00
iphydf
a549807df7
refactor: Add mem module to allow tests to override allocators.
...
This will allow us to do more interesting things with memory allocation
within toxcore, and allow fuzzers to explore various allocation failure
paths.
2023-08-30 22:55:05 +00:00
iphydf
7469a529b1
fix: Add missing #include <array>.
2023-08-15 20:47:27 +00:00
iphydf
2e02d56379
chore: Add missing module dependencies.
...
Also flip some callback asserts, because they can be reached by fuzzing
eventually.
Also update the bootstrapd checksum, since the alpine image changed a
bit.
2023-08-10 21:01:17 +00:00
sudden6
d222d708b5
fix: expand asserts in fuzz_support.cc
2022-12-08 17:27:00 +01:00
Green Sky
e1c38b40d6
fix : #1144 by forcing misc_tools to be a static lib
2022-12-08 14:43:01 +01:00
sudden6
9fae455bab
test: enable tcp relay for bootstrap fuzzing
2022-12-04 18:52:09 +01:00
jfreegman
0a277b52ea
Merge the remainder of the new groupchats implementation
...
Commit history: https://github.com/jfreegman/toxcore/tree/ngc_jf
Spec: https://toktok.ltd/spec.html#dht-group-chats
2022-09-22 11:16:08 -04:00
iphydf
50094b7385
test: Add a protocol dump test to generate initial fuzzer input.
2022-04-19 23:42:47 +00:00
iphydf
debedb3c94
test: Add a Null_System used in toxsave_harness.
...
This does nothing but has a working simple RNG.
2022-04-14 19:04:25 +00:00
iphydf
19b9cf3812
test: Enable fuzzing for TCP.
...
If the `recvbuf` network function returns 0 all the time, that means
there is never any data available on the TCP socket. This change makes
it so there is a random amount of data available on the TCP socket.
This invalidates the bootstrap fuzzer corpus.
2022-04-14 13:19:56 +00:00
iphydf
d78ee9b12e
fix: Fix potential array out-of-bounds in DHT random node retrieval.
...
It can't happen in almost every reality, except when the RNG is fairly
broken and doesn't add 2 fake DHT friends on startup. Still, this code
should be defensive and never index outside `num_friends` elements.
2022-04-10 23:17:15 +00:00
iphydf
60b71adbfa
test: Don't abort fuzz test when tox_new fails.
...
Right now, it can't fail, but later we want the fuzzer to randomly let
I/O functions fail, so we shouldn't assert tox_new succeeded.
2022-04-10 22:35:00 +00:00
iphydf
27c27b7c8c
refactor: Avoid static_cast in Fuzz_System functions.
...
Declutters the fuzz system code a bit, hiding the cast behind a `!`
operator.
2022-04-10 19:13:01 +00:00
jfreegman
616bd63021
Downgrade C++ version to 17
2022-04-10 12:44:04 -04:00
iphydf
cb34fe12d1
test: Add more functionality to the bootstrap harness.
...
Ideally this would be able to reach some of the events, so we can write
code to respond to those events, but so far only the friend request
event actually happens.
2022-04-07 20:17:56 +00:00
iphydf
941026266e
refactor: Allow overriding mono_time in tox_new.
...
This makes it so if mono_time is overridden, no monotonic time-related
system call is invoked in tox_new.
2022-04-03 22:48:16 +00:00
iphydf
378febffff
cleanup: Use static_assert instead of assert where possible.
...
This avoids some "always true condition" warnings and lifts the errors
(if any) into compile time.
2022-04-03 17:58:14 +00:00
zugz (tox)
e49a477a84
feat: add forwarding and announce request handling
...
This is the "server-side" part of the new friend finding system,
allowing DHT nodes to store small amounts of data and permit searching
for it. A forwarding (proxying) mechanism allows this to be used by TCP
clients, and deals with non-transitivity in the network.
2022-04-03 00:00:08 +00:00
iphydf
dec1399776
test: Add fuzzer support functions for internal toxcore objects.
...
These help creating fuzzer fixtures with non-trivially constructed
objects and takes care of cleaning them up afterwards so the fuzzer code
can focus on the system under test.
2022-04-03 11:21:06 +00:00
iphydf
cc31ff07fa
feat: Add support for custom random number generator.
...
This can be used by fuzzers to make RNG-driven code deterministic (i.e.
based on the fuzzer input).
2022-04-01 14:06:05 +00:00
iphydf
e04484efae
cleanup: Remove unused random_testing program.
...
Fuzzers do a better job of this.
2022-04-01 09:20:04 +00:00
jfreegman
015305a088
Merge moderation portion of new groupchats codebase
2022-03-30 20:09:50 -04:00
iphydf
7db0c80c93
test: Add DHT and tox_events fuzz tests to the cmake build.
2022-03-29 22:57:23 +00:00
iphydf
f39aac09e6
feat: Allow custom network functions.
...
The idea here is to have a `Network` object that contains functions for
network operations and an optional userdata object that can manage those
network operations. This allows e.g. a fuzzer to replace the network
functions with no-ops or fuzzer inputs, reducing the need for `#ifdef`s.
2022-03-29 22:03:26 +00:00
iphydf
e4558a287c
perf: Make time move a lot faster in fuzzing runs.
2022-03-27 22:52:35 +00:00
iphydf
478ef39b39
test: Add some support functions to make writing fuzzers easier.
2022-03-27 18:43:41 +00:00
sudden6
bc006beb4e
cleanup: split CMakeLists.txt and add some missing targets
2022-03-27 20:09:10 +02:00
sudden6
48fb45887f
try to save the fuzzed save file again
...
This should test some additional code paths.
2022-03-26 14:09:04 +01:00
iphydf
1928704065
test: Add fuzzer tests to the bazel build.
2022-03-25 18:48:41 +00:00
iphydf
2dcb946e62
cleanup: Reduce scope of array-typed variables where possible.
...
Cimple cannot actually find these without also causing false positives,
but I found them with cimple before removing the code causing false
positives again.
2022-03-21 12:02:46 +00:00
iphydf
c3a938e38c
cleanup: Avoid memset on structs.
...
Most of these were safe (some were not), but even the safe ones can
become unsafe (non-portable) later on when adding pointer or float members.
2022-03-19 12:32:36 +00:00
iphydf
cff9a18e39
cleanup: Split util.c out of the network library.
...
Also, don't include ccompat.h in header files. Instead, explicitly
include it in .c files.
2022-03-04 10:33:11 +00:00
iphydf
163e9c3b03
cleanup: Remove more boolean conversions (and a bugfix).
...
These were found by the new stronger type check in cimple. The one
bugfix is in `crypto_sha512_cmp`, which used to think `crypto_verify_32`
returns bool while actually it's -1/0/1.
2022-02-26 00:03:56 +00:00
iphydf
093927ba4f
test: Add mallocfail and proxy test to our coverage runs.
2022-02-25 01:55:28 +00:00
