mannol
7122d2e862
Use after free reported in #278 occurs because toxav_kill()
...
calls msi_kill() (toxav.c:180) which frees msi_call instances (msi.c:161)
which are then used when call_remove() (toxav.c:1136) is called.
This fix prevents call_remove() from calling invalid pointer.
Fixes #278
2016-12-21 00:16:22 +01:00
Maxim Biro
44ac196936
Fix NULL pointer dereference in log calls
2016-11-20 20:32:48 -05:00
Gregory Mullen (grayhatter)
51139a080c
v0.0.0 => v0.0.1
2016-09-28 12:12:39 -07:00
iphydf
15cb426166
Make toxcore code C++ compatible.
...
It is still C code, so still compatible with C compilers as well. This
change lets us see more clearly where implicit conversions occur by
making them explicit.
2016-09-24 21:53:50 +01:00
iphydf
51d18236c8
Revert "Make ToxAV stateless"
...
This reverts commit 21f8db12c4
.
It is currently broken. Incoming call callbacks are not invoked, and
instead the client goes offline immediately.
2016-09-19 21:53:40 +01:00
Gregory Mullen (grayhatter)
21f8db12c4
Make ToxAV stateless
2016-09-17 14:05:51 -07:00
iphydf
1494e474dd
Ensure that all TODOs have an owner.
...
In the future, all TODOs added either need a bug number (TODO(#NN)) or a
person's github user name. By default, I made irungentoo the owner of
all toxcore TODOs, mannol the owner of toxav TODOs, and myself the owner
of API TODOs.
2016-09-16 12:06:02 +01:00
iphydf
a8823830d3
Add some astyle options to make it do more.
...
It now enforces a bit more formatting. In particular, padding inside
parentheses is removed. I would like it to remove padding after unary
operators, but there seems to be no option for that.
2016-09-13 01:07:02 +01:00
iphydf
0aa2840164
Group #include directives in 3-4 groups.
...
1. Current module (if C file).
2. Headers from current library.
3. Headers from other library (e.g. toxcore includes in toxav).
4. System headers.
2016-09-13 00:32:02 +01:00
iphydf
a9fbdaf46b
Do not use else
after return
.
...
http://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code
2016-09-02 11:02:56 +01:00
iphydf
45d1f9acb9
Match parameter names in declarations with their definitions.
...
The parameter names were taken from function definitions to update the names in
function declarations (prototypes).
2016-09-01 14:54:17 +01:00
iphydf
633da98ae6
Add braces to all if statements.
2016-08-31 20:04:16 +01:00
iphydf
13ae9e9a93
Move logging to a callback.
...
This removes the global logger (which by the way was deleted when the first tox
was killed, so other toxes would then stop logging). Various bits of the code
now carry a logger or pass it around. It's a bit less transparent now, but now
there is no need to have a global logger, and clients can decide what to log and
where.
2016-08-27 01:16:14 +01:00
iphydf
459f8f2013
Check code formatting on Travis.
...
We run astyle on Travis and check if there is a diff. The build terminates if
git finds a difference.
2016-08-12 01:00:00 +01:00
Gregory Mullen (GrayHatter)
9628f9d171
added the dropped ;
2016-02-13 20:53:30 -08:00
Gregory Mullen (GrayHatter)
ea21a541ff
missed a line tox to toxav
2016-02-13 20:50:01 -08:00
Gregory Mullen (GrayHatter)
96bf594be5
update the compatablity function to match the macro
2016-02-13 20:44:30 -08:00
Gregory Mullen (GrayHatter)
2d361228cd
SemVer toxav too
2016-02-13 20:23:29 -08:00
Eniz Vukovic
96a7b7b4fc
Fix error reporting in toxav_call()
2015-11-29 00:38:33 +01:00
irungentoo
74f2fa00c2
Merge branch 'master' of https://github.com/helium-software/toxcore
2015-11-19 14:43:09 -05:00
irungentoo
4df59de504
Mannol toxav fix.
2015-11-17 18:41:00 -05:00
Tibor Stolz
edbfca5474
fix BWController misspelling
2015-11-11 10:33:03 +01:00
irungentoo
6a494e2cbd
Astyle.
2015-11-03 13:42:05 -05:00
Eniz Vukovic
fa0c87fa55
Revert "Removed mutex operations"
2015-10-31 14:53:20 +01:00
Eniz Vukovic
87828a1b42
Add synchronization protection for send_frame API functions
2015-10-24 01:56:49 +02:00
Eniz Vukovic
7972db5c41
Removed mutex operations
2015-10-23 22:56:54 +02:00
irungentoo
d012bb1e8e
Added mutex lock+unlock.
...
Should it be also added to the other parts of this function?
2015-10-23 22:54:22 +02:00
irungentoo
d8a85d9a78
Fixed error in last commit.
2015-10-23 22:54:22 +02:00
irungentoo
b23819a4d1
Fixed some memory related bugs.
2015-10-23 22:54:22 +02:00
Eniz Vukovic
90b1ca8727
Fix setting resolution for vpx v1.4 (or newer i suppose)
2015-10-23 22:53:56 +02:00
Eniz Vukovic
8f130b6f25
Remove old comment
2015-10-11 00:41:34 +02:00
Eniz Vukovic
d6fdf16520
New Adaptive BR algorithm, cleanups and fixes
2015-10-10 23:54:23 +02:00
mannol
0be0e88f3e
Remove empty lines
2015-08-09 12:02:52 +02:00
mannol
12d3f9396b
Fix possible double free
2015-08-09 11:57:39 +02:00
mannol
3c8cae72d0
Removed redundant function from video.[h|c]
2015-08-08 17:45:24 +02:00
mannol
6c126e34e6
Implement handling capability change on rtp level
2015-06-30 01:41:38 +02:00
mannol
2ecb71bb1e
Renamed TOXAV_CALL_STATE to TOXAV_FRIEND_CALL_STATE
2015-06-27 17:28:07 +02:00
mannol
08bc4eb0e0
Added payload turning off by setting bit rate to 0
2015-06-27 01:55:28 +02:00
mannol
9aba4ec273
Random fixes
2015-06-25 01:04:31 +02:00
mannol
d694839d60
Rebased on master and removed alpha channel (again)
2015-06-05 22:14:37 +02:00
mannol
3100042a2b
Updated with master
2015-05-22 23:22:31 +02:00
mannol
64037017cc
Fix bug
2015-05-12 22:16:00 +02:00
irungentoo
b2350f2e26
Check if call supports video encoding before encoding frame.
2015-05-09 16:09:48 -04:00
mannol
73fbc22961
Fixed inconsistencies
2015-05-07 23:14:03 +02:00
irungentoo
048d793021
Toxav fix.
...
Use stored image width instead of displayed image width.
2015-05-05 16:12:09 -04:00
mannol
eb6e8aa290
Fixed* api comments and some bugs
2015-05-01 22:29:25 +02:00
mannol
b2b11f0fba
Added many test and fixed various warnings
2015-04-30 00:40:30 +02:00
mannol
9bba7a0434
Done
2015-04-29 01:01:25 +02:00
mannol
e4a020333d
working av new api
2015-04-28 00:55:57 +02:00
mannol
27e0254a98
Almooooooost
2015-04-27 00:15:57 +02:00
mannol
144fc94d69
Almost done
2015-04-26 00:31:03 +02:00
mannol
1bfd93e64a
Finished refactoring
2015-04-22 02:09:37 +02:00
mannol
3fd0ee5f08
Final touchups
2015-04-21 02:31:12 +02:00
mannol
eb9f4ad592
Fix toxav callback
2015-04-18 19:08:18 +02:00
mannol
d1fd3e36a6
Updated with upstream
2015-04-17 19:19:58 +02:00
mannol
969367b72a
Update latest
2015-04-17 15:55:02 +02:00
mannol
da6c17222f
The pretty basic adaptive bitrate is *working*
2015-04-16 02:00:34 +02:00
mannol
2465f486ac
Started custom RTCP
2015-04-13 01:45:53 +02:00
mannol
b2d88a4544
Random fixes
2015-04-11 02:07:54 +02:00
mannol
4fa31d14cf
Make it possible to decode mono audio with stereo decoder
2015-04-09 02:43:13 +02:00
mannol
9c003c9dd2
Video works now
2015-04-08 01:00:19 +02:00
mannol
bf9f7e2ae8
Video works but there is one deadlock left and video replay is slow
2015-04-07 01:24:36 +02:00
mannol
62c4fd7409
Video preview works (lmao)
2015-04-02 02:04:45 +02:00
mannol
fdaad0b7c0
A little CS cleanup
2015-03-29 01:10:34 +01:00
mannol
e65efc8936
Improvement in test and removed some bloat from CS
2015-03-28 03:36:31 +01:00
Dubslow
56e5373a11
Consistency with core api
2015-03-25 14:55:42 -05:00
mannol
96ca88a0d6
Make it possible to change channels/sample rate of the decoder
2015-03-23 23:38:04 +01:00
mannol
995bddbc26
Audio works in test
2015-03-23 22:22:17 +01:00
mannol
62af82705a
Some progress
2015-03-22 23:50:43 +01:00
mannol
45e8807c1e
Make toxav thread safe
2015-03-01 18:45:04 +01:00
irungentoo
ca997bda70
toxav new api fixes.
2015-02-25 20:51:37 -05:00
mannol
9e65cd5337
Implement pausing
2015-02-24 23:27:20 +01:00
mannol
29601feb76
New msi protocol
2015-02-21 01:07:22 +01:00
mannol
efe31ec92f
Removed extra msi header and started testing
2015-02-20 00:23:38 +01:00
mannol
6e259d5fcb
Msi should be done; toxav.c need a cleanup and adjustments
2015-02-18 23:23:46 +01:00
mannol
483a6ffa32
Added 2 new headers into msi for buffer control
2015-02-17 23:34:40 +01:00
mannol
7329f3b3d4
Fixed header protectors and cleaning up the msi
2015-02-16 23:30:20 +01:00
mannol
8c245affb1
Started adjusting msi backend to new api
2015-02-15 22:41:10 +01:00
mannol
aad857527c
Control part of new api already kind of works
2015-02-14 23:37:52 +01:00
mannol
39680f31d0
Progress
2015-02-01 23:43:54 +01:00
mannol
1450c22d01
Current progress
2015-01-24 23:29:54 +01:00
mannol
e57fb8c12e
Progress
2015-01-17 18:22:20 +01:00
Tux3 / Mlkj / !Lev.uXFMLA
4f4967a45e
toxav_prepare_transmission: More descriptive error
...
When trying to prepare an already active call, return av_ErrorAlreadyInCallWithPeer not av_ErrorNoCall
2015-01-04 18:35:50 +01:00
irungentoo
9da75d009f
Cut one on one default audio bitrate by half.
2014-12-17 20:52:39 -05:00
irungentoo
ecba631493
Fixed some A/V threading issues.
...
Audio dropping on video calls issue should no longer happen.
2014-12-16 16:10:48 -05:00
irungentoo
f6b3e6e8fe
Fixed possible threading issues.
2014-12-03 14:41:01 -05:00
irungentoo
be9c6f88d3
Fixed possible threading issue.
2014-12-03 13:52:18 -05:00
irungentoo
e254c4fe3e
Fixed bug where video didn't work anymore.
...
Some other cleanups.
2014-11-29 16:09:50 -05:00
irungentoo
8deb032b2d
Merge branch 'mutex-1' of https://github.com/mannol/toxcore
2014-11-29 16:09:24 -05:00
mannol
e62ded3a6d
More av cleanup
2014-11-29 13:42:19 +01:00
irungentoo
db68c6eff6
Fixed toxav issues.
2014-11-28 13:10:27 -05:00
Imperative
6cff9ecf73
Forgot to replace this
2014-11-26 00:26:03 +01:00
irungentoo
6e361a52fb
Fixed integer rollover bug in toxav.
2014-11-25 17:22:44 -05:00
irungentoo
279c33c01a
Merge branch 'master' of https://github.com/mannol/toxcore
2014-11-24 20:24:59 -05:00
mannol
386c9748d4
av refactor
2014-11-18 00:46:46 +01:00
irungentoo
8c0225b27f
2 channel audio can now be sent to groupchats.
...
Some cleanups and added comments.
2014-11-11 14:39:25 -05:00
irungentoo
a8f670bd68
Added comments.
2014-11-11 09:48:52 -05:00
irungentoo
94ac524374
Group audio might work now but I have not tested anything yet.
2014-11-10 17:59:14 -05:00
xor2003
837f72b39e
Fix for memory leak. And add forgotten break
2014-10-24 15:53:38 +04:00
cgar
2bb2bc4163
spelling corrections
2014-09-09 20:31:37 -04:00