iphydf
a549807df7
refactor: Add mem module to allow tests to override allocators.
...
This will allow us to do more interesting things with memory allocation
within toxcore, and allow fuzzers to explore various allocation failure
paths.
2023-08-30 22:55:05 +00:00
iphydf
cc31ff07fa
feat: Add support for custom random number generator.
...
This can be used by fuzzers to make RNG-driven code deterministic (i.e.
based on the fuzzer input).
2022-04-01 14:06:05 +00:00
iphydf
83c9c0bd85
cleanup: Move all the group.h structs into group.c.
...
Almost nothing used these. The one thing that did only does it to get a
`Mono_Time` object. We should probably get that from elsewhere, but for
now the refactoring is just this simple move.
2022-03-13 17:49:50 +00:00
iphydf
e1e92c1ac1
docs: Clean up doxygen comments to be more doxygen-like.
2022-03-05 22:30:48 +00:00
iphydf
cff9a18e39
cleanup: Split util.c out of the network library.
...
Also, don't include ccompat.h in header files. Instead, explicitly
include it in .c files.
2022-03-04 10:33:11 +00:00
iphydf
b13590a86d
cleanup: Mark all local non-pointers as const where possible.
2022-02-23 19:30:01 +00:00
iphydf
a9ccf1be26
cleanup: Remove all implicit bool conversions in if-conditions.
...
Note to reviewer: please review carefully. This was done manually.
2022-02-21 15:10:22 +00:00
iphydf
87c38ece30
cleanup: Avoid implicit bool conversions in logical operators.
2022-02-18 10:24:31 +00:00
iphydf
5e724d8909
cleanup: Avoid implicit pointer-to-bool conversion in if in toxav.
2022-02-17 20:33:24 +00:00
iphydf
7f0395b746
chore: Make the last few remaining top level comments doxygen style.
2022-02-04 23:25:45 +00:00
jfreegman
791fd01349
Make some non-const pointers const
2022-01-29 11:14:56 -05:00
jfreegman
ade11eb35d
Fix group av memory leak
...
Introduced in 762a601
2022-01-22 14:52:05 -05:00
jfreegman
762a6017f9
Refactor group audio packet data handling
...
We now malloc and free the data field separately. This increases
readability of the code and gets rid of static analyzer false
positives.
2022-01-17 19:01:51 -05:00
iphydf
f7557b4c16
cleanup: Even more pointer-to-const parameters.
...
I missed these the first time around.
2022-01-16 02:35:08 +00:00
iphydf
9ab77e015d
cleanup: Fix calloc argument order.
...
See https://github.com/TokTok/hs-tokstyle/pull/102
2022-01-09 18:42:20 +00:00
jfreegman
53bd3c86df
Fix possible unintended negative loop bound
2022-01-01 16:01:29 -05:00
iphydf
fd32c87707
cleanup: Don't include "config.h" unless needed.
...
Currently only `crypto_core_mem.c` needs this. We should try not to
depend on configure'd values. Also note: config.h is only created and
used in the autotools build. In CMake, we pass `-D` flags directly.
2021-12-12 22:18:38 +00:00
iphydf
e4ad0c833c
cleanup: Enforce for loop consistency.
...
All for-loops must have an init-decl, a condition, and an increment
statement. Any loop that doesn't have one of these should be a while
loop (only 2 of these exist in toxav, none in toxcore).
2021-12-09 14:53:00 +00:00
iphydf
11ad5471b9
Use spdx license identifier instead of GPL blurb.
2020-03-14 13:06:19 +00:00
zugz (tox)
959f468eac
add API function to test whether av is enabled
2019-02-10 00:00:00 +00:00
zugz (tox)
49e2406ffa
Expose api functions for enabling and disabling AV in AV groups
...
A group loaded from a savefile starts with AV disabled.
2019-02-10 00:00:00 +00:00
zugz (tox)
a122ee9e01
Expose offline conference peers in API
2019-01-05 15:01:29 +00:00
iphydf
473cde24d8
Update copyright to 2018.
2018-08-26 18:57:29 +00:00
iphydf
d6d305feeb
Use per-instance Mono_Time for Messenger and onion.
2018-08-16 21:01:43 +00:00
iphydf
2d84681529
Fix ToxAv's use of struct Tox.
...
* Fix `toxav_get_tox` to return tox, not messenger.
* Fix the casts from Tox* to Messenger* in toxav_old.c.
* Pass Tox instead of Messenger to public group AV callbacks.
2018-08-13 22:11:48 +00:00
iphydf
97a4b8e6a7
Fix memory leak in error path in group A/V.
...
This probably doesn't happen, but it can in theory, so we avoid it.
2018-08-13 10:45:21 +00:00
iphydf
d518374819
Fix groupav.c style and avoid casts in toxav_old.c.
...
* No anonymous structs.
* No assignment expressions.
* Only one declarator per struct member declaration.
* Named callback types only, no inline types.
* No `;` empty statements.
* `++i` instead of `i++`.
Avoiding a cast in toxav_old.c avoids some potential (and real) bugs.
2018-08-13 10:37:09 +00:00
iphydf
abc17b0f89
Factor out time keeping code into its own module: mono_time.c.
...
It turns out, `unix_time` is also monotonic, and is used as such, so I've
renamed the new functions to `mono_time_*`.
2018-07-08:
```
00:01 <@irungentoo> the idea used to be that the unix_time() function
could go backward in time but I think I might have started using it like
if it could not after I changed it so that it would never go back in time
```
2018-07-09 21:04:50 +00:00
iphydf
b3889f0f05
Remove VLA usage from send_audio_packet.
...
Also use `net_pack_u16` in that function instead of manual ntohs+memcpy
and `net_unpack_u16` in its receiving counterpart.
2018-07-08 13:59:37 +00:00
iphydf
08ff19a63b
Call the "peer leaves" callback only once on group delete.
...
We used to pass the actual peer numbers of peers leaving, but we no
longer know these in the PGC world, so we don't pass them anymore.
2018-07-07 16:02:00 +00:00
iphydf
8e00294b3c
Add Logger to various net_crypto functions.
...
In preparation for adding log statements.
Also, fix an uninitialised variable warning in cppcheck.
2018-06-24 19:17:32 +00:00
iphydf
be797d4b03
Move system header includes from network.h to network.c
2018-05-20 15:42:42 +00:00
sudden6
03b55cde1a
make groupnumber uint32_t
...
fixes #606
2018-02-20 20:58:54 +01:00
iphydf
92ffad1a72
Use nullptr as NULL pointer constant instead of NULL or 0.
...
This changes only code, no string literals or comments.
2018-01-30 23:35:50 +00:00
Diadlo
b19a9e5464
Add part of platform-independent network API implementation
...
socket -> net_socket
htons -> net_htons
htonl -> net_htonl
connect -> net_connect
sendto -> net_sendto_ip4
getaddrinfo -> net_getipport
sa_family_t -> Family
2017-02-26 23:16:16 +03:00
iphydf
6ae33c16cf
Add VLA compatibility macro for C89-ish compilers.
2017-01-28 20:49:12 +00:00
iphydf
8f96ca6d86
Update license headers and remove redundant file name comment.
...
"All rights reserved" was incorrect. The project was licensed under GPL3,
which means a lot of rights are licensed to everybody in the world, i.e.
not reserved to the "Tox Project".
2017-01-19 00:01:44 +00:00
Maxim Biro
551660a64a
Fix a memory leak in GroupAV
2016-11-20 20:51:48 -05:00
Dmytro Vorobiov
59d27e6d94
toxav renaming: group.{h,c} -> groupav.{h,c}
...
toxav file for "group" conflicts with toxcore "group" file. While this
works fine in almost all cases, Xcode on macOS is confused with that.
2016-10-28 22:11:48 +02:00
