StarMirror/toxcore
1
0
Fork 0
mirror of https://github.com/irungentoo/toxcore.git synced 2024-03-22 13:30:51 +08:00
Code Issues Projects Releases Wiki Activity

fix: properly deallocate frozen peers

Browse Source
This commit is contained in:
sudden6 2022-02-18 15:19:12 +01:00
parent 84a03bc2ed
commit fde2a7d16d
No known key found for this signature in database
GPG Key ID: 279509B499E032B9
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
toxcore/group.c
View File

@ -131,6 +131,13 @@ static int32_t create_group_chat(Group_Chats *g_c)
return -1;
}
non_null()
static void wipe_group_c(Group_c *g)
{
free(g->frozen);
free(g->group);
crypto_memzero(g, sizeof(Group_c));
}
/** Wipe a groupchat.
*
@ -139,12 +146,13 @@ static int32_t create_group_chat(Group_Chats *g_c)
non_null()
static bool wipe_group_chat(Group_Chats *g_c, uint32_t groupnumber)
{
if (!is_groupnumber_valid(g_c, groupnumber)) {
if (groupnumber >= g_c->num_chats || g_c->chats == nullptr) {
return false;
}
wipe_group_c(&g_c->chats[groupnumber]);
uint16_t i;
crypto_memzero(&g_c->chats[groupnumber], sizeof(Group_c));
for (i = g_c->num_chats; i != 0; --i) {
if (g_c->chats[i - 1].status != GROUPCHAT_STATUS_NONE) {
@ -1208,9 +1216,6 @@ int del_groupchat(Group_Chats *g_c, uint32_t groupnumber, bool leave_permanently
}
}
free(g->group);
free(g->frozen);
if (g->group_on_delete != nullptr) {
g->group_on_delete(g->object, groupnumber);
}