From d46091072dce471367423d3033820a669f008ca6 Mon Sep 17 00:00:00 2001 From: iphydf Date: Fri, 18 Feb 2022 21:44:28 +0000 Subject: [PATCH] chore: Remove msan from all CIs except circleci. It doesn't work yet and is wasting CI resources. --- .cirrus.yml | 34 +++++++++++++++++----------------- .github/settings.yml | 3 --- .github/workflows/ci.yml | 11 ----------- 3 files changed, 17 insertions(+), 31 deletions(-) diff --git a/.cirrus.yml b/.cirrus.yml index d91200d6..b160b0e6 100644 --- a/.cirrus.yml +++ b/.cirrus.yml @@ -50,23 +50,23 @@ bazel-asan_task: //c-toxcore/... -//c-toxcore/auto_tests:tcp_relay_test # TODO(robinlinden): Why does this pass locally but not in Cirrus? -# TODO(iphydf): Remove "|| true" once this works properly. -bazel-msan_task: - container: - image: toxchat/toktok-stack:latest-msan - cpu: 2 - memory: 4G - configure_script: - - /src/workspace/tools/inject-repo c-toxcore - test_all_script: - - cd /src/workspace && bazel test -k - --remote_http_cache=http://$CIRRUS_HTTP_CACHE_HOST - --build_tag_filters=-haskell - --test_tag_filters=-haskell - --remote_download_minimal - -- - //c-toxcore/... - -//c-toxcore/auto_tests:tcp_relay_test || true # TODO(robinlinden): Why does this pass locally but not in Cirrus? +# TODO(iphydf): Enable once this works properly. +#bazel-msan_task: +# container: +# image: toxchat/toktok-stack:latest-msan +# cpu: 2 +# memory: 4G +# configure_script: +# - /src/workspace/tools/inject-repo c-toxcore +# test_all_script: +# - cd /src/workspace && bazel test -k +# --remote_http_cache=http://$CIRRUS_HTTP_CACHE_HOST +# --build_tag_filters=-haskell +# --test_tag_filters=-haskell +# --remote_download_minimal +# -- +# //c-toxcore/... +# -//c-toxcore/auto_tests:tcp_relay_test # TODO(robinlinden): Why does this pass locally but not in Cirrus? # TODO(iphydf): Fix test timeouts. bazel-tsan_task: diff --git a/.github/settings.yml b/.github/settings.yml index b3eecaeb..8550b686 100644 --- a/.github/settings.yml +++ b/.github/settings.yml @@ -14,13 +14,11 @@ branches: contexts: - "bazel-asan" - "bazel-dbg" - - "bazel-msan" - "bazel-opt" - "bazel-tsan" - "bazel-valgrind" - "build-compcert" - "build-macos" - - "build-msan" - "build-nacl" - "build-tcc" - "build-win32" @@ -44,7 +42,6 @@ branches: - "docker-bootstrap-node-websocket" - "docker-toxcore-js" - "mypy" - - "netlify/c-toxcore/deploy-preview" - "sonar-scan" # Labels specific to c-toxcore. diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2dfc4274..b107d706 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -33,17 +33,6 @@ jobs: with: file: other/docker/tokstyle/Dockerfile - build-msan: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - - name: Pull toxchat/toktok-stack:latest-msan - run: docker pull toxchat/toktok-stack:latest-msan - - name: Run tests under MemorySanitizer - # TODO(iphydf): Remove "|| true" once this works correctly. - run: docker run --rm -v $PWD:/src/workspace/c-toxcore toxchat/toktok-stack:latest-msan - bazel test //c-toxcore/auto_tests:lossless_packet_test || true - build-nacl: runs-on: ubuntu-latest steps: