From 53bd3c86dfdc414a6e28cae9e891cfc158d9ee6b Mon Sep 17 00:00:00 2001 From: jfreegman Date: Sat, 1 Jan 2022 13:47:35 -0500 Subject: [PATCH] Fix possible unintended negative loop bound --- toxav/groupav.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/toxav/groupav.c b/toxav/groupav.c index fec1b517..da25c20b 100644 --- a/toxav/groupav.c +++ b/toxav/groupav.c @@ -443,7 +443,12 @@ int groupchat_enable_av(const Logger *log, Tox *tox, Group_Chats *g_c, uint32_t return -1; } - int numpeers = group_number_peers(g_c, groupnumber, false); + const int numpeers = group_number_peers(g_c, groupnumber, false); + + if (numpeers < 0) { + kill_group_av(group_av); + return -1; + } for (uint32_t i = 0; i < numpeers; ++i) { group_av_peer_new(group_av, groupnumber, i); @@ -470,7 +475,12 @@ int groupchat_disable_av(Group_Chats *g_c, uint32_t groupnumber) return -1; } - int numpeers = group_number_peers(g_c, groupnumber, false); + const int numpeers = group_number_peers(g_c, groupnumber, false); + + if (numpeers < 0) { + kill_group_av(group_av); + return -1; + } for (uint32_t i = 0; i < numpeers; ++i) { group_av_peer_delete(group_av, groupnumber, group_peer_get_object(g_c, groupnumber, i));