StarMirror/toxcore
1
0
Fork 0
mirror of https://github.com/irungentoo/toxcore.git synced 2024-03-22 13:30:51 +08:00
Code Issues Projects Releases Wiki Activity

Use larger arrays in crypto timing tests.

Browse Source 
Increasing from 256K to 1M and increasing the number of iterations from
1000 to 2000. This makes the test more accurate and less flaky.
This commit is contained in:
iphydf 2018-01-13 20:51:04 +00:00
parent 0a5be3cbc5
commit 25d3001556
No known key found for this signature in database
GPG Key ID: 3855DBA2D74403C9
1 changed files with 15 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
auto_tests/crypto_test.c
View File

@ -339,8 +339,8 @@ START_TEST(test_memzero)
} }
END_TEST END_TEST
#define CRYPTO_TEST_MEMCMP_SIZE 1024*256 #define CRYPTO_TEST_MEMCMP_SIZE 1024*1024 // 1MiB
#define CRYPTO_TEST_MEMCMP_COUNT 1000 #define CRYPTO_TEST_MEMCMP_COUNT 2000
#define CRYPTO_TEST_MEMCMP_EPS 10 #define CRYPTO_TEST_MEMCMP_EPS 10
static int cmp(const void *a, const void *b) static int cmp(const void *a, const void *b)
@ -381,21 +381,25 @@ static clock_t memcmp_median(void *a, void *b, size_t len)
START_TEST(test_memcmp) START_TEST(test_memcmp)
{ {
uint8_t src[CRYPTO_TEST_MEMCMP_SIZE]; uint8_t *src = (uint8_t *)malloc(CRYPTO_TEST_MEMCMP_SIZE);
rand_bytes(src, sizeof(src)); rand_bytes(src, CRYPTO_TEST_MEMCMP_SIZE);
uint8_t same[sizeof(src)]; uint8_t *same = (uint8_t *)malloc(CRYPTO_TEST_MEMCMP_SIZE);
memcpy(same, src, sizeof(src)); memcpy(same, src, CRYPTO_TEST_MEMCMP_SIZE);
uint8_t not_same[sizeof(src)]; uint8_t *not_same = (uint8_t *)malloc(CRYPTO_TEST_MEMCMP_SIZE);
rand_bytes(not_same, sizeof(not_same)); rand_bytes(not_same, CRYPTO_TEST_MEMCMP_SIZE);
printf("timing memcmp (equal arrays)\n"); printf("timing memcmp (equal arrays)\n");
clock_t same_median = memcmp_median(src, same, sizeof(src)); clock_t same_median = memcmp_median(src, same, CRYPTO_TEST_MEMCMP_SIZE);
printf("timing memcmp (non-equal arrays)\n"); printf("timing memcmp (non-equal arrays)\n");
clock_t not_same_median = memcmp_median(src, not_same, sizeof(src)); clock_t not_same_median = memcmp_median(src, not_same, CRYPTO_TEST_MEMCMP_SIZE);
printf("comparing times\n"); printf("comparing times\n");
free(not_same);
free(same);
free(src);
clock_t delta; clock_t delta;
if (same_median > not_same_median) { if (same_median > not_same_median) {
@ -423,7 +427,7 @@ static Suite *crypto_suite(void)
DEFTESTCASE(large_data_symmetric); DEFTESTCASE(large_data_symmetric);
DEFTESTCASE_SLOW(increment_nonce, 20); DEFTESTCASE_SLOW(increment_nonce, 20);
DEFTESTCASE(memzero); DEFTESTCASE(memzero);
DEFTESTCASE(memcmp); DEFTESTCASE_SLOW(memcmp, 30);
return s; return s;
} }